Merge pull request #2208 from remote-v2ray/feature/UnregisterCounter

add UnregisterCounter method to stats manager
This commit is contained in:
Kslr
2020-06-28 16:11:55 +08:00
committed by GitHub
2 changed files with 18 additions and 0 deletions
+12
View File
@@ -63,6 +63,18 @@ func (m *Manager) RegisterCounter(name string) (stats.Counter, error) {
return c, nil
}
func (m *Manager) UnregisterCounter(name string) error {
m.access.Lock()
defer m.access.Unlock()
if _, found := m.counters[name]; !found {
return newError("Counter ", name, " was not found.")
}
newError("remove counter ", name).AtDebug().WriteToLog()
delete(m.counters, name)
return nil
}
func (m *Manager) GetCounter(name string) stats.Counter {
m.access.RLock()
defer m.access.RUnlock()
+6
View File
@@ -24,6 +24,7 @@ type Manager interface {
// RegisterCounter registers a new counter to the manager. The identifier string must not be emtpy, and unique among other counters.
RegisterCounter(string) (Counter, error)
UnregisterCounter(string) error
// GetCounter returns a counter by its identifier.
GetCounter(string) Counter
}
@@ -58,6 +59,11 @@ func (NoopManager) RegisterCounter(string) (Counter, error) {
return nil, newError("not implemented")
}
// UnregisterCounter implements Manager.
func (NoopManager) UnregisterCounter(string) error {
return newError("not implemented")
}
// GetCounter implements Manager.
func (NoopManager) GetCounter(string) Counter {
return nil