github/ebean
4
0
Fork 0
mirror of https://github.com/ebean-orm/ebean.git synced 2024-04-21 10:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

#2424 Preserve using PersistenceException when transaction register(Callback) called with no active transaction

Browse Source
This commit is contained in:
Rob Bygrave
2021-10-21 12:06:45 +13:00
parent 4d34c9e868
commit fcda419abb
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+5 -1
View File
@@ -691,7 +691,11 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
@Override
public void register(TransactionCallback transactionCallback) {
currentTransaction().register(transactionCallback);
Transaction transaction = currentTransaction();
if (transaction == null) {
throw new PersistenceException("Not currently active transaction when trying to register transactionCallback");
}
transaction.register(transactionCallback);
}
/**
ebean-test/src/test/java/org/tests/transaction/TestTransactionCallback.java
+2 -2
View File
@@ -72,12 +72,12 @@ public class TestTransactionCallback extends BaseTestCase {
@Test
public void test_noActiveTransaction() {
assertThrows(NullPointerException.class, () -> DB.register(new MyCallback()));
assertThrows(PersistenceException.class, () -> DB.register(new MyCallback()));
}
@Test
public void test_noActiveTransaction_withDatabase() {
assertThrows(NullPointerException.class, () -> DB.getDefault().register(new MyCallback()));
assertThrows(PersistenceException.class, () -> DB.getDefault().register(new MyCallback()));
}
class MyCallback extends TransactionCallbackAdapter {