#2694 - Postgres DDL - For Postgres table partitioning, remove the "suppressPrimaryKeyOnPartition" mode

ebean-ddl-generator/src/main/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/BaseTableDdl.java

@@ -216,9 +216,7 @@ public class BaseTableDdl implements TableDdl {
     writeCompoundUniqueConstraints(apply, createTable);
     if (!pk.isEmpty()) {
       // defined on the columns
-      if (partitionMode == null || !platformDdl.suppressPrimaryKeyOnPartition()) {
-        writePrimaryKeyConstraint(apply, createTable.getPkName(), toColumnNames(pk));
-      }
+      writePrimaryKeyConstraint(apply, createTable.getPkName(), toColumnNames(pk));
     }
     if (platformDdl.isInlineForeignKeys()) {
       writeInlineForeignKeys(apply, createTable);

ebean-ddl-generator/src/main/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl.java

@@ -732,10 +732,6 @@ public class PlatformDdl {
     return createTable;
   }
 
-  public boolean suppressPrimaryKeyOnPartition() {
-    return false;
-  }
-
   public void addTablePartition(DdlBuffer apply, String partitionMode, String partitionColumn) {
     // only supported by postgres initially
   }

ebean-ddl-generator/src/main/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PostgresDdl.java

@@ -30,11 +30,6 @@ public class PostgresDdl extends PlatformDdl {
     return "set lock_timeout = " + (lockTimeoutSeconds * 1000);
   }
 
-  @Override
-  public boolean suppressPrimaryKeyOnPartition() {
-    return true;
-  }
-
   @Override
   protected String convertArrayType(String logicalArrayType) {
     return NativeDbArray.logicalToNative(logicalArrayType);