github/ebean
4
0
Fork 0
mirror of https://github.com/ebean-orm/ebean.git synced 2024-04-21 10:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

#3265 Fix for Update Query logging to trim large values in bind log

Browse Source
This commit is contained in:
Rob Bygrave
2023-11-21 22:32:35 +13:00
parent cbca940611
commit c48e5428c5
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ebean-core/src/main/java/io/ebeaninternal/server/persist/Binder.java
+5 -1
View File
@@ -119,7 +119,11 @@ public final class Binder {
if (param.isEncryptionKey()) {
bindLog.append("****");
} else {
bindLog.append(value);
String sv = String.valueOf(value);
if (sv.length() > 50) {
sv = sv.substring(0, 47) + "...";
}
bindLog.append(sv);
}
}
if (value instanceof Collection) {
ebean-test/src/test/java/org/tests/basic/TestUpdate.java
+8 -3
View File
@@ -1,8 +1,8 @@
package org.tests.basic;
import io.ebean.xtest.BaseTestCase;
import io.ebean.DB;
import io.ebean.Update;
import io.ebean.xtest.BaseTestCase;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
@@ -10,6 +10,7 @@ import org.tests.model.basic.Customer;
import org.tests.model.basic.ResetBasicData;
import java.util.Arrays;
import java.util.List;
import static org.assertj.core.api.Assertions.assertThat;
@@ -37,13 +38,17 @@ public class TestUpdate extends BaseTestCase {
@Test
public void testNormal() {
String sillyContent = "a123456789b123456789c123456789d123456789e123456789";
for (int i = 1; i <= 3; i++) {
Update<Customer> update = DB.createUpdate(Customer.class,
"update customer set smallnote = :smallnote where name in (:name)");
update.setParameter("name", Arrays.asList("testUpdate" + i)).setParameter("smallnote", "Note #" + i).execute();
update
.setParameter("name", List.of("testUpdate" + i))
.setParameter("smallnote", "Note #" + i + sillyContent)
.execute();
}
Customer cust = DB.find(Customer.class).where().eq("name", "testUpdate3").findOne();
assertThat(cust.getSmallnote()).isEqualTo("Note #3");
assertThat(cust.getSmallnote()).isEqualTo("Note #3" + sillyContent);
}
@Test