Merge pull request #3077 from ebean-orm/feature/3062-dtoQuery

Use Statement for truncate table and postgres version query
This commit is contained in:
Rob Bygrave
2023-05-26 15:03:52 +12:00
committed by GitHub
3 changed files with 7 additions and 7 deletions
@@ -51,8 +51,8 @@ import javax.persistence.OptimisticLockException;
import javax.persistence.PersistenceException;
import javax.sql.DataSource;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.sql.Statement;
import java.time.Clock;
import java.util.*;
import java.util.concurrent.Callable;
@@ -560,9 +560,9 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
private void executeSql(Connection connection, @Nullable String sql) throws SQLException {
if (sql != null) {
try (PreparedStatement stmt = connection.prepareStatement(sql)) {
try (Statement stmt = connection.createStatement()) {
transactionManager.log().sql().debug(sql);
stmt.execute();
stmt.execute(sql);
}
}
}
@@ -14,7 +14,7 @@ class DtoQuery3Test extends BaseTestCase {
void dtoQuery_when_constructorsClash() {
ResetBasicData.reset();
List<DCust> list = server().findDto(DCust.class, "select id, name, status from o_customer").findList();
List<DCust> list = server().findDto(DCust.class, "select id, name, status from o_customer where status is not null").findList();
assertThat(list).isNotEmpty();
for (DCust cust: list) {
@@ -52,10 +52,10 @@ public class PostgresPlatformProvider implements DatabasePlatformProvider {
if (productVersion.contains("-yb-")) {
return new YugabytePlatform();
}
try (PreparedStatement statement = connection.prepareStatement("select version() as \"version\"")) {
try (ResultSet resultSet = statement.executeQuery()) {
try (Statement statement = connection.createStatement()) {
try (ResultSet resultSet = statement.executeQuery("select version()")) {
if (resultSet.next()) {
productVersion = resultSet.getString("version").toLowerCase();
productVersion = resultSet.getString(1).toLowerCase();
if (productVersion.contains("cockroach")) {
return new CockroachPlatform();
}