configure a presubmit to ensure that it stays formatted.
Highlights include:
* simplified import order
* method annotations are now consistently defined on the preceding line
* javadoc reformatted to 100 chars column width
One test that contained line numbers in error messages had to be modified and
the formatter didn't like some of the more complicated preprocessor directives
(MOE and AOP).
To avoid formatting the copyright notices as javadoc i did a preprocessing step to rewrite the initial '/**' to '/*' using perl
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=132692207
99% of this is adding missing @Override annotations, in the long tail we also have
* insert missing calls to Assert.fail() in tests that are testing exception behavior
* rewrite a few cases of Foo.class.instanceof(c) to c instanceof Foo
* rewrite Class.newInstance - > Class.getConstructor().newInstance() which doesn't break checked exception checking.
* adding @javax.inject.Inject annotations to methods that override methods annotated with @javax.inject.Inject
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=131839622
* consolidate common versions in dependencyManagement section
* clean up OSGi metadata (remove asm/cglib imports, fix version range to account for Guava's versioning scheme)
* update jarjar-maven-plugin to 1.9 (makes sure manifest is first entry in final jar)
* attach correct pre-jarjar'd classes
* fix old references to Java5
* remove out-of-date asm:asm exclusion
* fix versions of mini/service extensions
* Sort imports
* Convert tabs to spaces
* Fix the ant no_aop build
Revision created by MOE tool push_codebase.
MOE_MIGRATION=2532
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1572 d779f126-a31b-0410-b53b-1d3aecad763e
Also fixing bugs where supertype fields weren't injected.
Also improving error reporting when an injection fails to include the requiring injection. Otherwise things like "Expected injection of String" fails miserably.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1229 d779f126-a31b-0410-b53b-1d3aecad763e
The standard Guice injector hits a diverse set of use cases with a small core. It has advanced features to make developers productive and it's very fast. And it scales to extremely large teams very well. In a world of JavaEE aircraft carriers, Guice is a sports car.
To contrast, MiniGuice (placeholder name) is roller skates. It has barely any features and can't do anything but the bare essentials: field & constructor injection, provider methods, provider injections, singletons, and binding annotations. It's intended for use in tiny dozen-file projects maintained by a single developer in leisure time. It's only features are its compact size and implementation simplicity.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1225 d779f126-a31b-0410-b53b-1d3aecad763e