Commit Graph
1898 Commits
Author SHA1 Message Date
Guice TeamandGuice Team 15ce8eb669 Avoid defensive clone() in ParameterizedType.getActualTypeArguments() when possible.
PiperOrigin-RevId: 347701829
2020-12-15 15:12:54 -08:00
Guice TeamandGuice Team 363f568b6d Fix quadratic behavior of AbstractProcessor.process() observed in profiles.
The received lists are always ArrayList, for which removing items one-by-one
from the left is inefficient.

This changes the behavior on exception.  Unlike std::remove_if,
ArrayList.removeIf() buffers all filter results before shifting any elements.

PiperOrigin-RevId: 347469725
2020-12-14 14:27:57 -08:00
Guice TeamandGuice Team 2712230640 Fix formatting of source with module stack. Add NullInjectedIntoNonNullable tests.
PiperOrigin-RevId: 346890324
2020-12-10 16:30:51 -08:00
Guice TeamandGuice Team e399b21ab8 Split generate-latest-docs.sh script into two script: one generates the docs and one generates and publishes them.
This will allow us to generate the released version of the api docs as  part of release process.

PiperOrigin-RevId: 345773223
2020-12-04 15:50:59 -08:00
Guice TeamandGuice Team ed6993aa14 Delete ant related build files.
PiperOrigin-RevId: 345749534
2020-12-04 13:51:03 -08:00
Guice TeamandGuice Team 79660ea0f5 Update github access token used for publishing api docs.
PiperOrigin-RevId: 345726340
2020-12-04 11:57:27 -08:00
Guice TeamandGuice Team 4b4b9a6fa8 Run mvn install to install snapshot artifact before running jdiff.
PiperOrigin-RevId: 345714487
2020-12-04 11:05:55 -08:00
Guice TeamandGuice Team 9c7fe49c7a Fix bash script for publishing latest api docs.
Using `/bin/sh` cause an "unexpected operator" so remove it.

PiperOrigin-RevId: 345708574
2020-12-04 10:40:30 -08:00
Guice TeamandGuice Team 07d13be147 Change to use jdiff maven plugin to generate API diffs.
The plugin is configured to diff the current version against last released version of the API.

Unlike the jdiff task run by ant, this plugin generates diff on a per module basis. So the script used to generate latest docs is updated to copy over per module API diffs into a single directory with a index page that links to each module's diffs.

Also fixed travis CI config to remove the docs configuration since the javadoc
and api diffs are now generated using maven.

PiperOrigin-RevId: 345697612
2020-12-04 09:52:37 -08:00
Guice TeamandGuice Team a795fcc1b8 Clarify wording of the MissingConstructor Guice error message
PiperOrigin-RevId: 345502715
2020-12-03 11:57:18 -08:00
Guice TeamandGuice Team 413d0d5dba Configure maven-javadoc-plugin to group modules into separate tabs.
PiperOrigin-RevId: 345329769
2020-12-02 15:51:57 -08:00
Guice TeamandGuice Team 70062306db Update BoundFieldModule description to be more specific about what it does.
PiperOrigin-RevId: 345252174
2020-12-02 09:49:56 -08:00
Guice TeamandGuice Team 338d0039c1 Add documentation for AbstractBindingBuilder.
PiperOrigin-RevId: 340925080
2020-11-05 14:07:24 -08:00
Guice TeamandGuice Team 6eaf556c8b Fix ServletConfig.getInitParameterNames return type.
Closes #1440.

PiperOrigin-RevId: 339960006
2020-10-30 16:30:10 -07:00
Guice TeamandGuice Team 59640fa0df Fix release page link.
PiperOrigin-RevId: 339944405
2020-10-30 14:52:17 -07:00
Guice TeamandGuice Team 383d377436 Bump snapshot version, update README & prior API xml
PiperOrigin-RevId: 339910400
2020-10-30 11:43:16 -07:00
Guice TeamandGuice Team b1975a7c29 Update dagger jar used by ant to match the actual version used in maven.
PiperOrigin-RevId: 339701941
2020-10-29 10:53:18 -07:00
Guice TeamandGuice Team c79a90405a Delete unused build property.
PiperOrigin-RevId: 339501190
2020-10-28 11:28:10 -07:00
Guice TeamandGuice Team 9e7afde656 Documentation nit: update text to match variable name.
PiperOrigin-RevId: 339493357
2020-10-28 10:55:31 -07:00
Guice TeamandGuice Team f3f8fc0c7c Update the AbstractModule javadoc
PiperOrigin-RevId: 339493051
2020-10-28 10:52:53 -07:00
Guice TeamandGuice Team dc6a1657db Run tests against openjdk-15.
PiperOrigin-RevId: 339133656
2020-10-26 15:41:36 -07:00
Guice TeamandGuice Team 2de2311318 Update FactoryProvider2 to support Java 15.
The private constructor used in looking up method handles has changed to take an extra parameter. This change update the code to look for both constructor signatures.

PiperOrigin-RevId: 339124988
2020-10-26 15:00:30 -07:00
Guice TeamandGuice Team 8b2a048a71 Fix BoundFieldModuleTest to run with Java 15.
PiperOrigin-RevId: 339039746
2020-10-26 08:09:52 -07:00
Guice TeamandGuice Team b256703850 Remove multibindings extension, it has been part of Guice core since 4.2 release.
Also clean up no_aop build variant from BOM.

PiperOrigin-RevId: 338771054
2020-10-23 17:03:44 -07:00
Guice TeamandGuice Team ba5b90a9f6 Update ASM to version 9.0.
Closes #1400

PiperOrigin-RevId: 338751330
2020-10-23 15:00:54 -07:00
Guice TeamandGuice Team 80b91afae2 Update tests to support running with Java 15.
In Java 15, the annotation `toString` implementation omits the member name.

PiperOrigin-RevId: 338746927
2020-10-23 14:37:28 -07:00
Guice TeamandGuice Team b97095d388 Delete obsolete methods in Messages and migrate callers to use equivalent methods in SourceFormatter.
PiperOrigin-RevId: 338582362
2020-10-22 17:32:37 -07:00
Guice TeamandGuice Team d3df2d5854 Delete deprecated dependency stack APIs.
PiperOrigin-RevId: 338343877
2020-10-21 14:44:42 -07:00
Guice TeamandGuice Team 50e7c7e02c Remove obsolete error message flag and clean up dead code.
PiperOrigin-RevId: 338104581
2020-10-20 11:55:35 -07:00
Guice TeamandGuice Team 5caa549395 Enable the new Guice error messages.
Changes include:

 - update Guice tests that asserts error messages
 - export new errors tests
 - update Guice compiler flag so parameter names are available at runtime, which is required for the errors tests

PiperOrigin-RevId: 337602195
2020-10-16 16:55:03 -07:00
Sam BerlinandGuice Team 02a2e3c5d9 Actually, leave branches: only: master in travis.yml. Otherwise (if we rely on the "don't run Travis on pushes"), then Travis doesn't run on the master commit and we only get the Travis run from the PR. I'd like Travis to run on master commits too. After this submits, I'll tweak the Travis settings again.
PiperOrigin-RevId: 337552114
2020-10-16 12:06:57 -07:00
Sam BerlinandGuice Team b9ee4a56b5 Cleanup travis config: remove jdk9, and remove master branch only requirement. (Instead, Travis is now configured to ignore branch commits entirely.)
PiperOrigin-RevId: 337549300
2020-10-16 11:52:21 -07:00
Guice TeamandGuice Team 9a8e46716e Revert previous change because it broke some tests when running with openjdk8.
PiperOrigin-RevId: 337517262
2020-10-16 09:13:55 -07:00
Guice TeamandGuice Team 2c8c7fed12 Enable the new Guice error messages.
Changes include:
- update Guice tests that asserts error messages
- export new errors tests
- update Guice compiler flag so parameter names are available at runtime, which is required for the errors tests

PiperOrigin-RevId: 337401912
2020-10-15 16:06:22 -07:00
Liam Miller-CushonandGuice Team 180ed4ead4 Replace annotations-in-comments with real annotations
PiperOrigin-RevId: 337365709
2020-10-15 13:03:29 -07:00
Guice TeamandGuice Team 1ae63eb443 Strip embedded class name legend in the case that one Guice error is included in another Guice error.
PiperOrigin-RevId: 336366033
2020-10-09 14:30:12 -07:00
Guice TeamandGuice Team 0781568a6c Fix test when bytecode generation is disabled.
PiperOrigin-RevId: 336311235
2020-10-09 09:51:37 -07:00
Guice TeamandGuice Team dd873be400 Remove AOP build variant.
Changes include:

- skip tests that are testing bytecode generation enabled behaviors
- make line number and source file name information available even when bytecode generation is disabled since it does not use bytecode generation and makes testing easier (some tests rely on the information being available)
- update maven pom files to stop producing a no-aop version of Guice
- added test profile to execute tests with bytecode generation disabled

PiperOrigin-RevId: 336306344
2020-10-09 09:23:54 -07:00
Sam BerlinandGuice Team 0405856c98 Remove after_failure stanza. It breaks Travis integration and it doesn't seem to work anyway. Also fix ant version.
PiperOrigin-RevId: 336301009
2020-10-09 08:53:05 -07:00
Guice TeamandGuice Team 6c6eb52332 Rename guice_aop_option flag to guice_bytecode_gen_option.
This makes it explicit that the flag controls whether Guice uses bytecode generation at runtime and not just method interception (AOP).

PiperOrigin-RevId: 336196985
2020-10-08 17:19:56 -07:00
Guice TeamandGuice Team 36b710d441 Add internal support for recognizing Kotlin nullability in Guice. This will be available publicly in a later CL.
PiperOrigin-RevId: 335965575
2020-10-07 15:29:19 -07:00
Guice TeamandGuice Team deb5a1b3f0 Add an option to control whether AOP is enabled or not.
Also remove some unnecessary methods by inlining the calls.

PiperOrigin-RevId: 335917232
2020-10-07 11:47:10 -07:00
Guice TeamandGuice Team 3bc61ccec2 Add internal support for recognizing Kotlin nullability in Guice. This will be available publicly in a later CL.
PiperOrigin-RevId: 335756454
2020-10-06 17:25:44 -07:00
Guice TeamandGuice Team b7cadc1cfa Migrate several tests to junit4 so that tests that rely on AOP can be skipped using Assume.assumeTrue.
PiperOrigin-RevId: 335755255
2020-10-06 17:18:53 -07:00
Guice TeamandGuice Team b0e5ade45e Add internal support for recognizing Kotlin nullability in Guice. This will be available publicly in a later CL.
PiperOrigin-RevId: 335739263
2020-10-06 15:59:25 -07:00
Guice TeamandGuice Team 690e189a7d Use assumeTrue to skip tests that only need to run under certain conditions.
This requires migrating some tests from JUnit3 to JUnit4.

PiperOrigin-RevId: 335094691
2020-10-02 13:55:43 -07:00
Guice TeamandGuice Team 98f977662f Fix the command used to print out failed tests results.
There are multiple target directories that can have tests report files and they are not located at the root directory. So Change to use grep find reports with failed tests instead.

PiperOrigin-RevId: 335054160
2020-10-02 10:36:54 -07:00
Guice TeamandGuice Team 4312765380 Print out the test report if there are any test failures.
PiperOrigin-RevId: 334849942
2020-10-01 10:53:03 -07:00
Guice TeamandGuice Team 67c957b5e4 Include the @RestrictedBindingSource explanation as a missing binding suggestion.
PiperOrigin-RevId: 334803319
2020-10-01 06:48:28 -07:00
Guice TeamandGuice Team 9997527a93 Quote the duplicate key in DuplicateMapKeyError.
This will ensure that the key will not be modified by Guice's package name compressor.

Also fix package name compressor to handle single letter class names.

PiperOrigin-RevId: 334653432
2020-09-30 12:24:00 -07:00