Commit Graph
17 Commits
Author SHA1 Message Date
Guice TeamandGuice Team 80b91afae2 Update tests to support running with Java 15.
In Java 15, the annotation `toString` implementation omits the member name.

PiperOrigin-RevId: 338746927
2020-10-23 14:37:28 -07:00
Guice TeamandGuice Team 5caa549395 Enable the new Guice error messages.
Changes include:

 - update Guice tests that asserts error messages
 - export new errors tests
 - update Guice compiler flag so parameter names are available at runtime, which is required for the errors tests

PiperOrigin-RevId: 337602195
2020-10-16 16:55:03 -07:00
Guice TeamandGuice Team 9a8e46716e Revert previous change because it broke some tests when running with openjdk8.
PiperOrigin-RevId: 337517262
2020-10-16 09:13:55 -07:00
Guice TeamandGuice Team 2c8c7fed12 Enable the new Guice error messages.
Changes include:
- update Guice tests that asserts error messages
- export new errors tests
- update Guice compiler flag so parameter names are available at runtime, which is required for the errors tests

PiperOrigin-RevId: 337401912
2020-10-15 16:06:22 -07:00
xiaomingjiaandKurt Alfred Kluever af26c72479 Fix some unchecked and rawtypes warnings in Guice code.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=324843912
2020-08-05 09:53:37 -04:00
diamondmandDavid P. Baker c1225dcf8f Change the error message for missingConstructor() to be more similar to missingImplementation() (which is far more often the actual issue).
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=263249646
2019-08-15 14:38:41 -04:00
dpbandRon Shapiro 13ca52bc3b Support Java 9.
Don't assume classloaders are URLClassLoaders. Parse the java.class.path property for URLs if not.
In Java 9, annotations with string values quote them. Make tests and implementations match that behavior.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=170488154
2018-01-25 11:12:58 -05:00
lukesandSam Berlin 34e7c5d715 Run google-java-format on all Guice code.
configure a presubmit to ensure that it stays formatted.

Highlights include:
* simplified import order
* method annotations are now consistently defined on the preceding line
* javadoc reformatted to 100 chars column width

One test that contained line numbers in error messages had to be modified and
the formatter didn't like some of the more complicated preprocessor directives
(MOE and AOP).

To avoid formatting the copyright notices as javadoc i did a preprocessing step to rewrite the initial '/**' to '/*' using perl

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=132718493
2016-09-13 11:47:18 -04:00
lukesandSam Berlin 713c06cce9 Fix issues reported by errorprone
99% of this is adding missing @Override annotations, in the long tail we also have

* insert missing calls to Assert.fail() in tests that are testing exception behavior
* rewrite a few cases of Foo.class.instanceof(c) to c instanceof Foo
* rewrite Class.newInstance - > Class.getConstructor().newInstance() which doesn't break checked exception checking.
* adding @javax.inject.Inject annotations to methods that override methods annotated with @javax.inject.Inject

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=131839622
2016-09-07 17:45:54 -04:00
cssandSam Berlin 036e9a8276 Enable better guice error messages for a missing binding.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=125479432
2016-08-29 16:39:11 -04:00
lukesandSam Berlin 5de3812790 Fix the visibility predicates that are used to decide whether or not to use FastClass in guice.
Due to a bug in cglib, Guice has avoided using fastclass for non public constructors and for protected @Provides methods.  The cglib bug was fixed in cglib 3.2 (recently added to guice).  Also, stop reusing the Visibility.forMember helper to calculate the classloader for FastClass instances.  Visibility.forMember was geared towards AOP usecases where cglib is used to generate a subclass.  FastClass doesn't work that way so I don't believe the predicate make sense and instead I essentially hardcoded SAME_PACKAGE.

Finally, avoid using FastConstructor/FastMethod in a few places to save some stack frames/method calls
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=108259347
2016-01-06 15:19:42 -05:00
Sam Berlin 12857901e5 Guice: Fix for issue 295 (@ProvidedBy doesn't work with enums)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=72100195
2014-08-06 15:45:28 -04:00
Sam Berlin 0558b32449 Update references in code & configuration to point to github instead of
googlecode.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=70898906
2014-07-10 16:39:30 -04:00
guice.mirrorbot@gmail.com efa4e9f24a Fix a bug in the way failed JIT bindings are cleaned up. Because we removed bindings from the jitBindings Map, it was possible for an Injector to try and recreate the failed JIT binding. Normally we want this behavior.. but in the case of a circular failed JIT binding, it can lead to a ComputationException from ComputingConcurrentHashMap, because we attempt to create two ConstructorInjectors for the same InjectionPoint recursively.
Revision created by MOE tool push_codebase.
MOE_MIGRATION=3242


git-svn-id: https://google-guice.googlecode.com/svn/trunk@1584 d779f126-a31b-0410-b53b-1d3aecad763e
2011-09-13 17:41:32 +00:00
sberlin b7a02b02d8 * Remove unused imports
* Sort imports
* Convert tabs to spaces
* Fix the ant no_aop build


Revision created by MOE tool push_codebase.
MOE_MIGRATION=2532


git-svn-id: https://google-guice.googlecode.com/svn/trunk@1572 d779f126-a31b-0410-b53b-1d3aecad763e
2011-07-08 00:34:16 +00:00
sberlin d9c913acca switch Guice from manually repackaging Guava to depending on Guava. it's still jarjar'd right now, which is causing a ~400k increase in guice-snapshot.jar. next step is to switch to ProGuard to remove the unnecessary code and cut it back down (even further?!). this will let people build from Guice source and depend directly on Guava code without having to worry about hiding internal/util.
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1558 d779f126-a31b-0410-b53b-1d3aecad763e
2011-06-26 21:02:54 +00:00
mcculls 74d714c1e7 Issue 552: (step 1) move core code to its own subdirectory
git-svn-id: https://google-guice.googlecode.com/svn/trunk@1300 d779f126-a31b-0410-b53b-1d3aecad763e
2010-10-21 19:10:16 +00:00