From c8e34d4e5ba3c1c3917ed50841ba7d212c58ea3c Mon Sep 17 00:00:00 2001 From: Ryan Di Date: Fri, 19 Apr 2024 20:29:45 +0800 Subject: [PATCH] reduce hit threshold --- packages/excalidraw/components/App.tsx | 2 +- .../__snapshots__/contextmenu.test.tsx.snap | 56 +++++++++---------- .../excalidraw/tests/contextmenu.test.tsx | 36 ++++++------ 3 files changed, 47 insertions(+), 47 deletions(-) diff --git a/packages/excalidraw/components/App.tsx b/packages/excalidraw/components/App.tsx index bdd4bc29a..1b0340407 100644 --- a/packages/excalidraw/components/App.tsx +++ b/packages/excalidraw/components/App.tsx @@ -4600,7 +4600,7 @@ class App extends React.Component { } private getHitThreshold() { - return 10 / this.state.zoom.value; + return 8 / this.state.zoom.value; } private hitElement( diff --git a/packages/excalidraw/tests/__snapshots__/contextmenu.test.tsx.snap b/packages/excalidraw/tests/__snapshots__/contextmenu.test.tsx.snap index 7f9b791e5..813f64266 100644 --- a/packages/excalidraw/tests/__snapshots__/contextmenu.test.tsx.snap +++ b/packages/excalidraw/tests/__snapshots__/contextmenu.test.tsx.snap @@ -2170,14 +2170,14 @@ exports[`contextMenu element > selecting 'Delete' in context menu deletes elemen "roundness": { "type": 3, }, - "seed": 1278240551, + "seed": 449462985, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 4, - "versionNonce": 1150084233, + "versionNonce": 1014066025, "width": 20, "x": -10, "y": 0, @@ -2404,14 +2404,14 @@ exports[`contextMenu element > selecting 'Duplicate' in context menu duplicates "roundness": { "type": 3, }, - "seed": 1278240551, + "seed": 449462985, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 3, - "versionNonce": 401146281, + "versionNonce": 1150084233, "width": 20, "x": -10, "y": 0, @@ -2438,14 +2438,14 @@ exports[`contextMenu element > selecting 'Duplicate' in context menu duplicates "roundness": { "type": 3, }, - "seed": 1150084233, + "seed": 1014066025, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 4, - "versionNonce": 1116226695, + "versionNonce": 238820263, "width": 20, "x": 0, "y": 10, @@ -2704,14 +2704,14 @@ exports[`contextMenu element > selecting 'Group selection' in context menu group "roundness": { "type": 3, }, - "seed": 1278240551, + "seed": 449462985, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 4, - "versionNonce": 1505387817, + "versionNonce": 493213705, "width": 20, "x": -10, "y": 0, @@ -2740,14 +2740,14 @@ exports[`contextMenu element > selecting 'Group selection' in context menu group "roundness": { "type": 3, }, - "seed": 1150084233, + "seed": 1014066025, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 4, - "versionNonce": 23633383, + "versionNonce": 915032327, "width": 20, "x": 20, "y": 30, @@ -3060,14 +3060,14 @@ exports[`contextMenu element > selecting 'Paste styles' in context menu pastes s "roundness": { "type": 3, }, - "seed": 1278240551, + "seed": 449462985, "strokeColor": "#e03131", "strokeStyle": "dotted", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 4, - "versionNonce": 640725609, + "versionNonce": 941653321, "width": 20, "x": -10, "y": 0, @@ -3094,14 +3094,14 @@ exports[`contextMenu element > selecting 'Paste styles' in context menu pastes s "roundness": { "type": 3, }, - "seed": 760410951, + "seed": 289600103, "strokeColor": "#e03131", "strokeStyle": "dotted", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 9, - "versionNonce": 1315507081, + "versionNonce": 640725609, "width": 20, "x": 20, "y": 30, @@ -3840,14 +3840,14 @@ exports[`contextMenu element > selecting 'Send to back' in context menu sends el "roundness": { "type": 3, }, - "seed": 1150084233, + "seed": 1014066025, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 4, - "versionNonce": 1604849351, + "versionNonce": 23633383, "width": 20, "x": 20, "y": 30, @@ -3874,14 +3874,14 @@ exports[`contextMenu element > selecting 'Send to back' in context menu sends el "roundness": { "type": 3, }, - "seed": 1278240551, + "seed": 449462985, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 3, - "versionNonce": 401146281, + "versionNonce": 1150084233, "width": 20, "x": -10, "y": 0, @@ -5224,8 +5224,8 @@ exports[`contextMenu element > shows 'Group selection' in context menu for multi }, }, ], - "left": -19, - "top": -9, + "left": -17, + "top": -7, }, "currentChartType": "bar", "currentItemBackgroundColor": "transparent", @@ -5342,14 +5342,14 @@ exports[`contextMenu element > shows 'Group selection' in context menu for multi "roundness": { "type": 3, }, - "seed": 449462985, + "seed": 453191, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 3, - "versionNonce": 1150084233, + "versionNonce": 1014066025, "width": 10, "x": -10, "y": 0, @@ -5376,14 +5376,14 @@ exports[`contextMenu element > shows 'Group selection' in context menu for multi "roundness": { "type": 3, }, - "seed": 1014066025, + "seed": 400692809, "strokeColor": "#1e1e1e", "strokeStyle": "solid", "strokeWidth": 2, "type": "rectangle", "updated": 1, "version": 3, - "versionNonce": 1604849351, + "versionNonce": 23633383, "width": 10, "x": 12, "y": 0, @@ -6349,8 +6349,8 @@ exports[`contextMenu element > shows 'Ungroup selection' in context menu for gro }, }, ], - "left": -19, - "top": -9, + "left": -17, + "top": -7, }, "currentChartType": "bar", "currentItemBackgroundColor": "transparent", @@ -8181,8 +8181,8 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap }, }, ], - "left": -19, - "top": -9, + "left": -17, + "top": -7, }, "currentChartType": "bar", "currentItemBackgroundColor": "transparent", diff --git a/packages/excalidraw/tests/contextmenu.test.tsx b/packages/excalidraw/tests/contextmenu.test.tsx index 841f83560..89ad68f73 100644 --- a/packages/excalidraw/tests/contextmenu.test.tsx +++ b/packages/excalidraw/tests/contextmenu.test.tsx @@ -108,8 +108,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu(); const contextMenuOptions = @@ -199,8 +199,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu(); @@ -255,8 +255,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu(); @@ -297,8 +297,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu(); expect(copiedStyles).toBe("{}"); @@ -382,8 +382,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu(); fireEvent.click(queryAllByText(contextMenu!, "Delete")[0]); @@ -398,8 +398,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu(); fireEvent.click(queryByText(contextMenu!, "Add to library")!); @@ -417,8 +417,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu(); fireEvent.click(queryByText(contextMenu!, "Duplicate")!); @@ -548,8 +548,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu(); fireEvent.click(queryByText(contextMenu!, "Group selection")!); @@ -578,8 +578,8 @@ describe("contextMenu element", () => { fireEvent.contextMenu(GlobalTestState.interactiveCanvas, { button: 2, - clientX: 1, - clientY: 1, + clientX: 3, + clientY: 3, }); const contextMenu = UI.queryContextMenu();