rbygrave
ceea705a76
Treat json Jackson collections the same wrt mutation detection
2021-07-30 20:20:03 +12:00
rbygrave
d9f7531e81
Tidy tests only - TestDbJson_Jackson3 TestJacksonPlainBean
2021-07-30 17:26:46 +12:00
rbygrave
7bd7640c63
Update test TestDbJson_Jackson3 showing HASH mode is used even on ModifyAwareType
2021-07-30 17:18:28 +12:00
rbygrave
ca1636ff9e
Fix when json/jackson bean inserted as null and not changed
...
Expectation is that it is not included in update (still null, no change)
2021-07-30 17:16:05 +12:00
rbygrave
ea741d0169
Update TestDbJson_Jackson3 with comments
2021-07-30 15:41:52 +12:00
rbygrave
c43e2e6956
Update TestDbJson_Jackson3
2021-07-30 15:34:54 +12:00
rbygrave
822fb7325a
Due to mutableNext handling, with checkMutableProperties() even when known dirty go into beanProperty.checkMutable()
...
As per rPraml's PR and comment
Due to handling of mutableNext we need checkMutableProperties() to call into what is now beanProperty.checkMutable() even when we already know it's dirty.
2021-07-29 23:37:29 +12:00
rbygrave
20e0eb1021
Re-enable TestDbJson_Jackson3 via adding mutationDetection = HASH to beanList property
...
@DbJsonB(mutationDetection = HASH)
List<PlainBean> beanList;
2021-07-29 23:17:11 +12:00
rbygrave
20becf951d
Use MutationDetection replacing dirtyDetection and keepSource
...
Also adds NoMutationDetection to support NONE
2021-07-29 23:11:42 +12:00
rbygrave
5aa8557168
Update tests only - TestJacksonPlainBean with dirtyDetection = false property
2021-07-29 16:29:10 +12:00
rbygrave
c66d248e96
Add MutableValueNext to replace mutableContent such that hash compute is only done once
...
Adds MutableValueInfo.nextDirty() to replace the isEqualToJson() method. The next is computed once and stored. BindablePropertyJsonUpdate makes the .mutableNext(propertyIndex) call to move the next MutableValueInfo and return the json content.
2021-07-29 15:42:16 +12:00
rbygrave
0d8e7c852b
Change Checksum to use CRC32
2021-07-29 15:32:06 +12:00
rbygrave
991c6d6b5c
No effective change - tidy FactoryProperty
2021-07-29 13:30:15 +12:00
rbygrave
2bc5d3d325
Refactor rename MutableHash to MutableValueInfo (and subsequent rename on methods etc)
2021-07-29 13:20:30 +12:00
rbygrave
5ad8e7ead4
Use new @DbJson dirtyDetection and keepSource attributes
...
- Bump ebean-annotation with new @DbJson dirtyDetection and keepSource attributes
- Get those to BeanPropertyJsonMapper to chose MutableHash implementation
- Modify MD5MutableHash to include check for isDirty()
- EBasicJsonList needs keepSource=true to pass that test with oldValue
2021-07-29 12:47:10 +12:00
rbygrave
8832bbc57f
No effective change - format EntityBeanIntercept only
...
Plus adjust timing on SqlQueryCancelTest
2021-07-29 12:43:37 +12:00
rbygrave
86483ff947
Use scalarType.format(value) removing scalarType.jsonMapper(value)
...
Remove scalarType.jsonMapper(value) as we can just use format(value) instead
2021-07-29 11:52:15 +12:00
rbygrave
92d7a7562f
Tidy only - no functional change to MutableHash and BeanPropertyJsonMapper
2021-07-29 11:49:01 +12:00
rbygrave
52fe3cf3c8
Change from MD5 to Checksum (Adler32) for json content dirty detection
2021-07-29 11:40:05 +12:00
rbygrave
94fb6414fa
Refactor move createMutableHash() method from ScalarType to BeanProperty / BeanPropertyJsonMapper
2021-07-29 11:28:25 +12:00
rbygrave
d0270dbc6a
Temporarily disable TestDbJson_Jackson3 updateIncludesJsonColumn_when_list_loadedAndNotDirtyAware()
...
BeanState state = DB.getBeanState(found);
assertThat(state.getChangedProps()).containsExactlyInAnyOrder("beanList");
// this test fails, because we have a OmList instead of a GenericObject
// TODO: Can/Should we enhance the @DbJson/@DbJsonB annotations with a property "dirtyDetection"
2021-07-29 11:21:38 +12:00
Roland Praml
b497b8635b
some refactor and tidying
2021-07-28 17:22:29 +02:00
Roland Praml
5e595ec5f8
Proof of concept to support also bean change detection / changelog on mutable properties
2021-07-28 14:54:56 +02:00
rbygrave
49b86d07d3
Modify SqlBeanLoad to use readSet()
...
Note that we don't need to use readSetIntercept() now as there is no property change listener support
2021-07-28 22:48:29 +12:00
rbygrave
11eed4cfe9
Add BeanPropertyJsonMapper for JSON dirty detection
2021-07-28 21:43:57 +12:00
rbygrave
6c262f1df5
JSON bean dirty detection via MD5 of JSON string content
...
- MD5 of json content stored on EntityBeanIntercept for dirty detection
- Only convert to JSON once (at dirty detection time). Store this json content on EntityBeanIntercept to later push to ScalarTypeJsonObjectMapper for bind
Should consider alternative to extend BeanProperty rather than have these if blocks.
2021-07-23 16:50:24 +12:00
rbygrave
492bb98e0e
#2269 - findSingleAttributeList does not filter soft-deleted record
2021-07-22 17:12:06 +12:00
Rob Bygrave and GitHub
103b75172d
Merge pull request #2267 from FOCONIS/pr/bugfix/connection_closed_on_clob
...
Retrieve (C|B)LOB on SqlRow construction
2021-07-22 16:44:05 +12:00
rbygrave
0baa3a0eac
#2270 - ebean-agent enhancement NPE with MappedSuperclass with no properties that uses named database
2021-07-22 16:38:28 +12:00
Jonas Pöhler
3d4de4dee5
FIX TestRawSqlService and TestRawSqlBuilder
2021-07-16 15:17:04 +02:00
Jonas Pöhler
c621435a28
Merge remote-tracking branch 'ebean/master' into pr/bugfix/connection_closed_on_clob
2021-07-16 13:32:24 +02:00
rbygrave
7408483a43
#2264 - Use of default timezone for OffsetDateTime offsets problematic for unit tests and presentation layer
2021-07-15 17:14:22 +12:00
rbygrave
4d15535381
No functional change - tidy DefaultDbSqlContext
2021-07-13 16:48:45 +12:00
Rob Bygrave and GitHub
787c2f90f2
Merge pull request #2188 from FOCONIS/fix-order-by
...
FIX: orderBy does not work when used on formula property
2021-07-13 16:41:33 +12:00
Rob Bygrave and GitHub
e590a2149d
Merge pull request #2257 from FOCONIS/queries-are-cancelable
...
Queries are cancelable
2021-07-13 16:11:36 +12:00
Rob Bygrave and GitHub
29582b57f7
Merge pull request #2256 from FOCONIS/many-where-support
...
Improved @Where support, especially for Many-to-many tables
2021-07-13 15:01:49 +12:00
rbygrave
2763f333d4
#2262 - Tidy tests for Transaction postCommit Callback
2021-07-13 14:48:40 +12:00
rbygrave
8840628d34
#2262 - Transaction postCommit Callback not invoked when the active transaction has no database writes
2021-07-13 14:45:48 +12:00
rbygrave
6fb28d7ded
#2255 Specific test for setParameter cannot assigning the value when parameter in selecting section of query
2021-07-13 12:54:21 +12:00
rbygrave
e82b8c80f0
#2265 - ArrayIndexOutOfBoundsException: Index -1 out of bounds with @IdClass and batch insert accessing id property
2021-07-13 11:30:31 +12:00
Roland Praml
824cfa27be
Queries are cancelable
2021-06-23 17:11:21 +02:00
Roland Praml
66cb6d5e7d
Imporved @Where support, especially for Many-to-many tables
2021-06-21 14:50:15 +02:00
rbygrave
8f432aa0a9
#2251 - Transparent persistence of to-many associations (with orphanRemoval)
2021-06-18 16:05:25 +12:00
rbygrave
4aa4137abe
Merge branch 'transparent_persistence' of https://github.com/cit-consulting/ebean into cit-consulting-transparent_persistence
2021-06-18 13:03:36 +12:00
rbygrave
f4bb4e1b6a
#2254 - OraclePlatform needs columnAliasPrefix 'c' - Regression in version 12.2.1 due to #1967
2021-06-18 12:37:16 +12:00
rbygrave
7af4e166a4
#2253 - Incorrect JSON format for LocalDateTime. Includes Z suffix when it should not.
2021-06-17 13:26:34 +12:00
Vladimir Konkov
1fa488d870
Test for transparent persistence of to-many associations
2021-06-14 16:20:25 +03:00
rbygrave
55bc498f9d
No functional change - refactor QueryIterator to use Iterator.remove()
...
default method
Iterator.remove() has a default implementation that throws UnsupportedOperationException which is what we want. Remove the close() method from QueryIterator and implementations so that we just use the Iterator.remove() default implementation.
2021-06-11 10:20:47 +12:00
rbygrave
884dd939b7
#2249 - Bug with DbJson Jackson property that is null is updated as null (unnecessarily included in update)
...
When the value is null and not changed then is was null before and should not be treated as dirty. Hence only check for dirty when value != null in BeanDescriptor 3182
2021-06-11 00:19:20 +12:00
rbygrave
4e088a40d9
Refactor DbJson Jackson handling adding DatabaseConfig.setJsonDirtyByDefault()
...
Adds the ability to change the default "jsonDirtyByDefault" configuration setting used with DbJson Jackson properties. Currently these default to being assumed dirty and this allows us to change that to be assumed not dirty (which is very likely the better default).
2021-06-11 00:08:03 +12:00