diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java b/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java index e19212e96..7a012d034 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java @@ -391,7 +391,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setUseDocStore(boolean useDocStore) { + public Query setUseDocStore(boolean useDocStore) { this.useDocStore = useDocStore; return this; } @@ -431,7 +431,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setAllowLoadErrors() { + public Query setAllowLoadErrors() { this.allowLoadErrors = true; return this; } @@ -452,21 +452,21 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery asOf(Timestamp asOfDateTime) { + public Query asOf(Timestamp asOfDateTime) { this.temporalMode = (asOfDateTime != null) ? TemporalMode.AS_OF : TemporalMode.CURRENT; this.asOf = asOfDateTime; return this; } @Override - public DefaultOrmQuery asDraft() { + public Query asDraft() { this.temporalMode = TemporalMode.DRAFT; this.useBeanCache = CacheMode.OFF; return this; } @Override - public DefaultOrmQuery setIncludeSoftDeletes() { + public Query setIncludeSoftDeletes() { this.temporalMode = TemporalMode.SOFT_DELETED; return this; } @@ -489,7 +489,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setRawSql(RawSql rawSql) { + public Query setRawSql(RawSql rawSql) { this.rawSql = (SpiRawSql) rawSql; return this; } @@ -802,12 +802,12 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery copy() { + public SpiQuery copy() { return copy(server); } @Override - public DefaultOrmQuery copy(SpiEbeanServer server) { + public SpiQuery copy(SpiEbeanServer server) { DefaultOrmQuery copy = new DefaultOrmQuery<>(beanDescriptor, server, expressionFactory); copy.transaction = transaction; copy.m2mIncludeJoin = m2mIncludeJoin; @@ -955,7 +955,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setAutoTune(boolean autoTune) { + public Query setAutoTune(boolean autoTune) { this.autoTune = autoTune; return this; } @@ -971,21 +971,21 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery forUpdate() { + public Query forUpdate() { return setForUpdateWithMode(LockWait.WAIT, LockType.DEFAULT); } @Override - public DefaultOrmQuery forUpdateNoWait() { + public Query forUpdateNoWait() { return setForUpdateWithMode(LockWait.NOWAIT, LockType.DEFAULT); } @Override - public DefaultOrmQuery forUpdateSkipLocked() { + public Query forUpdateSkipLocked() { return setForUpdateWithMode(LockWait.SKIPLOCKED, LockType.DEFAULT); } - private DefaultOrmQuery setForUpdateWithMode(LockWait mode, LockType lockType) { + private Query setForUpdateWithMode(LockWait mode, LockType lockType) { this.forUpdate = mode; this.lockType = lockType; this.useBeanCache = CacheMode.OFF; @@ -1329,7 +1329,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setReadOnly(boolean readOnly) { + public Query setReadOnly(boolean readOnly) { this.readOnly = readOnly; return this; } @@ -1375,19 +1375,19 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setUseQueryCache(CacheMode useQueryCache) { + public Query setUseQueryCache(CacheMode useQueryCache) { this.useQueryCache = useQueryCache; return this; } @Override - public DefaultOrmQuery setLoadBeanCache(boolean loadBeanCache) { + public Query setLoadBeanCache(boolean loadBeanCache) { this.useBeanCache = CacheMode.PUT; return this; } @Override - public DefaultOrmQuery setTimeout(int secs) { + public Query setTimeout(int secs) { this.timeout = secs; return this; } @@ -1413,19 +1413,19 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery select(String columns) { + public Query select(String columns) { detail.select(columns); return this; } @Override - public DefaultOrmQuery select(FetchGroup fetchGroup) { + public Query select(FetchGroup fetchGroup) { this.detail = ((SpiFetchGroup) fetchGroup).detail(); return this; } @Override - public DefaultOrmQuery fetch(String property) { + public Query fetch(String property) { return fetch(property, null, null); } @@ -1444,12 +1444,12 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery fetch(String property, FetchConfig joinConfig) { + public Query fetch(String property, FetchConfig joinConfig) { return fetch(property, null, joinConfig); } @Override - public DefaultOrmQuery fetch(String property, String columns) { + public Query fetch(String property, String columns) { return fetch(property, columns, null); } @@ -1469,7 +1469,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery fetch(String property, String columns, FetchConfig config) { + public Query fetch(String property, String columns, FetchConfig config) { detail.fetch(property, columns, config); return this; } @@ -1633,7 +1633,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setParameter(Object value) { + public Query setParameter(Object value) { if (bindParams == null) { bindParams = new BindParams(); } @@ -1642,7 +1642,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setParameters(Object... values) { + public Query setParameters(Object... values) { if (bindParams == null) { bindParams = new BindParams(); } @@ -1656,7 +1656,7 @@ public class DefaultOrmQuery implements SpiQuery { * have in the query. */ @Override - public DefaultOrmQuery setParameter(int position, Object value) { + public Query setParameter(int position, Object value) { if (bindParams == null) { bindParams = new BindParams(); } @@ -1668,7 +1668,7 @@ public class DefaultOrmQuery implements SpiQuery { * Set a named bind parameter. Named parameters have a colon to prefix the name. */ @Override - public DefaultOrmQuery setParameter(String name, Object value) { + public Query setParameter(String name, Object value) { if (namedParams != null) { ONamedParam param = namedParams.get(name); if (param != null) { @@ -1714,12 +1714,12 @@ public class DefaultOrmQuery implements SpiQuery { @Override @Deprecated - public DefaultOrmQuery orderBy(String orderByClause) { + public Query orderBy(String orderByClause) { return order(orderByClause); } @Override - public DefaultOrmQuery order(String orderByClause) { + public Query order(String orderByClause) { if (orderByClause == null || orderByClause.trim().isEmpty()) { this.orderBy = null; } else { @@ -1730,12 +1730,12 @@ public class DefaultOrmQuery implements SpiQuery { @Override @Deprecated - public DefaultOrmQuery setOrderBy(OrderBy orderBy) { + public Query setOrderBy(OrderBy orderBy) { return setOrder(orderBy); } @Override - public DefaultOrmQuery setOrder(OrderBy orderBy) { + public Query setOrder(OrderBy orderBy) { this.orderBy = orderBy; if (orderBy != null) { orderBy.setQuery(this); @@ -1767,13 +1767,13 @@ public class DefaultOrmQuery implements SpiQuery { * Internally set to use SQL DISTINCT on the query but still have id property included. */ @Override - public DefaultOrmQuery setDistinct(boolean distinct) { + public Query setDistinct(boolean distinct) { this.distinct = distinct; return this; } @Override - public DefaultOrmQuery setCountDistinct(CountDistinctOrder countDistinctOrder) { + public Query setCountDistinct(CountDistinctOrder countDistinctOrder) { this.countDistinctOrder = countDistinctOrder; return this; } @@ -1824,7 +1824,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setDisableLazyLoading(boolean disableLazyLoading) { + public Query setDisableLazyLoading(boolean disableLazyLoading) { this.disableLazyLoading = disableLazyLoading; return this; } @@ -1840,7 +1840,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setFirstRow(int firstRow) { + public Query setFirstRow(int firstRow) { this.firstRow = firstRow; return this; } @@ -1851,7 +1851,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setMaxRows(int maxRows) { + public Query setMaxRows(int maxRows) { this.maxRows = maxRows; return this; } @@ -1862,7 +1862,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setMapKey(String mapKey) { + public Query setMapKey(String mapKey) { this.mapKey = mapKey; return this; } @@ -1873,7 +1873,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery setId(Object id) { + public Query setId(Object id) { if (id == null) { throw new NullPointerException("The id is null"); } @@ -1887,7 +1887,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery where(Expression expression) { + public Query where(Expression expression) { where().add(expression); return this; } @@ -1917,7 +1917,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery having(Expression expression) { + public Query having(Expression expression) { having().add(expression); return this; } @@ -2043,7 +2043,7 @@ public class DefaultOrmQuery implements SpiQuery { } @Override - public DefaultOrmQuery alias(String alias) { + public Query alias(String alias) { this.rootTableAlias = alias; return this; } diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/querydefn/OrmQueryPlanKeyTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/querydefn/OrmQueryPlanKeyTest.java index 0c2f07e98..305f9122b 100644 --- a/ebean-core/src/test/java/io/ebeaninternal/server/querydefn/OrmQueryPlanKeyTest.java +++ b/ebean-core/src/test/java/io/ebeaninternal/server/querydefn/OrmQueryPlanKeyTest.java @@ -18,8 +18,7 @@ import static org.assertj.core.api.Assertions.assertThat; public class OrmQueryPlanKeyTest extends BaseExpressionTest { - - @SuppressWarnings("unchecked") + @SuppressWarnings({"unchecked", "rawtypes"}) private DefaultOrmQuery query() { return (DefaultOrmQuery) server().find(Customer.class); } @@ -85,41 +84,40 @@ public class OrmQueryPlanKeyTest extends BaseExpressionTest { @Test public void equals_when_firstRowsDifferent() { - CQueryPlanKey key1 = query().setFirstRow(10).createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setFirstRow(10)); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); - key1 = query().setFirstRow(10).createQueryPlanKey(); - key2 = query().setFirstRow(9).createQueryPlanKey(); + key1 = planKey(query().setFirstRow(10)); + key2 = planKey(query().setFirstRow(9)); assertDifferent(key1, key2); - key1 = query().createQueryPlanKey(); - key2 = query().setFirstRow(9).createQueryPlanKey(); + key1 = planKey(query()); + key2 = planKey(query().setFirstRow(9)); assertDifferent(key1, key2); } @Test public void equals_when_maxRowsDifferent() { - CQueryPlanKey key1 = query().setMaxRows(10).createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setMaxRows(10)); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); - key1 = query().setMaxRows(10).createQueryPlanKey(); - key2 = query().setMaxRows(9).createQueryPlanKey(); + key1 = planKey(query().setMaxRows(10)); + key2 = planKey(query().setMaxRows(9)); assertDifferent(key1, key2); - key1 = query().createQueryPlanKey(); - key2 = query().setMaxRows(9).createQueryPlanKey(); + key1 = planKey(query()); + key2 = planKey(query().setMaxRows(9)); assertDifferent(key1, key2); - } @Test public void equals_when_firstRowsMaxRowsSame() { - CQueryPlanKey key1 = query().setMaxRows(10).setFirstRow(20).createQueryPlanKey(); - CQueryPlanKey key2 = query().setFirstRow(20).setMaxRows(10).createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setMaxRows(10).setFirstRow(20)); + CQueryPlanKey key2 = planKey(query().setFirstRow(20).setMaxRows(10)); assertSame(key1, key2); } @@ -132,43 +130,43 @@ public class OrmQueryPlanKeyTest extends BaseExpressionTest { @Test public void equals_when_diffOrderByNull() { - CQueryPlanKey key1 = query().order("id").createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().order("id")); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); - key1 = ((DefaultOrmQuery) query().order().asc("id")).createQueryPlanKey(); - key2 = query().createQueryPlanKey(); + key1 = planKey(query().order().asc("id")); + key2 = planKey(query()); assertDifferent(key1, key2); } @Test public void equals_when_orderBySame() { - CQueryPlanKey key1 = query().order("id, name").createQueryPlanKey(); - CQueryPlanKey key2 = query().order("id, name").createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().order("id, name")); + CQueryPlanKey key2 = planKey(query().order("id, name")); assertSame(key1, key2); } @Test public void equals_when_diffDistinct() { - CQueryPlanKey key1 = query().setDistinct(true).createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setDistinct(true)); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); } @Test public void equals_when_sameDistinct() { - CQueryPlanKey key1 = query().setDistinct(true).createQueryPlanKey(); - CQueryPlanKey key2 = query().setDistinct(true).createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setDistinct(true)); + CQueryPlanKey key2 = planKey(query().setDistinct(true)); assertSame(key1, key2); } @Test public void equals_when_useDocStore() { - CQueryPlanKey key1 = query().setUseDocStore(true).createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setUseDocStore(true)); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); } @@ -176,79 +174,78 @@ public class OrmQueryPlanKeyTest extends BaseExpressionTest { @Test public void equals_when_diffMapKey() { - CQueryPlanKey key1 = query().setMapKey("name").createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setMapKey("name")); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); - CQueryPlanKey key3 = query().setMapKey("email").createQueryPlanKey(); + CQueryPlanKey key3 = planKey(query().setMapKey("email")); assertDifferent(key1, key3); - CQueryPlanKey key4 = query().setMapKey("name").createQueryPlanKey(); + CQueryPlanKey key4 = planKey(query().setMapKey("name")); assertSame(key1, key4); } @Test public void equals_when_diffIdNull() { - CQueryPlanKey key1 = query().setId(42).createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setId(42)); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); } @Test public void equals_when_idBothGiven() { - CQueryPlanKey key1 = query().setId(42).createQueryPlanKey(); - CQueryPlanKey key2 = query().setId(23).createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().setId(42)); + CQueryPlanKey key2 = planKey(query().setId(23)); assertSame(key1, key2); } @Test public void equals_when_diffTemporalMode() { - CQueryPlanKey key1 = query().createQueryPlanKey(); - CQueryPlanKey key2 = query().asDraft().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query()); + CQueryPlanKey key2 = planKey(query().asDraft()); assertDifferent(key1, key2); - CQueryPlanKey key3 = query().asOf(new Timestamp(System.currentTimeMillis())).createQueryPlanKey(); + CQueryPlanKey key3 = planKey(query().asOf(new Timestamp(System.currentTimeMillis()))); assertDifferent(key1, key3); - CQueryPlanKey key4 = query().setIncludeSoftDeletes().createQueryPlanKey(); + CQueryPlanKey key4 = planKey(query().setIncludeSoftDeletes()); assertDifferent(key1, key4); } @Test public void equals_when_diffForUpdate() { - CQueryPlanKey key1 = query().forUpdate().createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().forUpdate()); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); - CQueryPlanKey key3 = query().forUpdateNoWait().createQueryPlanKey(); + CQueryPlanKey key3 = planKey(query().forUpdateNoWait()); assertDifferent(key1, key3); - CQueryPlanKey key4 = query().forUpdateSkipLocked().createQueryPlanKey(); + CQueryPlanKey key4 = planKey(query().forUpdateSkipLocked()); assertDifferent(key1, key4); - CQueryPlanKey key5 = query().forUpdate().createQueryPlanKey(); + CQueryPlanKey key5 = planKey(query().forUpdate()); assertSame(key1, key5); } @Test public void equals_when_diffRootAliasNull() { - CQueryPlanKey key1 = query().alias("alias").createQueryPlanKey(); - CQueryPlanKey key2 = query().createQueryPlanKey(); + CQueryPlanKey key1 = planKey(query().alias("alias")); + CQueryPlanKey key2 = planKey(query()); assertDifferent(key1, key2); - CQueryPlanKey key3 = query().alias("diff").createQueryPlanKey(); + CQueryPlanKey key3 = planKey(query().alias("diff")); assertDifferent(key1, key3); - CQueryPlanKey key4 = query().alias("alias").createQueryPlanKey(); + CQueryPlanKey key4 = planKey(query().alias("alias")); assertSame(key1, key4); } - private DefaultOrmQuery list_id_eq_42() { return (DefaultOrmQuery) server().find(Customer.class) .where().eq("id", 42).query(); @@ -298,7 +295,6 @@ public class OrmQueryPlanKeyTest extends BaseExpressionTest { assertDifferent(key1, key4); } - @Test public void equals_when_sameHaving() { @@ -309,7 +305,7 @@ public class OrmQueryPlanKeyTest extends BaseExpressionTest { @Test public void equals_when_manualId_andSelectClause() { - DefaultOrmQuery q1 = query().select("name"); + DefaultOrmQuery q1 = (DefaultOrmQuery)query().select("name"); q1.setManualId(); assertDifferent(q1, query().select("name")); @@ -327,16 +323,19 @@ public class OrmQueryPlanKeyTest extends BaseExpressionTest { return planKey(id.query()); } + @SuppressWarnings({"rawtypes"}) private CQueryPlanKey planKey(Query query) { return ((DefaultOrmQuery) query).createQueryPlanKey(); } - private void assertDifferent(DefaultOrmQuery q1, DefaultOrmQuery q2) { - assertDifferent(q1.createQueryPlanKey(), q2.createQueryPlanKey()); + @SuppressWarnings({"unchecked", "rawtypes"}) + private void assertDifferent(Query q1, Query q2) { + assertDifferent(planKey(q1), planKey(q2)); } - private void assertSame(DefaultOrmQuery q1, DefaultOrmQuery q2) { - assertSame(q1.createQueryPlanKey(), q2.createQueryPlanKey()); + @SuppressWarnings({"unchecked", "rawtypes"}) + private void assertSame(Query q1, Query q2) { + assertSame(planKey(q1), planKey(q2)); } private void assertDifferent(CQueryPlanKey key1, CQueryPlanKey key2) {