Internal refactor / tidy - Suggestions from intellij code analysis. (#1209)

This commit is contained in:
Koen De Groote
2017-11-14 18:19:38 +13:00
committed by Rob Bygrave
parent 0056568bc7
commit f1ebe7929b
29 changed files with 66 additions and 59 deletions
@@ -68,7 +68,7 @@ public class IdInExpression extends NonPrepareExpression {
DefaultExpressionRequest r = (DefaultExpressionRequest) request;
BeanDescriptor<?> descriptor = r.getBeanDescriptor();
IdBinder idBinder = descriptor.getIdBinder();
if (idCollection.size() == 0) {
if (idCollection.isEmpty()) {
request.append("1=0"); // append false for this stage
} else {
request.append(descriptor.getIdBinder().getBindIdInSql(null));
@@ -83,7 +83,7 @@ public class IdInExpression extends NonPrepareExpression {
DefaultExpressionRequest r = (DefaultExpressionRequest) request;
BeanDescriptor<?> descriptor = r.getBeanDescriptor();
IdBinder idBinder = descriptor.getIdBinder();
if (idCollection.size() == 0) {
if (idCollection.isEmpty()) {
request.append("1=0"); // append false for this stage
} else {
request.append(descriptor.getIdBinderInLHSSql());