mirror of
https://github.com/ebean-orm/ebean.git
synced 2024-04-21 10:51:47 +00:00
FIX: possible resource leaking in testcases (all created transactions are closed by followed try statement) (#1273)
This commit is contained in:
committed by
Rob Bygrave
parent
8e9843ab8a
commit
e3425a8850
@@ -77,29 +77,30 @@ public class TestExplicitTransactionMode extends BaseTestCase {
|
||||
UTMaster bean3 = new UTMaster("three3");
|
||||
|
||||
// use a different transaction to do final query check
|
||||
Transaction otherTxn = ebeanServer.createTransaction();
|
||||
Transaction txn = ebeanServer.beginTransaction();
|
||||
try (Transaction otherTxn = ebeanServer.createTransaction()) {
|
||||
|
||||
try {
|
||||
ebeanServer.save(bean1);
|
||||
ebeanServer.save(bean2);
|
||||
Transaction txn = ebeanServer.beginTransaction();
|
||||
try {
|
||||
ebeanServer.save(bean1);
|
||||
ebeanServer.save(bean2);
|
||||
|
||||
// not visible in other transaction
|
||||
Query<UTMaster> query2 = ebeanServer.find(UTMaster.class);
|
||||
details = ebeanServer.findList(query2, otherTxn);
|
||||
assertEquals(0, details.size());
|
||||
// not visible in other transaction
|
||||
Query<UTMaster> query2 = ebeanServer.find(UTMaster.class);
|
||||
details = ebeanServer.findList(query2, otherTxn);
|
||||
assertEquals(0, details.size());
|
||||
|
||||
ebeanServer.save(bean3);
|
||||
ebeanServer.save(bean3);
|
||||
|
||||
txn.commit();
|
||||
txn.commit();
|
||||
|
||||
} finally {
|
||||
txn.end();
|
||||
} finally {
|
||||
txn.end();
|
||||
}
|
||||
|
||||
// commit as expected
|
||||
Query<UTMaster> query3 = ebeanServer.find(UTMaster.class);
|
||||
details = ebeanServer.findList(query3, otherTxn);
|
||||
assertEquals(3, details.size());
|
||||
}
|
||||
|
||||
// commit as expected
|
||||
Query<UTMaster> query3 = ebeanServer.find(UTMaster.class);
|
||||
details = ebeanServer.findList(query3, otherTxn);
|
||||
assertEquals(3, details.size());
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user