From ca7e5b79b8e0f00f07d4da19fd8bfe0a307a24e4 Mon Sep 17 00:00:00 2001 From: Rob Bygrave Date: Mon, 11 Jun 2018 00:04:58 +1200 Subject: [PATCH] #1412 - Fix Resource leaks for properties & yaml files etc - ManifestReader Not fixing a leak but just changing to use try with resources --- .../server/core/bootup/ManifestReader.java | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/main/java/io/ebeaninternal/server/core/bootup/ManifestReader.java b/src/main/java/io/ebeaninternal/server/core/bootup/ManifestReader.java index c4c1982b0..1a1e89f36 100644 --- a/src/main/java/io/ebeaninternal/server/core/bootup/ManifestReader.java +++ b/src/main/java/io/ebeaninternal/server/core/bootup/ManifestReader.java @@ -59,11 +59,8 @@ class ManifestReader { try { Enumeration resources = classLoader.getResources(resourcePath); while (resources.hasMoreElements()) { - InputStream is = resources.nextElement().openStream(); - try { + try (InputStream is = resources.nextElement().openStream()) { read(new Manifest(is)); - } finally { - close(is); } } } catch (IOException e) { @@ -72,14 +69,6 @@ class ManifestReader { return packageSet; } - private void close(InputStream is) { - try { - is.close(); - } catch (IOException e) { - logger.warn("Error closing manifest InputStream", e); - } - } - /** * Read the entity packages from the manifest. */