github/ebean
4
0
Fork 0
mirror of https://github.com/ebean-orm/ebean.git synced 2024-04-21 10:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: append extraWhere to join

Browse Source
This commit is contained in:
Roland Praml
2018-11-10 23:42:02 +01:00
parent 1b2bfc5df8
commit c5536aaeec
4 changed files with 30 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/java/org/tests/model/view/TestViewBaseEntity.java
+1 -1
View File
@@ -65,6 +65,6 @@ public class TestViewBaseEntity extends BaseTestCase {
assertThat(details).isNotEmpty();
}
assertThat(query.getGeneratedSql()).contains("from order_agg_vw t0 left join o_order t1 on t1.id = t0.order_id left join o_customer t3 on t3.id = t1.kcustomer_id left join o_order_detail t2 on t2.order_id = t1.id where t2.id > 0 and t0.order_total > ?");
assertThat(query.getGeneratedSql()).contains("from order_agg_vw t0 left join o_order t1 on t1.id = t0.order_id left join o_customer t3 on t3.id = t1.kcustomer_id left join o_order_detail t2 on t2.order_id = t1.id and t2.id > 0 where t0.order_total > ?");
}
}
src/test/java/org/tests/query/TestOuterJoin.java
+1 -18
View File
@@ -174,24 +174,7 @@ public class TestOuterJoin extends BaseTestCase {
LoggedSql.stop();
// Note: You would expect, that the two lists are equal.
// but there is a @Where(clause = "${ta}.id > 0") on the details
// property, that will filter orders, where details is zero.
// The produced SQL is:
// select * from o_order t0
// join o_customer t2 on t2.id = t0.kcustomer_id
// left join o_order_detail t1 on t1.order_id = t0.id
// where t1.id > 0
// order by t0.id, t1.id asc, t1.order_qty asc, t1.cretime desc; --bind()
//
// I think this is NOT correct as it may exclude orders without details or with negative ID
//
// Correct way could/would be, to add that extra where to the join
//
//
// assertThat(orders2).isEqualTo(orders1);
assertThat(orders2).isEqualTo(orders1);
}
}