github/ebean
4
0
Fork 0
mirror of https://github.com/ebean-orm/ebean.git synced 2024-04-21 10:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

"insert into table default values" is invalid MySQL syntax (#1978)

Browse Source 
* ADD: failing testcase for "insert into table default values;" is invalid MySql syntax

* FIX: "insert into table default values;" is invalid MySql syntax
This commit is contained in:
Jonas Pöhler
2020-03-23 22:09:28 +13:00
committed by GitHub
parent 896aed0b38
commit c2fb23a25c
4 changed files with 137 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/io/ebeaninternal/server/persist/dml/InsertMeta.java
+9 -1
View File
@@ -1,5 +1,6 @@
package io.ebeaninternal.server.persist.dml;
import io.ebean.annotation.Platform;
import io.ebean.bean.EntityBean;
import io.ebean.config.dbplatform.DatabasePlatform;
import io.ebeaninternal.server.core.PersistRequestBean;
@@ -44,7 +45,10 @@ final class InsertMeta {
private final String[] identityDbColumns;
private final Platform platform;
InsertMeta(DatabasePlatform dbPlatform, BeanDescriptor<?> desc, Bindable shadowFKey, BindableId id, BindableList all) {
this.platform = dbPlatform.getPlatform();
this.discriminator = getDiscriminator(desc);
this.id = id;
this.all = all;
@@ -162,7 +166,11 @@ final class InsertMeta {
request.append("insert into ").append(table);
if (nullId && noColumnsForInsert(draftTable)) {
request.append(" default values");
if (this.platform.base() == Platform.MYSQL) {
request.append(" values (default)");
} else {
request.append(" default values");
}
return request.toString();
}