#1547 - Revert for - FIX for the limit query #1540

This commit is contained in:
rob bygrave
2018-11-14 09:29:36 +13:00
parent 528ad7c7fb
commit c074b7c457
5 changed files with 12 additions and 16 deletions
@@ -3,11 +3,10 @@ package org.tests.basic;
import io.ebean.BaseTestCase;
import io.ebean.Ebean;
import io.ebean.Query;
import org.junit.Assert;
import org.junit.Test;
import org.tests.model.basic.Order;
import org.tests.model.basic.ResetBasicData;
import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Test;
import java.util.List;
@@ -23,7 +22,6 @@ public class TestLimitQuery extends BaseTestCase {
}
@Test
@Ignore("TODO: maxRows=-1 should become the default value for 'unset'")
public void testMaxRowsZeroWithFirstRow() {
ResetBasicData.reset();
@@ -24,7 +24,7 @@ public class TestAddOrderByWithFirstRowsMaxRows extends BaseTestCase {
LoggedSqlCollector.start();
List<Order> list = Ebean.find(Order.class)
Ebean.find(Order.class)
.setFirstRow(3)
.orderBy().asc("id")
.findList();
@@ -33,7 +33,6 @@ public class TestAddOrderByWithFirstRowsMaxRows extends BaseTestCase {
assertThat(loggedSql).hasSize(1);
assertThat(loggedSql.get(0)).contains("order by t0.id");
assertThat(list).isNotEmpty();
}