From 371a50176e934ab2c49270830b0558200a3ba032 Mon Sep 17 00:00:00 2001
From: rob
Date: Mon, 30 Aug 2021 22:39:11 +1200
Subject: [PATCH 001/102] Tidy tests only - ClusterTest and
TestAggregateFormula
---
.../java/org/tests/aggregateformula/TestAggregateFormula.java | 2 --
ebean-redis/src/test/java/org/integration/ClusterTest.java | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/ebean-core/src/test/java/org/tests/aggregateformula/TestAggregateFormula.java b/ebean-core/src/test/java/org/tests/aggregateformula/TestAggregateFormula.java
index ff9bfb70a..223316cc1 100644
--- a/ebean-core/src/test/java/org/tests/aggregateformula/TestAggregateFormula.java
+++ b/ebean-core/src/test/java/org/tests/aggregateformula/TestAggregateFormula.java
@@ -81,7 +81,6 @@ public class TestAggregateFormula extends BaseTestCase {
for (Contact contact : contacts) {
Customer customer = contact.getCustomer();
assertNotNull(customer.getName());
- assertNotNull(customer.getStatus());
}
List sql = LoggedSqlCollector.stop();
@@ -112,7 +111,6 @@ public class TestAggregateFormula extends BaseTestCase {
for (Contact contact : contacts) {
Customer customer = contact.getCustomer();
assertNotNull(customer.getName());
- assertNotNull(customer.getStatus());
final Address billingAddress = customer.getBillingAddress();
if (billingAddress != null) {
assertNotNull(billingAddress.getCountry());
diff --git a/ebean-redis/src/test/java/org/integration/ClusterTest.java b/ebean-redis/src/test/java/org/integration/ClusterTest.java
index 64c54baaa..2d1046009 100644
--- a/ebean-redis/src/test/java/org/integration/ClusterTest.java
+++ b/ebean-redis/src/test/java/org/integration/ClusterTest.java
@@ -40,6 +40,7 @@ public class ClusterTest {
foo.save();
DB.getServerCacheManager().clearAll();
+ DB.getDefault().getMetaInfoManager().resetAllMetrics();
other.getMetaInfoManager().resetAllMetrics();
Person fooA = DB.find(Person.class, foo.getId());
From c5dca6948222aa03d39ac05ac2fe2ff35b6a12a7 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Mon, 30 Aug 2021 22:42:12 +1200
Subject: [PATCH 002/102] Tests only - update tests for sql server
---
.../java/org/tests/m2m/TestM2MDistinct_sqlServer.java | 4 ++--
.../src/test/java/org/tests/model/cache/EColAB.java | 6 +++---
.../java/org/tests/model/json/TestJacksonPlainBean.java | 9 +++++++--
.../test/java/org/tests/query/TestQueryFilterMany.java | 6 +++++-
.../java/org/tests/softdelete/TestSoftDeleteBasic.java | 4 ++--
.../softdelete/TestSoftDeleteOptionalRelationship.java | 6 +++++-
6 files changed, 24 insertions(+), 11 deletions(-)
diff --git a/ebean-core/src/test/java/org/tests/m2m/TestM2MDistinct_sqlServer.java b/ebean-core/src/test/java/org/tests/m2m/TestM2MDistinct_sqlServer.java
index 29c216ce7..d06989acb 100644
--- a/ebean-core/src/test/java/org/tests/m2m/TestM2MDistinct_sqlServer.java
+++ b/ebean-core/src/test/java/org/tests/m2m/TestM2MDistinct_sqlServer.java
@@ -29,8 +29,8 @@ public class TestM2MDistinct_sqlServer extends BaseTestCase {
List sqls = LoggedSql.stop();
assertThat(sqls.get(0)).startsWith("select distinct t0.id, t0.name, t0.version, t0.tenant_id, t0.name collate Latin1_General_CI_AS "
- + "from mt_role t0 join mt_role_permission u1z_ on u1z_.mt_role_id = t0.id "
- + "join mt_permission u1 on u1.id = u1z_.mt_permission_id where u1.id = ? "
+ + "from mt_role t0 join mt_role_permission u1z_ on u1z_.mt_role_id = t0.id "
+ + "join mt_permission u1 on u1.id = u1z_.mt_permission_id where u1.id = ? "
+ "order by t0.name collate Latin1_General_CI_AS;");
}
}
diff --git a/ebean-core/src/test/java/org/tests/model/cache/EColAB.java b/ebean-core/src/test/java/org/tests/model/cache/EColAB.java
index f3a7377b7..763d70e6c 100644
--- a/ebean-core/src/test/java/org/tests/model/cache/EColAB.java
+++ b/ebean-core/src/test/java/org/tests/model/cache/EColAB.java
@@ -13,7 +13,7 @@ import javax.persistence.Table;
public class EColAB extends Model {
@Id
- private Long id;
+ private Integer id;
private String columnA;
@@ -24,11 +24,11 @@ public class EColAB extends Model {
this.columnB = columnB;
}
- public Long getId() {
+ public Integer getId() {
return id;
}
- public void setId(Long id) {
+ public void setId(Integer id) {
this.id = id;
}
diff --git a/ebean-core/src/test/java/org/tests/model/json/TestJacksonPlainBean.java b/ebean-core/src/test/java/org/tests/model/json/TestJacksonPlainBean.java
index b2237731d..2a7456b07 100644
--- a/ebean-core/src/test/java/org/tests/model/json/TestJacksonPlainBean.java
+++ b/ebean-core/src/test/java/org/tests/model/json/TestJacksonPlainBean.java
@@ -1,12 +1,13 @@
package org.tests.model.json;
+import io.ebean.BaseTestCase;
import io.ebean.DB;
import io.ebeantest.LoggedSql;
import org.junit.Test;
import static org.assertj.core.api.Assertions.assertThat;
-public class TestJacksonPlainBean {
+public class TestJacksonPlainBean extends BaseTestCase {
@Test
public void insertNullStayNull() {
@@ -46,7 +47,11 @@ public class TestJacksonPlainBean {
bean.setPlainBean2(new PlainBean("bar", 27));
DB.save(bean);
- expectedSql(0, "insert into ebasic_plain (attr, plain_bean, plain_bean2, version) values (?,?,?,?)");
+ if (isSqlServer()) {
+ expectedSql(0, "insert into ebasic_plain (id, attr, plain_bean, plain_bean2, version) values (?,?,?,?,?)");
+ } else {
+ expectedSql(0, "insert into ebasic_plain (attr, plain_bean, plain_bean2, version) values (?,?,?,?)");
+ }
// inserted plainBean has not been mutated
bean.setAttr("attr1");
diff --git a/ebean-core/src/test/java/org/tests/query/TestQueryFilterMany.java b/ebean-core/src/test/java/org/tests/query/TestQueryFilterMany.java
index 92c334ed0..eafadf8b8 100644
--- a/ebean-core/src/test/java/org/tests/query/TestQueryFilterMany.java
+++ b/ebean-core/src/test/java/org/tests/query/TestQueryFilterMany.java
@@ -302,6 +302,10 @@ public class TestQueryFilterMany extends BaseTestCase {
List sql = LoggedSqlCollector.stop();
assertThat(sql).hasSize(1);
- assertSql(sql.get(0)).contains(" from o_customer t0 left join contact t1 on t1.customer_id = t0.id where (t1.first_name is not null and lower(t1.email) like ? escape'|' ) order by t0.id; --bind(rob%)");
+ if (isSqlServer()) {
+ assertSql(sql.get(0)).contains(" from o_customer t0 left join contact t1 on t1.customer_id = t0.id where (t1.first_name is not null and lower(t1.email) like ? ) order by t0.id; --bind(rob%)");
+ } else {
+ assertSql(sql.get(0)).contains(" from o_customer t0 left join contact t1 on t1.customer_id = t0.id where (t1.first_name is not null and lower(t1.email) like ? escape'|' ) order by t0.id; --bind(rob%)");
+ }
}
}
diff --git a/ebean-core/src/test/java/org/tests/softdelete/TestSoftDeleteBasic.java b/ebean-core/src/test/java/org/tests/softdelete/TestSoftDeleteBasic.java
index 3364417b9..4f271f0f6 100644
--- a/ebean-core/src/test/java/org/tests/softdelete/TestSoftDeleteBasic.java
+++ b/ebean-core/src/test/java/org/tests/softdelete/TestSoftDeleteBasic.java
@@ -241,7 +241,7 @@ public class TestSoftDeleteBasic extends BaseTestCase {
.query();
List list = query.findList();
- if (isMySql() || isMariaDB()) {
+ if (isMySql() || isMariaDB() || isSqlServer()) {
assertSql(query).contains("t0.deleted = 0");
assertSql(query).contains("u1.deleted = 0");
} else {
@@ -277,7 +277,7 @@ public class TestSoftDeleteBasic extends BaseTestCase {
List list = query.findList();
// Make sure that query includes that the child mustn't've been deleted
- if (isMySql() || isMariaDB()) {
+ if (isMySql() || isMariaDB() || isSqlServer()) {
assertSql(query).contains("u1.deleted = 0");
assertSql(query).contains("u2.deleted = 0");
} else {
diff --git a/ebean-core/src/test/java/org/tests/softdelete/TestSoftDeleteOptionalRelationship.java b/ebean-core/src/test/java/org/tests/softdelete/TestSoftDeleteOptionalRelationship.java
index b4e320b21..8f730921a 100644
--- a/ebean-core/src/test/java/org/tests/softdelete/TestSoftDeleteOptionalRelationship.java
+++ b/ebean-core/src/test/java/org/tests/softdelete/TestSoftDeleteOptionalRelationship.java
@@ -60,7 +60,11 @@ public class TestSoftDeleteOptionalRelationship extends BaseTestCase {
final List sql = LoggedSqlCollector.stop();
assertThat(sql).hasSize(1);
- assertThat(sql.get(0)).contains("left join esoft_del_z t1 on t1.id = t0.organization_id and t1.deleted = false where");
+ if (isSqlServer()) {
+ assertThat(sql.get(0)).contains("left join esoft_del_z t1 on t1.id = t0.organization_id and t1.deleted = 0 where");
+ } else {
+ assertThat(sql.get(0)).contains("left join esoft_del_z t1 on t1.id = t0.organization_id and t1.deleted = false where");
+ }
}
}
From da6f7d671b8b777ca3f42f2534b307d516060280 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Tue, 31 Aug 2021 14:26:52 +1200
Subject: [PATCH 003/102] #2336 - @DbArray List or Set of UUID or enum returned
as String (not converted) when DB does not support ARRAY
---
.../server/type/DefaultTypeManager.java | 32 ++++---------
.../type/PlatformArrayTypeJsonList.java | 41 ++++++++++++++++
.../server/type/PlatformArrayTypeJsonSet.java | 41 ++++++++++++++++
.../server/type/ScalarTypeJsonList.java | 48 ++++++++++++++++++-
.../server/type/ScalarTypeJsonSet.java | 47 +++++++++++++++++-
.../tests/model/array/TestDbArray_asSet.java | 10 ++--
.../tests/model/array/TestDbArray_basic.java | 9 ++--
7 files changed, 193 insertions(+), 35 deletions(-)
create mode 100644 ebean-core/src/main/java/io/ebeaninternal/server/type/PlatformArrayTypeJsonList.java
create mode 100644 ebean-core/src/main/java/io/ebeaninternal/server/type/PlatformArrayTypeJsonSet.java
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/type/DefaultTypeManager.java b/ebean-core/src/main/java/io/ebeaninternal/server/type/DefaultTypeManager.java
index d58c284f3..5d95efd6e 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/type/DefaultTypeManager.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/type/DefaultTypeManager.java
@@ -162,30 +162,22 @@ public final class DefaultTypeManager implements TypeManager {
}
}
- /**
- * Return the factory to use to support DB ARRAY types.
- */
private PlatformArrayTypeFactory arrayTypeListFactory(DatabasePlatform databasePlatform) {
if (databasePlatform.isNativeArrayType()) {
return ScalarTypeArrayList.factory();
} else if (databasePlatform.isPlatform(Platform.H2)) {
return ScalarTypeArrayListH2.factory();
}
- // not supported for this DB platform
- return null;
+ return new PlatformArrayTypeJsonList();
}
- /**
- * Return the factory to use to support DB ARRAY types.
- */
private PlatformArrayTypeFactory arrayTypeSetFactory(DatabasePlatform databasePlatform) {
if (databasePlatform.isNativeArrayType()) {
return ScalarTypeArraySet.factory();
} else if (databasePlatform.isPlatform(Platform.H2)) {
return ScalarTypeArraySetH2.factory();
}
- // not supported for this DB platform
- return null;
+ return new PlatformArrayTypeJsonSet();
}
/**
@@ -305,25 +297,17 @@ public final class DefaultTypeManager implements TypeManager {
}
private ScalarType> getArrayScalarTypeSet(Type valueType, boolean nullable) {
- if (arrayTypeSetFactory != null) {
- if (isEnumType(valueType)) {
- return arrayTypeSetFactory.typeForEnum(createEnumScalarType(asEnumClass(valueType), null), nullable);
- }
- return arrayTypeSetFactory.typeFor(valueType, nullable);
+ if (isEnumType(valueType)) {
+ return arrayTypeSetFactory.typeForEnum(createEnumScalarType(asEnumClass(valueType), null), nullable);
}
- // fallback to JSON storage in VARCHAR column
- return new ScalarTypeJsonSet.Varchar(getDocType(valueType), nullable, false); // TODO: keepSource for @DbArray?
+ return arrayTypeSetFactory.typeFor(valueType, nullable);
}
private ScalarType> getArrayScalarTypeList(Type valueType, boolean nullable) {
- if (arrayTypeListFactory != null) {
- if (isEnumType(valueType)) {
- return arrayTypeListFactory.typeForEnum(createEnumScalarType(asEnumClass(valueType), null), nullable);
- }
- return arrayTypeListFactory.typeFor(valueType, nullable);
+ if (isEnumType(valueType)) {
+ return arrayTypeListFactory.typeForEnum(createEnumScalarType(asEnumClass(valueType), null), nullable);
}
- // fallback to JSON storage in VARCHAR column
- return new ScalarTypeJsonList.Varchar(getDocType(valueType), nullable, false); // TODO: keepSource for @DbArray?
+ return arrayTypeListFactory.typeFor(valueType, nullable);
}
private Class extends Enum>> asEnumClass(Type valueType) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/type/PlatformArrayTypeJsonList.java b/ebean-core/src/main/java/io/ebeaninternal/server/type/PlatformArrayTypeJsonList.java
new file mode 100644
index 000000000..8b3232b28
--- /dev/null
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/type/PlatformArrayTypeJsonList.java
@@ -0,0 +1,41 @@
+package io.ebeaninternal.server.type;
+
+import io.ebean.core.type.DocPropertyType;
+import io.ebean.core.type.ScalarType;
+
+import java.lang.reflect.Type;
+import java.util.UUID;
+
+/**
+ * Fallback for DbArray as Json List.
+ */
+class PlatformArrayTypeJsonList implements PlatformArrayTypeFactory {
+
+ private DocPropertyType docType(Type valueType) {
+ if (valueType.equals(Long.class)) {
+ return DocPropertyType.LONG;
+ }
+ if (valueType.equals(Integer.class)) {
+ return DocPropertyType.INTEGER;
+ }
+ if (valueType.equals(Double.class)) {
+ return DocPropertyType.DOUBLE;
+ }
+ return DocPropertyType.TEXT;
+ }
+
+ @Override
+ public ScalarType> typeFor(Type valueType, boolean nullable) {
+ if (valueType.equals(UUID.class)) {
+ // TODO: keepSource for @DbArray?
+ return new ScalarTypeJsonList.VarcharWithConverter(DocPropertyType.UUID, nullable, false, ArrayElementConverter.UUID);
+ }
+ return new ScalarTypeJsonList.Varchar(docType(valueType), nullable, false);
+ }
+
+ @Override
+ public ScalarType> typeForEnum(ScalarType> scalarType, boolean nullable) {
+ final ArrayElementConverter.EnumConverter converter = new ArrayElementConverter.EnumConverter(scalarType);
+ return new ScalarTypeJsonList.VarcharWithConverter(scalarType.getDocType(), nullable, false, converter);
+ }
+}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/type/PlatformArrayTypeJsonSet.java b/ebean-core/src/main/java/io/ebeaninternal/server/type/PlatformArrayTypeJsonSet.java
new file mode 100644
index 000000000..a5c7595f7
--- /dev/null
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/type/PlatformArrayTypeJsonSet.java
@@ -0,0 +1,41 @@
+package io.ebeaninternal.server.type;
+
+import io.ebean.core.type.DocPropertyType;
+import io.ebean.core.type.ScalarType;
+
+import java.lang.reflect.Type;
+import java.util.UUID;
+
+/**
+ * Fallback for DbArray as Json Set.
+ */
+class PlatformArrayTypeJsonSet implements PlatformArrayTypeFactory {
+
+ private DocPropertyType docType(Type valueType) {
+ if (valueType.equals(Long.class)) {
+ return DocPropertyType.LONG;
+ }
+ if (valueType.equals(Integer.class)) {
+ return DocPropertyType.INTEGER;
+ }
+ if (valueType.equals(Double.class)) {
+ return DocPropertyType.DOUBLE;
+ }
+ return DocPropertyType.TEXT;
+ }
+
+ @Override
+ public ScalarType> typeFor(Type valueType, boolean nullable) {
+ if (valueType.equals(UUID.class)) {
+ // TODO: keepSource for @DbArray?
+ return new ScalarTypeJsonSet.VarcharWithConverter(DocPropertyType.UUID, nullable, false, ArrayElementConverter.UUID);
+ }
+ return new ScalarTypeJsonSet.Varchar(docType(valueType), nullable, false);
+ }
+
+ @Override
+ public ScalarType> typeForEnum(ScalarType> scalarType, boolean nullable) {
+ final ArrayElementConverter.EnumConverter converter = new ArrayElementConverter.EnumConverter(scalarType);
+ return new ScalarTypeJsonSet.VarcharWithConverter(scalarType.getDocType(), nullable, false, converter);
+ }
+}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/type/ScalarTypeJsonList.java b/ebean-core/src/main/java/io/ebeaninternal/server/type/ScalarTypeJsonList.java
index 71179dba7..4abd85931 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/type/ScalarTypeJsonList.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/type/ScalarTypeJsonList.java
@@ -9,11 +9,13 @@ import io.ebean.core.type.DocPropertyType;
import io.ebean.core.type.ScalarType;
import io.ebean.text.TextException;
import io.ebean.text.json.EJson;
+import io.ebeaninternal.json.ModifyAwareList;
import javax.persistence.PersistenceException;
import java.io.IOException;
import java.sql.SQLException;
import java.sql.Types;
+import java.util.ArrayList;
import java.util.List;
/**
@@ -36,6 +38,46 @@ final class ScalarTypeJsonList {
return new ScalarTypeJsonList.Varchar(docType, nullable, keepSource);
}
+ @SuppressWarnings("rawtypes")
+ static final class VarcharWithConverter extends ScalarTypeJsonList.Base {
+ private final ArrayElementConverter converter;
+
+ VarcharWithConverter(DocPropertyType docType, boolean nullable, boolean keepSource, ArrayElementConverter converter) {
+ super(Types.VARCHAR, docType, nullable, keepSource);
+ this.converter = converter;
+ }
+
+ @Override
+ List readJsonConvert(String json) {
+ try {
+ return convertElements(EJson.parseList(json, false));
+ } catch (IOException e) {
+ throw new TextException("Failed to parse JSON [{}] as List", json, e);
+ }
+ }
+
+ @SuppressWarnings("unchecked")
+ private List convertElements(List
*/
public static ExpressionFactory getExpressionFactory() {
- return getDefault().getExpressionFactory();
+ return getDefault().expressionFactory();
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/Database.java b/ebean-api/src/main/java/io/ebean/Database.java
index 043b775f9..eb68f06d9 100644
--- a/ebean-api/src/main/java/io/ebean/Database.java
+++ b/ebean-api/src/main/java/io/ebean/Database.java
@@ -173,7 +173,15 @@ public interface Database {
/**
* Return the ExpressionFactory for this database.
*/
- ExpressionFactory getExpressionFactory();
+ ExpressionFactory expressionFactory();
+
+ /**
+ * Deprecated migrate to expressionFactory().
+ */
+ @Deprecated
+ default ExpressionFactory getExpressionFactory() {
+ return expressionFactory();
+ }
/**
* Return the MetaInfoManager which is used to get meta data from the Database
diff --git a/ebean-api/src/main/java/io/ebean/Ebean.java b/ebean-api/src/main/java/io/ebean/Ebean.java
index fb0e34db3..ae2bfe0c1 100644
--- a/ebean-api/src/main/java/io/ebean/Ebean.java
+++ b/ebean-api/src/main/java/io/ebean/Ebean.java
@@ -103,7 +103,7 @@ public final class Ebean {
*
*/
public static ExpressionFactory getExpressionFactory() {
- return getDefault().getExpressionFactory();
+ return getDefault().expressionFactory();
}
/**
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index 92f47b516..b2d4268b2 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -345,7 +345,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public ExpressionFactory getExpressionFactory() {
+ public ExpressionFactory expressionFactory() {
return expressionFactory;
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
index 6541cade1..f9f8fa97d 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
@@ -1793,7 +1793,7 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType {
* We actually need to do a query because we don't know the type without the discriminator value.
*/
private T findReferenceBean(Object id, PersistenceContext pc) {
- DefaultOrmQuery query = new DefaultOrmQuery<>(this, ebeanServer, ebeanServer.getExpressionFactory());
+ DefaultOrmQuery query = new DefaultOrmQuery<>(this, ebeanServer, ebeanServer.expressionFactory());
query.setPersistenceContext(pc);
return query.setId(id).findOne();
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssoc.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssoc.java
index 33304f5f9..416d500aa 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssoc.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanPropertyAssoc.java
@@ -229,7 +229,7 @@ public abstract class BeanPropertyAssoc extends BeanProperty implements STree
* We use target descriptor rather than target property type to support ElementCollection.
*/
public SpiQuery newQuery(SpiEbeanServer server) {
- return new DefaultOrmQuery<>(targetDescriptor, server, server.getExpressionFactory());
+ return new DefaultOrmQuery<>(targetDescriptor, server, server.expressionFactory());
}
@Override
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
index 6c971d831..6131b5df1 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
@@ -353,7 +353,7 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public ExpressionFactory getExpressionFactory() {
+ public ExpressionFactory expressionFactory() {
return null;
}
diff --git a/ebean-core/src/test/java/org/tests/query/other/TestSubQueryBinding.java b/ebean-core/src/test/java/org/tests/query/other/TestSubQueryBinding.java
index ba51c90b8..a2b1815d6 100644
--- a/ebean-core/src/test/java/org/tests/query/other/TestSubQueryBinding.java
+++ b/ebean-core/src/test/java/org/tests/query/other/TestSubQueryBinding.java
@@ -17,7 +17,7 @@ public class TestSubQueryBinding extends BaseTestCase {
Query someCustomerIds = server.find(Customer.class).select("id").where().lt("id", 5).query();
- Expression someCustIdsExpression = server.getExpressionFactory().in("id", someCustomerIds);
+ Expression someCustIdsExpression = server.expressionFactory().in("id", someCustomerIds);
Query query = server.find(Customer.class).where().like("name", "Rob%").not(someCustIdsExpression).query();
From 7fba9adc433ff1e105de0e647c9f4d71b0ce81a2 Mon Sep 17 00:00:00 2001
From: Rob Bygrave
Date: Thu, 2 Sep 2021 22:58:09 +1200
Subject: [PATCH 031/102] #2346 - Rename Database.getMetaInfoManager() to
metaInfo() with deprecation
---
.../src/main/java/io/ebean/Database.java | 10 +++++++++-
.../server/core/DefaultServer.java | 2 +-
.../server/core/DumpMetrics.java | 2 +-
.../server/core/DumpMetricsData.java | 2 +-
.../server/core/DumpMetricsJson.java | 4 ++--
.../src/test/java/io/ebean/BaseTestCase.java | 4 ++--
.../src/test/java/io/ebean/DtoQuery2Test.java | 4 ++--
.../java/io/ebean/DtoQueryFromOrmTest.java | 4 ++--
.../src/test/java/io/ebean/DtoQueryTest.java | 4 ++--
.../ebeaninternal/api/TDSpiEbeanServer.java | 2 +-
.../query/finder/TestCustomerFinder.java | 20 +++++++++----------
.../src/test/java/io/ebean/BaseTestCase.java | 4 ++--
.../java/org/integration/ClusterTest.java | 6 +++---
13 files changed, 38 insertions(+), 30 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/Database.java b/ebean-api/src/main/java/io/ebean/Database.java
index eb68f06d9..1adacc8e1 100644
--- a/ebean-api/src/main/java/io/ebean/Database.java
+++ b/ebean-api/src/main/java/io/ebean/Database.java
@@ -187,7 +187,15 @@ public interface Database {
* Return the MetaInfoManager which is used to get meta data from the Database
* such as query execution statistics.
*/
- MetaInfoManager getMetaInfoManager();
+ MetaInfoManager metaInfo();
+
+ /**
+ * Deprecated migrate to metaInfo().
+ */
+ @Deprecated
+ default MetaInfoManager getMetaInfoManager() {
+ return metaInfo();
+ }
/**
* Return the platform used for this database instance.
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index b2d4268b2..2b588655b 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -325,7 +325,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public MetaInfoManager getMetaInfoManager() {
+ public MetaInfoManager metaInfo() {
return metaInfoManager;
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetrics.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetrics.java
index b1f66f7ef..73ad97f2c 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetrics.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetrics.java
@@ -74,7 +74,7 @@ final class DumpMetrics {
void dump() {
out("-- Dumping metrics for " + server.name() + " -- ");
- ServerMetrics serverMetrics = server.getMetaInfoManager().collectMetrics();
+ ServerMetrics serverMetrics = server.metaInfo().collectMetrics();
for (MetaTimedMetric metric : serverMetrics.timedMetrics()) {
log(metric);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsData.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsData.java
index 712521ce0..ef006949f 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsData.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsData.java
@@ -24,7 +24,7 @@ final class DumpMetricsData {
}
List data() {
- collect(database.getMetaInfoManager().collectMetrics());
+ collect(database.metaInfo().collectMetrics());
return list;
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsJson.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsJson.java
index 3358a709a..0b96dcbd9 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsJson.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsJson.java
@@ -66,14 +66,14 @@ final class DumpMetricsJson implements ServerMetricsAsJson {
@Override
public String json() {
writer = new StringWriter();
- collect(database.getMetaInfoManager().collectMetrics());
+ collect(database.metaInfo().collectMetrics());
return writer.toString();
}
@Override
public void write(Appendable buffer) {
writer = buffer;
- collect(database.getMetaInfoManager().collectMetrics());
+ collect(database.metaInfo().collectMetrics());
}
private void collect(ServerMetrics serverMetrics) {
diff --git a/ebean-core/src/test/java/io/ebean/BaseTestCase.java b/ebean-core/src/test/java/io/ebean/BaseTestCase.java
index 988e73b59..f771d7ab1 100644
--- a/ebean-core/src/test/java/io/ebean/BaseTestCase.java
+++ b/ebean-core/src/test/java/io/ebean/BaseTestCase.java
@@ -82,11 +82,11 @@ public abstract class BaseTestCase {
}
protected void resetAllMetrics() {
- server().getMetaInfoManager().resetAllMetrics();
+ server().metaInfo().resetAllMetrics();
}
protected ServerMetrics collectMetrics() {
- return server().getMetaInfoManager().collectMetrics();
+ return server().metaInfo().collectMetrics();
}
protected List visitTimedMetrics() {
diff --git a/ebean-core/src/test/java/io/ebean/DtoQuery2Test.java b/ebean-core/src/test/java/io/ebean/DtoQuery2Test.java
index 625cc9ae9..4d37aaf57 100644
--- a/ebean-core/src/test/java/io/ebean/DtoQuery2Test.java
+++ b/ebean-core/src/test/java/io/ebean/DtoQuery2Test.java
@@ -189,7 +189,7 @@ public class DtoQuery2Test extends BaseTestCase {
// collect without reset
BasicMetricVisitor basic = new BasicMetricVisitor(false, true, true, true);
- server().getMetaInfoManager().visitMetrics(basic);
+ server().metaInfo().visitMetrics(basic);
List stats = basic.queryMetrics();
assertThat(stats).hasSize(1);
@@ -205,7 +205,7 @@ public class DtoQuery2Test extends BaseTestCase {
.setParameter("name", "rob")
.findList();
- BasicMetricVisitor metric2 = server().getMetaInfoManager().visitBasic();
+ BasicMetricVisitor metric2 = server().metaInfo().visitBasic();
stats = metric2.queryMetrics();
assertThat(stats).hasSize(2);
diff --git a/ebean-core/src/test/java/io/ebean/DtoQueryFromOrmTest.java b/ebean-core/src/test/java/io/ebean/DtoQueryFromOrmTest.java
index 28b0bd490..db9e85aa9 100644
--- a/ebean-core/src/test/java/io/ebean/DtoQueryFromOrmTest.java
+++ b/ebean-core/src/test/java/io/ebean/DtoQueryFromOrmTest.java
@@ -21,12 +21,12 @@ public class DtoQueryFromOrmTest extends BaseTestCase {
@BeforeClass
public static void resetStats() {
- DB.getDefault().getMetaInfoManager().resetAllMetrics();
+ DB.getDefault().metaInfo().resetAllMetrics();
}
@AfterClass
public static void reportStats() {
- ServerMetrics metrics = DB.getDefault().getMetaInfoManager().collectMetrics();
+ ServerMetrics metrics = DB.getDefault().metaInfo().collectMetrics();
for (MetaQueryMetric metric : metrics.queryMetrics()) {
System.out.println(metric);
}
diff --git a/ebean-core/src/test/java/io/ebean/DtoQueryTest.java b/ebean-core/src/test/java/io/ebean/DtoQueryTest.java
index 0331a8215..f9e5406e1 100644
--- a/ebean-core/src/test/java/io/ebean/DtoQueryTest.java
+++ b/ebean-core/src/test/java/io/ebean/DtoQueryTest.java
@@ -281,7 +281,7 @@ public class DtoQueryTest extends BaseTestCase {
// collect without reset
BasicMetricVisitor basic = new BasicMetricVisitor(false, true, true, true);
- server().getMetaInfoManager().visitMetrics(basic);
+ server().metaInfo().visitMetrics(basic);
List stats = basic.queryMetrics();
assertThat(stats).hasSize(1);
@@ -297,7 +297,7 @@ public class DtoQueryTest extends BaseTestCase {
.setParameter("name", "rob")
.findList();
- ServerMetrics metric2 = server().getMetaInfoManager().collectMetrics();
+ ServerMetrics metric2 = server().metaInfo().collectMetrics();
stats = metric2.queryMetrics();
assertThat(stats).hasSize(2);
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
index 6131b5df1..8963bfa5b 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
@@ -358,7 +358,7 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public MetaInfoManager getMetaInfoManager() {
+ public MetaInfoManager metaInfo() {
return null;
}
diff --git a/ebean-core/src/test/java/org/tests/query/finder/TestCustomerFinder.java b/ebean-core/src/test/java/org/tests/query/finder/TestCustomerFinder.java
index 68b5c627a..04b0e755d 100644
--- a/ebean-core/src/test/java/org/tests/query/finder/TestCustomerFinder.java
+++ b/ebean-core/src/test/java/org/tests/query/finder/TestCustomerFinder.java
@@ -31,7 +31,7 @@ public class TestCustomerFinder extends BaseTestCase {
runQueries();
StringBuilder buffer0 = new StringBuilder();
- DB.getDefault().getMetaInfoManager()
+ DB.getDefault().metaInfo()
.collectMetricsAsJson()
.withHeader(false)
.write(buffer0);
@@ -45,7 +45,7 @@ public class TestCustomerFinder extends BaseTestCase {
runQueries();
StringBuilder buffer1 = new StringBuilder();
- DB.getDefault().getMetaInfoManager()
+ DB.getDefault().metaInfo()
.collectMetricsAsJson()
.withHeader(false)
.write(buffer1);
@@ -177,7 +177,7 @@ public class TestCustomerFinder extends BaseTestCase {
QueryPlanInit init0 = new QueryPlanInit();
init0.setAll(true);
init0.thresholdMicros(2);
- final List plans = server().getMetaInfoManager().queryPlanInit(init0);
+ final List plans = server().metaInfo().queryPlanInit(init0);
assertThat(plans.size()).isGreaterThan(1);
// the server has some plans
@@ -187,13 +187,13 @@ public class TestCustomerFinder extends BaseTestCase {
QueryPlanInit init = new QueryPlanInit();
init.setAll(true);
init.thresholdMicros(1);
- final List appliedToPlans = server().getMetaInfoManager().queryPlanInit(init);
+ final List appliedToPlans = server().metaInfo().queryPlanInit(init);
assertThat(appliedToPlans.size()).isGreaterThan(4);
// run queries again
runQueries();
- ServerMetrics metrics = DB.getDefault().getMetaInfoManager().collectMetrics();
+ ServerMetrics metrics = DB.getDefault().metaInfo().collectMetrics();
List planStats = metrics.queryMetrics();
assertThat(planStats.size()).isGreaterThan(4);
@@ -212,7 +212,7 @@ public class TestCustomerFinder extends BaseTestCase {
request.maxCount(1_000);
// don't collect any more plans if used 10 secs
request.maxTimeMillis(10_000);
- List plans0 = server().getMetaInfoManager().queryPlanCollectNow(request);
+ List plans0 = server().metaInfo().queryPlanCollectNow(request);
assertThat(plans0).isNotEmpty();
for (MetaQueryPlan plan : plans) {
@@ -232,7 +232,7 @@ public class TestCustomerFinder extends BaseTestCase {
runQueries();
- String metricsJson = server().getMetaInfoManager()
+ String metricsJson = server().metaInfo()
.collectMetricsAsJson()
.withHash(true)
.withExtraAttributes(true)
@@ -256,7 +256,7 @@ public class TestCustomerFinder extends BaseTestCase {
runQueries();
- String metricsJson = server().getMetaInfoManager()
+ String metricsJson = server().metaInfo()
.collectMetricsAsJson()
.withHash(false)
.withExtraAttributes(false)
@@ -279,7 +279,7 @@ public class TestCustomerFinder extends BaseTestCase {
runQueries();
StringBuilder buffer = new StringBuilder();
- server().getMetaInfoManager()
+ server().metaInfo()
.collectMetricsAsJson()
.withHeader(false)
.write(buffer);
@@ -297,7 +297,7 @@ public class TestCustomerFinder extends BaseTestCase {
runQueries();
StringBuilder buffer = new StringBuilder();
- server().getMetaInfoManager()
+ server().metaInfo()
.collectMetricsAsJson()
.withHeader(true)
.write(buffer);
diff --git a/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java b/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
index 4c0410ff3..568664de2 100644
--- a/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
+++ b/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
@@ -78,11 +78,11 @@ public abstract class BaseTestCase {
}
protected void resetAllMetrics() {
- server().getMetaInfoManager().resetAllMetrics();
+ server().metaInfo().resetAllMetrics();
}
protected ServerMetrics collectMetrics() {
- return server().getMetaInfoManager().collectMetrics();
+ return server().metaInfo().collectMetrics();
}
protected List visitTimedMetrics() {
diff --git a/ebean-redis/src/test/java/org/integration/ClusterTest.java b/ebean-redis/src/test/java/org/integration/ClusterTest.java
index 57e4568d7..9ae04139e 100644
--- a/ebean-redis/src/test/java/org/integration/ClusterTest.java
+++ b/ebean-redis/src/test/java/org/integration/ClusterTest.java
@@ -40,8 +40,8 @@ public class ClusterTest {
foo.save();
DB.getServerCacheManager().clearAll();
- DB.getDefault().getMetaInfoManager().resetAllMetrics();
- other.getMetaInfoManager().resetAllMetrics();
+ DB.getDefault().metaInfo().resetAllMetrics();
+ other.metaInfo().resetAllMetrics();
Person fooA = DB.find(Person.class, foo.getId());
Person fooB = other.find(Person.class, foo.getId());
@@ -70,7 +70,7 @@ public class ClusterTest {
}
other.getServerCacheManager().clearAll();
- other.getMetaInfoManager().resetAllMetrics();
+ other.metaInfo().resetAllMetrics();
DuelCache dualCache = (DuelCache) other.getServerCacheManager().getBeanCache(Person.class);
From fe67abce83890091d65e4f0529949063ff3ed5e9 Mon Sep 17 00:00:00 2001
From: Rob Bygrave
Date: Thu, 2 Sep 2021 23:04:57 +1200
Subject: [PATCH 032/102] #2347 - Rename Database.getPlatform() to platform()
with deprecation
---
ebean-api/src/main/java/io/ebean/DB.java | 2 +-
.../src/main/java/io/ebean/Database.java | 30 +++++++++++++++++--
ebean-api/src/main/java/io/ebean/Ebean.java | 2 +-
.../io/ebean/bean/EntityBeanIntercept.java | 2 +-
.../java/io/ebean/bean/SingleBeanLoader.java | 6 ++--
.../service/DefaultAutoTuneService.java | 2 +-
.../server/core/DefaultServer.java | 6 ++--
.../java/io/ebean/ConditionalTestRunner.java | 2 +-
.../dbplatform/DatabasePlatformTest.java | 10 +++----
.../sqlserver/SqlServerStepSequenceTest.java | 2 +-
.../java/io/ebean/plugin/BeanTypeTest.java | 2 +-
.../io/ebean/plugin/ExpressionPathTest.java | 2 +-
.../java/io/ebean/plugin/PropertyTest.java | 2 +-
.../java/io/ebean/plugin/SpiServerTest.java | 2 +-
.../ebeaninternal/api/TDSpiEbeanServer.java | 6 ++--
.../DefaultChangeLogListenerTest.java | 2 +-
.../TestShutdownWithBackgroundTasks.java | 2 +-
.../api/support/DocStoreDeleteEventTest.java | 2 +-
.../api/support/DocStoreIndexEventTest.java | 2 +-
.../java/org/tests/cache/TestQueryCache.java | 2 +-
.../java/org/tests/ddd/iud/TestDPersonEl.java | 4 +--
.../java/org/tests/el/TestPathExpression.java | 2 +-
.../org/tests/json/TestDbJson_Jackson.java | 4 +--
.../org/tests/json/TestDbJson_Jackson2.java | 2 +-
.../model/embedded/TestEmbeddedManyToOne.java | 2 +-
.../org/tests/query/TestQueryFindIterate.java | 2 +-
.../query/cancel/SqlQueryCancelTest.java | 3 +-
.../sqlquery/TestNativeILikeExpression.java | 4 +--
.../text/json/TestTextJsonInvokeLazy.java | 4 +--
.../java/org/tests/types/TestNewTypes.java | 2 +-
.../java/io/ebean/ConditionalTestRunner.java | 2 +-
.../dbmigration/DbMigrationTest.java | 2 +-
.../platform/PlatformDdl_AlterColumnTest.java | 2 +-
.../platform/PlatformDdl_CreateIndexTest.java | 2 +-
.../java/org/integration/ClusterTest.java | 4 +--
35 files changed, 76 insertions(+), 53 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/DB.java b/ebean-api/src/main/java/io/ebean/DB.java
index 2305a5d22..c9603ada6 100644
--- a/ebean-api/src/main/java/io/ebean/DB.java
+++ b/ebean-api/src/main/java/io/ebean/DB.java
@@ -1254,7 +1254,7 @@ public final class DB {
* queries.
*/
public static BackgroundExecutor getBackgroundExecutor() {
- return getDefault().getBackgroundExecutor();
+ return getDefault().backgroundExecutor();
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/Database.java b/ebean-api/src/main/java/io/ebean/Database.java
index 1adacc8e1..c11e0cedc 100644
--- a/ebean-api/src/main/java/io/ebean/Database.java
+++ b/ebean-api/src/main/java/io/ebean/Database.java
@@ -214,12 +214,28 @@ public interface Database {
*
* @return platform for this database instance
*/
- Platform getPlatform();
+ Platform platform();
+
+ /**
+ * Deprecated migrate to platform().
+ */
+ @Deprecated
+ default Platform getPlatform() {
+ return platform();
+ }
/**
* Return the extended API intended for use by plugins.
*/
- SpiServer getPluginApi();
+ SpiServer pluginApi();
+
+ /**
+ * Deprecated migrate to pluginApi().
+ */
+ @Deprecated
+ default SpiServer getPluginApi() {
+ return pluginApi();
+ }
/**
* Return the BeanState for a given entity bean.
@@ -1485,7 +1501,15 @@ public interface Database {
* Return the BackgroundExecutor service for asynchronous processing of
* queries.
*/
- BackgroundExecutor getBackgroundExecutor();
+ BackgroundExecutor backgroundExecutor();
+
+ /**
+ * Deprecated migrate to backgroundExecutor().
+ */
+ @Deprecated
+ default BackgroundExecutor getBackgroundExecutor() {
+ return backgroundExecutor();
+ }
/**
* Return the JsonContext for reading/writing JSON.
diff --git a/ebean-api/src/main/java/io/ebean/Ebean.java b/ebean-api/src/main/java/io/ebean/Ebean.java
index ae2bfe0c1..7dc6cd308 100644
--- a/ebean-api/src/main/java/io/ebean/Ebean.java
+++ b/ebean-api/src/main/java/io/ebean/Ebean.java
@@ -1216,7 +1216,7 @@ public final class Ebean {
* queries.
*/
public static BackgroundExecutor getBackgroundExecutor() {
- return getDefault().getBackgroundExecutor();
+ return getDefault().backgroundExecutor();
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/bean/EntityBeanIntercept.java b/ebean-api/src/main/java/io/ebean/bean/EntityBeanIntercept.java
index 9924bf4f7..3725cc73c 100644
--- a/ebean-api/src/main/java/io/ebean/bean/EntityBeanIntercept.java
+++ b/ebean-api/src/main/java/io/ebean/bean/EntityBeanIntercept.java
@@ -843,7 +843,7 @@ public final class EntityBeanIntercept implements Serializable {
}
// For stand alone reference bean or after deserialisation lazy load
// using the ebeanServer. Synchronise only on the bean.
- loadBeanInternal(loadProperty, database.getPluginApi().beanLoader());
+ loadBeanInternal(loadProperty, database.pluginApi().beanLoader());
return;
}
} finally {
diff --git a/ebean-api/src/main/java/io/ebean/bean/SingleBeanLoader.java b/ebean-api/src/main/java/io/ebean/bean/SingleBeanLoader.java
index e196d3c5a..73f3fe5d8 100644
--- a/ebean-api/src/main/java/io/ebean/bean/SingleBeanLoader.java
+++ b/ebean-api/src/main/java/io/ebean/bean/SingleBeanLoader.java
@@ -39,7 +39,7 @@ public abstract class SingleBeanLoader implements BeanLoader {
@Override
public void loadBean(EntityBeanIntercept ebi) {
- database.getPluginApi().loadBeanL2(ebi);
+ database.pluginApi().loadBeanL2(ebi);
}
}
@@ -53,7 +53,7 @@ public abstract class SingleBeanLoader implements BeanLoader {
@Override
public void loadBean(EntityBeanIntercept ebi) {
- database.getPluginApi().loadBeanRef(ebi);
+ database.pluginApi().loadBeanRef(ebi);
}
}
@@ -67,7 +67,7 @@ public abstract class SingleBeanLoader implements BeanLoader {
@Override
public void loadBean(EntityBeanIntercept ebi) {
- database.getPluginApi().loadBean(ebi);
+ database.pluginApi().loadBean(ebi);
}
}
}
diff --git a/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/DefaultAutoTuneService.java b/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/DefaultAutoTuneService.java
index 8ea80d3a6..b8d302f23 100644
--- a/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/DefaultAutoTuneService.java
+++ b/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/DefaultAutoTuneService.java
@@ -77,7 +77,7 @@ public class DefaultAutoTuneService implements AutoTuneService {
loadTuningFile();
if (isRuntimeTuningUpdates()) {
// periodically gather and update query tuning
- server.getBackgroundExecutor().scheduleWithFixedDelay(new ProfilingUpdate(), profilingUpdateFrequency, profilingUpdateFrequency, TimeUnit.SECONDS);
+ server.backgroundExecutor().scheduleWithFixedDelay(new ProfilingUpdate(), profilingUpdateFrequency, profilingUpdateFrequency, TimeUnit.SECONDS);
}
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index 2b588655b..df7a32beb 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -330,17 +330,17 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public Platform getPlatform() {
+ public Platform platform() {
return databasePlatform.getPlatform();
}
@Override
- public SpiServer getPluginApi() {
+ public SpiServer pluginApi() {
return this;
}
@Override
- public BackgroundExecutor getBackgroundExecutor() {
+ public BackgroundExecutor backgroundExecutor() {
return backgroundExecutor;
}
diff --git a/ebean-core/src/test/java/io/ebean/ConditionalTestRunner.java b/ebean-core/src/test/java/io/ebean/ConditionalTestRunner.java
index 4adf007d8..d0dea0067 100644
--- a/ebean-core/src/test/java/io/ebean/ConditionalTestRunner.java
+++ b/ebean-core/src/test/java/io/ebean/ConditionalTestRunner.java
@@ -37,7 +37,7 @@ public class ConditionalTestRunner extends BlockJUnit4ClassRunner {
}
private boolean platformMath(Platform[] platforms) {
- Platform basePlatform = DB.getDefault().getPlatform().base();
+ Platform basePlatform = DB.getDefault().platform().base();
for (Platform platform : platforms) {
if (platform.equals(basePlatform)) {
return true;
diff --git a/ebean-core/src/test/java/io/ebean/config/dbplatform/DatabasePlatformTest.java b/ebean-core/src/test/java/io/ebean/config/dbplatform/DatabasePlatformTest.java
index 40d8b6e28..1e7603a7e 100644
--- a/ebean-core/src/test/java/io/ebean/config/dbplatform/DatabasePlatformTest.java
+++ b/ebean-core/src/test/java/io/ebean/config/dbplatform/DatabasePlatformTest.java
@@ -20,35 +20,35 @@ public class DatabasePlatformTest extends BaseTestCase {
@Test
@ForPlatform(Platform.H2)
public void h2_platform() {
- final Platform platform = DB.getDefault().getPlatform();
+ final Platform platform = DB.getDefault().platform();
assertThat(platform).isSameAs(Platform.H2);
}
@Test
@ForPlatform(Platform.POSTGRES)
public void postgres_platform() {
- final Platform platform = DB.getDefault().getPlatform().base();
+ final Platform platform = DB.getDefault().platform().base();
assertThat(platform).isSameAs(Platform.POSTGRES);
}
@Test
@ForPlatform(Platform.MYSQL)
public void mysql_platform() {
- final Platform platform = DB.getDefault().getPlatform().base();
+ final Platform platform = DB.getDefault().platform().base();
assertThat(platform).isSameAs(Platform.MYSQL);
}
@Test
@ForPlatform(Platform.MARIADB)
public void mariadb_platform() {
- final Platform platform = DB.getDefault().getPlatform().base();
+ final Platform platform = DB.getDefault().platform().base();
assertThat(platform).isSameAs(Platform.MARIADB);
}
@Test
@ForPlatform(Platform.SQLSERVER)
public void sqlserver_platform() {
- final Platform platform = DB.getDefault().getPlatform().base();
+ final Platform platform = DB.getDefault().platform().base();
assertThat(platform).isSameAs(Platform.SQLSERVER);
}
diff --git a/ebean-core/src/test/java/io/ebean/config/dbplatform/sqlserver/SqlServerStepSequenceTest.java b/ebean-core/src/test/java/io/ebean/config/dbplatform/sqlserver/SqlServerStepSequenceTest.java
index ff4f3ad05..e6c622437 100644
--- a/ebean-core/src/test/java/io/ebean/config/dbplatform/sqlserver/SqlServerStepSequenceTest.java
+++ b/ebean-core/src/test/java/io/ebean/config/dbplatform/sqlserver/SqlServerStepSequenceTest.java
@@ -26,7 +26,7 @@ public class SqlServerStepSequenceTest extends BaseTestCase {
server().sqlUpdate("drop sequence if exists sqls_testseq_9876").execute();
server().sqlUpdate("create sequence sqls_testseq_9876 start with 1 increment by 50").execute();
- BackgroundExecutor be = server().getBackgroundExecutor();
+ BackgroundExecutor be = server().backgroundExecutor();
DataSource ds = server().dataSource();
SqlServerStepSequence s = new SqlServerStepSequence(be, ds, "sqls_testseq_9876", 50);
diff --git a/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java b/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
index 820e89408..222dd2508 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
@@ -28,7 +28,7 @@ public class BeanTypeTest {
private static Database db = DB.getDefault();
private BeanType beanType(Class cls) {
- return db.getPluginApi().getBeanType(cls);
+ return db.pluginApi().getBeanType(cls);
}
@Test
diff --git a/ebean-core/src/test/java/io/ebean/plugin/ExpressionPathTest.java b/ebean-core/src/test/java/io/ebean/plugin/ExpressionPathTest.java
index 274cbb846..de6a79308 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/ExpressionPathTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/ExpressionPathTest.java
@@ -15,7 +15,7 @@ public class ExpressionPathTest {
static EbeanServer server = Ebean.getDefaultServer();
BeanType beanType(Class cls) {
- return server.getPluginApi().getBeanType(cls);
+ return server.pluginApi().getBeanType(cls);
}
@Test
diff --git a/ebean-core/src/test/java/io/ebean/plugin/PropertyTest.java b/ebean-core/src/test/java/io/ebean/plugin/PropertyTest.java
index 581d5a647..1e3fcf472 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/PropertyTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/PropertyTest.java
@@ -15,7 +15,7 @@ public class PropertyTest {
static EbeanServer server = Ebean.getDefaultServer();
BeanType beanType(Class cls) {
- return server.getPluginApi().getBeanType(cls);
+ return server.pluginApi().getBeanType(cls);
}
@Test
diff --git a/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java b/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
index 4ea9727de..507df1339 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
@@ -23,7 +23,7 @@ public class SpiServerTest extends BaseTestCase {
public void test() {
EbeanServer defaultServer = Ebean.getDefaultServer();
- SpiServer pluginApi = defaultServer.getPluginApi();
+ SpiServer pluginApi = defaultServer.pluginApi();
BeanType beanType = pluginApi.getBeanType(Customer.class);
assertEquals("o_customer", beanType.getBaseTable());
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
index 8963bfa5b..1e52c263e 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
@@ -143,12 +143,12 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public Platform getPlatform() {
+ public Platform platform() {
return Platform.GENERIC;
}
@Override
- public SpiServer getPluginApi() {
+ public SpiServer pluginApi() {
return null;
}
@@ -924,7 +924,7 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public BackgroundExecutor getBackgroundExecutor() {
+ public BackgroundExecutor backgroundExecutor() {
return null;
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/changelog/DefaultChangeLogListenerTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/changelog/DefaultChangeLogListenerTest.java
index e13ff7615..0209d5438 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/changelog/DefaultChangeLogListenerTest.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/changelog/DefaultChangeLogListenerTest.java
@@ -16,7 +16,7 @@ public class DefaultChangeLogListenerTest extends BaseTestCase {
DefaultChangeLogListener changeLogListener = new DefaultChangeLogListener();
EbeanServer defaultServer = Ebean.getDefaultServer();
- changeLogListener.configure(defaultServer.getPluginApi());
+ changeLogListener.configure(defaultServer.pluginApi());
ChangeSet changeSet = helper.createChangeSet("INT-001", 13);
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/executor/TestShutdownWithBackgroundTasks.java b/ebean-core/src/test/java/io/ebeaninternal/server/executor/TestShutdownWithBackgroundTasks.java
index a0a98c38a..563e50f3e 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/executor/TestShutdownWithBackgroundTasks.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/executor/TestShutdownWithBackgroundTasks.java
@@ -15,7 +15,7 @@ public class TestShutdownWithBackgroundTasks extends BaseTestCase {
public void test() {
Database server = DB.getDefault();
- final BackgroundExecutor bg = server.getBackgroundExecutor();
+ final BackgroundExecutor bg = server.backgroundExecutor();
try {
for (int i = 0; i < 12; i++) {
bg.execute(new Job(server, 500, i));
diff --git a/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreDeleteEventTest.java b/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreDeleteEventTest.java
index 9381188cf..6bfb125fa 100644
--- a/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreDeleteEventTest.java
+++ b/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreDeleteEventTest.java
@@ -22,7 +22,7 @@ public class DocStoreDeleteEventTest {
static EbeanServer server = Ebean.getDefaultServer();
BeanType beanType(Class cls) {
- return server.getPluginApi().getBeanType(cls);
+ return server.pluginApi().getBeanType(cls);
}
BeanType orderType() {
diff --git a/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreIndexEventTest.java b/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreIndexEventTest.java
index c214f22ef..b2b8dd3ce 100644
--- a/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreIndexEventTest.java
+++ b/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreIndexEventTest.java
@@ -20,7 +20,7 @@ public class DocStoreIndexEventTest {
static EbeanServer server = Ebean.getDefaultServer();
BeanType beanType(Class cls) {
- return server.getPluginApi().getBeanType(cls);
+ return server.pluginApi().getBeanType(cls);
}
BeanType orderType() {
diff --git a/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java b/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
index 4c4d56109..6fbcdac6d 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
@@ -300,7 +300,7 @@ public class TestQueryCache extends BaseTestCase {
@Test
public void findCountDifferentQueriesBit() {
- DB.getDefault().getPluginApi().getServerCacheManager().clearAll();
+ DB.getDefault().pluginApi().getServerCacheManager().clearAll();
differentFindCount(q->q.bitwiseAny("id",1), q->q.bitwiseAny("id",0));
differentFindCount(q->q.bitwiseAll("id",1), q->q.bitwiseAll("id",0));
// differentFindCount(q->q.bitwiseNot("id",1), q->q.bitwiseNot("id",0)); NOT 1 == AND 1 = 0
diff --git a/ebean-core/src/test/java/org/tests/ddd/iud/TestDPersonEl.java b/ebean-core/src/test/java/org/tests/ddd/iud/TestDPersonEl.java
index 237b4c66b..9dc2ec555 100644
--- a/ebean-core/src/test/java/org/tests/ddd/iud/TestDPersonEl.java
+++ b/ebean-core/src/test/java/org/tests/ddd/iud/TestDPersonEl.java
@@ -23,7 +23,7 @@ public class TestDPersonEl {
Currency NZD = Currency.getInstance("NZD");
assertThat(NZD).isNotNull();
-
+
DPerson p = new DPerson();
p.setFirstName("first");
p.setLastName("last");
@@ -31,7 +31,7 @@ public class TestDPersonEl {
Ebean.save(p);
- SpiServer server = Ebean.getDefaultServer().getPluginApi();
+ SpiServer server = Ebean.getDefaultServer().pluginApi();
BeanType descriptor = server.getBeanType(DPerson.class);
diff --git a/ebean-core/src/test/java/org/tests/el/TestPathExpression.java b/ebean-core/src/test/java/org/tests/el/TestPathExpression.java
index 1fa061269..a39d63f9a 100644
--- a/ebean-core/src/test/java/org/tests/el/TestPathExpression.java
+++ b/ebean-core/src/test/java/org/tests/el/TestPathExpression.java
@@ -20,7 +20,7 @@ public class TestPathExpression {
final ExpressionPath city;
public TestPathExpression() {
- SpiServer server = Ebean.getDefaultServer().getPluginApi();
+ SpiServer server = Ebean.getDefaultServer().pluginApi();
beanType = server.getBeanType(Customer.class);
billingId = beanType.getExpressionPath("billingAddress.id");
line1 = beanType.getExpressionPath("billingAddress.line1");
diff --git a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson.java b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson.java
index 00b4bfa52..3fb42e561 100644
--- a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson.java
+++ b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson.java
@@ -37,7 +37,7 @@ public class TestDbJson_Jackson extends BaseTestCase {
bean.getValueMap().put(1, "one");
bean.getValueMap().put(2, "two");
- ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().getPluginApi().getServerConfig().getObjectMapper();
+ ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().getServerConfig().getObjectMapper();
String json = mapper.writeValueAsString(bean);
EBasicJsonJackson found = mapper.readValue(json, EBasicJsonJackson.class);
@@ -83,7 +83,7 @@ public class TestDbJson_Jackson extends BaseTestCase {
bean.getValueMap().put(1, new StringJacksonType("A"));
bean.getValueMap().put(2, new LongJacksonType(7l));
- ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().getPluginApi().getServerConfig().getObjectMapper();
+ ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().getServerConfig().getObjectMapper();
String json = mapper.writeValueAsString(bean);
assertThat(json)
diff --git a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson2.java b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson2.java
index f4a9a0d41..ef258ec86 100644
--- a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson2.java
+++ b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson2.java
@@ -34,7 +34,7 @@ public class TestDbJson_Jackson2 extends BaseTestCase {
bean.getValueMap().put(1, new StringJacksonType("A"));
bean.getValueMap().put(2, new LongJacksonType(7l));
- ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().getPluginApi().getServerConfig().getObjectMapper();
+ ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().getServerConfig().getObjectMapper();
String json = mapper.writeValueAsString(bean);
found = mapper.readValue(json, EBasicJsonJackson2.class);
diff --git a/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java b/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
index fe957ef88..f98590371 100644
--- a/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
+++ b/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
@@ -20,7 +20,7 @@ public class TestEmbeddedManyToOne extends BaseTestCase {
ResetBasicData.reset();
- BeanType embType = Ebean.getDefaultServer().getPluginApi().getBeanType(EAddr.class);
+ BeanType embType = Ebean.getDefaultServer().pluginApi().getBeanType(EAddr.class);
Ebean.getDefaultServer().getServerCacheManager().clearAll();
diff --git a/ebean-core/src/test/java/org/tests/query/TestQueryFindIterate.java b/ebean-core/src/test/java/org/tests/query/TestQueryFindIterate.java
index 0cd41e022..7fb3b3863 100644
--- a/ebean-core/src/test/java/org/tests/query/TestQueryFindIterate.java
+++ b/ebean-core/src/test/java/org/tests/query/TestQueryFindIterate.java
@@ -232,7 +232,7 @@ public class TestQueryFindIterate extends BaseTestCase {
public void findIterateCloseConnection(boolean withLoadBatch) {
ResetBasicData.reset();
- SpiServer pluginApi = server().getPluginApi();
+ SpiServer pluginApi = server().pluginApi();
DataSourcePool dsPool = (DataSourcePool) pluginApi.getServerConfig().getReadOnlyDataSource();
if (dsPool == null) {
dsPool = (DataSourcePool) server().dataSource();
diff --git a/ebean-core/src/test/java/org/tests/query/cancel/SqlQueryCancelTest.java b/ebean-core/src/test/java/org/tests/query/cancel/SqlQueryCancelTest.java
index 40818cc91..5d51620c2 100644
--- a/ebean-core/src/test/java/org/tests/query/cancel/SqlQueryCancelTest.java
+++ b/ebean-core/src/test/java/org/tests/query/cancel/SqlQueryCancelTest.java
@@ -1,7 +1,6 @@
package org.tests.query.cancel;
import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThatCode;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import java.sql.SQLException;
@@ -76,7 +75,7 @@ public class SqlQueryCancelTest extends BaseTestCase {
EBasic model = new EBasic("Basic " + i);
DB.save(model);
}
- if (Platform.H2.equals(DB.getDefault().getPlatform())) {
+ if (Platform.H2.equals(DB.getDefault().platform())) {
SlowDownEBasic.setSelectWaitMillis(0);
}
}
diff --git a/ebean-core/src/test/java/org/tests/query/sqlquery/TestNativeILikeExpression.java b/ebean-core/src/test/java/org/tests/query/sqlquery/TestNativeILikeExpression.java
index b3898dfad..37963ead5 100644
--- a/ebean-core/src/test/java/org/tests/query/sqlquery/TestNativeILikeExpression.java
+++ b/ebean-core/src/test/java/org/tests/query/sqlquery/TestNativeILikeExpression.java
@@ -36,9 +36,9 @@ public class TestNativeILikeExpression extends BaseTestCase {
private boolean isExpectNative() {
- SpiServer pluginApi = server().getPluginApi();
+ SpiServer pluginApi = server().pluginApi();
boolean expressionNativeIlike = pluginApi.getServerConfig().isExpressionNativeIlike();
- Platform platform = pluginApi.getPlatform().base();
+ Platform platform = pluginApi.platform().base();
return expressionNativeIlike && platform == Platform.POSTGRES;
}
diff --git a/ebean-core/src/test/java/org/tests/text/json/TestTextJsonInvokeLazy.java b/ebean-core/src/test/java/org/tests/text/json/TestTextJsonInvokeLazy.java
index ee41b162e..99b0dd279 100644
--- a/ebean-core/src/test/java/org/tests/text/json/TestTextJsonInvokeLazy.java
+++ b/ebean-core/src/test/java/org/tests/text/json/TestTextJsonInvokeLazy.java
@@ -16,9 +16,9 @@ public class TestTextJsonInvokeLazy extends BaseTestCase {
@Before
public void clearBeanCache() {
- server().getPluginApi().getBeanType(Customer.class).clearBeanCache();
+ server().pluginApi().getBeanType(Customer.class).clearBeanCache();
}
-
+
@Test
public void test() throws IOException {
diff --git a/ebean-core/src/test/java/org/tests/types/TestNewTypes.java b/ebean-core/src/test/java/org/tests/types/TestNewTypes.java
index ca02e91bc..eb0210564 100644
--- a/ebean-core/src/test/java/org/tests/types/TestNewTypes.java
+++ b/ebean-core/src/test/java/org/tests/types/TestNewTypes.java
@@ -216,7 +216,7 @@ public class TestNewTypes extends BaseTestCase {
private void testSetGetPath(SomeNewTypesBean refBean) {
SomeNewTypesBean testBean = new SomeNewTypesBean();
- BeanType beanType = DB.getDefault().getPluginApi().getBeanType(SomeNewTypesBean.class);
+ BeanType beanType = DB.getDefault().pluginApi().getBeanType(SomeNewTypesBean.class);
ExpressionPath localDate = beanType.getExpressionPath("localDate");
ExpressionPath localDateTime = beanType.getExpressionPath("localDateTime");
ExpressionPath offsetDateTime = beanType.getExpressionPath("offsetDateTime");
diff --git a/ebean-ddl-generator/src/test/java/io/ebean/ConditionalTestRunner.java b/ebean-ddl-generator/src/test/java/io/ebean/ConditionalTestRunner.java
index 4adf007d8..d0dea0067 100644
--- a/ebean-ddl-generator/src/test/java/io/ebean/ConditionalTestRunner.java
+++ b/ebean-ddl-generator/src/test/java/io/ebean/ConditionalTestRunner.java
@@ -37,7 +37,7 @@ public class ConditionalTestRunner extends BlockJUnit4ClassRunner {
}
private boolean platformMath(Platform[] platforms) {
- Platform basePlatform = DB.getDefault().getPlatform().base();
+ Platform basePlatform = DB.getDefault().platform().base();
for (Platform platform : platforms) {
if (platform.equals(basePlatform)) {
return true;
diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationTest.java
index 110fcb943..a659a2b65 100644
--- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationTest.java
+++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationTest.java
@@ -16,7 +16,7 @@ import static org.assertj.core.api.Assertions.assertThat;
public class DbMigrationTest extends BaseTestCase {
private void runScript(boolean expectErrors, String scriptName) throws IOException {
- String ddl = Helper.asText(this, "/dbmigration/migrationtest/" + server().getPlatform().name().toLowerCase() + "/" + scriptName);
+ String ddl = Helper.asText(this, "/dbmigration/migrationtest/" + server().platform().name().toLowerCase() + "/" + scriptName);
runScript(expectErrors, ddl, scriptName);
}
diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java
index a696c4e62..0ddbcbca1 100644
--- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java
+++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java
@@ -33,7 +33,7 @@ public class PlatformDdl_AlterColumnTest {
private final PlatformDdl hanaDdl = PlatformDdlBuilder.create(new HanaPlatform());
{
- DatabaseConfig serverConfig = DB.getDefault().getPluginApi().getServerConfig();
+ DatabaseConfig serverConfig = DB.getDefault().pluginApi().getServerConfig();
sqlServerDdl.configure(serverConfig);
}
diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java
index d7d33feae..c1871d4db 100644
--- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java
+++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java
@@ -25,7 +25,7 @@ public class PlatformDdl_CreateIndexTest {
private final PlatformDdl hanaDdl = PlatformDdlBuilder.create(new HanaPlatform());
{
- DatabaseConfig config = DB.getDefault().getPluginApi().getServerConfig();
+ DatabaseConfig config = DB.getDefault().pluginApi().getServerConfig();
h2Ddl.configure(config);
pgDdl.configure(config);
mysqlDdl.configure(config);
diff --git a/ebean-redis/src/test/java/org/integration/ClusterTest.java b/ebean-redis/src/test/java/org/integration/ClusterTest.java
index 9ae04139e..c61b521a0 100644
--- a/ebean-redis/src/test/java/org/integration/ClusterTest.java
+++ b/ebean-redis/src/test/java/org/integration/ClusterTest.java
@@ -30,7 +30,7 @@ public class ClusterTest {
public void testBothNear() {
// ensure the default server exists first
final Database db = DB.getDefault();
- Database other = createOther(db.getPluginApi().dataSource());
+ Database other = createOther(db.pluginApi().dataSource());
new QPerson()
.name.eq("Someone")
@@ -62,7 +62,7 @@ public class ClusterTest {
public void test() throws InterruptedException {
// ensure the default server exists first
final Database db = DB.getDefault();
- Database other = createOther(db.getPluginApi().dataSource());
+ Database other = createOther(db.pluginApi().dataSource());
for (int i = 0; i < 10; i++) {
Person foo = new Person("name " + i);
From 0ed6ccf4998d66d199f9fdc5b6bdbb7ebd28de48 Mon Sep 17 00:00:00 2001
From: Rob Bygrave
Date: Thu, 2 Sep 2021 23:14:33 +1200
Subject: [PATCH 033/102] #2348 - Rename Database.getServerCacheManager() to
cacheManager() with deprecation
---
ebean-api/src/main/java/io/ebean/DB.java | 2 +-
ebean-api/src/main/java/io/ebean/Database.java | 10 +++++++++-
ebean-api/src/main/java/io/ebean/Ebean.java | 2 +-
.../io/ebeaninternal/server/core/DefaultServer.java | 2 +-
ebean-core/src/test/java/io/ebean/BaseTestCase.java | 4 ++--
.../java/io/ebean/cache/ServerCacheManagerTest.java | 2 +-
.../java/io/ebeaninternal/api/TDSpiEbeanServer.java | 2 +-
.../server/transaction/JdbcTransactionTest.java | 2 +-
.../test/java/org/tests/basic/TestQueryWithCache.java | 2 +-
.../tests/batchload/TestBatchLazyWithCacheHits.java | 2 +-
.../src/test/java/org/tests/cache/TestBeanCache.java | 2 +-
.../java/org/tests/cache/TestBeanFetchJoinCache.java | 4 ++--
.../org/tests/cache/TestL2DirtyFlagOnLazyLoad.java | 2 +-
.../src/test/java/org/tests/cache/TestQueryCache.java | 2 +-
.../org/tests/cache/personinfo/PersonCacheTests.java | 6 +++---
.../inheritance/cache/TestInheritCacheRefLoad.java | 2 +-
.../basic/cache/TestCacheViaComplexNaturalKey.java | 2 +-
.../basic/cache/TestCacheViaComplexNaturalKey3.java | 3 +--
.../tests/model/embedded/TestEmbeddedManyToOne.java | 2 +-
.../query/embedded/TestMultipleEmbeddedLoading.java | 2 +-
.../test/java/org/tests/readaudit/TestReadAudit.java | 4 ++--
.../src/test/java/io/ebean/BaseTestCase.java | 4 ++--
.../src/test/java/org/integration/ClusterTest.java | 6 +++---
23 files changed, 39 insertions(+), 32 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/DB.java b/ebean-api/src/main/java/io/ebean/DB.java
index c9603ada6..619a6ecc2 100644
--- a/ebean-api/src/main/java/io/ebean/DB.java
+++ b/ebean-api/src/main/java/io/ebean/DB.java
@@ -1246,7 +1246,7 @@ public final class DB {
* Return the manager of the level 2 cache ("L2" cache).
*/
public static ServerCacheManager getServerCacheManager() {
- return getDefault().getServerCacheManager();
+ return getDefault().cacheManager();
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/Database.java b/ebean-api/src/main/java/io/ebean/Database.java
index c11e0cedc..be89f86c2 100644
--- a/ebean-api/src/main/java/io/ebean/Database.java
+++ b/ebean-api/src/main/java/io/ebean/Database.java
@@ -1495,7 +1495,15 @@ public interface Database {
/**
* Return the manager of the server cache ("L2" cache).
*/
- ServerCacheManager getServerCacheManager();
+ ServerCacheManager cacheManager();
+
+ /**
+ * Deprecated migrate to cacheManager().
+ */
+ @Deprecated
+ default ServerCacheManager getServerCacheManager() {
+ return cacheManager();
+ }
/**
* Return the BackgroundExecutor service for asynchronous processing of
diff --git a/ebean-api/src/main/java/io/ebean/Ebean.java b/ebean-api/src/main/java/io/ebean/Ebean.java
index 7dc6cd308..5756a18bf 100644
--- a/ebean-api/src/main/java/io/ebean/Ebean.java
+++ b/ebean-api/src/main/java/io/ebean/Ebean.java
@@ -1208,7 +1208,7 @@ public final class Ebean {
* Return the manager of the server cache ("L2" cache).
*/
public static ServerCacheManager getServerCacheManager() {
- return getDefault().getServerCacheManager();
+ return getDefault().cacheManager();
}
/**
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index df7a32beb..0cee2236b 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -538,7 +538,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public ServerCacheManager getServerCacheManager() {
+ public ServerCacheManager cacheManager() {
return serverCacheManager;
}
diff --git a/ebean-core/src/test/java/io/ebean/BaseTestCase.java b/ebean-core/src/test/java/io/ebean/BaseTestCase.java
index f771d7ab1..dd3c949f9 100644
--- a/ebean-core/src/test/java/io/ebean/BaseTestCase.java
+++ b/ebean-core/src/test/java/io/ebean/BaseTestCase.java
@@ -78,7 +78,7 @@ public abstract class BaseTestCase {
}
protected void clearAllL2Cache() {
- server().getServerCacheManager().clearAll();
+ server().cacheManager().clearAll();
}
protected void resetAllMetrics() {
@@ -242,7 +242,7 @@ public abstract class BaseTestCase {
}
protected ServerCacheStatistics getBeanCacheStats(Class cls, boolean reset) {
- return server().getServerCacheManager().getBeanCache(cls).getStatistics(reset);
+ return server().cacheManager().getBeanCache(cls).getStatistics(reset);
}
protected Platform platform() {
diff --git a/ebean-core/src/test/java/io/ebean/cache/ServerCacheManagerTest.java b/ebean-core/src/test/java/io/ebean/cache/ServerCacheManagerTest.java
index 337a80116..beaa1b31f 100644
--- a/ebean-core/src/test/java/io/ebean/cache/ServerCacheManagerTest.java
+++ b/ebean-core/src/test/java/io/ebean/cache/ServerCacheManagerTest.java
@@ -12,7 +12,7 @@ public class ServerCacheManagerTest {
@Test
public void test() {
- ServerCacheManager cacheManager = DB.getDefault().getServerCacheManager();
+ ServerCacheManager cacheManager = DB.getDefault().cacheManager();
for (ServerCacheRegion region : cacheManager.allRegions()) {
assertTrue(region.isEnabled());
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
index 1e52c263e..648744ca8 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
@@ -919,7 +919,7 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public ServerCacheManager getServerCacheManager() {
+ public ServerCacheManager cacheManager() {
return null;
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/transaction/JdbcTransactionTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/transaction/JdbcTransactionTest.java
index 7416ca58b..ad5a4e1a6 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/transaction/JdbcTransactionTest.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/transaction/JdbcTransactionTest.java
@@ -43,7 +43,7 @@ public class JdbcTransactionTest {
@Test
public void skipCacheAfterSave() {
- ServerCacheManager cacheManager = DB.getDefault().getServerCacheManager();
+ ServerCacheManager cacheManager = DB.getDefault().cacheManager();
ServerCache customerBeanCache = cacheManager.getBeanCache(Customer.class);
ServerCache contactNatKeyCache = cacheManager.getNaturalKeyCache(Contact.class);
diff --git a/ebean-core/src/test/java/org/tests/basic/TestQueryWithCache.java b/ebean-core/src/test/java/org/tests/basic/TestQueryWithCache.java
index 6e8208409..06ef39bdf 100644
--- a/ebean-core/src/test/java/org/tests/basic/TestQueryWithCache.java
+++ b/ebean-core/src/test/java/org/tests/basic/TestQueryWithCache.java
@@ -30,7 +30,7 @@ public class TestQueryWithCache extends BaseTestCase {
assertTrue(cacheOptions.isReadOnly());
assertTrue(beanDescriptor.isCacheSharableBeans());
- ServerCacheManager serverCacheManager = server.getServerCacheManager();
+ ServerCacheManager serverCacheManager = server.cacheManager();
serverCacheManager.clear(Country.class);
ServerCache beanCache = serverCacheManager.getBeanCache(Country.class);
diff --git a/ebean-core/src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java b/ebean-core/src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java
index 2869b2121..3d78cd137 100644
--- a/ebean-core/src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java
+++ b/ebean-core/src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java
@@ -17,7 +17,7 @@ import static org.junit.Assert.assertNotNull;
public class TestBatchLazyWithCacheHits extends BaseTestCase {
- private final ServerCache beanCache = server().getServerCacheManager().getBeanCache(UUOne.class);
+ private final ServerCache beanCache = server().cacheManager().getBeanCache(UUOne.class);
private UUOne insert(String name) {
UUOne one = new UUOne();
diff --git a/ebean-core/src/test/java/org/tests/cache/TestBeanCache.java b/ebean-core/src/test/java/org/tests/cache/TestBeanCache.java
index 99e40879d..280848b95 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestBeanCache.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestBeanCache.java
@@ -27,7 +27,7 @@ public class TestBeanCache extends BaseTestCase {
private static final Logger log = LoggerFactory.getLogger(TestBeanCache.class);
- private final ServerCache beanCache = DB.getDefault().getServerCacheManager().getBeanCache(OCachedBean.class);
+ private final ServerCache beanCache = DB.getDefault().cacheManager().getBeanCache(OCachedBean.class);
@Test
public void findById_when_idTypeConverted() {
diff --git a/ebean-core/src/test/java/org/tests/cache/TestBeanFetchJoinCache.java b/ebean-core/src/test/java/org/tests/cache/TestBeanFetchJoinCache.java
index d22c21e3b..c0d632abc 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestBeanFetchJoinCache.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestBeanFetchJoinCache.java
@@ -18,7 +18,7 @@ import static org.assertj.core.api.Assertions.assertThat;
public class TestBeanFetchJoinCache extends BaseTestCase {
- private final ServerCache customerBeanCache = server().getServerCacheManager().getBeanCache(Customer.class);
+ private final ServerCache customerBeanCache = server().cacheManager().getBeanCache(Customer.class);
@Test
public void fetchCache_when_allHits() {
@@ -181,6 +181,6 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
private void initDataClearCache() {
ResetBasicData.reset();
- server().getServerCacheManager().clearAll();
+ server().cacheManager().clearAll();
}
}
diff --git a/ebean-core/src/test/java/org/tests/cache/TestL2DirtyFlagOnLazyLoad.java b/ebean-core/src/test/java/org/tests/cache/TestL2DirtyFlagOnLazyLoad.java
index bd655c2fd..6032728a4 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestL2DirtyFlagOnLazyLoad.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestL2DirtyFlagOnLazyLoad.java
@@ -27,7 +27,7 @@ public class TestL2DirtyFlagOnLazyLoad extends BaseTestCase {
// clearAll() caches via the ServerCacheManager ...
// Clear all the caches on the default/primary EbeanServer
- server().getServerCacheManager().clearAll();
+ server().cacheManager().clearAll();
//TEST
try (Transaction tx1 = Ebean.beginTransaction()) {
diff --git a/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java b/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
index 6fbcdac6d..b8a2b518b 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
@@ -300,7 +300,7 @@ public class TestQueryCache extends BaseTestCase {
@Test
public void findCountDifferentQueriesBit() {
- DB.getDefault().pluginApi().getServerCacheManager().clearAll();
+ DB.getDefault().pluginApi().cacheManager().clearAll();
differentFindCount(q->q.bitwiseAny("id",1), q->q.bitwiseAny("id",0));
differentFindCount(q->q.bitwiseAll("id",1), q->q.bitwiseAll("id",0));
// differentFindCount(q->q.bitwiseNot("id",1), q->q.bitwiseNot("id",0)); NOT 1 == AND 1 = 0
diff --git a/ebean-core/src/test/java/org/tests/cache/personinfo/PersonCacheTests.java b/ebean-core/src/test/java/org/tests/cache/personinfo/PersonCacheTests.java
index 20935a319..d057edffd 100644
--- a/ebean-core/src/test/java/org/tests/cache/personinfo/PersonCacheTests.java
+++ b/ebean-core/src/test/java/org/tests/cache/personinfo/PersonCacheTests.java
@@ -21,10 +21,10 @@ public class PersonCacheTests {
private final List ids = Arrays.asList("E001", "E002", "E003");
- private ServerCache beanCacheInfo = DB.getDefault().getServerCacheManager().getBeanCache(PersonCacheInfo.class);
- private ServerCache beanCacheEmail = DB.getDefault().getServerCacheManager().getBeanCache(PersonCacheEmail.class);
+ private ServerCache beanCacheInfo = DB.getDefault().cacheManager().getBeanCache(PersonCacheInfo.class);
+ private ServerCache beanCacheEmail = DB.getDefault().cacheManager().getBeanCache(PersonCacheEmail.class);
- private ServerCacheRegion region = DB.getDefault().getServerCacheManager().getRegion("email");
+ private ServerCacheRegion region = DB.getDefault().cacheManager().getRegion("email");
private void insert(int id, String email) {
diff --git a/ebean-core/src/test/java/org/tests/inheritance/cache/TestInheritCacheRefLoad.java b/ebean-core/src/test/java/org/tests/inheritance/cache/TestInheritCacheRefLoad.java
index 0f79a4206..af6c1299d 100644
--- a/ebean-core/src/test/java/org/tests/inheritance/cache/TestInheritCacheRefLoad.java
+++ b/ebean-core/src/test/java/org/tests/inheritance/cache/TestInheritCacheRefLoad.java
@@ -56,7 +56,7 @@ public class TestInheritCacheRefLoad {
Class streetClassLazyLoaded = customerReloaded.getAddress().getStreet().getClass();
//Show Cache Hits
- System.out.println("Class of Street (Cache on: " + l2Cache + "): " + streetClassLazyLoaded + " | Cache Hit: " + DB.getDefault().getServerCacheManager().getQueryCache(streetClassLazyLoaded).getStatistics(false).getHitCount());
+ System.out.println("Class of Street (Cache on: " + l2Cache + "): " + streetClassLazyLoaded + " | Cache Hit: " + DB.getDefault().cacheManager().getQueryCache(streetClassLazyLoaded).getStatistics(false).getHitCount());
return streetClassLazyLoaded;
}
diff --git a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey.java b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey.java
index 3b2cfc5f5..7411b1842 100644
--- a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey.java
+++ b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey.java
@@ -27,7 +27,7 @@ public class TestCacheViaComplexNaturalKey extends BaseTestCase {
private static boolean loadOnce;
private ServerCacheManager cacheManager() {
- return server().getServerCacheManager();
+ return server().cacheManager();
}
private static void insertSome() {
diff --git a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey3.java b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey3.java
index 236b2545e..a94b77725 100644
--- a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey3.java
+++ b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey3.java
@@ -10,7 +10,6 @@ import io.ebean.cache.ServerCacheStatistics;
import org.ebeantest.LoggedSqlCollector;
import org.junit.Test;
-import java.util.Arrays;
import java.util.List;
import java.util.Map;
@@ -25,7 +24,7 @@ public class TestCacheViaComplexNaturalKey3 extends BaseTestCase {
private static boolean loadOnce;
private ServerCacheManager cacheManager() {
- return server().getServerCacheManager();
+ return server().cacheManager();
}
private static void insertSome() {
diff --git a/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java b/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
index f98590371..7eff8c97f 100644
--- a/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
+++ b/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
@@ -22,7 +22,7 @@ public class TestEmbeddedManyToOne extends BaseTestCase {
BeanType embType = Ebean.getDefaultServer().pluginApi().getBeanType(EAddr.class);
- Ebean.getDefaultServer().getServerCacheManager().clearAll();
+ Ebean.getDefaultServer().cacheManager().clearAll();
Country nz = Ebean.getReference(Country.class, "NZ");
diff --git a/ebean-core/src/test/java/org/tests/query/embedded/TestMultipleEmbeddedLoading.java b/ebean-core/src/test/java/org/tests/query/embedded/TestMultipleEmbeddedLoading.java
index b6ca2d3c0..616d0b441 100644
--- a/ebean-core/src/test/java/org/tests/query/embedded/TestMultipleEmbeddedLoading.java
+++ b/ebean-core/src/test/java/org/tests/query/embedded/TestMultipleEmbeddedLoading.java
@@ -77,7 +77,7 @@ public class TestMultipleEmbeddedLoading extends BaseTestCase {
assertEquals("3 Pineapple St", billAddress.getStreet());
EbeanServer server = Ebean.getServer(null);
- ServerCacheManager serverCacheManager = server.getServerCacheManager();
+ ServerCacheManager serverCacheManager = server.cacheManager();
// get cache, clear the cache and statistics
ServerCache beanCache = serverCacheManager.getBeanCache(EInvoice.class);
diff --git a/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java b/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
index 98f24353b..f2e74e4f5 100644
--- a/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
+++ b/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
@@ -83,7 +83,7 @@ public class TestReadAudit extends BaseTestCase {
public void test_findById_usingL2Cache() {
resetCounters();
- ServerCache beanCache = server.getServerCacheManager().getBeanCache(EBasicChangeLog.class);
+ ServerCache beanCache = server.cacheManager().getBeanCache(EBasicChangeLog.class);
beanCache.getStatistics(true);
EBasicChangeLog found = server.find(EBasicChangeLog.class, id1);
@@ -111,7 +111,7 @@ public class TestReadAudit extends BaseTestCase {
public void test_findById_usingL2Cache_sharedBean() {
resetCounters();
- ServerCache beanCache = server.getServerCacheManager().getBeanCache(Country.class);
+ ServerCache beanCache = server.cacheManager().getBeanCache(Country.class);
beanCache.getStatistics(true);
Country found = server.find(Country.class, "AR");
diff --git a/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java b/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
index 568664de2..93ca61c87 100644
--- a/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
+++ b/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
@@ -74,7 +74,7 @@ public abstract class BaseTestCase {
}
protected void clearAllL2Cache() {
- server().getServerCacheManager().clearAll();
+ server().cacheManager().clearAll();
}
protected void resetAllMetrics() {
@@ -238,7 +238,7 @@ public abstract class BaseTestCase {
}
protected ServerCacheStatistics getBeanCacheStats(Class cls, boolean reset) {
- return server().getServerCacheManager().getBeanCache(cls).getStatistics(reset);
+ return server().cacheManager().getBeanCache(cls).getStatistics(reset);
}
protected Platform platform() {
diff --git a/ebean-redis/src/test/java/org/integration/ClusterTest.java b/ebean-redis/src/test/java/org/integration/ClusterTest.java
index c61b521a0..b1f134ca3 100644
--- a/ebean-redis/src/test/java/org/integration/ClusterTest.java
+++ b/ebean-redis/src/test/java/org/integration/ClusterTest.java
@@ -54,7 +54,7 @@ public class ClusterTest {
fooA = DB.find(Person.class, foo.getId());
assertCounts(dualCacheA, 2, 1, 0, 1);
fooB = other.find(Person.class, foo.getId());
- DuelCache dualCacheB = (DuelCache) other.getServerCacheManager().getBeanCache(Person.class);
+ DuelCache dualCacheB = (DuelCache) other.cacheManager().getBeanCache(Person.class);
assertCounts(dualCacheB, 2, 1, 1, 0);
}
@@ -69,10 +69,10 @@ public class ClusterTest {
foo.save();
}
- other.getServerCacheManager().clearAll();
+ other.cacheManager().clearAll();
other.metaInfo().resetAllMetrics();
- DuelCache dualCache = (DuelCache) other.getServerCacheManager().getBeanCache(Person.class);
+ DuelCache dualCache = (DuelCache) other.cacheManager().getBeanCache(Person.class);
Person foo0 = other.find(Person.class, 1);
assertCounts(dualCache, 0, 1, 0, 1);
From a5f9beabdffa7cb4f87d954885e999c6647abba9 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 09:31:16 +1200
Subject: [PATCH 034/102] #2349 - Rename Database.getBeanId() to beanId() with
deprecation
---
ebean-api/src/main/java/io/ebean/DB.java | 2 +-
.../src/main/java/io/ebean/Database.java | 20 +++++++++++++++++--
.../server/core/DefaultServer.java | 4 ++--
.../ebeaninternal/api/TDSpiEbeanServer.java | 4 ++--
.../org/tests/basic/TestExplicitInsert.java | 6 +++---
.../TestBatchSaveWithGetBeanId.java | 2 +-
.../bothsides/TestInheritanceBothSides.java | 4 ++--
7 files changed, 29 insertions(+), 13 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/DB.java b/ebean-api/src/main/java/io/ebean/DB.java
index 619a6ecc2..6851a6129 100644
--- a/ebean-api/src/main/java/io/ebean/DB.java
+++ b/ebean-api/src/main/java/io/ebean/DB.java
@@ -1239,7 +1239,7 @@ public final class DB {
* Return the value of the Id property for a given bean.
*/
public static Object getBeanId(Object bean) {
- return getDefault().getBeanId(bean);
+ return getDefault().beanId(bean);
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/Database.java b/ebean-api/src/main/java/io/ebean/Database.java
index be89f86c2..d113cf041 100644
--- a/ebean-api/src/main/java/io/ebean/Database.java
+++ b/ebean-api/src/main/java/io/ebean/Database.java
@@ -248,7 +248,15 @@ public interface Database {
/**
* Return the value of the Id property for a given bean.
*/
- Object getBeanId(Object bean);
+ Object beanId(Object bean);
+
+ /**
+ * Deprecated migrate to beanId().
+ */
+ @Deprecated
+ default Object getBeanId(Object bean) {
+ return beanId(bean);
+ }
/**
* Set the Id value onto the bean converting the type of the id value if necessary.
@@ -260,7 +268,15 @@ public interface Database {
* @param bean The entity bean to set the id value on.
* @param id The id value to set.
*/
- Object setBeanId(Object bean, Object id);
+ Object beanId(Object bean, Object id);
+
+ /**
+ * Deprecated migrate to beanId().
+ */
+ @Deprecated
+ default Object setBeanId(Object bean, Object id) {
+ return beanId(bean, id);
+ }
/**
* Return a map of the differences between two objects of the same type.
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index 0cee2236b..f6916bbe4 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -2079,7 +2079,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public Object setBeanId(Object bean, Object id) {
+ public Object beanId(Object bean, Object id) {
EntityBean eb = checkEntityBean(bean);
BeanDescriptor> desc = getBeanDescriptor(bean.getClass());
if (desc == null) {
@@ -2089,7 +2089,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public Object getBeanId(Object bean) {
+ public Object beanId(Object bean) {
EntityBean eb = checkEntityBean(bean);
BeanDescriptor> desc = getBeanDescriptor(bean.getClass());
if (desc == null) {
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
index 648744ca8..df747b1d0 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
@@ -368,12 +368,12 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public Object setBeanId(Object bean, Object id) {
+ public Object beanId(Object bean, Object id) {
return id;
}
@Override
- public Object getBeanId(Object bean) {
+ public Object beanId(Object bean) {
return null;
}
diff --git a/ebean-core/src/test/java/org/tests/basic/TestExplicitInsert.java b/ebean-core/src/test/java/org/tests/basic/TestExplicitInsert.java
index c6f8fb287..3dae9111d 100644
--- a/ebean-core/src/test/java/org/tests/basic/TestExplicitInsert.java
+++ b/ebean-core/src/test/java/org/tests/basic/TestExplicitInsert.java
@@ -22,7 +22,7 @@ public class TestExplicitInsert extends BaseTestCase {
EbeanServer server = Ebean.getDefaultServer();
Customer cust = new Customer();
- Object returnId = server.setBeanId(cust, "42");
+ Object returnId = server.beanId(cust, "42");
assertThat(returnId).isEqualTo(42);
assertThat(cust.getId()).isEqualTo(42);
@@ -34,7 +34,7 @@ public class TestExplicitInsert extends BaseTestCase {
EbeanServer server = Ebean.getDefaultServer();
Customer customer = new Customer();
- Object returnId = server.setBeanId(customer, 42);
+ Object returnId = server.beanId(customer, 42);
assertThat(returnId).isEqualTo(42);
assertThat(customer.getId()).isEqualTo(42);
@@ -57,7 +57,7 @@ public class TestExplicitInsert extends BaseTestCase {
Assert.assertNotNull(b.getId());
- Assert.assertEquals(b.getId(), server.getBeanId(b));
+ Assert.assertEquals(b.getId(), server.beanId(b));
EBasic b2 = server.find(EBasic.class, b.getId());
diff --git a/ebean-core/src/test/java/org/tests/batchinsert/TestBatchSaveWithGetBeanId.java b/ebean-core/src/test/java/org/tests/batchinsert/TestBatchSaveWithGetBeanId.java
index a83aa13ae..c92440fa6 100644
--- a/ebean-core/src/test/java/org/tests/batchinsert/TestBatchSaveWithGetBeanId.java
+++ b/ebean-core/src/test/java/org/tests/batchinsert/TestBatchSaveWithGetBeanId.java
@@ -31,7 +31,7 @@ public class TestBatchSaveWithGetBeanId extends BaseTestCase {
// should invoke a flush which then means the
// insert occurs and the bean has an Id value
- Object beanId = server.getBeanId(model);
+ Object beanId = server.beanId(model);
assertNotNull(beanId);
Ebean.delete(Customer.class, beanId);
diff --git a/ebean-core/src/test/java/org/tests/inheritance/bothsides/TestInheritanceBothSides.java b/ebean-core/src/test/java/org/tests/inheritance/bothsides/TestInheritanceBothSides.java
index 788e9cf28..df7a28462 100644
--- a/ebean-core/src/test/java/org/tests/inheritance/bothsides/TestInheritanceBothSides.java
+++ b/ebean-core/src/test/java/org/tests/inheritance/bothsides/TestInheritanceBothSides.java
@@ -57,8 +57,8 @@ public class TestInheritanceBothSides extends BaseTestCase {
final Database db = DB.getDefault();
- final SourceBase foundA = DB.find(SourceBase.class, db.getBeanId(sourceA));
- final SourceBase foundB = DB.find(SourceBase.class, db.getBeanId(sourceB));
+ final SourceBase foundA = DB.find(SourceBase.class, db.beanId(sourceA));
+ final SourceBase foundB = DB.find(SourceBase.class, db.beanId(sourceB));
assertSourceBaseEqual(foundA, sourceA);
assertThat(foundA).isInstanceOf(SourceA.class);
From 058e16d1a8570c67dd5b0b5c739e791ca9aa0328 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 09:32:47 +1200
Subject: [PATCH 035/102] #2349 - Rename Database.getBeanId() to beanId() with
deprecation
---
ebean-api/src/main/java/io/ebean/DB.java | 10 +++++++++-
.../cascadedelete/TestInheritanceDeleteCascade.java | 4 ++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/DB.java b/ebean-api/src/main/java/io/ebean/DB.java
index 6851a6129..a6a831853 100644
--- a/ebean-api/src/main/java/io/ebean/DB.java
+++ b/ebean-api/src/main/java/io/ebean/DB.java
@@ -1238,10 +1238,18 @@ public final class DB {
/**
* Return the value of the Id property for a given bean.
*/
- public static Object getBeanId(Object bean) {
+ public static Object beanId(Object bean) {
return getDefault().beanId(bean);
}
+ /**
+ * Deprecated migrate to beanId().
+ */
+ @Deprecated
+ public static Object getBeanId(Object bean) {
+ return beanId(bean);
+ }
+
/**
* Return the manager of the level 2 cache ("L2" cache).
*/
diff --git a/ebean-core/src/test/java/org/tests/inheritance/cascadedelete/TestInheritanceDeleteCascade.java b/ebean-core/src/test/java/org/tests/inheritance/cascadedelete/TestInheritanceDeleteCascade.java
index e4da9b23d..269642b2f 100644
--- a/ebean-core/src/test/java/org/tests/inheritance/cascadedelete/TestInheritanceDeleteCascade.java
+++ b/ebean-core/src/test/java/org/tests/inheritance/cascadedelete/TestInheritanceDeleteCascade.java
@@ -19,8 +19,8 @@ public class TestInheritanceDeleteCascade extends BaseTestCase {
DB.save(referencingBean);
DB.delete(referencingBean);
- assertNull(DB.find(RootBean.class, DB.getBeanId(bean1)));
- assertNull(DB.find(RootBean.class, DB.getBeanId(bean2)));
+ assertNull(DB.find(RootBean.class, DB.beanId(bean1)));
+ assertNull(DB.find(RootBean.class, DB.beanId(bean2)));
}
}
From 921ee9f8a1bb27bac7f03f522858b00620042b30 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 09:46:04 +1200
Subject: [PATCH 036/102] #2345 - Rename Database.getExpressionFactory() to
expressionFactory with deprecation
---
ebean-api/src/main/java/io/ebean/DB.java | 20 ++++-
ebean-api/src/main/java/io/ebean/Expr.java | 85 ++++++++++------------
2 files changed, 58 insertions(+), 47 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/DB.java b/ebean-api/src/main/java/io/ebean/DB.java
index a6a831853..4935b5d9e 100644
--- a/ebean-api/src/main/java/io/ebean/DB.java
+++ b/ebean-api/src/main/java/io/ebean/DB.java
@@ -126,10 +126,18 @@ public final class DB {
* an expression that uses OR like Expression e = Expr.or(..., ...);
*
*/
- public static ExpressionFactory getExpressionFactory() {
+ public static ExpressionFactory expressionFactory() {
return getDefault().expressionFactory();
}
+ /**
+ * Deprecated migrate to expressionFactory().
+ */
+ @Deprecated
+ public static ExpressionFactory getExpressionFactory() {
+ return expressionFactory();
+ }
+
/**
* Return the next identity value for a given bean type.
*
@@ -1261,10 +1269,18 @@ public final class DB {
* Return the BackgroundExecutor service for asynchronous processing of
* queries.
*/
- public static BackgroundExecutor getBackgroundExecutor() {
+ public static BackgroundExecutor backgroundExecutor() {
return getDefault().backgroundExecutor();
}
+ /**
+ * Deprecated migrate to backgroundExecutor().
+ */
+ @Deprecated
+ public static BackgroundExecutor getBackgroundExecutor() {
+ return backgroundExecutor();
+ }
+
/**
* Return the JsonContext for reading/writing JSON.
*/
diff --git a/ebean-api/src/main/java/io/ebean/Expr.java b/ebean-api/src/main/java/io/ebean/Expr.java
index 01b8f0c49..1316f9873 100644
--- a/ebean-api/src/main/java/io/ebean/Expr.java
+++ b/ebean-api/src/main/java/io/ebean/Expr.java
@@ -16,7 +16,7 @@ import java.util.Map;
* This provides a convenient way to create expressions for the default
* database.
*
- * See also {@link DB#getExpressionFactory()}
+ * See also {@link DB#expressionFactory()}
*
*
* Creates standard common expressions for using in a Query Where or Having
@@ -34,14 +34,14 @@ public class Expr {
* Equal To - property equal to the given value.
*/
public static Expression eq(String propertyName, Object value) {
- return DB.getExpressionFactory().eq(propertyName, value);
+ return DB.expressionFactory().eq(propertyName, value);
}
/**
* Not Equal To - property not equal to the given value.
*/
public static Expression ne(String propertyName, Object value) {
- return DB.getExpressionFactory().ne(propertyName, value);
+ return DB.expressionFactory().ne(propertyName, value);
}
/**
@@ -49,7 +49,7 @@ public class Expr {
* using a lower() function to make it case insensitive).
*/
public static Expression ieq(String propertyName, String value) {
- return DB.getExpressionFactory().ieq(propertyName, value);
+ return DB.expressionFactory().ieq(propertyName, value);
}
/**
@@ -59,28 +59,28 @@ public class Expr {
*
*/
public static Expression inRange(String propertyName, Object value1, Object value2) {
- return DB.getExpressionFactory().inRange(propertyName, value1, value2);
+ return DB.expressionFactory().inRange(propertyName, value1, value2);
}
/**
* Between - property between the two given values.
*/
public static Expression between(String propertyName, Object value1, Object value2) {
- return DB.getExpressionFactory().between(propertyName, value1, value2);
+ return DB.expressionFactory().between(propertyName, value1, value2);
}
/**
* Between - value between two given properties.
*/
public static Expression between(String lowProperty, String highProperty, Object value) {
- return DB.getExpressionFactory().betweenProperties(lowProperty, highProperty, value);
+ return DB.expressionFactory().betweenProperties(lowProperty, highProperty, value);
}
/**
* Greater Than - property greater than the given value.
*/
public static Expression gt(String propertyName, Object value) {
- return DB.getExpressionFactory().gt(propertyName, value);
+ return DB.expressionFactory().gt(propertyName, value);
}
/**
@@ -88,42 +88,42 @@ public class Expr {
* value.
*/
public static Expression ge(String propertyName, Object value) {
- return DB.getExpressionFactory().ge(propertyName, value);
+ return DB.expressionFactory().ge(propertyName, value);
}
/**
* Less Than - property less than the given value.
*/
public static Expression lt(String propertyName, Object value) {
- return DB.getExpressionFactory().lt(propertyName, value);
+ return DB.expressionFactory().lt(propertyName, value);
}
/**
* Less Than or Equal to - property less than or equal to the given value.
*/
public static Expression le(String propertyName, Object value) {
- return DB.getExpressionFactory().le(propertyName, value);
+ return DB.expressionFactory().le(propertyName, value);
}
/**
* Is Null - property is null.
*/
public static Expression isNull(String propertyName) {
- return DB.getExpressionFactory().isNull(propertyName);
+ return DB.expressionFactory().isNull(propertyName);
}
/**
* Is Not Null - property is not null.
*/
public static Expression isNotNull(String propertyName) {
- return DB.getExpressionFactory().isNotNull(propertyName);
+ return DB.expressionFactory().isNotNull(propertyName);
}
/**
* Case insensitive {@link #exampleLike(Object)}
*/
public static ExampleExpression iexampleLike(Object example) {
- return DB.getExpressionFactory().iexampleLike(example);
+ return DB.expressionFactory().iexampleLike(example);
}
/**
@@ -131,14 +131,14 @@ public class Expr {
* LikeType.RAW (you need to add you own wildcards % and _).
*/
public static ExampleExpression exampleLike(Object example) {
- return DB.getExpressionFactory().exampleLike(example);
+ return DB.expressionFactory().exampleLike(example);
}
/**
* Create the query by Example expression specifying more options.
*/
public static ExampleExpression exampleLike(Object example, boolean caseInsensitive, LikeType likeType) {
- return DB.getExpressionFactory().exampleLike(example, caseInsensitive, likeType);
+ return DB.expressionFactory().exampleLike(example, caseInsensitive, likeType);
}
/**
@@ -146,7 +146,7 @@ public class Expr {
* characters % (percentage) and _ (underscore).
*/
public static Expression like(String propertyName, String value) {
- return DB.getExpressionFactory().like(propertyName, value);
+ return DB.expressionFactory().like(propertyName, value);
}
/**
@@ -155,14 +155,14 @@ public class Expr {
* a lower() function to make the expression case insensitive.
*/
public static Expression ilike(String propertyName, String value) {
- return DB.getExpressionFactory().ilike(propertyName, value);
+ return DB.expressionFactory().ilike(propertyName, value);
}
/**
* Starts With - property like value%.
*/
public static Expression startsWith(String propertyName, String value) {
- return DB.getExpressionFactory().startsWith(propertyName, value);
+ return DB.expressionFactory().startsWith(propertyName, value);
}
/**
@@ -170,14 +170,14 @@ public class Expr {
* lower() function to make the expression case insensitive.
*/
public static Expression istartsWith(String propertyName, String value) {
- return DB.getExpressionFactory().istartsWith(propertyName, value);
+ return DB.expressionFactory().istartsWith(propertyName, value);
}
/**
* Ends With - property like %value.
*/
public static Expression endsWith(String propertyName, String value) {
- return DB.getExpressionFactory().endsWith(propertyName, value);
+ return DB.expressionFactory().endsWith(propertyName, value);
}
/**
@@ -185,14 +185,14 @@ public class Expr {
* function to make the expression case insensitive.
*/
public static Expression iendsWith(String propertyName, String value) {
- return DB.getExpressionFactory().iendsWith(propertyName, value);
+ return DB.expressionFactory().iendsWith(propertyName, value);
}
/**
* Contains - property like %value%.
*/
public static Expression contains(String propertyName, String value) {
- return DB.getExpressionFactory().contains(propertyName, value);
+ return DB.expressionFactory().contains(propertyName, value);
}
/**
@@ -200,42 +200,42 @@ public class Expr {
* function to make the expression case insensitive.
*/
public static Expression icontains(String propertyName, String value) {
- return DB.getExpressionFactory().icontains(propertyName, value);
+ return DB.expressionFactory().icontains(propertyName, value);
}
/**
* For collection properties that are empty (have not existing elements).
*/
public static Expression isEmpty(String propertyName) {
- return DB.getExpressionFactory().isEmpty(propertyName);
+ return DB.expressionFactory().isEmpty(propertyName);
}
/**
* For collection properties that are not empty (have existing elements).
*/
public static Expression isNotEmpty(String propertyName) {
- return DB.getExpressionFactory().isNotEmpty(propertyName);
+ return DB.expressionFactory().isNotEmpty(propertyName);
}
/**
* In - property has a value in the array of values.
*/
public static Expression in(String propertyName, Object[] values) {
- return DB.getExpressionFactory().in(propertyName, values);
+ return DB.expressionFactory().in(propertyName, values);
}
/**
* In - using a subQuery.
*/
public static Expression in(String propertyName, Query> subQuery) {
- return DB.getExpressionFactory().in(propertyName, subQuery);
+ return DB.expressionFactory().in(propertyName, subQuery);
}
/**
* In - property has a value in the collection of values.
*/
public static Expression in(String propertyName, Collection> values) {
- return DB.getExpressionFactory().in(propertyName, values);
+ return DB.expressionFactory().in(propertyName, values);
}
/**
@@ -272,14 +272,14 @@ public class Expr {
* }
*/
public static Expression inOrEmpty(String propertyName, Collection> values) {
- return DB.getExpressionFactory().inOrEmpty(propertyName, values);
+ return DB.expressionFactory().inOrEmpty(propertyName, values);
}
/**
* Id Equal to - ID property is equal to the value.
*/
public static Expression idEq(Object value) {
- return DB.getExpressionFactory().idEq(value);
+ return DB.expressionFactory().idEq(value);
}
/**
@@ -292,7 +292,7 @@ public class Expr {
* @param propertyMap a map keyed by property names.
*/
public static Expression allEq(Map propertyMap) {
- return DB.getExpressionFactory().allEq(propertyMap);
+ return DB.expressionFactory().allEq(propertyMap);
}
/**
@@ -303,7 +303,7 @@ public class Expr {
*
*/
public static Expression raw(String raw, Object value) {
- return DB.getExpressionFactory().raw(raw, value);
+ return DB.expressionFactory().raw(raw, value);
}
/**
@@ -314,53 +314,48 @@ public class Expr {
*
*/
public static Expression raw(String raw, Object[] values) {
- return DB.getExpressionFactory().raw(raw, values);
+ return DB.expressionFactory().raw(raw, values);
}
/**
* Add raw expression with no parameters.
*/
public static Expression raw(String raw) {
- return DB.getExpressionFactory().raw(raw);
+ return DB.expressionFactory().raw(raw);
}
/**
* And - join two expressions with a logical and.
*/
public static Expression and(Expression expOne, Expression expTwo) {
-
- return DB.getExpressionFactory().and(expOne, expTwo);
+ return DB.expressionFactory().and(expOne, expTwo);
}
/**
* Or - join two expressions with a logical or.
*/
public static Expression or(Expression expOne, Expression expTwo) {
-
- return DB.getExpressionFactory().or(expOne, expTwo);
+ return DB.expressionFactory().or(expOne, expTwo);
}
/**
* Negate the expression (prefix it with NOT).
*/
public static Expression not(Expression exp) {
-
- return DB.getExpressionFactory().not(exp);
+ return DB.expressionFactory().not(exp);
}
/**
* Return a list of expressions that will be joined by AND's.
*/
public static Junction conjunction(Query query) {
-
- return DB.getExpressionFactory().conjunction(query);
+ return DB.expressionFactory().conjunction(query);
}
/**
* Return a list of expressions that will be joined by OR's.
*/
public static Junction disjunction(Query query) {
-
- return DB.getExpressionFactory().disjunction(query);
+ return DB.expressionFactory().disjunction(query);
}
}
From 8cb43788dc3ea0d8018056ca369f3c90b7d6813d Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 09:55:48 +1200
Subject: [PATCH 037/102] #2350 - Rename Database.getBeanState() to beanState()
with deprecation
---
ebean-api/src/main/java/io/ebean/DB.java | 10 ++++++++-
.../src/main/java/io/ebean/Database.java | 10 ++++++++-
ebean-api/src/main/java/io/ebean/Ebean.java | 2 +-
.../server/core/DefaultServer.java | 2 +-
.../java/io/ebean/EbeanServer_refresh.java | 4 ++--
.../java/io/ebean/event/BeanPostLoadTest.java | 2 +-
.../ebeaninternal/api/TDSpiEbeanServer.java | 2 +-
.../server/deploy/BeanDescriptorTest.java | 10 ++++-----
.../org/tests/basic/TestDynamicUpdate.java | 2 +-
.../tests/basic/TestReadOnlyPropagation.java | 6 ++---
.../java/org/tests/basic/TestTransient.java | 2 +-
.../org/tests/batchload/TestBeanState.java | 12 +++++-----
.../java/org/tests/cache/TestQueryCache.java | 2 +-
.../org/tests/json/TestDbJson_Jackson3.java | 22 +++++++++----------
.../java/org/tests/json/TestDbJson_List.java | 2 +-
.../java/org/tests/json/TestOldValue.java | 22 +++++++++----------
.../org/tests/update/TestStatelessUpdate.java | 2 +-
17 files changed, 65 insertions(+), 49 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/DB.java b/ebean-api/src/main/java/io/ebean/DB.java
index 4935b5d9e..ab719b7da 100644
--- a/ebean-api/src/main/java/io/ebean/DB.java
+++ b/ebean-api/src/main/java/io/ebean/DB.java
@@ -1239,8 +1239,16 @@ public final class DB {
* This will return null if the bean is not an enhanced entity bean.
*
*/
+ public static BeanState beanState(Object bean) {
+ return getDefault().beanState(bean);
+ }
+
+ /**
+ * Deprecated migrate to beanState().
+ */
+ @Deprecated
public static BeanState getBeanState(Object bean) {
- return getDefault().getBeanState(bean);
+ return beanState(bean);
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/Database.java b/ebean-api/src/main/java/io/ebean/Database.java
index d113cf041..7bc21364a 100644
--- a/ebean-api/src/main/java/io/ebean/Database.java
+++ b/ebean-api/src/main/java/io/ebean/Database.java
@@ -243,7 +243,15 @@ public interface Database {
* This will return null if the bean is not an enhanced entity bean.
*
*/
- BeanState getBeanState(Object bean);
+ BeanState beanState(Object bean);
+
+ /**
+ * Deprecated migrate to beanState().
+ */
+ @Deprecated
+ default BeanState getBeanState(Object bean) {
+ return beanState(bean);
+ }
/**
* Return the value of the Id property for a given bean.
diff --git a/ebean-api/src/main/java/io/ebean/Ebean.java b/ebean-api/src/main/java/io/ebean/Ebean.java
index 5756a18bf..53d76811f 100644
--- a/ebean-api/src/main/java/io/ebean/Ebean.java
+++ b/ebean-api/src/main/java/io/ebean/Ebean.java
@@ -1201,7 +1201,7 @@ public final class Ebean {
*
*/
public static BeanState getBeanState(Object bean) {
- return getDefault().getBeanState(bean);
+ return getDefault().beanState(bean);
}
/**
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index f6916bbe4..cd25b08c5 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -519,7 +519,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public BeanState getBeanState(Object bean) {
+ public BeanState beanState(Object bean) {
if (bean instanceof EntityBean) {
return new DefaultBeanState((EntityBean) bean);
}
diff --git a/ebean-core/src/test/java/io/ebean/EbeanServer_refresh.java b/ebean-core/src/test/java/io/ebean/EbeanServer_refresh.java
index 66af5d164..638f110f6 100644
--- a/ebean-core/src/test/java/io/ebean/EbeanServer_refresh.java
+++ b/ebean-core/src/test/java/io/ebean/EbeanServer_refresh.java
@@ -40,10 +40,10 @@ public class EbeanServer_refresh {
assertEquals(rows, 1);
basic.setName("modify");
- assertTrue(DB.getBeanState(basic).isDirty());
+ assertTrue(DB.beanState(basic).isDirty());
server.refresh(basic);
assertEquals(basic.getStatus(), EBasic.Status.ACTIVE);
- assertFalse(DB.getBeanState(basic).isDirty());
+ assertFalse(DB.beanState(basic).isDirty());
}
@Test
diff --git a/ebean-core/src/test/java/io/ebean/event/BeanPostLoadTest.java b/ebean-core/src/test/java/io/ebean/event/BeanPostLoadTest.java
index 4b0dcde41..7775ccc47 100644
--- a/ebean-core/src/test/java/io/ebean/event/BeanPostLoadTest.java
+++ b/ebean-core/src/test/java/io/ebean/event/BeanPostLoadTest.java
@@ -91,7 +91,7 @@ public class BeanPostLoadTest extends BaseTestCase {
public void postLoad(Object bean) {
this.methodsCalled.add("postLoad");
this.bean = bean;
- this.beanState = DB.getBeanState(bean);
+ this.beanState = DB.beanState(bean);
}
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
index df747b1d0..6c5d929cd 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
@@ -363,7 +363,7 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public BeanState getBeanState(Object bean) {
+ public BeanState beanState(Object bean) {
return null;
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/deploy/BeanDescriptorTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/deploy/BeanDescriptorTest.java
index ab8ae6a87..d79d79427 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/deploy/BeanDescriptorTest.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/deploy/BeanDescriptorTest.java
@@ -30,31 +30,31 @@ public class BeanDescriptorTest extends BaseTestCase {
Customer bean = customerDesc.createReference(null, false, 42, null);
assertThat(bean.getId()).isEqualTo(42);
- assertThat(server().getBeanState(bean).isReadOnly()).isFalse();
+ assertThat(server().beanState(bean).isReadOnly()).isFalse();
}
@Test
public void createReference_whenReadOnly() {
Customer bean = customerDesc.createReference(Boolean.TRUE, false, 42, null);
- assertThat(server().getBeanState(bean).isReadOnly()).isTrue();
+ assertThat(server().beanState(bean).isReadOnly()).isTrue();
}
@Test
public void createReference_whenNotReadOnly() {
Customer bean = customerDesc.createReference(Boolean.FALSE, false, 42, null);
- assertThat(server().getBeanState(bean).isReadOnly()).isFalse();
+ assertThat(server().beanState(bean).isReadOnly()).isFalse();
bean = customerDesc.createReference(42, null);
- assertThat(server().getBeanState(bean).isReadOnly()).isFalse();
+ assertThat(server().beanState(bean).isReadOnly()).isFalse();
}
@Test
public void createReference_when_disabledLazyLoad() {
Customer bean = customerDesc.createReference(Boolean.FALSE, true, 42, null);
- assertThat(server().getBeanState(bean).isDisableLazyLoad()).isTrue();
+ assertThat(server().beanState(bean).isDisableLazyLoad()).isTrue();
}
@Test
diff --git a/ebean-core/src/test/java/org/tests/basic/TestDynamicUpdate.java b/ebean-core/src/test/java/org/tests/basic/TestDynamicUpdate.java
index ac6764edb..6f3d21332 100644
--- a/ebean-core/src/test/java/org/tests/basic/TestDynamicUpdate.java
+++ b/ebean-core/src/test/java/org/tests/basic/TestDynamicUpdate.java
@@ -29,7 +29,7 @@ public class TestDynamicUpdate extends BaseTestCase {
b2.getEmbeddable().setDescription("ABC");
- BeanState beanState = server.getBeanState(b2);
+ BeanState beanState = server.beanState(b2);
boolean dirty = beanState.isDirty();
Assert.assertTrue(dirty);
diff --git a/ebean-core/src/test/java/org/tests/basic/TestReadOnlyPropagation.java b/ebean-core/src/test/java/org/tests/basic/TestReadOnlyPropagation.java
index b77dc577c..64d449fda 100644
--- a/ebean-core/src/test/java/org/tests/basic/TestReadOnlyPropagation.java
+++ b/ebean-core/src/test/java/org/tests/basic/TestReadOnlyPropagation.java
@@ -30,15 +30,15 @@ public class TestReadOnlyPropagation extends BaseTestCase {
.setId(1)
.findOne();
- Assert.assertTrue(DB.getBeanState(order).isReadOnly());
+ Assert.assertTrue(DB.beanState(order).isReadOnly());
Customer customer = order.getCustomer();
- Assert.assertTrue(DB.getBeanState(customer).isReadOnly());
+ Assert.assertTrue(DB.beanState(customer).isReadOnly());
Address billingAddress = customer.getBillingAddress();
assertNotNull(billingAddress);
- Assert.assertTrue(DB.getBeanState(billingAddress).isReadOnly());
+ Assert.assertTrue(DB.beanState(billingAddress).isReadOnly());
List details = order.getDetails();
diff --git a/ebean-core/src/test/java/org/tests/basic/TestTransient.java b/ebean-core/src/test/java/org/tests/basic/TestTransient.java
index 428896ac1..ef0db80bb 100644
--- a/ebean-core/src/test/java/org/tests/basic/TestTransient.java
+++ b/ebean-core/src/test/java/org/tests/basic/TestTransient.java
@@ -30,7 +30,7 @@ public class TestTransient extends BaseTestCase {
assertNotNull(c);
- BeanState beanState = DB.getBeanState(c);
+ BeanState beanState = DB.beanState(c);
assertFalse("not new or dirty as transient", beanState.isNewOrDirty());
c.getLock().tryLock();
diff --git a/ebean-core/src/test/java/org/tests/batchload/TestBeanState.java b/ebean-core/src/test/java/org/tests/batchload/TestBeanState.java
index 28161dc3d..c6ef4fbd1 100644
--- a/ebean-core/src/test/java/org/tests/batchload/TestBeanState.java
+++ b/ebean-core/src/test/java/org/tests/batchload/TestBeanState.java
@@ -29,7 +29,7 @@ public class TestBeanState extends BaseTestCase {
.setUseCache(false)
.findOne();
- BeanState beanState = DB.getBeanState(customer);
+ BeanState beanState = DB.beanState(customer);
assertFalse(beanState.isNew());
assertFalse(beanState.isDirty());
assertFalse(beanState.isNewOrDirty());
@@ -67,7 +67,7 @@ public class TestBeanState extends BaseTestCase {
.setUseCache(false)
.findOne();
- BeanState beanState = DB.getBeanState(customer);
+ BeanState beanState = DB.beanState(customer);
beanState.setDisableLazyLoad(true);
assertNull(customer.getName());
}
@@ -79,7 +79,7 @@ public class TestBeanState extends BaseTestCase {
Customer customer = DB.find(Customer.class).order("id").setMaxRows(1).findOne();
- BeanState beanState = DB.getBeanState(customer);
+ BeanState beanState = DB.beanState(customer);
assertThat(beanState.getChangedProps()).isEmpty();
customer.setContacts(new ArrayList<>());
@@ -91,7 +91,7 @@ public class TestBeanState extends BaseTestCase {
Customer customer = new Customer();
- BeanState beanState = DB.getBeanState(customer);
+ BeanState beanState = DB.beanState(customer);
assertThat(beanState.getChangedProps()).isEmpty();
// when new state, then loaded
@@ -112,7 +112,7 @@ public class TestBeanState extends BaseTestCase {
Customer customer = new Customer();
customer.setContacts(new ArrayList<>());
- BeanState beanState = DB.getBeanState(customer);
+ BeanState beanState = DB.beanState(customer);
beanState.setLoaded();
beanState.setReadOnly(true);
@@ -127,7 +127,7 @@ public class TestBeanState extends BaseTestCase {
Customer customer = new Customer();
customer.setName("a");
- BeanState beanState = DB.getBeanState(customer);
+ BeanState beanState = DB.beanState(customer);
beanState.setLoaded();
beanState.setReadOnly(true);
diff --git a/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java b/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
index b8a2b518b..b8ce6d1d5 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
@@ -227,7 +227,7 @@ public class TestQueryCache extends BaseTestCase {
Assert.assertTrue(bc.isReadOnly());
Assert.assertFalse(bc.isEmpty());
Assert.assertTrue(!list.isEmpty());
- Assert.assertTrue(DB.getBeanState(list.get(0)).isReadOnly());
+ Assert.assertTrue(DB.beanState(list.get(0)).isReadOnly());
List list2 = DB.find(Customer.class).setUseQueryCache(true).setReadOnly(true).where()
.ilike("name", "Rob").findList();
diff --git a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson3.java b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson3.java
index 5b58b3108..1eafa2328 100644
--- a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson3.java
+++ b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson3.java
@@ -92,7 +92,7 @@ public class TestDbJson_Jackson3 extends BaseTestCase {
found.setName("p1-mod");
found.setBeanList(null);
- BeanState state = DB.getBeanState(found);
+ BeanState state = DB.beanState(found);
assertThat(state.getChangedProps()).containsExactlyInAnyOrder("name", "beanList");
ValuePair pair = state.getDirtyValues().get("name");
@@ -115,12 +115,12 @@ public class TestDbJson_Jackson3 extends BaseTestCase {
.extracting(Map.Entry::toString)
.containsExactlyInAnyOrder("beanList=null,[name:a]","name=p1-mod,p1","version=2,1");
- assertThat(DB.getBeanState(found).isDirty()).isFalse();
+ assertThat(DB.beanState(found).isDirty()).isFalse();
found.getPlainBean().setName("b");
- assertThat(DB.getBeanState(found).isDirty()).isTrue();
+ assertThat(DB.beanState(found).isDirty()).isTrue();
- state = DB.getBeanState(found);
+ state = DB.beanState(found);
assertThat(state.getChangedProps()).containsExactlyInAnyOrder("plainBean");
pair = state.getDirtyValues().get("plainBean");
assertThat(pair.getNewValue()).hasToString("name:b");
@@ -153,7 +153,7 @@ public class TestDbJson_Jackson3 extends BaseTestCase {
final EBasicJsonList found = DB.find(EBasicJsonList.class, bean.getId());
found.getBeanList().get(0).setName("p1-mod");
- BeanState state = DB.getBeanState(found);
+ BeanState state = DB.beanState(found);
assertThat(state.getChangedProps()).containsExactlyInAnyOrder("beanList");
}
@@ -169,7 +169,7 @@ public class TestDbJson_Jackson3 extends BaseTestCase {
bean.setPlainValue2(contentBean2);
bean.setPlainValue3(contentBean3);
- BeanState state = DB.getBeanState(bean);
+ BeanState state = DB.beanState(bean);
// a new bean is not considered as dirty (thus have no changed props)
assertThat(state.isDirty()).isFalse();
assertThat(state.isNewOrDirty()).isTrue();
@@ -178,7 +178,7 @@ public class TestDbJson_Jackson3 extends BaseTestCase {
bean.save();
bean = DB.find(EBasicJsonJackson3.class, bean.getId());
- state = DB.getBeanState(bean);
+ state = DB.beanState(bean);
// a fresh loaded bean is also not considered as dirty
assertThat(state.isDirty()).isFalse();
assertThat(state.isNewOrDirty()).isFalse();
@@ -222,19 +222,19 @@ public class TestDbJson_Jackson3 extends BaseTestCase {
LoggedSql.stop();
}
-
+
@Test
public void push_pop_test() {
-
+
EBasicJsonMulti bean = new EBasicJsonMulti();
bean.setPlainValue2(new PlainBeanDirtyAware("x", 42));
bean.save();
-
+
bean = DB.find(EBasicJsonMulti.class, bean.getId());
bean.setPlainValue1(null); // already null
bean.setPlainValue2(null);
bean.setPlainValue3(null); // already null
- BeanState state = DB.getBeanState(bean);
+ BeanState state = DB.beanState(bean);
assertThat(state.getDirtyValues()).hasSize(1).containsKey("plainValue2");
}
diff --git a/ebean-core/src/test/java/org/tests/json/TestDbJson_List.java b/ebean-core/src/test/java/org/tests/json/TestDbJson_List.java
index e20beb1d8..771a5f54a 100644
--- a/ebean-core/src/test/java/org/tests/json/TestDbJson_List.java
+++ b/ebean-core/src/test/java/org/tests/json/TestDbJson_List.java
@@ -216,7 +216,7 @@ public class TestDbJson_List extends BaseTestCase {
.setAllowLoadErrors() // allow invalid JSON content
.findOne();
- Map errors = server().getBeanState(bean).getLoadErrors();
+ Map errors = server().beanState(bean).getLoadErrors();
assertThat(errors).containsKey("beanMap").hasSize(1);
assertThat(errors.values().iterator().next())
diff --git a/ebean-core/src/test/java/org/tests/json/TestOldValue.java b/ebean-core/src/test/java/org/tests/json/TestOldValue.java
index f7bd391e5..fd108204e 100644
--- a/ebean-core/src/test/java/org/tests/json/TestOldValue.java
+++ b/ebean-core/src/test/java/org/tests/json/TestOldValue.java
@@ -18,8 +18,8 @@ import java.util.Set;
public class TestOldValue extends BaseTestCase {
-
-
+
+
@SuppressWarnings({ "rawtypes", "unchecked" })
@Test
public void testDbJsonOldValue() throws Exception {
@@ -35,9 +35,9 @@ public class TestOldValue extends BaseTestCase {
bean.getIntList().add(2);
bean.getIntSet().add(1002);
bean.getIntMap().put("ik1",2002);
-
+
bean.setJsonNode(jnf.arrayNode().add("Foo"));
-
+
DB.save(bean);
bean = DB.find(EBasicOldValue.class, bean.getId());
@@ -51,8 +51,8 @@ public class TestOldValue extends BaseTestCase {
bean.getIntSet().add(1006);
bean.getIntMap().put("ik2",2006);
((ArrayNode)bean.getJsonNode()).add("Bar");
-
- Map dirty = DB.getBeanState(bean).getDirtyValues();
+
+ Map dirty = DB.beanState(bean).getDirtyValues();
SoftAssertions softly = new SoftAssertions();
softly.assertThat(dirty).hasSize(10);
@@ -83,7 +83,7 @@ public class TestOldValue extends BaseTestCase {
softly.assertAll();
}
-
+
@SuppressWarnings({ "rawtypes", "unchecked" })
@Test
@Ignore("Old value detection does not work for @DbArray")
@@ -91,16 +91,16 @@ public class TestOldValue extends BaseTestCase {
EBasicOldValue bean = new EBasicOldValue();
bean.getStringArr().add("sa1");
-
+
DB.save(bean);
bean = DB.find(EBasicOldValue.class, bean.getId());
bean.getStringArr().add("sa2");
-
-
- Map dirty = DB.getBeanState(bean).getDirtyValues();
+
+
+ Map dirty = DB.beanState(bean).getDirtyValues();
SoftAssertions softly = new SoftAssertions();
softly.assertThat(dirty).hasSize(1);
diff --git a/ebean-core/src/test/java/org/tests/update/TestStatelessUpdate.java b/ebean-core/src/test/java/org/tests/update/TestStatelessUpdate.java
index d96de03e4..02f17ffe5 100644
--- a/ebean-core/src/test/java/org/tests/update/TestStatelessUpdate.java
+++ b/ebean-core/src/test/java/org/tests/update/TestStatelessUpdate.java
@@ -272,7 +272,7 @@ public class TestStatelessUpdate extends TransactionalTestCase {
}
private boolean containsContacts(Customer cust) {
- return DB.getBeanState(cust).getLoadedProps().contains("contacts");
+ return DB.beanState(cust).getLoadedProps().contains("contacts");
}
/**
From 57c0bceb6348449a669052081506900295acda59 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 10:47:56 +1200
Subject: [PATCH 038/102] #2351 - Rename Database.getReference() to reference()
with deprecation
---
.../src/main/java/io/ebean/BeanFinder.java | 4 +-
ebean-api/src/main/java/io/ebean/DB.java | 2 +-
.../src/main/java/io/ebean/Database.java | 10 +++-
ebean-api/src/main/java/io/ebean/Ebean.java | 2 +-
ebean-api/src/main/java/io/ebean/Finder.java | 4 +-
.../server/core/DefaultServer.java | 2 +-
.../test/java/io/ebean/UpdateQueryTest.java | 4 +-
.../ebeaninternal/api/TDSpiEbeanServer.java | 2 +-
.../server/cache/CacheBeanDataTest.java | 2 +-
.../server/core/TestDiffHelpSimple.java | 8 ++--
.../deploy/TestDiffHelpInsertSimple.java | 2 +-
.../tests/docstore/CustomerReportTest.java | 46 ++++++++-----------
.../inheritance/TestInheritanceRefBean.java | 4 +-
.../org/tests/readaudit/TestReadAudit.java | 2 +-
14 files changed, 48 insertions(+), 46 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/BeanFinder.java b/ebean-api/src/main/java/io/ebean/BeanFinder.java
index 2c8e04eec..aab61b572 100644
--- a/ebean-api/src/main/java/io/ebean/BeanFinder.java
+++ b/ebean-api/src/main/java/io/ebean/BeanFinder.java
@@ -79,11 +79,11 @@ public abstract class BeanFinder {
/**
* Creates an entity reference for this ID.
*
- * Equivalent to {@link Database#getReference(Class, Object)}
+ * Equivalent to {@link Database#reference(Class, Object)}
*/
@Nonnull
public T ref(I id) {
- return db().getReference(type, id);
+ return db().reference(type, id);
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/DB.java b/ebean-api/src/main/java/io/ebean/DB.java
index ab719b7da..636889b4e 100644
--- a/ebean-api/src/main/java/io/ebean/DB.java
+++ b/ebean-api/src/main/java/io/ebean/DB.java
@@ -659,7 +659,7 @@ public final class DB {
* @param id the id value
*/
public static T getReference(Class beanType, Object id) {
- return getDefault().getReference(beanType, id);
+ return getDefault().reference(beanType, id);
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/Database.java b/ebean-api/src/main/java/io/ebean/Database.java
index 7bc21364a..594644c62 100644
--- a/ebean-api/src/main/java/io/ebean/Database.java
+++ b/ebean-api/src/main/java/io/ebean/Database.java
@@ -950,7 +950,15 @@ public interface Database {
* @param id the id value
*/
@Nonnull
- T getReference(Class beanType, Object id);
+ T reference(Class beanType, Object id);
+
+ /**
+ * Deprecated migrate to reference().
+ */
+ @Deprecated
+ default T getReference(Class beanType, Object id) {
+ return reference(beanType, id);
+ }
/**
* Return the extended API for Database.
diff --git a/ebean-api/src/main/java/io/ebean/Ebean.java b/ebean-api/src/main/java/io/ebean/Ebean.java
index 53d76811f..eabc3c5b4 100644
--- a/ebean-api/src/main/java/io/ebean/Ebean.java
+++ b/ebean-api/src/main/java/io/ebean/Ebean.java
@@ -642,7 +642,7 @@ public final class Ebean {
* @param id the id value
*/
public static T getReference(Class beanType, Object id) {
- return getDefault().getReference(beanType, id);
+ return getDefault().reference(beanType, id);
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/Finder.java b/ebean-api/src/main/java/io/ebean/Finder.java
index 3c9318e7d..cc5ef87f6 100644
--- a/ebean-api/src/main/java/io/ebean/Finder.java
+++ b/ebean-api/src/main/java/io/ebean/Finder.java
@@ -137,11 +137,11 @@ public class Finder {
/**
* Creates an entity reference for this ID.
*
- * Equivalent to {@link Database#getReference(Class, Object)}
+ * Equivalent to {@link Database#reference(Class, Object)}
*/
@Nonnull
public T ref(I id) {
- return db().getReference(type, id);
+ return db().reference(type, id);
}
/**
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index cd25b08c5..469cc148f 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -687,7 +687,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
*/
@Override
@SuppressWarnings({"unchecked", "rawtypes"})
- public T getReference(Class type, Object id) {
+ public T reference(Class type, Object id) {
if (id == null) {
throw new NullPointerException("The id is null");
}
diff --git a/ebean-core/src/test/java/io/ebean/UpdateQueryTest.java b/ebean-core/src/test/java/io/ebean/UpdateQueryTest.java
index 5b9c42991..bcbdd103b 100644
--- a/ebean-core/src/test/java/io/ebean/UpdateQueryTest.java
+++ b/ebean-core/src/test/java/io/ebean/UpdateQueryTest.java
@@ -174,7 +174,7 @@ public class UpdateQueryTest extends BaseTestCase {
EbeanServer server = server();
- Country nz = server.getReference(Country.class, "NZ");
+ Country nz = server.reference(Country.class, "NZ");
UpdateQuery update = server.update(Customer.class);
Query query = update
@@ -198,7 +198,7 @@ public class UpdateQueryTest extends BaseTestCase {
EbeanServer server = server();
- Country nz = server.getReference(Country.class, "NZ");
+ Country nz = server.reference(Country.class, "NZ");
LoggedSqlCollector.start();
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
index 6c5d929cd..7dc5a0b63 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
@@ -660,7 +660,7 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public T getReference(Class beanType, Object id) {
+ public T reference(Class beanType, Object id) {
return null;
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/cache/CacheBeanDataTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/cache/CacheBeanDataTest.java
index 957515f80..d7ab3ea5e 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/cache/CacheBeanDataTest.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/cache/CacheBeanDataTest.java
@@ -39,7 +39,7 @@ public class CacheBeanDataTest extends BaseTestCase {
Address billingAddress = new Address();
billingAddress.setId(12);
billingAddress.setCity("Auckland");
- billingAddress.setCountry(server.getReference(Country.class, "NZ"));
+ billingAddress.setCountry(server.reference(Country.class, "NZ"));
billingAddress.setLine1("92 Someplace Else");
c.setBillingAddress(billingAddress);
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/core/TestDiffHelpSimple.java b/ebean-core/src/test/java/io/ebeaninternal/server/core/TestDiffHelpSimple.java
index 5ab4b56ee..7d14d858c 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/core/TestDiffHelpSimple.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/core/TestDiffHelpSimple.java
@@ -35,7 +35,7 @@ public class TestDiffHelpSimple extends BaseTestCase {
Order order1 = new Order();
order1.setId(12);
order1.setCretime(new Timestamp(firstTime));
- order1.setCustomer(server.getReference(Customer.class, 1234));
+ order1.setCustomer(server.reference(Customer.class, 1234));
order1.setStatus(Status.NEW);
order1.setShipDate(new Date(firstTime));
order1.setOrderDate(new Date(firstTime));
@@ -51,7 +51,7 @@ public class TestDiffHelpSimple extends BaseTestCase {
Order order2 = new Order();
order2.setId(14);
order2.setCretime(new Timestamp(secondTime));
- order2.setCustomer(server.getReference(Customer.class, 2133));
+ order2.setCustomer(server.reference(Customer.class, 2133));
order2.setStatus(Status.COMPLETE);
order2.setShipDate(new Date(secondTime));
order2.setOrderDate(new Date(secondTime));
@@ -77,7 +77,7 @@ public class TestDiffHelpSimple extends BaseTestCase {
Order order2 = new Order();
order2.setId(14);
order2.setCretime(new Timestamp(secondTime));
- order2.setCustomer(server.getReference(Customer.class, 2133));
+ order2.setCustomer(server.reference(Customer.class, 2133));
order2.setStatus(Status.COMPLETE);
order2.setShipDate(new Date(secondTime));
order2.setOrderDate(new Date(secondTime));
@@ -114,7 +114,7 @@ public class TestDiffHelpSimple extends BaseTestCase {
Order order1 = createBaseOrder(server);
Order order2 = createBaseOrder(server);
- order2.setCustomer(server.getReference(Customer.class, 2133));
+ order2.setCustomer(server.reference(Customer.class, 2133));
order2.setStatus(Status.COMPLETE);
order2.setShipDate(null);
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/deploy/TestDiffHelpInsertSimple.java b/ebean-core/src/test/java/io/ebeaninternal/server/deploy/TestDiffHelpInsertSimple.java
index 4e7704a02..58cdd45ee 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/deploy/TestDiffHelpInsertSimple.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/deploy/TestDiffHelpInsertSimple.java
@@ -37,7 +37,7 @@ public class TestDiffHelpInsertSimple extends BaseTestCase {
Order order1 = new Order();
order1.setId(12);
order1.setCretime(new Timestamp(firstTime));
- order1.setCustomer(server.getReference(Customer.class, 1234));
+ order1.setCustomer(server.reference(Customer.class, 1234));
order1.setStatus(Status.NEW);
//order1.setShipDate(new Date(firstTime));
order1.setOrderDate(new Date(firstTime));
diff --git a/ebean-core/src/test/java/org/tests/docstore/CustomerReportTest.java b/ebean-core/src/test/java/org/tests/docstore/CustomerReportTest.java
index 3668d833f..e7047cc37 100644
--- a/ebean-core/src/test/java/org/tests/docstore/CustomerReportTest.java
+++ b/ebean-core/src/test/java/org/tests/docstore/CustomerReportTest.java
@@ -16,53 +16,47 @@ import io.ebean.BaseTestCase;
import io.ebean.text.json.JsonReadOptions;
public class CustomerReportTest extends BaseTestCase {
-
-
-
+
@Test
public void testToJson() throws Exception {
ResetBasicData.reset();
-
-
+
+
String json = server().json().toJson(getCustomerReport());
-
-
assertThat(json).isEqualTo("{\"dtype\":\"CR\",\"friends\":[{\"id\":2},{\"id\":3}],\"customer\":{\"id\":1}}");
}
-
-
@Test
public void testFromJson() throws Exception {
ResetBasicData.reset();
String json = "{\"dtype\":\"CR\",\"friends\":[{\"id\":2},{\"id\":3}],\"customer\":{\"id\":1}}";
-
+
JsonReadOptions opts = new JsonReadOptions();
opts.setEnableLazyLoading(true);
CustomerReport report = server().json().toBean(CustomerReport.class, json, opts);
-
+
assertThat(report.getCustomer().getName()).isEqualTo("Rob");
-
+
assertThat(report.getFriends().get(0).getName()).isEqualTo("Cust NoAddress");
assertThat(report.getFriends().get(1).getName()).isEqualTo("Fiona");
}
-
+
@Test
public void testEmbeddedDocs() throws Exception {
ResetBasicData.reset();
-
+
CustomerReport report = getCustomerReport();
report.getEmbeddedReports().add(getProductReport());
-
+
String json = server().json().toJson(report);
-
+
assertThat(json).isEqualTo("{\"dtype\":\"CR\","
+ "\"embeddedReports\":[{\"dtype\":\"PR\",\"title\":\"This is a good product\",\"product\":{\"id\":1}}],"
+ "\"friends\":[{\"id\":2},{\"id\":3}],"
+ "\"customer\":{\"id\":1}}");
-
+
JsonReadOptions opts = new JsonReadOptions();
opts.setEnableLazyLoading(true);
report = server().json().toBean(CustomerReport.class, json, opts);
@@ -70,22 +64,22 @@ public class CustomerReportTest extends BaseTestCase {
assertThat(ar.getTitle()).isEqualTo("This is a good product");
assertThat(ar.getProduct().getName()).isEqualTo("Chair");
}
-
-
+
+
private CustomerReport getCustomerReport() {
- Customer customer = server().getReference(Customer.class, 1);
- Customer friend1 = server().getReference(Customer.class, 2);
- Customer friend2 = server().getReference(Customer.class, 3);
-
+ Customer customer = server().reference(Customer.class, 1);
+ Customer friend1 = server().reference(Customer.class, 2);
+ Customer friend2 = server().reference(Customer.class, 3);
+
CustomerReport report = new CustomerReport();
-
+
report.setCustomer(customer);
report.setFriends(Arrays.asList(friend1, friend2));
return report;
}
-
+
private ProductReport getProductReport() {
- Product product = server().getReference(Product.class, 1);
+ Product product = server().reference(Product.class, 1);
ProductReport report = new ProductReport();
report.setTitle("This is a good product");
diff --git a/ebean-core/src/test/java/org/tests/inheritance/TestInheritanceRefBean.java b/ebean-core/src/test/java/org/tests/inheritance/TestInheritanceRefBean.java
index 520e84866..f38000825 100644
--- a/ebean-core/src/test/java/org/tests/inheritance/TestInheritanceRefBean.java
+++ b/ebean-core/src/test/java/org/tests/inheritance/TestInheritanceRefBean.java
@@ -26,12 +26,12 @@ public class TestInheritanceRefBean extends BaseTestCase {
Parent test;
LoggedSqlCollector.start();
- test = server().getReference(ChildA.class, idA);
+ test = server().reference(ChildA.class, idA);
assertTrue(test instanceof ChildA);
assertEquals(0, LoggedSqlCollector.stop().size());
LoggedSqlCollector.start();
- test = server().getReference(Parent.class, idB);
+ test = server().reference(Parent.class, idB);
assertTrue(test instanceof ChildB);
assertEquals(1, LoggedSqlCollector.stop().size());
diff --git a/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java b/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
index f2e74e4f5..2f202d83c 100644
--- a/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
+++ b/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
@@ -134,7 +134,7 @@ public class TestReadAudit extends BaseTestCase {
assertThat(readAuditLogger.beans).hasSize(2);
- Country ref = server.getReference(Country.class, "AR");
+ Country ref = server.reference(Country.class, "AR");
assertThat(readAuditLogger.beans).hasSize(3);
assertThat(ref).isSameAs(found2);
}
From 7c2a77081b4b3c37bf54821cfaea2a3700960b52 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 10:50:29 +1200
Subject: [PATCH 039/102] #2351 - Rename Database.getReference() to reference()
with deprecation
---
ebean-api/src/main/java/io/ebean/DB.java | 14 ++++++++++----
.../basic/TestQueryForUpdatePostgresLock.java | 2 +-
.../java/org/tests/model/m2m/TestM2MWithWhere.java | 8 +++-----
.../java/org/tests/o2m/TestOneToManyOnlyBean.java | 2 +-
.../o2m/jointable/TestOneToManyJoinTable.java | 2 +-
.../org/tests/transaction/TestExecuteComplete.java | 6 +++---
6 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/DB.java b/ebean-api/src/main/java/io/ebean/DB.java
index 636889b4e..d5f281599 100644
--- a/ebean-api/src/main/java/io/ebean/DB.java
+++ b/ebean-api/src/main/java/io/ebean/DB.java
@@ -658,24 +658,30 @@ public final class DB {
* @param beanType the type of entity bean
* @param id the id value
*/
- public static T getReference(Class beanType, Object id) {
+ public static T reference(Class beanType, Object id) {
return getDefault().reference(beanType, id);
}
+ /**
+ * Deprecated migrate to beanId().
+ */
+ @Deprecated
+ public static T getReference(Class beanType, Object id) {
+ return reference(beanType, id);
+ }
+
/**
* Sort the list using the sortByClause which can contain a comma delimited
* list of property names and keywords asc, desc, nullsHigh and nullsLow.
*
*
asc - ascending order (which is the default)
*
desc - Descending order
- *
nullsHigh - Treat null values as high/large values (which is the
- * default)
+ *
nullsHigh - Treat null values as high/large values (which is the default)
*
nullsLow- Treat null values as low/very small values
*
*
* If you leave off any keywords the defaults are ascending order and treating
* nulls as high values.
- *
*
* Note that the sorting uses a Comparator and Collections.sort(); and does
* not invoke a DB query.
diff --git a/ebean-core/src/test/java/org/tests/basic/TestQueryForUpdatePostgresLock.java b/ebean-core/src/test/java/org/tests/basic/TestQueryForUpdatePostgresLock.java
index ecda6bee2..eee072594 100644
--- a/ebean-core/src/test/java/org/tests/basic/TestQueryForUpdatePostgresLock.java
+++ b/ebean-core/src/test/java/org/tests/basic/TestQueryForUpdatePostgresLock.java
@@ -71,7 +71,7 @@ public class TestQueryForUpdatePostgresLock extends BaseTestCase {
log.info("insert start");
timePreInsert = System.currentTimeMillis();
Section section = new Section();
- section.setArticle(DB.getReference(Article.class, id));
+ section.setArticle(DB.reference(Article.class, id));
DB.save(section);
timePostInsert = System.currentTimeMillis();
log.info("inserted");
diff --git a/ebean-core/src/test/java/org/tests/model/m2m/TestM2MWithWhere.java b/ebean-core/src/test/java/org/tests/model/m2m/TestM2MWithWhere.java
index da8d83dd5..6a6c8e85e 100644
--- a/ebean-core/src/test/java/org/tests/model/m2m/TestM2MWithWhere.java
+++ b/ebean-core/src/test/java/org/tests/model/m2m/TestM2MWithWhere.java
@@ -5,8 +5,6 @@ import static org.assertj.core.api.Assertions.assertThat;
import java.util.List;
import org.junit.Test;
-import org.tests.model.m2m.MnyEdge;
-import org.tests.model.m2m.MnyNode;
import io.ebean.BaseTestCase;
import io.ebean.DB;
@@ -108,8 +106,8 @@ public class TestM2MWithWhere extends BaseTestCase {
sb.append("from = ").append(from).append(" |");
for (int to = 1; to <= 5; to++) {
MnyEdge edge = new MnyEdge();
- edge.setFrom(DB.getReference(MnyNode.class, from));
- edge.setTo(DB.getReference(MnyNode.class, to));
+ edge.setFrom(DB.reference(MnyNode.class, from));
+ edge.setTo(DB.reference(MnyNode.class, to));
int flags = 0;
if (from < to) {
flags |= 1;
@@ -125,7 +123,7 @@ public class TestM2MWithWhere extends BaseTestCase {
}
// System.out.println(sb); dump the table
}
-
+
@Test
public void testWithDbTableName() {
diff --git a/ebean-core/src/test/java/org/tests/o2m/TestOneToManyOnlyBean.java b/ebean-core/src/test/java/org/tests/o2m/TestOneToManyOnlyBean.java
index 2dccb4a1e..a07c415d4 100644
--- a/ebean-core/src/test/java/org/tests/o2m/TestOneToManyOnlyBean.java
+++ b/ebean-core/src/test/java/org/tests/o2m/TestOneToManyOnlyBean.java
@@ -33,7 +33,7 @@ public class TestOneToManyOnlyBean extends BaseTestCase {
@Test
public void isReference_when_getReference_expectTrue() {
- OMVertex myBean = DB.getReference(OMVertex.class, UUID.randomUUID());
+ OMVertex myBean = DB.reference(OMVertex.class, UUID.randomUUID());
assertTrue(isReference(myBean));
}
diff --git a/ebean-core/src/test/java/org/tests/o2m/jointable/TestOneToManyJoinTable.java b/ebean-core/src/test/java/org/tests/o2m/jointable/TestOneToManyJoinTable.java
index 1fb128e09..c0747fb7a 100644
--- a/ebean-core/src/test/java/org/tests/o2m/jointable/TestOneToManyJoinTable.java
+++ b/ebean-core/src/test/java/org/tests/o2m/jointable/TestOneToManyJoinTable.java
@@ -85,7 +85,7 @@ public class TestOneToManyJoinTable extends BaseTestCase {
// make m2 dirty ... cascades to an update on Uim
m2.setFoodPreference("Apple");
trainer.getMonkeys().add(m2);
- trainer.getMonkeys().add(DB.getReference(JtMonkey.class, m1.getMid()));
+ trainer.getMonkeys().add(DB.reference(JtMonkey.class, m1.getMid()));
trainer.getMonkeys().add(new JtMonkey("FAlp"));
trainer.getMonkeys().add(new JtMonkey("FBet"));
trainer.getMonkeys().add(new JtMonkey("FThe"));
diff --git a/ebean-core/src/test/java/org/tests/transaction/TestExecuteComplete.java b/ebean-core/src/test/java/org/tests/transaction/TestExecuteComplete.java
index 6632816a5..60b6e6e03 100644
--- a/ebean-core/src/test/java/org/tests/transaction/TestExecuteComplete.java
+++ b/ebean-core/src/test/java/org/tests/transaction/TestExecuteComplete.java
@@ -27,7 +27,7 @@ public class TestExecuteComplete extends BaseTestCase {
try {
DB.execute(TxScope.required().setBatch(PersistBatch.ALL), () -> {
- Customer customer = DB.getReference(Customer.class, 42424242L);
+ Customer customer = DB.reference(Customer.class, 42424242L);
Order order = new Order();
order.setCustomer(customer);
@@ -48,7 +48,7 @@ public class TestExecuteComplete extends BaseTestCase {
DB.execute(TxScope.required().setBatch(PersistBatch.ALL), () ->
DB.execute(() -> {
- Customer customer = DB.getReference(Customer.class, 42424242L);
+ Customer customer = DB.reference(Customer.class, 42424242L);
Order order = new Order();
order.setCustomer(customer);
@@ -75,7 +75,7 @@ public class TestExecuteComplete extends BaseTestCase {
@Transactional(batchSize = 10)
private void errorOnCommit() {
- Customer customer = DB.getReference(Customer.class, 42424242L);
+ Customer customer = DB.reference(Customer.class, 42424242L);
Order order = new Order();
order.setCustomer(customer);
From aa53742a07d254a1c05486e49fea89690192d775 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 17:24:33 +1200
Subject: [PATCH 040/102] #2352 - Rename ServerCache methods with deprecation
---
.../main/java/io/ebean/cache/ServerCache.java | 18 ++++-
.../io/ebean/cache/ServerCacheManager.java | 65 ++++++++++++++++---
.../server/cache/DefaultCacheAdapter.java | 16 ++---
.../server/core/DefaultServer.java | 2 +-
.../src/test/java/io/ebean/BaseTestCase.java | 2 +-
.../ebean/cache/ServerCacheManagerTest.java | 28 ++++----
.../server/cache/DefaultServerCacheTest.java | 8 +--
.../DefaultServerCache_RunEvictionTest.java | 2 +-
.../transaction/JdbcTransactionTest.java | 16 ++---
.../tests/basic/TestBeanReferenceRefresh.java | 2 +-
.../org/tests/basic/TestQueryWithCache.java | 2 +-
.../batchload/TestBatchLazyWithCacheHits.java | 8 +--
.../org/tests/batchload/TestQueryJoin.java | 2 +-
.../java/org/tests/cache/TestBeanCache.java | 10 +--
.../tests/cache/TestBeanFetchJoinCache.java | 24 +++----
.../java/org/tests/cache/TestCacheBasic.java | 6 +-
.../tests/cache/TestCacheCollectionIds.java | 10 +--
.../org/tests/cache/TestCacheNaturalId.java | 10 +--
.../tests/cache/TestExternalNotification.java | 2 +-
.../cache/TestL2CacheWithSharedBean.java | 6 +-
.../java/org/tests/cache/TestQueryCache.java | 2 +-
.../tests/cache/TestQueryCacheCountry.java | 24 +++----
.../org/tests/cache/TestQueryCacheInsert.java | 6 +-
.../cache/TestQueryCacheTableDependency.java | 10 +--
.../cache/personinfo/PersonCacheTests.java | 18 ++---
.../cache/TestInheritCacheRefLoad.java | 2 +-
.../cache/TestCacheViaComplexNaturalKey.java | 12 ++--
.../cache/TestCacheViaComplexNaturalKey3.java | 12 ++--
.../basic/cache/TestCacheWithSoftDelete.java | 4 +-
.../embedded/TestMultipleEmbeddedLoading.java | 8 +--
.../org/tests/readaudit/TestReadAudit.java | 16 ++---
.../src/test/java/io/ebean/BaseTestCase.java | 2 +-
.../java/org/integration/ClusterTest.java | 6 +-
33 files changed, 212 insertions(+), 149 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/cache/ServerCache.java b/ebean-api/src/main/java/io/ebean/cache/ServerCache.java
index 724b71531..1476e567d 100644
--- a/ebean-api/src/main/java/io/ebean/cache/ServerCache.java
+++ b/ebean-api/src/main/java/io/ebean/cache/ServerCache.java
@@ -10,12 +10,10 @@ import java.util.Set;
* Represents part of the "L2" server side cache.
*
* This is used to cache beans or query results (bean collections).
- *
*
* There are 2 ServerCache's for each bean type. One is used as the 'bean cache'
* which holds beans of a given type. The other is the 'query cache' holding
* query results for a given type.
- *
*/
public interface ServerCache {
@@ -75,6 +73,14 @@ public interface ServerCache {
/**
* Return the hit ratio the cache is currently getting.
*/
+ default int hitRatio() {
+ return getHitRatio();
+ }
+
+ /**
+ * Deprecated migrate to hitRatio().
+ */
+ @Deprecated
int getHitRatio();
/**
@@ -82,6 +88,14 @@ public interface ServerCache {
*
* @param reset if true the statistics are reset.
*/
+ default ServerCacheStatistics statistics(boolean reset) {
+ return getStatistics(reset);
+ }
+
+ /**
+ * Deprecated migrate to statistics().
+ */
+ @Deprecated
ServerCacheStatistics getStatistics(boolean reset);
/**
diff --git a/ebean-api/src/main/java/io/ebean/cache/ServerCacheManager.java b/ebean-api/src/main/java/io/ebean/cache/ServerCacheManager.java
index 82b85c956..67156a642 100644
--- a/ebean-api/src/main/java/io/ebean/cache/ServerCacheManager.java
+++ b/ebean-api/src/main/java/io/ebean/cache/ServerCacheManager.java
@@ -21,7 +21,15 @@ public interface ServerCacheManager {
* rather than background processing.
*
*/
- boolean isLocalL2Caching();
+ boolean localL2Caching();
+
+ /**
+ * Deprecated migrate to localL2Caching().
+ */
+ @Deprecated
+ default boolean isLocalL2Caching() {
+ return localL2Caching();
+ }
/**
* Return all the cache regions.
@@ -36,37 +44,78 @@ public interface ServerCacheManager {
*
* @param regions A region name or comma delimited list of region names.
*/
- void setEnabledRegions(String regions);
+ void enabledRegions(String regions);
+
+ /**
+ * Deprecated migrate to enabledRegions().
+ */
+ @Deprecated
+ default void setEnabledRegions(String regions) {
+ enabledRegions(regions);
+ }
/**
* Enable or disable all the cache regions.
*/
- void setAllRegionsEnabled(boolean enabled);
+ void allRegionsEnabled(boolean enabled);
+
+ /**
+ * Deprecated migrate to allRegionsEnabled().
+ */
+ @Deprecated
+ default void setAllRegionsEnabled(boolean enabled) {
+ allRegionsEnabled(enabled);
+ }
/**
* Return the cache region by name. Typically, to enable or disable the region.
*/
- ServerCacheRegion getRegion(String name);
+ ServerCacheRegion region(String name);
+
+ @Deprecated
+ default ServerCacheRegion getRegion(String name) {
+ return region(name);
+ }
/**
* Return the cache for mapping natural keys to id values.
*/
- ServerCache getNaturalKeyCache(Class> beanType);
+ ServerCache naturalKeyCache(Class> beanType);
+
+ @Deprecated
+ default ServerCache getNaturalKeyCache(Class> beanType) {
+ return naturalKeyCache(beanType);
+ }
/**
* Return the cache for beans of a particular type.
*/
- ServerCache getBeanCache(Class> beanType);
+ ServerCache beanCache(Class> beanType);
+
+ @Deprecated
+ default ServerCache getBeanCache(Class> beanType) {
+ return beanCache(beanType);
+ }
/**
* Return the cache for associated many properties of a bean type.
*/
- ServerCache getCollectionIdsCache(Class> beanType, String propertyName);
+ ServerCache collectionIdsCache(Class> beanType, String propertyName);
+
+ @Deprecated
+ default ServerCache getCollectionIdsCache(Class> beanType, String propertyName) {
+ return collectionIdsCache(beanType, propertyName);
+ }
/**
* Return the cache for query results of a particular type of bean.
*/
- ServerCache getQueryCache(Class> beanType);
+ ServerCache queryCache(Class> beanType);
+
+ @Deprecated
+ default ServerCache getQueryCache(Class> beanType) {
+ return queryCache(beanType);
+ }
/**
* This clears both the bean and query cache for a given type.
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultCacheAdapter.java b/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultCacheAdapter.java
index 413af049d..e9b3752d6 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultCacheAdapter.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultCacheAdapter.java
@@ -27,7 +27,7 @@ public final class DefaultCacheAdapter implements ServerCacheManager {
}
@Override
- public boolean isLocalL2Caching() {
+ public boolean localL2Caching() {
return cacheManager.isLocalL2Caching();
}
@@ -37,37 +37,37 @@ public final class DefaultCacheAdapter implements ServerCacheManager {
}
@Override
- public void setEnabledRegions(String regions) {
+ public void enabledRegions(String regions) {
cacheManager.setEnabledRegions(regions);
}
@Override
- public ServerCacheRegion getRegion(String region) {
+ public ServerCacheRegion region(String region) {
return cacheManager.getRegion(region);
}
@Override
- public void setAllRegionsEnabled(boolean enabled) {
+ public void allRegionsEnabled(boolean enabled) {
cacheManager.setAllRegionsEnabled(enabled);
}
@Override
- public ServerCache getNaturalKeyCache(Class> beanType) {
+ public ServerCache naturalKeyCache(Class> beanType) {
return cacheManager.getNaturalKeyCache(beanType);
}
@Override
- public ServerCache getBeanCache(Class> beanType) {
+ public ServerCache beanCache(Class> beanType) {
return cacheManager.getBeanCache(beanType);
}
@Override
- public ServerCache getCollectionIdsCache(Class> beanType, String propertyName) {
+ public ServerCache collectionIdsCache(Class> beanType, String propertyName) {
return cacheManager.getCollectionIdsCache(beanType, propertyName);
}
@Override
- public ServerCache getQueryCache(Class> beanType) {
+ public ServerCache queryCache(Class> beanType) {
return cacheManager.getQueryCache(beanType);
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index 469cc148f..e517b37ec 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -381,7 +381,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
if (encryptKeyManager != null) {
encryptKeyManager.initialise();
}
- serverCacheManager.setEnabledRegions(config.getEnabledL2Regions());
+ serverCacheManager.enabledRegions(config.getEnabledL2Regions());
}
/**
diff --git a/ebean-core/src/test/java/io/ebean/BaseTestCase.java b/ebean-core/src/test/java/io/ebean/BaseTestCase.java
index dd3c949f9..e33900534 100644
--- a/ebean-core/src/test/java/io/ebean/BaseTestCase.java
+++ b/ebean-core/src/test/java/io/ebean/BaseTestCase.java
@@ -242,7 +242,7 @@ public abstract class BaseTestCase {
}
protected ServerCacheStatistics getBeanCacheStats(Class cls, boolean reset) {
- return server().cacheManager().getBeanCache(cls).getStatistics(reset);
+ return server().cacheManager().beanCache(cls).statistics(reset);
}
protected Platform platform() {
diff --git a/ebean-core/src/test/java/io/ebean/cache/ServerCacheManagerTest.java b/ebean-core/src/test/java/io/ebean/cache/ServerCacheManagerTest.java
index beaa1b31f..977b38b42 100644
--- a/ebean-core/src/test/java/io/ebean/cache/ServerCacheManagerTest.java
+++ b/ebean-core/src/test/java/io/ebean/cache/ServerCacheManagerTest.java
@@ -18,28 +18,28 @@ public class ServerCacheManagerTest {
assertTrue(region.isEnabled());
}
- cacheManager.setEnabledRegions("r0,doesNotExist");
- assertThat(cacheManager.getRegion("email").isEnabled()).isFalse();
- assertThat(cacheManager.getRegion("r0").isEnabled()).isTrue();
+ cacheManager.enabledRegions("r0,doesNotExist");
+ assertThat(cacheManager.region("email").isEnabled()).isFalse();
+ assertThat(cacheManager.region("r0").isEnabled()).isTrue();
- cacheManager.setEnabledRegions("r0");
- assertThat(cacheManager.getRegion("email").isEnabled()).isFalse();
- assertThat(cacheManager.getRegion("r0").isEnabled()).isTrue();
+ cacheManager.enabledRegions("r0");
+ assertThat(cacheManager.region("email").isEnabled()).isFalse();
+ assertThat(cacheManager.region("r0").isEnabled()).isTrue();
- cacheManager.setEnabledRegions(null);
- assertThat(cacheManager.getRegion("email").isEnabled()).isFalse();
- assertThat(cacheManager.getRegion("r0").isEnabled()).isTrue();
+ cacheManager.enabledRegions(null);
+ assertThat(cacheManager.region("email").isEnabled()).isFalse();
+ assertThat(cacheManager.region("r0").isEnabled()).isTrue();
- cacheManager.setEnabledRegions("email");
- assertThat(cacheManager.getRegion("email").isEnabled()).isTrue();
- assertThat(cacheManager.getRegion("r0").isEnabled()).isFalse();
+ cacheManager.enabledRegions("email");
+ assertThat(cacheManager.region("email").isEnabled()).isTrue();
+ assertThat(cacheManager.region("r0").isEnabled()).isFalse();
- cacheManager.setAllRegionsEnabled(false);
+ cacheManager.allRegionsEnabled(false);
for (ServerCacheRegion region : cacheManager.allRegions()) {
assertFalse(region.isEnabled());
}
- cacheManager.setAllRegionsEnabled(true);
+ cacheManager.allRegionsEnabled(true);
for (ServerCacheRegion region : cacheManager.allRegions()) {
assertTrue(region.isEnabled());
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/cache/DefaultServerCacheTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/cache/DefaultServerCacheTest.java
index e86a4cea0..9bf023c6e 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/cache/DefaultServerCacheTest.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/cache/DefaultServerCacheTest.java
@@ -26,20 +26,20 @@ public class DefaultServerCacheTest {
public void testGetHitRatio() {
DefaultServerCache cache = createCache();
- assertEquals(0, cache.getHitRatio());
+ assertEquals(0, cache.hitRatio());
assertEquals(0, cache.getHitCount());
assertEquals(0, cache.getMissCount());
cache.put("A", "A");
cache.get("A");
- assertEquals(100, cache.getHitRatio());
+ assertEquals(100, cache.hitRatio());
assertEquals(1, cache.getHitCount());
assertEquals(0, cache.getMissCount());
cache.get("B");
- assertEquals(50, cache.getHitRatio());
+ assertEquals(50, cache.hitRatio());
assertEquals(1, cache.getMissCount());
cache.get("B");
cache.get("B");
- assertEquals(25, cache.getHitRatio());
+ assertEquals(25, cache.hitRatio());
assertEquals(3, cache.getMissCount());
assertEquals(1, cache.getHitCount());
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/cache/DefaultServerCache_RunEvictionTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/cache/DefaultServerCache_RunEvictionTest.java
index aa79cf71e..184783627 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/cache/DefaultServerCache_RunEvictionTest.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/cache/DefaultServerCache_RunEvictionTest.java
@@ -40,7 +40,7 @@ public class DefaultServerCache_RunEvictionTest {
for (int i = 0; i < 15; i++) {
doStuff();
cache.runEviction();
- ServerCacheStatistics statistics = cache.getStatistics(true);
+ ServerCacheStatistics statistics = cache.statistics(true);
System.out.println(statistics);
Thread.sleep(500);
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/transaction/JdbcTransactionTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/transaction/JdbcTransactionTest.java
index ad5a4e1a6..ae7405354 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/transaction/JdbcTransactionTest.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/transaction/JdbcTransactionTest.java
@@ -44,18 +44,18 @@ public class JdbcTransactionTest {
public void skipCacheAfterSave() {
ServerCacheManager cacheManager = DB.getDefault().cacheManager();
- ServerCache customerBeanCache = cacheManager.getBeanCache(Customer.class);
- ServerCache contactNatKeyCache = cacheManager.getNaturalKeyCache(Contact.class);
+ ServerCache customerBeanCache = cacheManager.beanCache(Customer.class);
+ ServerCache contactNatKeyCache = cacheManager.naturalKeyCache(Contact.class);
try (Transaction transaction = DB.beginTransaction()) {
- customerBeanCache.getStatistics(true);
- contactNatKeyCache.getStatistics(true);
+ customerBeanCache.statistics(true);
+ contactNatKeyCache.statistics(true);
Customer.find.byId(19898989);
DB.find(Contact.class).where().eq("email", "junk@foo.com").findOne();
- assertThat(customerBeanCache.getStatistics(true).getMissCount()).isEqualTo(1);
- assertThat(contactNatKeyCache.getStatistics(true).getMissCount()).isEqualTo(1);
+ assertThat(customerBeanCache.statistics(true).getMissCount()).isEqualTo(1);
+ assertThat(contactNatKeyCache.statistics(true).getMissCount()).isEqualTo(1);
EBasic basic = new EBasic("b1");
DB.save(basic);
@@ -64,8 +64,8 @@ public class JdbcTransactionTest {
Customer.find.byId(29898989);
DB.find(Contact.class).where().eq("email", "junk2@foo.com").findOne();
- assertThat(customerBeanCache.getStatistics(true).getMissCount()).isEqualTo(0);
- assertThat(contactNatKeyCache.getStatistics(true).getMissCount()).isEqualTo(0);
+ assertThat(customerBeanCache.statistics(true).getMissCount()).isEqualTo(0);
+ assertThat(contactNatKeyCache.statistics(true).getMissCount()).isEqualTo(0);
}
}
diff --git a/ebean-core/src/test/java/org/tests/basic/TestBeanReferenceRefresh.java b/ebean-core/src/test/java/org/tests/basic/TestBeanReferenceRefresh.java
index 4827e46f0..d20ceb952 100644
--- a/ebean-core/src/test/java/org/tests/basic/TestBeanReferenceRefresh.java
+++ b/ebean-core/src/test/java/org/tests/basic/TestBeanReferenceRefresh.java
@@ -19,7 +19,7 @@ public class TestBeanReferenceRefresh extends BaseTestCase {
ResetBasicData.reset();
- ServerCache beanCache = Ebean.getServerCacheManager().getBeanCache(Order.class);
+ ServerCache beanCache = Ebean.getServerCacheManager().beanCache(Order.class);
beanCache.clear();
Order order = Ebean.getReference(Order.class, 1);
diff --git a/ebean-core/src/test/java/org/tests/basic/TestQueryWithCache.java b/ebean-core/src/test/java/org/tests/basic/TestQueryWithCache.java
index 06ef39bdf..914191cc9 100644
--- a/ebean-core/src/test/java/org/tests/basic/TestQueryWithCache.java
+++ b/ebean-core/src/test/java/org/tests/basic/TestQueryWithCache.java
@@ -33,7 +33,7 @@ public class TestQueryWithCache extends BaseTestCase {
ServerCacheManager serverCacheManager = server.cacheManager();
serverCacheManager.clear(Country.class);
- ServerCache beanCache = serverCacheManager.getBeanCache(Country.class);
+ ServerCache beanCache = serverCacheManager.beanCache(Country.class);
assertEquals(0, beanCache.size());
Country nz1 = Ebean.getReference(Country.class, "NZ");
diff --git a/ebean-core/src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java b/ebean-core/src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java
index 3d78cd137..4558594a5 100644
--- a/ebean-core/src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java
+++ b/ebean-core/src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java
@@ -17,7 +17,7 @@ import static org.junit.Assert.assertNotNull;
public class TestBatchLazyWithCacheHits extends BaseTestCase {
- private final ServerCache beanCache = server().cacheManager().getBeanCache(UUOne.class);
+ private final ServerCache beanCache = server().cacheManager().beanCache(UUOne.class);
private UUOne insert(String name) {
UUOne one = new UUOne();
@@ -61,19 +61,19 @@ public class TestBatchLazyWithCacheHits extends BaseTestCase {
platformAssertIn(sql.get(1), "from uuone t0 where t0.id");
// not lazy loading into bean cache
- final ServerCacheStatistics stats = beanCache.getStatistics(true);
+ final ServerCacheStatistics stats = beanCache.statistics(true);
assertThat(stats.getHitCount()).isEqualTo(10);
assertThat(stats.getSize()).isEqualTo(10);
}
private void assertBeanCacheHits(int hits) {
- ServerCacheStatistics statistics = beanCache.getStatistics(true);
+ ServerCacheStatistics statistics = beanCache.statistics(true);
assertEquals(statistics.getHitCount(), hits);
}
private void clearCacheAndStatistics() {
beanCache.clear();
- beanCache.getStatistics(true);
+ beanCache.statistics(true);
}
private List insertData() {
diff --git a/ebean-core/src/test/java/org/tests/batchload/TestQueryJoin.java b/ebean-core/src/test/java/org/tests/batchload/TestQueryJoin.java
index 71b5a4b4d..822f80a21 100644
--- a/ebean-core/src/test/java/org/tests/batchload/TestQueryJoin.java
+++ b/ebean-core/src/test/java/org/tests/batchload/TestQueryJoin.java
@@ -23,7 +23,7 @@ public class TestQueryJoin extends BaseTestCase {
// Need to make sure the customer cache is cleared for the later
// asserts on the lazy loading
- ServerCache custCache = Ebean.getServerCacheManager().getBeanCache(Customer.class);
+ ServerCache custCache = Ebean.getServerCacheManager().beanCache(Customer.class);
custCache.clear();
Query query = Ebean.find(Order.class).select("status")
diff --git a/ebean-core/src/test/java/org/tests/cache/TestBeanCache.java b/ebean-core/src/test/java/org/tests/cache/TestBeanCache.java
index 280848b95..80ef3b99d 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestBeanCache.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestBeanCache.java
@@ -27,7 +27,7 @@ public class TestBeanCache extends BaseTestCase {
private static final Logger log = LoggerFactory.getLogger(TestBeanCache.class);
- private final ServerCache beanCache = DB.getDefault().cacheManager().getBeanCache(OCachedBean.class);
+ private final ServerCache beanCache = DB.getDefault().cacheManager().beanCache(OCachedBean.class);
@Test
public void findById_when_idTypeConverted() {
@@ -61,7 +61,7 @@ public class TestBeanCache extends BaseTestCase {
List ids = beans.stream().map(OCachedBean::getId).collect(Collectors.toList());
beanCache.clear();
- beanCache.getStatistics(true);
+ beanCache.statistics(true);
try (Transaction transaction = DB.beginTransaction()) {
// skipCacheAfterWrite set after this write ...
@@ -77,7 +77,7 @@ public class TestBeanCache extends BaseTestCase {
transaction.commit();
}
- ServerCacheStatistics statistics = beanCache.getStatistics(true);
+ ServerCacheStatistics statistics = beanCache.statistics(true);
assertThat(statistics.getHitCount()).isEqualTo(0);
assertThat(statistics.getMissCount()).isEqualTo(2);
assertThat(statistics.getPutCount()).isEqualTo(2);
@@ -90,7 +90,7 @@ public class TestBeanCache extends BaseTestCase {
List ids = beans.stream().map(OCachedBean::getId).collect(Collectors.toList());
beanCache.clear();
- beanCache.getStatistics(true);
+ beanCache.statistics(true);
LoggedSqlCollector.start();
@@ -158,7 +158,7 @@ public class TestBeanCache extends BaseTestCase {
}
private void assertBeanCacheHitMiss(int hitCount, int missCount) {
- ServerCacheStatistics statistics = beanCache.getStatistics(true);
+ ServerCacheStatistics statistics = beanCache.statistics(true);
assertThat(statistics.getHitCount()).isEqualTo(hitCount);
assertThat(statistics.getMissCount()).isEqualTo(missCount);
}
diff --git a/ebean-core/src/test/java/org/tests/cache/TestBeanFetchJoinCache.java b/ebean-core/src/test/java/org/tests/cache/TestBeanFetchJoinCache.java
index c0d632abc..4144ca557 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestBeanFetchJoinCache.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestBeanFetchJoinCache.java
@@ -18,13 +18,13 @@ import static org.assertj.core.api.Assertions.assertThat;
public class TestBeanFetchJoinCache extends BaseTestCase {
- private final ServerCache customerBeanCache = server().cacheManager().getBeanCache(Customer.class);
+ private final ServerCache customerBeanCache = server().cacheManager().beanCache(Customer.class);
@Test
public void fetchCache_when_allHits() {
initDataClearCache();
loadCustomerBeanCache();
- customerBeanCache.getStatistics(true);
+ customerBeanCache.statistics(true);
LoggedSqlCollector.start();
@@ -35,7 +35,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
final List sql0 = LoggedSqlCollector.current();
assertThat(sql0).hasSize(1);
- final ServerCacheStatistics statistics = customerBeanCache.getStatistics(true);
+ final ServerCacheStatistics statistics = customerBeanCache.statistics(true);
assertThat(statistics.getHitCount()).isEqualTo(2);
assertThat(trimSql(sql0.get(0))).doesNotContain("t1.status");
@@ -64,7 +64,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
.where().lt("id", 2)
.findList();
- customerBeanCache.getStatistics(true);
+ customerBeanCache.statistics(true);
LoggedSqlCollector.start();
@@ -77,7 +77,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
assertThat(sql0.get(0)).contains(" from o_order ");
assertThat(sql0.get(1)).contains(" from o_customer t0 where t0.id ");
- final ServerCacheStatistics statistics = customerBeanCache.getStatistics(true);
+ final ServerCacheStatistics statistics = customerBeanCache.statistics(true);
assertThat(statistics.getHitCount()).isEqualTo(1);
for (Order order : orders) {
@@ -98,7 +98,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
.select("name") // not included status in bean cache
.findList();
- customerBeanCache.getStatistics(true);
+ customerBeanCache.statistics(true);
LoggedSqlCollector.start();
@@ -112,7 +112,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
final List sql0 = LoggedSqlCollector.current();
assertThat(sql0).hasSize(1);
- final ServerCacheStatistics statistics = customerBeanCache.getStatistics(true);
+ final ServerCacheStatistics statistics = customerBeanCache.statistics(true);
assertThat(statistics.getHitCount()).isEqualTo(2);
assertThat(trimSql(sql0.get(0))).doesNotContain("t1.status");
@@ -129,7 +129,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
assertThat(sql1.get(0)).contains(" from o_customer t0 ");
// assert we didn't hit the L2 bean cache the second time around
- final ServerCacheStatistics statistics1 = customerBeanCache.getStatistics(true);
+ final ServerCacheStatistics statistics1 = customerBeanCache.statistics(true);
assertThat(statistics1.getHitCount()).isGreaterThan(0);
}
@@ -141,7 +141,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
public void fetchGroup_fetchCache() {
initDataClearCache();
loadCustomerBeanCache();
- customerBeanCache.getStatistics(true);
+ customerBeanCache.statistics(true);
List orders = DB.find(Order.class)
.select(fgBasic)
@@ -149,7 +149,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
assertThat(orders).isNotEmpty();
- final ServerCacheStatistics statistics1 = customerBeanCache.getStatistics(true);
+ final ServerCacheStatistics statistics1 = customerBeanCache.statistics(true);
assertThat(statistics1.getHitCount()).isEqualTo(2);
}
@@ -160,7 +160,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
@Test
public void fetchGroup_fetchCache_partial() {
initDataClearCache();
- customerBeanCache.getStatistics(true);
+ customerBeanCache.statistics(true);
LoggedSqlCollector.start();
@@ -170,7 +170,7 @@ public class TestBeanFetchJoinCache extends BaseTestCase {
assertThat(orders).isNotEmpty();
- final ServerCacheStatistics statistics1 = customerBeanCache.getStatistics(true);
+ final ServerCacheStatistics statistics1 = customerBeanCache.statistics(true);
assertThat(statistics1.getMissCount()).isEqualTo(2);
final List sql = LoggedSqlCollector.stop();
diff --git a/ebean-core/src/test/java/org/tests/cache/TestCacheBasic.java b/ebean-core/src/test/java/org/tests/cache/TestCacheBasic.java
index 390e3e4e4..20fa503c7 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestCacheBasic.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestCacheBasic.java
@@ -17,16 +17,16 @@ public class TestCacheBasic extends BaseTestCase {
ResetBasicData.reset();
Ebean.getServerCacheManager().clear(Country.class);
- ServerCache countryCache = Ebean.getServerCacheManager().getBeanCache(Country.class);
+ ServerCache countryCache = Ebean.getServerCacheManager().beanCache(Country.class);
loadCountryCache();
Assert.assertTrue(countryCache.size() > 0);
// reset the statistics
- countryCache.getStatistics(true);
+ countryCache.statistics(true);
Country c0 = Ebean.getReference(Country.class, "NZ");
- ServerCacheStatistics statistics = countryCache.getStatistics(false);
+ ServerCacheStatistics statistics = countryCache.statistics(false);
long hc = statistics.getHitCount();
Assert.assertEquals(1, hc);
Assert.assertNotNull(c0);
diff --git a/ebean-core/src/test/java/org/tests/cache/TestCacheCollectionIds.java b/ebean-core/src/test/java/org/tests/cache/TestCacheCollectionIds.java
index 5cff419c4..0fcef9cee 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestCacheCollectionIds.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestCacheCollectionIds.java
@@ -39,8 +39,8 @@ public class TestCacheCollectionIds extends BaseTestCase {
ResetBasicData.reset();
awaitL2Cache();
- ServerCache custCache = cacheManager.getBeanCache(Customer.class);
- ServerCache custManyIdsCache = cacheManager.getCollectionIdsCache(Customer.class, "contacts");
+ ServerCache custCache = cacheManager.beanCache(Customer.class);
+ ServerCache custManyIdsCache = cacheManager.collectionIdsCache(Customer.class, "contacts");
// cacheManager.setCaching(Customer.class, true);
// cacheManager.setCaching(Contact.class, true);
@@ -121,7 +121,7 @@ public class TestCacheCollectionIds extends BaseTestCase {
OCachedBean dummyToLoad = Ebean.find(OCachedBean.class, cachedBean.getId());
dummyToLoad.getCountries().size();
- ServerCache cachedBeanCountriesCache = cacheManager.getCollectionIdsCache(OCachedBean.class, "countries");
+ ServerCache cachedBeanCountriesCache = cacheManager.collectionIdsCache(OCachedBean.class, "countries");
CachedManyIds cachedManyIds = (CachedManyIds) cachedBeanCountriesCache.get(cachedBean.getId());
// confirm the starting data and cache entry
@@ -249,7 +249,7 @@ public class TestCacheCollectionIds extends BaseTestCase {
OCachedBean dummyToLoad = Ebean.find(OCachedBean.class, cachedBean.getId());
dummyToLoad.getCountries().size();
- ServerCache cachedBeanCountriesCache = cacheManager.getCollectionIdsCache(OCachedBean.class, "countries");
+ ServerCache cachedBeanCountriesCache = cacheManager.collectionIdsCache(OCachedBean.class, "countries");
CachedManyIds cachedManyIds = (CachedManyIds) cachedBeanCountriesCache.get(cachedBean.getId());
// confirm the starting data and cache entry
@@ -293,7 +293,7 @@ public class TestCacheCollectionIds extends BaseTestCase {
Ebean.save(cachedBean);
// clear the cache
- ServerCache cachedBeanCountriesCache = cacheManager.getCollectionIdsCache(OCachedBean.class, "countries");
+ ServerCache cachedBeanCountriesCache = cacheManager.collectionIdsCache(OCachedBean.class, "countries");
cachedBeanCountriesCache.clear();
assertEquals(0, cachedBeanCountriesCache.size());
diff --git a/ebean-core/src/test/java/org/tests/cache/TestCacheNaturalId.java b/ebean-core/src/test/java/org/tests/cache/TestCacheNaturalId.java
index 8e64c2327..608b481d7 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestCacheNaturalId.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestCacheNaturalId.java
@@ -22,7 +22,7 @@ public class TestCacheNaturalId extends BaseTestCase {
ResetBasicData.reset();
- ServerCache contactCache = Ebean.getServerCacheManager().getBeanCache(Contact.class);
+ ServerCache contactCache = Ebean.getServerCacheManager().beanCache(Contact.class);
List list = Ebean.find(Contact.class).setBeanCacheMode(CacheMode.PUT).findList();
@@ -36,15 +36,15 @@ public class TestCacheNaturalId extends BaseTestCase {
}
}
- contactCache.getStatistics(true);
+ contactCache.statistics(true);
Contact c0 = Ebean.find(Contact.class).where().eq("email", emailToSearch).findOne();
- ServerCacheStatistics stats0 = contactCache.getStatistics(false);
+ ServerCacheStatistics stats0 = contactCache.statistics(false);
Contact c1 = Ebean.find(Contact.class).where().eq("email", emailToSearch).findOne();
- ServerCacheStatistics stats1 = contactCache.getStatistics(false);
+ ServerCacheStatistics stats1 = contactCache.statistics(false);
assertNotNull(c0);
assertNotNull(c1);
@@ -59,7 +59,7 @@ public class TestCacheNaturalId extends BaseTestCase {
Contact c2 = Ebean.find(Contact.class).where().eq("email", "mychangedemail@what.com")
.findOne();
- ServerCacheStatistics stats2 = contactCache.getStatistics(false);
+ ServerCacheStatistics stats2 = contactCache.statistics(false);
assertNotNull(c2);
assertEquals(c2.getId(), c1.getId());
diff --git a/ebean-core/src/test/java/org/tests/cache/TestExternalNotification.java b/ebean-core/src/test/java/org/tests/cache/TestExternalNotification.java
index b55135f30..ef863dc65 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestExternalNotification.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestExternalNotification.java
@@ -21,7 +21,7 @@ public class TestExternalNotification extends BaseTestCase {
loadCountryCache();
- ServerCache countryCache = Ebean.getServerCacheManager().getBeanCache(Country.class);
+ ServerCache countryCache = Ebean.getServerCacheManager().beanCache(Country.class);
assertTrue(countryCache.size() > 0);
diff --git a/ebean-core/src/test/java/org/tests/cache/TestL2CacheWithSharedBean.java b/ebean-core/src/test/java/org/tests/cache/TestL2CacheWithSharedBean.java
index cbc736cc5..7e02c995c 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestL2CacheWithSharedBean.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestL2CacheWithSharedBean.java
@@ -28,8 +28,8 @@ public class TestL2CacheWithSharedBean extends BaseTestCase {
Ebean.save(f1);
- ServerCache beanCache = Ebean.getServerCacheManager().getBeanCache(FeatureDescription.class);
- beanCache.getStatistics(true);
+ ServerCache beanCache = Ebean.getServerCacheManager().beanCache(FeatureDescription.class);
+ beanCache.statistics(true);
OrmQueryDetail tunedDetail = new OrmQueryDetail();
tunedDetail.select("name");
@@ -49,7 +49,7 @@ public class TestL2CacheWithSharedBean extends BaseTestCase {
// load the cache
FeatureDescription fetchOne = Ebean.find(FeatureDescription.class, f1.getId());
Assert.assertNotNull(fetchOne);
- assertEquals(1, beanCache.getStatistics(false).getSize());
+ assertEquals(1, beanCache.statistics(false).getSize());
FeatureDescription fetchTwo = Ebean.find(FeatureDescription.class, f1.getId());
FeatureDescription fetchThree = Ebean.find(FeatureDescription.class, f1.getId());
diff --git a/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java b/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
index b8ce6d1d5..0c4dc2317 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestQueryCache.java
@@ -217,7 +217,7 @@ public class TestQueryCache extends BaseTestCase {
ResetBasicData.reset();
- ServerCache customerCache = DB.getServerCacheManager().getQueryCache(Customer.class);
+ ServerCache customerCache = DB.getServerCacheManager().queryCache(Customer.class);
customerCache.clear();
List list = DB.find(Customer.class).setUseQueryCache(true).setReadOnly(true).where()
diff --git a/ebean-core/src/test/java/org/tests/cache/TestQueryCacheCountry.java b/ebean-core/src/test/java/org/tests/cache/TestQueryCacheCountry.java
index 28694eac3..6e442fa4f 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestQueryCacheCountry.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestQueryCacheCountry.java
@@ -20,13 +20,13 @@ import static org.junit.Assert.assertTrue;
public class TestQueryCacheCountry extends BaseTestCase {
private ServerCacheManager cacheManager = Ebean.getServerCacheManager();
- private ServerCache queryCache = cacheManager.getQueryCache(Country.class);
- private ServerCache beanCache = cacheManager.getBeanCache(Country.class);
+ private ServerCache queryCache = cacheManager.queryCache(Country.class);
+ private ServerCache beanCache = cacheManager.beanCache(Country.class);
private void clearCache() {
queryCache.clear();
beanCache.clear();
- queryCache.getStatistics(true);
+ queryCache.statistics(true);
}
@@ -44,7 +44,7 @@ public class TestQueryCacheCountry extends BaseTestCase {
assertThat(countryList0).isEmpty();
- ServerCacheStatistics queryStats = queryCache.getStatistics(false);
+ ServerCacheStatistics queryStats = queryCache.statistics(false);
assertEquals(1, queryStats.getMissCount());
assertEquals(1, queryStats.getSize());
@@ -56,7 +56,7 @@ public class TestQueryCacheCountry extends BaseTestCase {
assertThat(countryList1).isEmpty();
- ServerCacheStatistics queryStats1 = queryCache.getStatistics(false);
+ ServerCacheStatistics queryStats1 = queryCache.statistics(false);
assertEquals(1, queryStats1.getMissCount());
assertEquals(1, queryStats1.getSize());
assertEquals(1, queryStats1.getHitCount());
@@ -83,7 +83,7 @@ public class TestQueryCacheCountry extends BaseTestCase {
assertThat(countryList1.get(0).getName()).isEqualTo("Australia");
- ServerCacheStatistics queryStats1 = queryCache.getStatistics(false);
+ ServerCacheStatistics queryStats1 = queryCache.statistics(false);
assertEquals(2, queryStats1.getMissCount());
assertEquals(2, queryStats1.getSize());
assertEquals(0, queryStats1.getHitCount()); // no hits yet
@@ -97,7 +97,7 @@ public class TestQueryCacheCountry extends BaseTestCase {
assertThat(countryList2.get(0).getName()).isEqualTo("New Zealand");
- ServerCacheStatistics queryStats2 = queryCache.getStatistics(false);
+ ServerCacheStatistics queryStats2 = queryCache.statistics(false);
assertEquals(2, queryStats2.getMissCount());
assertEquals(2, queryStats2.getSize());
assertEquals(1, queryStats2.getHitCount()); // got a hit
@@ -110,7 +110,7 @@ public class TestQueryCacheCountry extends BaseTestCase {
assertThat(countryList3.get(0).getName()).isEqualTo("Australia");
- ServerCacheStatistics queryStats3 = queryCache.getStatistics(false);
+ ServerCacheStatistics queryStats3 = queryCache.statistics(false);
assertEquals(2, queryStats3.getMissCount());
assertEquals(2, queryStats3.getSize());
assertEquals(2, queryStats3.getHitCount()); // got another hit
@@ -124,14 +124,14 @@ public class TestQueryCacheCountry extends BaseTestCase {
awaitL2Cache();
clearCache();
- assertEquals(0, queryCache.getStatistics(false).getSize());
+ assertEquals(0, queryCache.statistics(false).getSize());
List countryList0 = Ebean.find(Country.class)
.setUseQueryCache(true)
.order().asc("name")
.findList();
- assertEquals(1, queryCache.getStatistics(false).getSize());
+ assertEquals(1, queryCache.statistics(false).getSize());
assertTrue(!countryList0.isEmpty());
List countryList1 = Ebean.find(Country.class)
@@ -139,7 +139,7 @@ public class TestQueryCacheCountry extends BaseTestCase {
.order().asc("name")
.findList();
- ServerCacheStatistics statistics = queryCache.getStatistics(false);
+ ServerCacheStatistics statistics = queryCache.statistics(false);
assertEquals(1, statistics.getSize());
assertEquals(1, statistics.getHitCount());
Assert.assertSame(countryList1, countryList0);
@@ -149,7 +149,7 @@ public class TestQueryCacheCountry extends BaseTestCase {
Ebean.save(nz);
awaitL2Cache();
- statistics = queryCache.getStatistics(false);
+ statistics = queryCache.statistics(false);
assertEquals(0, statistics.getSize());
List countryList2 = Ebean.find(Country.class)
diff --git a/ebean-core/src/test/java/org/tests/cache/TestQueryCacheInsert.java b/ebean-core/src/test/java/org/tests/cache/TestQueryCacheInsert.java
index 3a5ca02ea..0b5517eb7 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestQueryCacheInsert.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestQueryCacheInsert.java
@@ -44,8 +44,8 @@ public class TestQueryCacheInsert extends BaseTestCase {
Ebean.save(doda);
- ServerCache queryCache = Ebean.getServerCacheManager().getQueryCache(EBasicVer.class);
- queryCache.getStatistics(true);
+ ServerCache queryCache = Ebean.getServerCacheManager().queryCache(EBasicVer.class);
+ queryCache.statistics(true);
Optional found0 = Ebean.find(EBasicVer.class)
.where().eq("description", "OddButUniqueSillyExample")
@@ -65,7 +65,7 @@ public class TestQueryCacheInsert extends BaseTestCase {
}
private void assertHitMiss(int hits, int miss, ServerCache queryCache) {
- ServerCacheStatistics stats = queryCache.getStatistics(true);
+ ServerCacheStatistics stats = queryCache.statistics(true);
assertEquals(hits, stats.getHitCount());
assertEquals(miss, stats.getMissCount());
}
diff --git a/ebean-core/src/test/java/org/tests/cache/TestQueryCacheTableDependency.java b/ebean-core/src/test/java/org/tests/cache/TestQueryCacheTableDependency.java
index 4403aa885..46c910f83 100644
--- a/ebean-core/src/test/java/org/tests/cache/TestQueryCacheTableDependency.java
+++ b/ebean-core/src/test/java/org/tests/cache/TestQueryCacheTableDependency.java
@@ -25,7 +25,7 @@ public class TestQueryCacheTableDependency extends BaseTestCase {
ResetBasicData.reset();
- ServerCache customerCache = Ebean.getServerCacheManager().getQueryCache(Customer.class);
+ ServerCache customerCache = Ebean.getServerCacheManager().queryCache(Customer.class);
customerCache.clear();
List addrs = Ebean.find(Address.class)
@@ -138,8 +138,8 @@ public class TestQueryCacheTableDependency extends BaseTestCase {
child.setName("bobby");
child.setBillingAddress(root);
DB.save(child);
- DB.getServerCacheManager().getQueryCache(Address.class).clear();
- DB.getServerCacheManager().getQueryCache(Customer.class).clear();
+ DB.getServerCacheManager().queryCache(Address.class).clear();
+ DB.getServerCacheManager().queryCache(Customer.class).clear();
// Test preparation finished, start the test
Thread.sleep(10);
@@ -169,8 +169,8 @@ public class TestQueryCacheTableDependency extends BaseTestCase {
child.setName("testChild");
child.setRoot(root);
DB.save(child);
- DB.getServerCacheManager().getQueryCache(ECacheChild.class).clear();
- DB.getServerCacheManager().getQueryCache(ECacheRoot.class).clear();
+ DB.getServerCacheManager().queryCache(ECacheChild.class).clear();
+ DB.getServerCacheManager().queryCache(ECacheRoot.class).clear();
// Test preparation finished, start the test
Thread.sleep(10);
// we need this thread.sleep here, because on a fast machine, DB.save(child) and computing the
diff --git a/ebean-core/src/test/java/org/tests/cache/personinfo/PersonCacheTests.java b/ebean-core/src/test/java/org/tests/cache/personinfo/PersonCacheTests.java
index d057edffd..a5d950009 100644
--- a/ebean-core/src/test/java/org/tests/cache/personinfo/PersonCacheTests.java
+++ b/ebean-core/src/test/java/org/tests/cache/personinfo/PersonCacheTests.java
@@ -21,10 +21,10 @@ public class PersonCacheTests {
private final List ids = Arrays.asList("E001", "E002", "E003");
- private ServerCache beanCacheInfo = DB.getDefault().cacheManager().getBeanCache(PersonCacheInfo.class);
- private ServerCache beanCacheEmail = DB.getDefault().cacheManager().getBeanCache(PersonCacheEmail.class);
+ private ServerCache beanCacheInfo = DB.getDefault().cacheManager().beanCache(PersonCacheInfo.class);
+ private ServerCache beanCacheEmail = DB.getDefault().cacheManager().beanCache(PersonCacheEmail.class);
- private ServerCacheRegion region = DB.getDefault().cacheManager().getRegion("email");
+ private ServerCacheRegion region = DB.getDefault().cacheManager().region("email");
private void insert(int id, String email) {
@@ -56,7 +56,7 @@ public class PersonCacheTests {
.setUseCache(true)
.findList();
- beanCacheInfo.getStatistics(true);
+ beanCacheInfo.statistics(true);
List emailList =
DB.find(PersonCacheEmail.class)
@@ -73,7 +73,7 @@ public class PersonCacheTests {
List sql = LoggedSqlCollector.current();
assertThat(sql).hasSize(3);
- assertThat(beanCacheInfo.getStatistics(true).getHitCount()).isEqualTo(3);
+ assertThat(beanCacheInfo.statistics(true).getHitCount()).isEqualTo(3);
// force cache misses on PersonCacheEmail
beanCacheEmail.clear();
@@ -94,7 +94,7 @@ public class PersonCacheTests {
sql = LoggedSqlCollector.stop();
assertThat(sql).hasSize(1);
- assertThat(beanCacheInfo.getStatistics(true).getHitCount()).isEqualTo(3);
+ assertThat(beanCacheInfo.statistics(true).getHitCount()).isEqualTo(3);
turnOffRegion_expect_noCacheUse();
@@ -103,7 +103,7 @@ public class PersonCacheTests {
private void turnOffRegion_expect_noCacheUse() {
assertTrue(region.isEnabled());
- beanCacheEmail.getStatistics(true);
+ beanCacheEmail.statistics(true);
log.info("Disabled region ...");
region.setEnabled(false);
@@ -116,7 +116,7 @@ public class PersonCacheTests {
}
// assert that we didn't hit the cache
- ServerCacheStatistics statistics = beanCacheEmail.getStatistics(true);
+ ServerCacheStatistics statistics = beanCacheEmail.statistics(true);
assertThat(statistics.getHitCount()).isEqualTo(0);
assertThat(statistics.getMissCount()).isEqualTo(0);
@@ -131,7 +131,7 @@ public class PersonCacheTests {
}
// assert that we DID hit the cache
- statistics = beanCacheEmail.getStatistics(true);
+ statistics = beanCacheEmail.statistics(true);
assertThat(statistics.getHitCount()).isEqualTo(3);
assertThat(statistics.getMissCount()).isEqualTo(0);
}
diff --git a/ebean-core/src/test/java/org/tests/inheritance/cache/TestInheritCacheRefLoad.java b/ebean-core/src/test/java/org/tests/inheritance/cache/TestInheritCacheRefLoad.java
index af6c1299d..3c88e598e 100644
--- a/ebean-core/src/test/java/org/tests/inheritance/cache/TestInheritCacheRefLoad.java
+++ b/ebean-core/src/test/java/org/tests/inheritance/cache/TestInheritCacheRefLoad.java
@@ -56,7 +56,7 @@ public class TestInheritCacheRefLoad {
Class streetClassLazyLoaded = customerReloaded.getAddress().getStreet().getClass();
//Show Cache Hits
- System.out.println("Class of Street (Cache on: " + l2Cache + "): " + streetClassLazyLoaded + " | Cache Hit: " + DB.getDefault().cacheManager().getQueryCache(streetClassLazyLoaded).getStatistics(false).getHitCount());
+ System.out.println("Class of Street (Cache on: " + l2Cache + "): " + streetClassLazyLoaded + " | Cache Hit: " + DB.getDefault().cacheManager().queryCache(streetClassLazyLoaded).statistics(false).getHitCount());
return streetClassLazyLoaded;
}
diff --git a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey.java b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey.java
index 7411b1842..bad02c0c4 100644
--- a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey.java
+++ b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey.java
@@ -21,8 +21,8 @@ public class TestCacheViaComplexNaturalKey extends BaseTestCase {
private static final Logger log = LoggerFactory.getLogger(TestCacheViaComplexNaturalKey.class);
- private ServerCache beanCache = cacheManager().getBeanCache(OCachedNatKeyBean.class);
- private ServerCache natKeyCache = cacheManager().getNaturalKeyCache(OCachedNatKeyBean.class);
+ private ServerCache beanCache = cacheManager().beanCache(OCachedNatKeyBean.class);
+ private ServerCache natKeyCache = cacheManager().naturalKeyCache(OCachedNatKeyBean.class);
private static boolean loadOnce;
@@ -52,17 +52,17 @@ public class TestCacheViaComplexNaturalKey extends BaseTestCase {
}
private void clearStatistics() {
- beanCache.getStatistics(true);
- natKeyCache.getStatistics(true);
+ beanCache.statistics(true);
+ natKeyCache.statistics(true);
}
private void assertNaturalKeyHitMiss(int expectedHit, int expectedMiss) {
- ServerCacheStatistics stats = natKeyCache.getStatistics(true);
+ ServerCacheStatistics stats = natKeyCache.statistics(true);
assertHitMiss(expectedHit, expectedMiss, stats);
}
private void assertBeanCacheHitMiss(int expectedHit, int expectedMiss) {
- ServerCacheStatistics stats = beanCache.getStatistics(true);
+ ServerCacheStatistics stats = beanCache.statistics(true);
assertHitMiss(expectedHit, expectedMiss, stats);
}
diff --git a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey3.java b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey3.java
index a94b77725..34175b77c 100644
--- a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey3.java
+++ b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheViaComplexNaturalKey3.java
@@ -18,8 +18,8 @@ import static org.assertj.core.api.Assertions.assertThat;
public class TestCacheViaComplexNaturalKey3 extends BaseTestCase {
- private ServerCache beanCache = cacheManager().getBeanCache(OCachedNatKeyBean3.class);
- private ServerCache natKeyCache = cacheManager().getNaturalKeyCache(OCachedNatKeyBean3.class);
+ private ServerCache beanCache = cacheManager().beanCache(OCachedNatKeyBean3.class);
+ private ServerCache natKeyCache = cacheManager().naturalKeyCache(OCachedNatKeyBean3.class);
private static boolean loadOnce;
@@ -55,17 +55,17 @@ public class TestCacheViaComplexNaturalKey3 extends BaseTestCase {
}
private void clearStatistics() {
- beanCache.getStatistics(true);
- natKeyCache.getStatistics(true);
+ beanCache.statistics(true);
+ natKeyCache.statistics(true);
}
private void assertNaturalKeyHitMiss(int expectedHit, int expectedMiss) {
- ServerCacheStatistics stats = natKeyCache.getStatistics(true);
+ ServerCacheStatistics stats = natKeyCache.statistics(true);
assertHitMiss(expectedHit, expectedMiss, stats);
}
private void assertBeanCacheHitMiss(int expectedHit, int expectedMiss) {
- ServerCacheStatistics stats = beanCache.getStatistics(true);
+ ServerCacheStatistics stats = beanCache.statistics(true);
assertHitMiss(expectedHit, expectedMiss, stats);
}
diff --git a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheWithSoftDelete.java b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheWithSoftDelete.java
index 321c50dc1..d96d49b17 100644
--- a/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheWithSoftDelete.java
+++ b/ebean-core/src/test/java/org/tests/model/basic/cache/TestCacheWithSoftDelete.java
@@ -13,7 +13,7 @@ import static org.assertj.core.api.Assertions.assertThat;
public class TestCacheWithSoftDelete extends BaseTestCase {
- private final ServerCache beanCache = DB.getServerCacheManager().getBeanCache(ESoftWithCache.class);
+ private final ServerCache beanCache = DB.getServerCacheManager().beanCache(ESoftWithCache.class);
@Test
public void idIn_expect_hitCache() {
@@ -41,6 +41,6 @@ public class TestCacheWithSoftDelete extends BaseTestCase {
}
private ServerCacheStatistics stats() {
- return beanCache.getStatistics(true);
+ return beanCache.statistics(true);
}
}
diff --git a/ebean-core/src/test/java/org/tests/query/embedded/TestMultipleEmbeddedLoading.java b/ebean-core/src/test/java/org/tests/query/embedded/TestMultipleEmbeddedLoading.java
index 616d0b441..52fb10c60 100644
--- a/ebean-core/src/test/java/org/tests/query/embedded/TestMultipleEmbeddedLoading.java
+++ b/ebean-core/src/test/java/org/tests/query/embedded/TestMultipleEmbeddedLoading.java
@@ -80,15 +80,15 @@ public class TestMultipleEmbeddedLoading extends BaseTestCase {
ServerCacheManager serverCacheManager = server.cacheManager();
// get cache, clear the cache and statistics
- ServerCache beanCache = serverCacheManager.getBeanCache(EInvoice.class);
+ ServerCache beanCache = serverCacheManager.beanCache(EInvoice.class);
beanCache.clear();
- beanCache.getStatistics(true);
+ beanCache.statistics(true);
// fetch and load the cache
EInvoice invoice4 = Ebean.find(EInvoice.class, invoice.getId());
assertNotNull(invoice4);
- ServerCacheStatistics statistics = beanCache.getStatistics(false);
+ ServerCacheStatistics statistics = beanCache.statistics(false);
assertEquals(1, statistics.getSize());
assertEquals(0, statistics.getHitCount());
@@ -97,7 +97,7 @@ public class TestMultipleEmbeddedLoading extends BaseTestCase {
EInvoice invoice5 = Ebean.find(EInvoice.class, invoice.getId());
assertNotNull(invoice5);
- statistics = beanCache.getStatistics(false);
+ statistics = beanCache.statistics(false);
assertEquals(1, statistics.getSize());
assertEquals(1, statistics.getHitCount());
diff --git a/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java b/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
index 2f202d83c..91ccb2b78 100644
--- a/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
+++ b/ebean-core/src/test/java/org/tests/readaudit/TestReadAudit.java
@@ -83,8 +83,8 @@ public class TestReadAudit extends BaseTestCase {
public void test_findById_usingL2Cache() {
resetCounters();
- ServerCache beanCache = server.cacheManager().getBeanCache(EBasicChangeLog.class);
- beanCache.getStatistics(true);
+ ServerCache beanCache = server.cacheManager().beanCache(EBasicChangeLog.class);
+ beanCache.statistics(true);
EBasicChangeLog found = server.find(EBasicChangeLog.class, id1);
assertThat(found).isNotNull();
@@ -94,13 +94,13 @@ public class TestReadAudit extends BaseTestCase {
assertThat(readAuditLogger.beans.get(0).getBeanType()).isEqualTo(EBasicChangeLog.class.getName());
assertThat(readAuditLogger.beans.get(0).getId()).isEqualTo(id1);
- ServerCacheStatistics statistics = beanCache.getStatistics(false);
+ ServerCacheStatistics statistics = beanCache.statistics(false);
assertThat(statistics.getSize()).isEqualTo(1);
assertThat(statistics.getHitCount()).isEqualTo(0);
EBasicChangeLog found2 = server.find(EBasicChangeLog.class, id1);
assertThat(found2).isNotNull();
- statistics = beanCache.getStatistics(false);
+ statistics = beanCache.statistics(false);
assertThat(statistics.getSize()).isEqualTo(1);
assertThat(statistics.getHitCount()).isEqualTo(1);
@@ -111,8 +111,8 @@ public class TestReadAudit extends BaseTestCase {
public void test_findById_usingL2Cache_sharedBean() {
resetCounters();
- ServerCache beanCache = server.cacheManager().getBeanCache(Country.class);
- beanCache.getStatistics(true);
+ ServerCache beanCache = server.cacheManager().beanCache(Country.class);
+ beanCache.statistics(true);
Country found = server.find(Country.class, "AR");
assertThat(found).isNotNull();
@@ -122,13 +122,13 @@ public class TestReadAudit extends BaseTestCase {
assertThat(readAuditLogger.beans.get(0).getBeanType()).isEqualTo(Country.class.getName());
assertThat(readAuditLogger.beans.get(0).getId()).isEqualTo("AR");
- ServerCacheStatistics statistics = beanCache.getStatistics(false);
+ ServerCacheStatistics statistics = beanCache.statistics(false);
assertThat(statistics.getSize()).isEqualTo(1);
assertThat(statistics.getHitCount()).isEqualTo(0);
Country found2 = server.find(Country.class, "AR");
assertThat(found2).isNotNull();
- statistics = beanCache.getStatistics(false);
+ statistics = beanCache.statistics(false);
assertThat(statistics.getSize()).isEqualTo(1);
assertThat(statistics.getHitCount()).isEqualTo(1);
diff --git a/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java b/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
index 93ca61c87..5b76d754f 100644
--- a/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
+++ b/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java
@@ -238,7 +238,7 @@ public abstract class BaseTestCase {
}
protected ServerCacheStatistics getBeanCacheStats(Class cls, boolean reset) {
- return server().cacheManager().getBeanCache(cls).getStatistics(reset);
+ return server().cacheManager().beanCache(cls).statistics(reset);
}
protected Platform platform() {
diff --git a/ebean-redis/src/test/java/org/integration/ClusterTest.java b/ebean-redis/src/test/java/org/integration/ClusterTest.java
index b1f134ca3..b895170f6 100644
--- a/ebean-redis/src/test/java/org/integration/ClusterTest.java
+++ b/ebean-redis/src/test/java/org/integration/ClusterTest.java
@@ -46,7 +46,7 @@ public class ClusterTest {
Person fooA = DB.find(Person.class, foo.getId());
Person fooB = other.find(Person.class, foo.getId());
- DuelCache dualCacheA = (DuelCache) DB.getServerCacheManager().getBeanCache(Person.class);
+ DuelCache dualCacheA = (DuelCache) DB.getServerCacheManager().beanCache(Person.class);
assertCounts(dualCacheA, 0, 1, 0, 1);
fooA = DB.find(Person.class, foo.getId());
assertCounts(dualCacheA, 1, 1, 0, 1);
@@ -54,7 +54,7 @@ public class ClusterTest {
fooA = DB.find(Person.class, foo.getId());
assertCounts(dualCacheA, 2, 1, 0, 1);
fooB = other.find(Person.class, foo.getId());
- DuelCache dualCacheB = (DuelCache) other.cacheManager().getBeanCache(Person.class);
+ DuelCache dualCacheB = (DuelCache) other.cacheManager().beanCache(Person.class);
assertCounts(dualCacheB, 2, 1, 1, 0);
}
@@ -72,7 +72,7 @@ public class ClusterTest {
other.cacheManager().clearAll();
other.metaInfo().resetAllMetrics();
- DuelCache dualCache = (DuelCache) other.cacheManager().getBeanCache(Person.class);
+ DuelCache dualCache = (DuelCache) other.cacheManager().beanCache(Person.class);
Person foo0 = other.find(Person.class, 1);
assertCounts(dualCache, 0, 1, 0, 1);
From b69c00b01e7557a0010ab28da7794a8d31791179 Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 18:01:27 +1200
Subject: [PATCH 041/102] #2353 - Rename BeanPersistRequest methods with
deprecation
---
.../io/ebean/event/BeanDeleteIdRequest.java | 47 +++++++++---
.../io/ebean/event/BeanPersistRequest.java | 71 +++++++++++++++++--
.../java/io/ebean/event/BeanQueryRequest.java | 31 +++++++-
.../java/io/ebean/event/BulkTableEvent.java | 10 ++-
.../io/ebeaninternal/api/LoadRequest.java | 4 +-
.../api/TransactionEventTable.java | 4 +-
.../server/core/BeanRequest.java | 2 +-
.../server/core/DefaultServer.java | 4 +-
.../server/core/OrmQueryRequest.java | 2 +-
.../server/core/PersistRequestBean.java | 14 ++--
.../server/core/SpiOrmQueryRequest.java | 2 +-
.../deploy/BeanCollectionHelpFactory.java | 2 +-
.../server/deploy/BeanDescriptorManager.java | 2 +-
.../deploy/BeanLifecycleAdapterFactory.java | 2 +-
.../server/deploy/BeanPropertyAssocMany.java | 2 +-
.../expression/ExistsQueryExpression.java | 2 +-
.../server/expression/InQueryExpression.java | 2 +-
.../server/loadcontext/DLoadContext.java | 2 +-
.../server/persist/DefaultPersister.java | 18 ++---
.../server/persist/DeleteIdRequest.java | 10 +--
.../persist/DeleteUnloadedForeignKeys.java | 6 +-
.../server/persist/ExeCallableSql.java | 2 +-
.../server/persist/ExeOrmUpdate.java | 2 +-
.../server/persist/ExeUpdateSql.java | 2 +-
.../server/persist/SaveManyBase.java | 2 +-
.../server/persist/dml/DeleteHandler.java | 2 +-
.../server/persist/dml/DmlBeanPersister.java | 4 +-
.../server/persist/dml/DmlHandler.java | 4 +-
.../server/persist/dml/InsertHandler.java | 2 +-
.../server/persist/dml/UpdateHandler.java | 2 +-
.../io/ebeaninternal/server/query/CQuery.java | 8 +--
.../server/query/CQueryBuilder.java | 22 +++---
.../server/query/CQueryBuilderRawSql.java | 8 +--
.../server/query/CQueryEngine.java | 20 +++---
.../query/CQueryFetchSingleAttribute.java | 4 +-
.../server/query/CQueryPlan.java | 4 +-
.../server/query/CQueryPlanRawSql.java | 2 +-
.../server/query/CQueryPredicates.java | 2 +-
.../server/query/CQueryRowCount.java | 4 +-
.../server/query/CQueryUpdate.java | 4 +-
.../server/query/DefaultOrmQueryEngine.java | 4 +-
.../server/query/SqlTreeBuilder.java | 4 +-
.../transaction/BulkEventListenerMap.java | 2 +-
.../docstore/api/DocQueryRequest.java | 4 +-
.../event/BeanPersistControllerTest.java | 2 +-
...faultServer_createOrmQueryRequestTest.java | 32 ++++-----
.../server/expression/BaseExpressionTest.java | 4 +-
.../org/tests/json/TestDbJson_Jackson3.java | 4 +-
.../basic/event/SimpleTOneQueryAdapter.java | 2 +-
.../event/TWithPreInsertPersistAdapter.java | 4 +-
.../tests/model/prnt/MPrinterListener.java | 4 +-
51 files changed, 263 insertions(+), 142 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/event/BeanDeleteIdRequest.java b/ebean-api/src/main/java/io/ebean/event/BeanDeleteIdRequest.java
index c86ff6c87..66831b69e 100644
--- a/ebean-api/src/main/java/io/ebean/event/BeanDeleteIdRequest.java
+++ b/ebean-api/src/main/java/io/ebean/event/BeanDeleteIdRequest.java
@@ -10,31 +10,62 @@ import io.ebean.Transaction;
public interface BeanDeleteIdRequest {
/**
- * Return the server processing the request.
- * @deprecated use {@link #getDatabase()}
+ * Deprecated migrate to database().
*/
+ @Deprecated
EbeanServer getEbeanServer();
+ /**
+ * Deprecated migrate to database().
+ */
+ @Deprecated
+ default Database getDatabase() {
+ return getEbeanServer();
+ }
+
/**
* Return the DB processing the request.
*/
- default Database getDatabase() {
+ default Database database() {
return getEbeanServer();
}
-
+
/**
* Return the Transaction associated with this request.
*/
- Transaction getTransaction();
-
+ Transaction transaction();
+
+ /**
+ * Deprecated migrate to transaction().
+ */
+ @Deprecated
+ default Transaction getTransaction() {
+ return transaction();
+ }
+
/**
* Returns the bean type of the bean being deleted.
*/
- Class> getBeanType();
+ Class> beanType();
+
+ /**
+ * Deprecated migrate to beanType().
+ */
+ @Deprecated
+ default Class> getBeanType() {
+ return beanType();
+ }
/**
* Returns the Id value of the bean being deleted.
*/
- Object getId();
+ Object id();
+ /**
+ * Deprecated migrate to id().
+ */
+ @Deprecated
+ default Object getId() {
+ return id();
+ }
}
diff --git a/ebean-api/src/main/java/io/ebean/event/BeanPersistRequest.java b/ebean-api/src/main/java/io/ebean/event/BeanPersistRequest.java
index c5043fb74..57930a107 100644
--- a/ebean-api/src/main/java/io/ebean/event/BeanPersistRequest.java
+++ b/ebean-api/src/main/java/io/ebean/event/BeanPersistRequest.java
@@ -1,5 +1,6 @@
package io.ebean.event;
+import io.ebean.Database;
import io.ebean.EbeanServer;
import io.ebean.Transaction;
import io.ebean.ValuePair;
@@ -17,20 +18,44 @@ import java.util.Set;
public interface BeanPersistRequest {
/**
- * Return the server processing the request.
+ * Return the DB processing the request.
*/
+ default Database database() {
+ return getEbeanServer();
+ }
+
+ /**
+ * Deprecated migrate to database().
+ */
+ @Deprecated
EbeanServer getEbeanServer();
/**
* Return the Transaction associated with this request.
*/
- Transaction getTransaction();
+ Transaction transaction();
+
+ /**
+ * Deprecated migrate to transaction().
+ */
+ @Deprecated
+ default Transaction getTransaction() {
+ return transaction();
+ }
/**
* For an update or delete of a partially populated bean this is the set of
* loaded properties and otherwise returns null.
*/
- Set getLoadedProperties();
+ Set loadedProperties();
+
+ /**
+ * Deprecated migrate to loadedProperties().
+ */
+ @Deprecated
+ default Set getLoadedProperties() {
+ return loadedProperties();
+ }
/**
* For an update this is the set of properties that where updated.
@@ -39,12 +64,28 @@ public interface BeanPersistRequest {
* should be preferred if it satisfies the requirement.
*
*/
- public CQueryPlanKey getQueryPlanKey() {
+ public CQueryPlanKey queryPlanKey() {
return queryPlanKey;
}
@@ -608,7 +589,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
}
@Override
- public List getBeanCacheHits() {
+ public List beanCacheHits() {
OrderBy orderBy = query.getOrderBy();
if (orderBy != null) {
beanDescriptor.sort(cacheBeans, orderBy.toStringFormat());
@@ -617,7 +598,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
}
@Override
- public Map getBeanCacheHitsAsMap() {
+ public Map beanCacheHitsAsMap() {
OrderBy orderBy = query.getOrderBy();
if (orderBy != null) {
beanDescriptor.sort(cacheBeans, orderBy.toStringFormat());
@@ -665,7 +646,6 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
if (!beanDescriptor.isNaturalKeyCaching()) {
return false;
}
-
NaturalKeyQueryData data = query.naturalKey();
if (data != null) {
NaturalKeySet naturalKeySet = data.buildKeys();
@@ -693,13 +673,11 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
} else {
cacheKey = query.queryHash();
}
-
if (!query.getUseQueryCache().isGet()) {
return null;
}
Object cached = beanDescriptor.queryCacheGet(cacheKey);
-
if (cached != null && isAuditReads() && readAuditQueryType()) {
if (cached instanceof BeanCollection) {
// raw sql can't use L2 cache so normal queries only in here
@@ -711,7 +689,6 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
beanDescriptor.readAuditMany(queryPlanKey.getPartialKey(), "l2-query-cache", ids);
}
}
-
if (Boolean.FALSE.equals(query.isReadOnly())) {
// return shallow copies if readonly is explicitly set to false
if (cached instanceof BeanCollection) {
@@ -750,7 +727,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
}
/**
- * Set an Query object that owns the PreparedStatement that can be cancelled.
+ * Set a Query object that owns the PreparedStatement that can be cancelled.
*/
public void setCancelableQuery(CancelableQuery cancelableQuery) {
query.setCancelableQuery(cancelableQuery);
@@ -766,7 +743,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
/**
* Return the batch size for lazy loading on this bean query request.
*/
- public int getLazyLoadBatchSize() {
+ public int lazyLoadBatchSize() {
int batchSize = query.getLazyLoadBatchSize();
return (batchSize > 0) ? batchSize : server.getLazyLoadBatchSize();
}
@@ -775,7 +752,6 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
* Return true if read auditing is on for this query request.
*
* This means that read audit is on for this bean type and that query has not explicitly disabled it.
- *
*/
public boolean isAuditReads() {
return beanDescriptor.isReadAuditing() && !query.isDisableReadAudit();
@@ -784,7 +760,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
/**
* Return the base table alias for this query.
*/
- public String getBaseTableAlias() {
+ public String baseTableAlias() {
return query.getAlias(beanDescriptor.getBaseTableAlias());
}
@@ -798,7 +774,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
/**
* Return the tenantId associated with this request.
*/
- public Object getTenantId() {
+ public Object tenantId() {
return (transaction == null) ? null : transaction.getTenantId();
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java
index dddfc032c..1eab09911 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequest.java
@@ -31,17 +31,10 @@ public abstract class PersistRequest extends BeanRequest implements BatchPostExe
}
}
- boolean persistCascade;
-
- /**
- * One of INSERT, UPDATE, DELETE, UPDATESQL or CALLABLESQL.
- */
protected Type type;
-
+ boolean persistCascade;
final PersistExecute persistExecute;
-
protected String label;
-
protected long startNanos;
PersistRequest(SpiEbeanServer server, SpiTransaction t, PersistExecute persistExecute) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java
index 17a2d1907..a5074ced4 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java
@@ -50,142 +50,94 @@ import java.util.Set;
public final class PersistRequestBean extends PersistRequest implements BeanPersistRequest, DocStoreUpdate, PreGetterCallback, SpiProfileTransactionEvent {
private final BeanManager beanManager;
-
private final BeanDescriptor beanDescriptor;
-
private final BeanPersistListener beanPersistListener;
-
- /**
- * For per post insert update delete control.
- */
private final BeanPersistController controller;
-
- /**
- * The bean being persisted.
- */
private final T bean;
-
private final EntityBean entityBean;
-
- /**
- * The associated intercept.
- */
private final EntityBeanIntercept intercept;
-
/**
* The parent bean for unidirectional save.
*/
private final Object parentBean;
-
private final boolean dirty;
-
private final boolean publish;
-
private int flags;
-
private boolean saveRecurse;
-
private DocStoreMode docStoreMode;
-
private final ConcurrencyMode concurrencyMode;
-
/**
* The unique id used for logging summary.
*/
private Object idValue;
-
/**
* Hash value used to handle cascade delete both ways in a relationship.
*/
private Integer beanHash;
-
- /**
- * Flag set if this is a stateless update.
- */
private boolean statelessUpdate;
-
private boolean notifyCache;
-
/**
* Flag used to detect when only many properties where updated via a cascade. Used to ensure
* appropriate caches are updated in that case.
*/
private boolean updatedManysOnly;
-
/**
* Element collection change as part of bean cache.
*/
private Map collectionChanges;
-
/**
* Set true when the request includes cascade save to a many.
*/
private boolean updatedMany;
-
/**
* Many properties that were cascade saved (and hence might need caches updated later).
*/
private List> updatedManys;
-
/**
* Need to get and store the updated properties because the persist listener is notified
* later on a different thread and the bean has been reset at that point.
*/
private Set updatedProperties;
-
/**
* Flags indicating the dirty properties on the bean.
*/
private boolean[] dirtyProperties;
-
/**
* Imported OneToOne orphan that needs to be deleted.
*/
private EntityBean orphanBean;
-
/**
* Flag set when request is added to JDBC batch.
*/
private boolean batched;
-
/**
* Flag set when batchOnCascade to avoid using batch on the top bean.
*/
private boolean skipBatchForTopLevel;
-
/**
* Flag set when batch mode is turned on for a persist cascade.
*/
private boolean batchOnCascadeSet;
-
/**
* Set for updates to determine if all loaded properties are included in the update.
*/
private boolean requestUpdateAllLoadedProps;
-
private long version;
-
private long now;
-
private long profileOffset;
-
/**
* Flag set when request is added to JDBC batch registered as a "getter callback" to automatically flush batch.
*/
private boolean getterCallback;
-
private boolean pendingPostUpdateNotify;
-
/**
* Set to true when post execute has occurred (so includes batch flush).
*/
private boolean postExecute;
-
/**
* Set to true after many properties have been persisted (so includes element collections).
*/
private boolean complete;
-
/**
* Many to many intersection table changes that are held for later batch processing.
*/
@@ -582,8 +534,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
}
/**
- * Return true if this bean has been already been persisted (inserted or updated) in this
- * transaction.
+ * Return true if this bean has been already been persisted (inserted or updated) in this transaction.
*/
public boolean isRegisteredBean() {
return transaction.isRegisteredBean(bean);
@@ -600,7 +551,6 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
* The hash used to register the bean with the transaction.
*
* Takes into account the class type and id value.
- *
*/
private Integer getBeanHash() {
if (beanHash == null) {
@@ -631,7 +581,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
/**
* Return the BeanDescriptor for the associated bean.
*/
- public BeanDescriptor getBeanDescriptor() {
+ public BeanDescriptor descriptor() {
return beanDescriptor;
}
@@ -656,7 +606,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
/**
* Return the concurrency mode used for this persist.
*/
- public ConcurrencyMode getConcurrencyMode() {
+ public ConcurrencyMode concurrencyMode() {
return concurrencyMode;
}
@@ -667,7 +617,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
* Used to determine common persist requests for queueing and statement batching.
*
*/
- public String getFullName() {
+ public String fullName() {
return beanDescriptor.getFullName();
}
@@ -679,14 +629,14 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
return bean;
}
- public EntityBean getEntityBean() {
+ public EntityBean entityBean() {
return entityBean;
}
/**
* Return the Id value for the bean.
*/
- public Object getBeanId() {
+ public Object beanId() {
return beanDescriptor.getId(entityBean);
}
@@ -694,7 +644,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
* Create and return a new reference bean matching this beans Id value.
*/
public T createReference() {
- return beanDescriptor.createRef(getBeanId(), null);
+ return beanDescriptor.createRef(beanId(), null);
}
/**
@@ -739,14 +689,14 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
/**
* Return the parent bean for cascading save with unidirectional relationship.
*/
- public Object getParentBean() {
+ public Object parentBean() {
return parentBean;
}
/**
* Return the intercept if there is one.
*/
- public EntityBeanIntercept getEntityBeanIntercept() {
+ public EntityBeanIntercept intercept() {
return intercept;
}
@@ -854,7 +804,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
* Check for optimistic concurrency exception.
*/
@Override
- public final void checkRowCount(int rowCount) {
+ public void checkRowCount(int rowCount) {
if (rowCount != 1 && rowCount != Statement.SUCCESS_NO_INFO) {
if (ConcurrencyMode.VERSION == concurrencyMode) {
throw new OptimisticLockException("Data has changed. updated row count " + rowCount, null, bean);
@@ -1074,7 +1024,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
/**
* Return the list of updated many properties for L2 cache update (can be null).
*/
- public List> getUpdatedManyForL2Cache() {
+ public List> updatedManyForL2Cache() {
return updatedManys;
}
@@ -1183,7 +1133,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
/**
* Return the flags set on this persist request.
*/
- public int getFlags() {
+ public int flags() {
return flags;
}
@@ -1197,7 +1147,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
/**
* Return the key for an update persist request.
*/
- public String getUpdatePlanHash() {
+ public String updatePlanHash() {
StringBuilder key;
if (determineUpdateAllLoadedProperties()) {
key = intercept.getLoadedPropertyKey();
@@ -1219,7 +1169,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
/**
* Return the table to update depending if the request is a 'publish' one or normal.
*/
- public String getUpdateTable() {
+ public String updateTable() {
return publish ? beanDescriptor.getBaseTable() : beanDescriptor.getDraftTable();
}
@@ -1240,7 +1190,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
/**
* Return the version in long form (if set).
*/
- public long getVersion() {
+ public long version() {
return version;
}
@@ -1383,7 +1333,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
String key = beanDescriptor.cacheKey(idValue);
Map changes = new LinkedHashMap<>();
- EntityBean bean = getEntityBean();
+ EntityBean bean = entityBean();
boolean[] dirtyProperties = dirtyProperties();
if (dirtyProperties != null) {
for (int i = 0; i < dirtyProperties.length; i++) {
@@ -1405,7 +1355,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
// add element collection update
changes.putAll(collectionChanges);
}
- changeSet.addBeanUpdate(beanDescriptor, key, changes, updateNaturalKey, getVersion());
+ changeSet.addBeanUpdate(beanDescriptor, key, changes, updateNaturalKey, version());
}
}
@@ -1419,7 +1369,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
}
}
- public EntityBean getImportedOrphanForRemoval() {
+ public EntityBean importedOrphanForRemoval() {
return orphanBean;
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestCallableSql.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestCallableSql.java
index 806691f5f..1edabf5bd 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestCallableSql.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestCallableSql.java
@@ -19,20 +19,15 @@ import java.util.List;
public final class PersistRequestCallableSql extends PersistRequest {
private final SpiCallableSql callableSql;
-
private int rowCount;
-
private String bindLog;
-
private CallableStatement cstmt;
-
private BindParams bindParam;
/**
* Create.
*/
public PersistRequestCallableSql(SpiEbeanServer server, CallableSql cs, SpiTransaction t, PersistExecute persistExecute) {
-
super(server, t, persistExecute, cs.getLabel());
this.type = PersistRequest.Type.CALLABLESQL;
this.callableSql = (SpiCallableSql) cs;
@@ -56,7 +51,7 @@ public final class PersistRequestCallableSql extends PersistRequest {
/**
* Return the CallableSql.
*/
- public SpiCallableSql getCallableSql() {
+ public SpiCallableSql callableSql() {
return callableSql;
}
@@ -97,13 +92,11 @@ public final class PersistRequestCallableSql extends PersistRequest {
// register table modifications with the transaction event
TransactionEventTable tableEvents = callableSql.getTransactionEventTable();
-
if (tableEvents != null && !tableEvents.isEmpty()) {
transaction.getEvent().add(tableEvents);
} else {
transaction.markNotQueryOnly();
}
-
}
/**
@@ -120,7 +113,6 @@ public final class PersistRequestCallableSql extends PersistRequest {
* Execute the statement in normal non batch mode.
*/
public int executeUpdate() throws SQLException {
-
// check to see if the execution has been overridden
// only works in non-batch mode
if (callableSql.executeOverride(cstmt)) {
@@ -129,20 +121,15 @@ public final class PersistRequestCallableSql extends PersistRequest {
// rowCount = callableSql.getRowCount();
// return rowCount;
}
-
rowCount = cstmt.executeUpdate();
-
// only read in non-batch mode
readOutParams();
-
return rowCount;
}
private void readOutParams() throws SQLException {
-
List list = bindParam.positionedParameters();
int pos = 0;
-
for (Param param : list) {
pos++;
if (param.isOutParam()) {
@@ -151,5 +138,4 @@ public final class PersistRequestCallableSql extends PersistRequest {
}
}
}
-
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestOrmUpdate.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestOrmUpdate.java
index 807feadd8..0ada82876 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestOrmUpdate.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestOrmUpdate.java
@@ -14,19 +14,11 @@ import io.ebeaninternal.server.persist.PersistExecute;
public final class PersistRequestOrmUpdate extends PersistRequest {
private final BeanDescriptor> beanDescriptor;
-
private final SpiUpdate> ormUpdate;
-
private int rowCount;
-
private String bindLog;
- /**
- * Create.
- */
- public PersistRequestOrmUpdate(SpiEbeanServer server, BeanManager> mgr, SpiUpdate> ormUpdate,
- SpiTransaction t, PersistExecute persistExecute) {
-
+ public PersistRequestOrmUpdate(SpiEbeanServer server, BeanManager> mgr, SpiUpdate> ormUpdate, SpiTransaction t, PersistExecute persistExecute) {
super(server, t, persistExecute, ormUpdate.getLabel());
this.beanDescriptor = mgr.getBeanDescriptor();
this.ormUpdate = ormUpdate;
@@ -37,7 +29,7 @@ public final class PersistRequestOrmUpdate extends PersistRequest {
profileBase(EVT_ORMUPDATE, offset, beanDescriptor.getName(), flushCount);
}
- public BeanDescriptor> getBeanDescriptor() {
+ public BeanDescriptor> descriptor() {
return beanDescriptor;
}
@@ -51,11 +43,10 @@ public final class PersistRequestOrmUpdate extends PersistRequest {
return executeStatement();
}
-
/**
* Return the UpdateSql.
*/
- public SpiUpdate> getOrmUpdate() {
+ public SpiUpdate> ormUpdate() {
return ormUpdate;
}
@@ -91,14 +82,11 @@ public final class PersistRequestOrmUpdate extends PersistRequest {
}
OrmUpdateType ormUpdateType = ormUpdate.getOrmUpdateType();
String tableName = ormUpdate.getBaseTable();
-
if (transaction.isLogSummary()) {
String m = ormUpdateType + " table[" + tableName + "] rows[" + rowCount + "] bind[" + bindLog + "]";
transaction.logSummary(m);
}
-
if (ormUpdate.isNotifyCache()) {
-
// add the modification info to the TransactionEvent
// this is used to invalidate cached objects etc
switch (ormUpdateType) {
@@ -116,5 +104,4 @@ public final class PersistRequestOrmUpdate extends PersistRequest {
}
}
}
-
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestUpdateSql.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestUpdateSql.java
index ae16bbd4b..63f31434a 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestUpdateSql.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestUpdateSql.java
@@ -18,25 +18,17 @@ public final class PersistRequestUpdateSql extends PersistRequest {
}
private final SpiSqlUpdate updateSql;
-
private int rowCount;
-
private String bindLog;
-
private SqlType sqlType;
-
private String tableName;
-
private boolean addBatch;
-
private final boolean forceNoBatch;
-
private boolean batchThisRequest;
private boolean flushQueue;
public PersistRequestUpdateSql(SpiEbeanServer server, SpiSqlUpdate sqlUpdate,
SpiTransaction t, PersistExecute persistExecute, boolean forceNoBatch) {
-
super(server, t, persistExecute, sqlUpdate.getLabel());
this.type = Type.UPDATESQL;
this.updateSql = sqlUpdate;
@@ -105,7 +97,7 @@ public final class PersistRequestUpdateSql extends PersistRequest {
/**
* Return the UpdateSql.
*/
- public SpiSqlUpdate getUpdateSql() {
+ public SpiSqlUpdate updateSql() {
return updateSql;
}
@@ -171,7 +163,6 @@ public final class PersistRequestUpdateSql extends PersistRequest {
if (transaction.isLogSql() && !batchThisRequest) {
transaction.logSql(Str.add(TrimLogSql.trim(updateSql.getGeneratedSql()), "; -- bind(", bindLog, ") rows(", String.valueOf(rowCount), ")"));
}
-
if (updateSql.isAutoTableMod()) {
// add the modification info to the TransactionEvent
// this is used to invalidate cached objects etc
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/SpiOrmQueryRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/SpiOrmQueryRequest.java
index ea59c48da..3c7139476 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/SpiOrmQueryRequest.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/SpiOrmQueryRequest.java
@@ -27,7 +27,7 @@ public interface SpiOrmQueryRequest extends BeanQueryRequest, DocQueryRequ
/**
* Return the associated BeanDescriptor.
*/
- BeanDescriptor getBeanDescriptor();
+ BeanDescriptor descriptor();
/**
* Prepare the query for execution.
@@ -145,12 +145,12 @@ public interface SpiOrmQueryRequest extends BeanQueryRequest, DocQueryRequ
/**
* Return the bean cache hits (when all hits / no misses).
*/
- List getBeanCacheHits();
+ List beanCacheHits();
/**
* Return the bean cache hits for findMap (when all hits / no misses).
*/
- Map getBeanCacheHitsAsMap();
+ Map beanCacheHitsAsMap();
/**
* Reset Bean cache mode AUTO - require explicit setting for bean cache use with findList().
@@ -160,7 +160,7 @@ public interface SpiOrmQueryRequest extends BeanQueryRequest, DocQueryRequ
/**
* Return the Database platform like clause.
*/
- String getDBLikeClause(boolean rawLikeExpression);
+ String dbLikeClause(boolean rawLikeExpression);
/**
* Escapes a string to use it as exact match in Like clause.
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanCollectionHelpFactory.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanCollectionHelpFactory.java
index f4bf3a328..209767fc6 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanCollectionHelpFactory.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanCollectionHelpFactory.java
@@ -44,7 +44,7 @@ public final class BeanCollectionHelpFactory {
return SET_HELP;
} else if (manyType == SpiQuery.Type.MAP) {
- BeanDescriptor target = request.getBeanDescriptor();
+ BeanDescriptor target = request.descriptor();
ElPropertyValue elProperty = target.getElGetValue(request.query().getMapKey());
return new BeanMapQueryHelp<>(elProperty);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
index 42b5aebe6..66610694b 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
@@ -799,7 +799,7 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType {
* Return the bean change for a delete.
*/
private BeanChange deleteBeanChange(PersistRequestBean request) {
- return beanChange(ChangeType.DELETE, request.getBeanId(), null, null);
+ return beanChange(ChangeType.DELETE, request.beanId(), null, null);
}
/**
@@ -808,9 +808,9 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType {
private BeanChange updateBeanChange(PersistRequestBean request) {
try {
BeanChangeJson changeJson = new BeanChangeJson(this, request.isStatelessUpdate());
- request.getEntityBeanIntercept().addDirtyPropertyValues(changeJson);
+ request.intercept().addDirtyPropertyValues(changeJson);
changeJson.flush();
- return beanChange(ChangeType.UPDATE, request.getBeanId(), changeJson.newJson(), changeJson.oldJson());
+ return beanChange(ChangeType.UPDATE, request.beanId(), changeJson.newJson(), changeJson.oldJson());
} catch (RuntimeException e) {
logger.error("Failed to write ChangeLog entry for update", e);
return null;
@@ -824,9 +824,9 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType {
try {
StringWriter writer = new StringWriter(200);
SpiJsonWriter jsonWriter = createJsonWriter(writer);
- jsonWriteForInsert(jsonWriter, request.getEntityBean());
+ jsonWriteForInsert(jsonWriter, request.entityBean());
jsonWriter.flush();
- return beanChange(ChangeType.INSERT, request.getBeanId(), writer.toString(), null);
+ return beanChange(ChangeType.INSERT, request.beanId(), writer.toString(), null);
} catch (IOException e) {
logger.error("Failed to write ChangeLog entry for insert", e);
return null;
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
index d2c95d76c..6eceddca4 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
@@ -803,7 +803,7 @@ final class BeanDescriptorCacheHelp {
if (beanCache != null) {
changeSet.addBeanRemove(desc, id);
}
- cacheDeleteImported(true, deleteRequest.getEntityBean(), changeSet);
+ cacheDeleteImported(true, deleteRequest.entityBean(), changeSet);
}
}
@@ -815,7 +815,7 @@ final class BeanDescriptorCacheHelp {
changeSet.addInvalidate(desc);
} else {
queryCacheClear(changeSet);
- cacheDeleteImported(false, insertRequest.getEntityBean(), changeSet);
+ cacheDeleteImported(false, insertRequest.entityBean(), changeSet);
changeSet.addBeanInsert(desc.getBaseTable());
}
}
@@ -839,10 +839,10 @@ final class BeanDescriptorCacheHelp {
// query caching only
return;
}
- List> manyCollections = updateRequest.getUpdatedManyForL2Cache();
+ List> manyCollections = updateRequest.updatedManyForL2Cache();
if (manyCollections != null) {
for (BeanPropertyAssocMany> many : manyCollections) {
- Object details = many.getValue(updateRequest.getEntityBean());
+ Object details = many.getValue(updateRequest.entityBean());
CachedManyIds entry = createManyIds(many, details);
if (entry != null) {
changeSet.addManyPut(desc, many.getName(), id, entry);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/expression/DefaultExpressionRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/expression/DefaultExpressionRequest.java
index 09ff401af..89273c230 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/expression/DefaultExpressionRequest.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/expression/DefaultExpressionRequest.java
@@ -28,7 +28,7 @@ public final class DefaultExpressionRequest implements SpiExpressionRequest {
public DefaultExpressionRequest(SpiOrmQueryRequest> queryRequest, DeployParser deployParser, Binder binder, SpiExpressionList> expressionList) {
this.queryRequest = queryRequest;
- this.beanDescriptor = queryRequest.getBeanDescriptor();
+ this.beanDescriptor = queryRequest.descriptor();
this.deployParser = deployParser;
this.binder = binder;
this.expressionList = expressionList;
@@ -84,7 +84,7 @@ public final class DefaultExpressionRequest implements SpiExpressionRequest {
@Override
public void appendLike(boolean rawLikeExpression) {
sql.append(" ");
- sql.append(queryRequest.getDBLikeClause(rawLikeExpression));
+ sql.append(queryRequest.dbLikeClause(rawLikeExpression));
sql.append(" ");
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/loadcontext/DLoadContext.java b/ebean-core/src/main/java/io/ebeaninternal/server/loadcontext/DLoadContext.java
index b42049e87..3bfba1459 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/loadcontext/DLoadContext.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/loadcontext/DLoadContext.java
@@ -91,11 +91,11 @@ public final class DLoadContext implements LoadContext {
}
public DLoadContext(OrmQueryRequest> request, SpiQuerySecondary secondaryQueries) {
- this.tenantId = request.getTenantId();
- this.persistenceContext = request.getPersistenceContext();
+ this.tenantId = request.tenantId();
+ this.persistenceContext = request.persistenceContext();
this.ebeanServer = request.server();
- this.defaultBatchSize = request.getLazyLoadBatchSize();
- this.rootDescriptor = request.getBeanDescriptor();
+ this.defaultBatchSize = request.lazyLoadBatchSize();
+ this.rootDescriptor = request.descriptor();
SpiQuery> query = request.query();
this.useDocStore = query.isUseDocStore();
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/BatchControl.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/BatchControl.java
index f276bb331..c2a2c834c 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/BatchControl.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/BatchControl.java
@@ -181,7 +181,7 @@ public final class BatchControl {
* Add the request to the batch and return true if we should flush.
*/
private boolean addToBatch(PersistRequestBean> request) {
- Object alreadyInBatch = persistedBeans.put(request.getEntityBean(), DUMMY);
+ Object alreadyInBatch = persistedBeans.put(request.entityBean(), DUMMY);
if (alreadyInBatch != null) {
// special case where the same bean instance has already been
// added to the batch (doesn't really occur with non-batching
@@ -345,7 +345,7 @@ public final class BatchControl {
private BatchedBeanHolder getBeanHolder(PersistRequestBean> request) {
int depth = transaction.depth();
- BeanDescriptor> desc = request.getBeanDescriptor();
+ BeanDescriptor> desc = request.descriptor();
// batching by bean type AND depth
String key = desc.rootName() + ":" + depth;
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java
index 5270ea8ca..fa877ae90 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java
@@ -906,11 +906,11 @@ public final class DefaultPersister implements Persister {
*/
private void saveAssocMany(PersistRequestBean> request) {
- EntityBean parentBean = request.getEntityBean();
- BeanDescriptor> desc = request.getBeanDescriptor();
+ EntityBean parentBean = request.entityBean();
+ BeanDescriptor> desc = request.descriptor();
SpiTransaction t = request.transaction();
- EntityBean orphanForRemoval = request.getImportedOrphanForRemoval();
+ EntityBean orphanForRemoval = request.importedOrphanForRemoval();
if (orphanForRemoval != null) {
delete(orphanForRemoval, request.transaction(), true);
}
@@ -924,7 +924,7 @@ public final class DefaultPersister implements Persister {
if (!prop.isSaveRecurseSkippable(detailBean)) {
t.depth(+1);
prop.setParentBeanToChild(parentBean, detailBean);
- saveRecurse(detailBean, t, parentBean, request.getFlags());
+ saveRecurse(detailBean, t, parentBean, request.flags());
t.depth(-1);
}
}
@@ -980,8 +980,8 @@ public final class DefaultPersister implements Persister {
SpiTransaction t = request.transaction();
t.depth(-1);
- BeanDescriptor> desc = request.getBeanDescriptor();
- EntityBean parentBean = request.getEntityBean();
+ BeanDescriptor> desc = request.descriptor();
+ EntityBean parentBean = request.entityBean();
DeleteMode deleteMode = request.deleteMode();
BeanPropertyAssocOne>[] expOnes = desc.propertiesOneExportedDelete();
@@ -1107,7 +1107,7 @@ public final class DefaultPersister implements Persister {
*/
private void saveAssocOne(PersistRequestBean> request) {
- BeanDescriptor> desc = request.getBeanDescriptor();
+ BeanDescriptor> desc = request.descriptor();
// imported ones with save cascade
for (BeanPropertyAssocOne> prop : desc.propertiesOneImportedSave()) {
@@ -1117,14 +1117,14 @@ public final class DefaultPersister implements Persister {
}
if (request.isLoadedProperty(prop)) {
- EntityBean detailBean = prop.getValueAsEntityBean(request.getEntityBean());
+ EntityBean detailBean = prop.getValueAsEntityBean(request.entityBean());
if (detailBean != null
&& !prop.isSaveRecurseSkippable(detailBean)
&& !prop.isReference(detailBean)
&& !request.isParent(detailBean)) {
SpiTransaction t = request.transaction();
t.depth(-1);
- saveRecurse(detailBean, t, null, request.getFlags());
+ saveRecurse(detailBean, t, null, request.flags());
t.depth(+1);
}
}
@@ -1152,7 +1152,7 @@ public final class DefaultPersister implements Persister {
DeleteUnloadedForeignKeys fkeys = null;
- for (BeanPropertyAssocOne> one : request.getBeanDescriptor().propertiesOneImportedDelete()) {
+ for (BeanPropertyAssocOne> one : request.descriptor().propertiesOneImportedDelete()) {
if (!request.isLoadedProperty(one)) {
// we have cascade Delete on a partially populated bean and
// this property was not loaded (so we are going to have to fetch it)
@@ -1173,10 +1173,10 @@ public final class DefaultPersister implements Persister {
DeleteMode deleteMode = request.deleteMode();
- for (BeanPropertyAssocOne> prop : request.getBeanDescriptor().propertiesOneImportedDelete()) {
+ for (BeanPropertyAssocOne> prop : request.descriptor().propertiesOneImportedDelete()) {
if (deleteMode.isHard() || prop.isTargetSoftDelete()) {
if (request.isLoadedProperty(prop)) {
- Object detailBean = prop.getValue(request.getEntityBean());
+ Object detailBean = prop.getValue(request.entityBean());
if (detailBean != null) {
EntityBean detail = (EntityBean) detailBean;
if (prop.hasId(detail)) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/DeleteUnloadedForeignKeys.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/DeleteUnloadedForeignKeys.java
index e5d8c5877..ed183afaf 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/DeleteUnloadedForeignKeys.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/DeleteUnloadedForeignKeys.java
@@ -49,10 +49,10 @@ final class DeleteUnloadedForeignKeys {
*/
void queryForeignKeys() {
- BeanDescriptor> descriptor = request.getBeanDescriptor();
+ BeanDescriptor> descriptor = request.descriptor();
SpiQuery> q = (SpiQuery>) server.createQuery(descriptor.getBeanType());
- Object id = request.getBeanId();
+ Object id = request.beanId();
StringBuilder sb = new StringBuilder(30);
for (BeanPropertyAssocOne> aPropList : propList) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeCallableSql.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeCallableSql.java
index f4cbacb42..150e02050 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeCallableSql.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeCallableSql.java
@@ -56,7 +56,7 @@ final class ExeCallableSql {
private CallableStatement bindStmt(PersistRequestCallableSql request, boolean batchThisRequest) throws SQLException {
request.startBind(batchThisRequest);
- SpiCallableSql callableSql = request.getCallableSql();
+ SpiCallableSql callableSql = request.callableSql();
SpiTransaction t = request.transaction();
String sql = callableSql.getSql();
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeOrmUpdate.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeOrmUpdate.java
index 9b1edb8d9..d6839adca 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeOrmUpdate.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeOrmUpdate.java
@@ -38,7 +38,7 @@ final class ExeOrmUpdate {
// return -1 to indicate batch mode
return -1;
} else {
- SpiUpdate> ormUpdate = request.getOrmUpdate();
+ SpiUpdate> ormUpdate = request.ormUpdate();
if (ormUpdate.getTimeout() > 0) {
pstmt.setQueryTimeout(ormUpdate.getTimeout());
}
@@ -49,7 +49,7 @@ final class ExeOrmUpdate {
}
} catch (SQLException ex) {
- throw new PersistenceException("Error executing: " + request.getOrmUpdate().getGeneratedSql(), ex);
+ throw new PersistenceException("Error executing: " + request.ormUpdate().getGeneratedSql(), ex);
} finally {
if (!batchThisRequest) {
@@ -62,13 +62,13 @@ final class ExeOrmUpdate {
* Convert bean and property names to db table and columns.
*/
private String translate(PersistRequestOrmUpdate request, String sql) {
- BeanDescriptor> descriptor = request.getBeanDescriptor();
+ BeanDescriptor> descriptor = request.descriptor();
return descriptor.convertOrmUpdateToSql(sql);
}
private PreparedStatement bindStmt(PersistRequestOrmUpdate request, boolean batchThisRequest) throws SQLException {
request.startBind(batchThisRequest);
- SpiUpdate> ormUpdate = request.getOrmUpdate();
+ SpiUpdate> ormUpdate = request.ormUpdate();
SpiTransaction t = request.transaction();
String sql = ormUpdate.getUpdateStatement();
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeUpdateSql.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeUpdateSql.java
index 5c8e838de..2261c81b2 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeUpdateSql.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/ExeUpdateSql.java
@@ -74,7 +74,7 @@ final class ExeUpdateSql {
private PreparedStatement bindStmt(PersistRequestUpdateSql request, boolean batchThisRequest) throws SQLException {
request.startBind(batchThisRequest);
- SpiSqlUpdate updateSql = request.getUpdateSql();
+ SpiSqlUpdate updateSql = request.updateSql();
SpiTransaction t = request.transaction();
BindParams bindParams = updateSql.getBindParams();
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBase.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBase.java
index 9353ebd31..130ce23e3 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBase.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBase.java
@@ -49,7 +49,7 @@ abstract class SaveManyBase implements SaveMany {
final void preElementCollectionUpdate() {
if (!insertedParent) {
request.preElementCollectionUpdate();
- persister.addToFlushQueue(many.deleteByParentId(request.getBeanId(), null), transaction, 1);
+ persister.addToFlushQueue(many.deleteByParentId(request.beanId(), null), transaction, 1);
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBeans.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBeans.java
index e48a7dd9d..6e842863e 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBeans.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyBeans.java
@@ -186,7 +186,7 @@ public final class SaveManyBeans extends SaveManyBase {
}
if (!skipSavingThisBean) {
- persister.saveRecurse(detail, transaction, parentBean, request.getFlags());
+ persister.saveRecurse(detail, transaction, parentBean, request.flags());
if (many.hasOrderColumn()) {
// Clear the bean from the PersistenceContext (L1 cache), because the order of referenced beans might have changed
final BeanDescriptor> beanDescriptor = many.getBeanDescriptor();
@@ -344,7 +344,7 @@ public final class SaveManyBeans extends SaveManyBase {
}
if (!(value instanceof BeanCollection>)) {
if (!insertedParent && cascade && isChangedProperty()) {
- persister.addToFlushQueue(many.deleteByParentId(request.getBeanId(), null), transaction, 0);
+ persister.addToFlushQueue(many.deleteByParentId(request.beanId(), null), transaction, 0);
}
} else {
BeanCollection> c = (BeanCollection>) value;
@@ -363,7 +363,7 @@ public final class SaveManyBeans extends SaveManyBase {
EntityBean eb = (EntityBean) removedBean;
if (eb._ebean_intercept().isOrphanDelete()) {
// only delete if the bean was loaded meaning that it is known to exist in the DB
- persister.deleteRequest(persister.createDeleteRemoved(removedBean, transaction, request.getFlags()));
+ persister.deleteRequest(persister.createDeleteRemoved(removedBean, transaction, request.flags()));
}
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyElementCollection.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyElementCollection.java
index 8b577da93..874505b83 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyElementCollection.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyElementCollection.java
@@ -43,7 +43,7 @@ final class SaveManyElementCollection extends SaveManyBase {
private void saveCollection() {
SpiSqlUpdate proto = many.insertElementCollection();
- Object parentId = request.getBeanId();
+ Object parentId = request.beanId();
for (Object value : collection) {
final SpiSqlUpdate sqlInsert = proto.copy();
sqlInsert.setParameter(parentId);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyElementCollectionMap.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyElementCollectionMap.java
index 2941a1499..f57a44d3d 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyElementCollectionMap.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/SaveManyElementCollectionMap.java
@@ -45,7 +45,7 @@ final class SaveManyElementCollectionMap extends SaveManyBase {
private void saveCollection() {
SpiSqlUpdate proto = many.insertElementCollection();
- Object parentId = request.getBeanId();
+ Object parentId = request.beanId();
for (Map.Entry, ?> entry : entries) {
final SpiSqlUpdate sqlInsert = proto.copy();
sqlInsert.setParameter(parentId);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DeleteMeta.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DeleteMeta.java
index 7baac04ab..78f653af3 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DeleteMeta.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DeleteMeta.java
@@ -40,13 +40,13 @@ final class DeleteMeta extends BaseMeta {
* Bind the request based on the concurrency mode.
*/
public void bind(PersistRequestBean> persist, DmlHandler bind) throws SQLException {
- EntityBean bean = persist.getEntityBean();
+ EntityBean bean = persist.entityBean();
id.dmlBind(bind, bean);
if (tenantId != null) {
tenantId.dmlBind(bind, bean);
}
- if (persist.getConcurrencyMode() == ConcurrencyMode.VERSION) {
+ if (persist.concurrencyMode() == ConcurrencyMode.VERSION) {
version.dmlBind(bind, bean);
}
}
@@ -56,11 +56,11 @@ final class DeleteMeta extends BaseMeta {
*/
public String getSql(PersistRequestBean> request) {
if (id.isEmpty()) {
- throw new IllegalStateException("Can not deleteById on " + request.getFullName() + " as no @Id property");
+ throw new IllegalStateException("Can not deleteById on " + request.fullName() + " as no @Id property");
}
boolean publish = request.isPublish();
- switch (request.getConcurrencyMode()) {
+ switch (request.concurrencyMode()) {
case NONE:
return publish ? sqlNone : sqlDraftNone;
@@ -68,7 +68,7 @@ final class DeleteMeta extends BaseMeta {
return publish ? sqlVersion : sqlDraftVersion;
default:
- throw new RuntimeException("Invalid mode " + request.getConcurrencyMode());
+ throw new RuntimeException("Invalid mode " + request.concurrencyMode());
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DocStoreBeanPersister.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DocStoreBeanPersister.java
index 9b9a9c2cf..b805da26e 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DocStoreBeanPersister.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/DocStoreBeanPersister.java
@@ -19,13 +19,13 @@ final class DocStoreBeanPersister implements BeanPersister {
@Override
public void insert(PersistRequestBean> request) throws PersistenceException {
//request.setIdValueForDocStore();
- generatedProperties.preInsert(request.getEntityBean(), request.now());
+ generatedProperties.preInsert(request.entityBean(), request.now());
request.docStorePersist();
}
@Override
public void update(PersistRequestBean> request) throws PersistenceException {
- generatedProperties.preUpdate(request.getEntityBean(), request.now());
+ generatedProperties.preUpdate(request.entityBean(), request.now());
request.docStorePersist();
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/InsertHandler.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/InsertHandler.java
index f981679e6..0e6d6ff80 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/InsertHandler.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/InsertHandler.java
@@ -47,8 +47,8 @@ public final class InsertHandler extends DmlHandler {
*/
@Override
public void bind() throws SQLException {
- BeanDescriptor> desc = persistRequest.getBeanDescriptor();
- EntityBean bean = persistRequest.getEntityBean();
+ BeanDescriptor> desc = persistRequest.descriptor();
+ EntityBean bean = persistRequest.entityBean();
Object idValue = desc.getId(bean);
boolean withId = !isNullOrZero(idValue);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/UpdateMeta.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/UpdateMeta.java
index 4b667e521..d2c511a50 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/UpdateMeta.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dml/UpdateMeta.java
@@ -30,13 +30,13 @@ final class UpdateMeta extends BaseMeta {
* Bind the request based on the concurrency mode.
*/
public void bind(PersistRequestBean> persist, DmlHandler bind, SpiUpdatePlan updatePlan) throws SQLException {
- EntityBean bean = persist.getEntityBean();
+ EntityBean bean = persist.entityBean();
updatePlan.bindSet(bind, bean);
id.dmlBind(bind, bean);
if (tenantId != null) {
tenantId.dmlBind(bind, bean);
}
- if (persist.getConcurrencyMode() == ConcurrencyMode.VERSION) {
+ if (persist.concurrencyMode() == ConcurrencyMode.VERSION) {
version.dmlBind(bind, bean);
}
}
@@ -49,9 +49,9 @@ final class UpdateMeta extends BaseMeta {
}
private SpiUpdatePlan getDynamicUpdatePlan(PersistRequestBean> persistRequest) {
- String key = persistRequest.getUpdatePlanHash();
+ String key = persistRequest.updatePlanHash();
// check if we can use a cached UpdatePlan
- BeanDescriptor> beanDescriptor = persistRequest.getBeanDescriptor();
+ BeanDescriptor> beanDescriptor = persistRequest.descriptor();
SpiUpdatePlan updatePlan = beanDescriptor.getUpdatePlan(key);
if (updatePlan != null) {
return updatePlan;
@@ -64,9 +64,9 @@ final class UpdateMeta extends BaseMeta {
set.addToUpdate(persistRequest, list);
BindableList bindableList = new BindableList(list);
- ConcurrencyMode mode = persistRequest.getConcurrencyMode();
+ ConcurrencyMode mode = persistRequest.concurrencyMode();
// build the SQL for this update statement
- String sql = genSql(mode, bindableList, persistRequest.getUpdateTable());
+ String sql = genSql(mode, bindableList, persistRequest.updateTable());
updatePlan = new UpdatePlan(key, mode, sql, bindableList);
// add the UpdatePlan to the cache
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableIdEmbedded.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableIdEmbedded.java
index 1f094b0c5..a62135f46 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableIdEmbedded.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableIdEmbedded.java
@@ -90,7 +90,7 @@ final class BindableIdEmbedded implements BindableId {
throw new PersistenceException(m);
}
- EntityBean bean = persist.getEntityBean();
+ EntityBean bean = persist.entityBean();
// create the new id
EntityBean newId = (EntityBean) embId.createEmbeddedId();
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableOrderColumn.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableOrderColumn.java
index 7879d192c..7f3e44e0c 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableOrderColumn.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableOrderColumn.java
@@ -18,7 +18,7 @@ public final class BindableOrderColumn extends BindableProperty {
@Override
public void addToUpdate(PersistRequestBean> request, List list) {
- int sortOrder = request.getEntityBeanIntercept().getSortOrder();
+ int sortOrder = request.intercept().getSortOrder();
if (sortOrder > 0) {
list.add(this);
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableUnidirectional.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableUnidirectional.java
index 2ea853644..768fd380d 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableUnidirectional.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableUnidirectional.java
@@ -54,7 +54,7 @@ public final class BindableUnidirectional implements Bindable {
@Override
public void dmlBind(BindableRequest request, EntityBean bean) throws SQLException {
PersistRequestBean> persistRequest = request.getPersistRequest();
- Object parentBean = persistRequest.getParentBean();
+ Object parentBean = persistRequest.parentBean();
if (parentBean == null) {
Class> localType = desc.getBeanType();
Class> targetType = unidirectional.getTargetType();
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQuery.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQuery.java
index 54cb75c8a..c517341e9 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQuery.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQuery.java
@@ -202,7 +202,7 @@ public final class CQuery implements DbReadContext, CancelableQuery, SpiProfi
this.sql = queryPlan.getSql();
this.rawSql = queryPlan.isRawSql();
this.logWhereSql = queryPlan.getLogWhereSql();
- this.desc = request.getBeanDescriptor();
+ this.desc = request.descriptor();
this.predicates = predicates;
if (lazyLoadManyProperty != null) {
this.help = NOOP_ADD;
@@ -370,7 +370,7 @@ public final class CQuery implements DbReadContext, CancelableQuery, SpiProfi
*/
@Override
public PersistenceContext getPersistenceContext() {
- return request.getPersistenceContext();
+ return request.persistenceContext();
}
@Override
@@ -586,19 +586,19 @@ public final class CQuery implements DbReadContext, CancelableQuery, SpiProfi
@Override
public void registerBeanInherit(BeanPropertyAssocOne> property, EntityBeanIntercept ebi) {
String path = getPath(property.getName());
- request.getGraphContext().register(path, ebi, property);
+ request.loadContext().register(path, ebi, property);
}
@Override
public void register(String path, EntityBeanIntercept ebi) {
path = getPath(path);
- request.getGraphContext().register(path, ebi);
+ request.loadContext().register(path, ebi);
}
@Override
public void register(BeanPropertyAssocMany> many, BeanCollection> bc) {
String path = getPath(many.getName());
- request.getGraphContext().register(path, many, bc);
+ request.loadContext().register(path, many, bc);
}
/**
@@ -683,7 +683,7 @@ public final class CQuery implements DbReadContext, CancelableQuery, SpiProfi
@Override
public void profileBean(EntityBeanIntercept ebi, String prefix) {
- ObjectGraphNode node = request.getGraphContext().getObjectGraphNode(prefix);
+ ObjectGraphNode node = request.loadContext().getObjectGraphNode(prefix);
ebi.setNodeUsageCollector(new NodeUsageCollector(node, profilingListenerRef));
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryBuilder.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryBuilder.java
index ca600f46c..709653a30 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryBuilder.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryBuilder.java
@@ -93,7 +93,7 @@ final class CQueryBuilder {
query.setupForDeleteOrUpdate();
CQueryPredicates predicates = new CQueryPredicates(binder, request);
- CQueryPlan queryPlan = request.getQueryPlan();
+ CQueryPlan queryPlan = request.queryPlan();
if (queryPlan != null) {
// skip building the SqlTree and Sql string
predicates.prepare(false);
@@ -130,7 +130,7 @@ final class CQueryBuilder {
}
// wrap as - delete from table where id in (select id ...)
String sql = buildSqlDelete(null, request, predicates, sqlTree).getSql();
- sql = request.getBeanDescriptor().getDeleteByIdInSql() + "in (" + sql + ")";
+ sql = request.descriptor().getDeleteByIdInSql() + "in (" + sql + ")";
sql = aliasReplace(sql, alias);
return sql;
}
@@ -145,7 +145,7 @@ final class CQueryBuilder {
private String buildUpdateSql(OrmQueryRequest request, String rootTableAlias, CQueryPredicates predicates, SqlTree sqlTree) {
StringBuilder sb = new StringBuilder(200);
- sb.append("update ").append(request.getBeanDescriptor().getBaseTable());
+ sb.append("update ").append(request.descriptor().getBaseTable());
if (rootTableAlias != null) {
sb.append(" ").append(rootTableAlias);
}
@@ -157,7 +157,7 @@ final class CQueryBuilder {
}
// wrap as - update table set ... where id in (select id ...)
String sql = buildSqlUpdate(null, request, predicates, sqlTree).getSql();
- sql = updateClause + " " + request.getBeanDescriptor().getWhereIdInSql() + "in (" + sql + ")";
+ sql = updateClause + " " + request.descriptor().getWhereIdInSql() + "in (" + sql + ")";
sql = aliasReplace(sql, alias(rootTableAlias));
return sql;
}
@@ -180,14 +180,14 @@ final class CQueryBuilder {
SpiQuery> query = request.query();
query.setSingleAttribute();
if (!query.isIncludeSoftDeletes()) {
- BeanDescriptor> desc = request.getBeanDescriptor();
+ BeanDescriptor> desc = request.descriptor();
if (desc.isSoftDelete()) {
query.addSoftDeletePredicate(desc.getSoftDeletePredicate(alias(query.getAlias())));
}
}
CQueryPredicates predicates = new CQueryPredicates(binder, request);
- CQueryPlan queryPlan = request.getQueryPlan();
+ CQueryPlan queryPlan = request.queryPlan();
if (queryPlan != null) {
predicates.prepare(false);
return new CQueryFetchSingleAttribute(request, predicates, queryPlan, query.isCountDistinct());
@@ -210,7 +210,7 @@ final class CQueryBuilder {
CQueryFetchSingleAttribute buildFetchIdsQuery(OrmQueryRequest request) {
SpiQuery query = request.query();
query.setSelectId();
- BeanDescriptor desc = request.getBeanDescriptor();
+ BeanDescriptor desc = request.descriptor();
if (!query.isIncludeSoftDeletes() && desc.isSoftDelete()) {
query.addSoftDeletePredicate(desc.getSoftDeletePredicate(alias(query.getAlias())));
}
@@ -252,7 +252,7 @@ final class CQueryBuilder {
}
CQueryPredicates predicates = new CQueryPredicates(binder, request);
- CQueryPlan queryPlan = request.getQueryPlan();
+ CQueryPlan queryPlan = request.queryPlan();
if (queryPlan != null) {
// skip building the SqlTree and Sql string
predicates.prepare(false);
@@ -304,7 +304,7 @@ final class CQueryBuilder {
* Return true if the query includes an aggregation property.
*/
private boolean includesAggregation(OrmQueryRequest request, SpiQuery query) {
- return request.getBeanDescriptor().includesAggregation(query.getDetail());
+ return request.descriptor().includesAggregation(query.getDetail());
}
private String wrapSelectCount(String sql) {
@@ -321,7 +321,7 @@ final class CQueryBuilder {
*/
CQuery buildQuery(OrmQueryRequest request) {
CQueryPredicates predicates = new CQueryPredicates(binder, request);
- CQueryPlan queryPlan = request.getQueryPlan();
+ CQueryPlan queryPlan = request.queryPlan();
if (queryPlan != null) {
// Reuse the query plan so skip generating SqlTree and SQL.
// We do prepare and bind the new parameters
@@ -358,7 +358,7 @@ final class CQueryBuilder {
queryPlan = new CQueryPlan(request, res, sqlTree, false, predicates.getLogWhereSql());
}
- BeanDescriptor desc = request.getBeanDescriptor();
+ BeanDescriptor desc = request.descriptor();
if (desc.isReadAuditing()) {
// log the query plan based bean type (i.e. ignoring query disabling for logging the sql/plan)
desc.getReadAuditLogger().queryPlan(new ReadAuditQueryPlan(desc.getFullName(), queryPlan.getAuditQueryKey(), queryPlan.getSql()));
@@ -411,7 +411,7 @@ final class CQueryBuilder {
Connection connection = request.transaction().getConnection();
- BeanDescriptor> desc = request.getBeanDescriptor();
+ BeanDescriptor> desc = request.descriptor();
try {
// For SqlServer we need either "selectMethod=cursor" in the connection string or fetch explicitly a cursorable
// statement here by specifying ResultSet.CONCUR_UPDATABLE
@@ -445,7 +445,7 @@ final class CQueryBuilder {
}
private SqlTree createRawSqlSqlTree(OrmQueryRequest> request, CQueryPredicates predicates) {
- BeanDescriptor> descriptor = request.getBeanDescriptor();
+ BeanDescriptor> descriptor = request.descriptor();
ColumnMapping columnMapping = request.query().getRawSql().getColumnMapping();
PathProperties pathProps = new PathProperties();
@@ -583,7 +583,7 @@ final class CQueryBuilder {
sb.append("r1.attribute_, count(*) from (select ");
if (distinct) {
sb.append("distinct t0.");
- sb.append(request.getBeanDescriptor().getIdProperty().getDbColumn()).append(", ");
+ sb.append(request.descriptor().getIdProperty().getDbColumn()).append(", ");
}
sb.append(select.getSelectSql()).append(" as attribute_");
} else {
@@ -652,7 +652,7 @@ final class CQueryBuilder {
private void appendHistoryAsOfPredicate() {
if (query.isAsOfBaseTable() && !historySupport.isStandardsBased()) {
appendAndOrWhere();
- sb.append(historySupport.getAsOfPredicate(request.getBaseTableAlias()));
+ sb.append(historySupport.getAsOfPredicate(request.baseTableAlias()));
}
}
@@ -660,7 +660,7 @@ final class CQueryBuilder {
if (request.isFindById() || query.getId() != null) {
appendAndOrWhere();
- BeanDescriptor> desc = request.getBeanDescriptor();
+ BeanDescriptor> desc = request.descriptor();
String idSql = desc.getIdBinderIdSql(query.getAlias());
if (idSql.isEmpty()) {
throw new IllegalStateException("Executing FindById query on entity bean " + desc.getName()
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryBuilderRawSql.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryBuilderRawSql.java
index dffcc61b2..a46d571c2 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryBuilderRawSql.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryBuilderRawSql.java
@@ -82,7 +82,7 @@ final class CQueryBuilderRawSql {
// assumption that id has its proper dbColumn assigned
// which may change if using multiple raw sql statements
// against the same bean.
- BeanDescriptor> descriptor = request.getBeanDescriptor();
+ BeanDescriptor> descriptor = request.descriptor();
//FIXME: I think this is broken... needs to be logical
// and then parsed for RawSqlSelect...
dynamicWhere = descriptor.getIdBinderIdSql(null);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryEngine.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryEngine.java
index 1380de179..56142b51d 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryEngine.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryEngine.java
@@ -198,7 +198,7 @@ public final class CQueryEngine {
logSql(cquery);
}
// first check batch sizes set on query joins
- int iterateBufferSize = request.getSecondaryQueriesMinBatchSize();
+ int iterateBufferSize = request.secondaryQueriesMinBatchSize();
if (iterateBufferSize < 1) {
// not set on query joins so check if batch size set on query itself
int queryBatch = request.query().getLazyLoadBatchSize();
@@ -274,7 +274,7 @@ public final class CQueryEngine {
}
private void deriveVersionDiffs(List> versions, OrmQueryRequest request) {
- BeanDescriptor descriptor = request.getBeanDescriptor();
+ BeanDescriptor descriptor = request.descriptor();
if (!versions.isEmpty()) {
Version current = versions.get(0);
if (versions.size() > 1) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryFetchSingleAttribute.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryFetchSingleAttribute.java
index 2f45f1b2e..466f812ed 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryFetchSingleAttribute.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryFetchSingleAttribute.java
@@ -52,7 +52,7 @@ final class CQueryFetchSingleAttribute implements SpiProfileTransactionEvent, Ca
this.queryPlan = queryPlan;
this.query = request.query();
this.sql = queryPlan.getSql();
- this.desc = request.getBeanDescriptor();
+ this.desc = request.descriptor();
this.predicates = predicates;
this.containsCounts = containsCounts;
this.reader = queryPlan.getSingleAttributeScalarType();
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java
index c40fcf939..ba6a3a459 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java
@@ -87,13 +87,13 @@ public class CQueryPlan implements SpiQueryPlan {
CQueryPlan(OrmQueryRequest> request, SqlLimitResponse sqlRes, SqlTree sqlTree, boolean rawSql, String logWhereSql) {
this.server = request.server();
this.dataTimeZone = server.getDataTimeZone();
- this.beanType = request.getBeanDescriptor().getBeanType();
- this.planKey = request.getQueryPlanKey();
+ this.beanType = request.descriptor().getBeanType();
+ this.planKey = request.queryPlanKey();
SpiQuery> query = request.query();
this.profileLocation = query.getProfileLocation();
this.location = (profileLocation == null) ? null : profileLocation.location();
this.label = query.getPlanLabel();
- this.name = deriveName(label, query.getType(), request.getBeanDescriptor().getSimpleName());
+ this.name = deriveName(label, query.getType(), request.descriptor().getSimpleName());
this.asOfTableCount = query.getAsOfTableCount();
this.sql = sqlRes.getSql();
this.sqlTree = sqlTree;
@@ -112,12 +112,12 @@ public class CQueryPlan implements SpiQueryPlan {
CQueryPlan(OrmQueryRequest> request, String sql, SqlTree sqlTree, String logWhereSql) {
this.server = request.server();
this.dataTimeZone = server.getDataTimeZone();
- this.beanType = request.getBeanDescriptor().getBeanType();
+ this.beanType = request.descriptor().getBeanType();
SpiQuery> query = request.query();
this.profileLocation = query.getProfileLocation();
this.location = (profileLocation == null) ? null : profileLocation.location();
this.label = query.getPlanLabel();
- this.name = deriveName(label, query.getType(), request.getBeanDescriptor().getSimpleName());
+ this.name = deriveName(label, query.getType(), request.descriptor().getSimpleName());
this.planKey = buildPlanKey(sql, logWhereSql);
this.asOfTableCount = 0;
this.sql = sql;
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPredicates.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPredicates.java
index 54c94da52..cab8530fa 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPredicates.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPredicates.java
@@ -115,7 +115,7 @@ public final class CQueryPredicates {
dataBind.append(", ");
}
- CQueryPlan queryPlan = request.getQueryPlan();
+ CQueryPlan queryPlan = request.queryPlan();
if (queryPlan != null) {
int asOfTableCount = queryPlan.getAsOfTableCount();
if (asOfTableCount > 0) {
@@ -132,7 +132,7 @@ public final class CQueryPredicates {
if (idValue != null) {
// this is a find by id type query...
- request.getBeanDescriptor().bindId(dataBind, idValue);
+ request.descriptor().bindId(dataBind, idValue);
dataBind.append(idValue);
dataBind.append(", ");
}
@@ -244,7 +244,7 @@ public final class CQueryPredicates {
private void parsePropertiesToDbColumns(DeployParser deployParser) {
// order by is dependent on the manyProperty (if there is one)
- String logicalOrderBy = deriveOrderByWithMany(request.getManyProperty());
+ String logicalOrderBy = deriveOrderByWithMany(request.manyProperty());
if (logicalOrderBy != null) {
dbOrderBy = deployParser.parse(logicalOrderBy);
}
@@ -312,7 +312,7 @@ public final class CQueryPredicates {
if (orderBy == null) {
return null;
}
- return CQueryOrderBy.parse(request.getBeanDescriptor(), orderBy);
+ return CQueryOrderBy.parse(request.descriptor(), orderBy);
}
/**
@@ -327,7 +327,7 @@ public final class CQueryPredicates {
String orderBy = parseOrderBy();
- BeanDescriptor> desc = request.getBeanDescriptor();
+ BeanDescriptor> desc = request.descriptor();
String orderById = desc.getDefaultOrderBy();
if (orderBy == null) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryRowCount.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryRowCount.java
index ac0f9c6f2..78b4093f7 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryRowCount.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryRowCount.java
@@ -43,7 +43,7 @@ final class CQueryRowCount implements SpiProfileTransactionEvent, CancelableQuer
this.request = request;
this.query = request.query();
this.sql = queryPlan.getSql();
- this.desc = request.getBeanDescriptor();
+ this.desc = request.descriptor();
this.predicates = predicates;
query.setGeneratedSql(sql);
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryUpdate.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryUpdate.java
index 2e4e1a871..b49849cfd 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryUpdate.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryUpdate.java
@@ -39,7 +39,7 @@ final class CQueryUpdate implements SpiProfileTransactionEvent, CancelableQuery
this.queryPlan = queryPlan;
this.query = request.query();
this.sql = queryPlan.getSql();
- this.desc = request.getBeanDescriptor();
+ this.desc = request.descriptor();
this.predicates = predicates;
query.setGeneratedSql(sql);
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultOrmQueryEngine.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultOrmQueryEngine.java
index 1b95fc55c..adbeee6d5 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultOrmQueryEngine.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultOrmQueryEngine.java
@@ -121,7 +121,7 @@ public final class DefaultOrmQueryEngine implements OrmQueryEngine {
flushJdbcBatchOnQuery(request);
- BeanFindController finder = request.getBeanFinder();
+ BeanFindController finder = request.finder();
BeanCollection result;
if (finder != null && finder.isInterceptFindMany(request)) {
@@ -135,7 +135,7 @@ public final class DefaultOrmQueryEngine implements OrmQueryEngine {
if (result != null && request.isBeanCachePutMany()) {
// load the individual beans into the bean cache
- BeanDescriptor descriptor = request.getBeanDescriptor();
+ BeanDescriptor descriptor = request.descriptor();
Collection c = result.getActualDetails();
descriptor.cacheBeanPutAll(c);
}
@@ -162,7 +162,7 @@ public final class DefaultOrmQueryEngine implements OrmQueryEngine {
flushJdbcBatchOnQuery(request);
- BeanFindController finder = request.getBeanFinder();
+ BeanFindController finder = request.finder();
T result;
if (finder != null && finder.isInterceptFind(request)) {
@@ -172,7 +172,7 @@ public final class DefaultOrmQueryEngine implements OrmQueryEngine {
}
if (result != null && request.isBeanCachePut()) {
- request.getBeanDescriptor().cacheBeanPut((EntityBean) result);
+ request.descriptor().cacheBeanPut((EntityBean) result);
}
return result;
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/SqlTreeBuilder.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/SqlTreeBuilder.java
index e127726de..f1768bb39 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/SqlTreeBuilder.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/SqlTreeBuilder.java
@@ -59,7 +59,7 @@ public final class SqlTreeBuilder {
*/
SqlTreeBuilder(OrmQueryRequest> request, CQueryPredicates predicates, OrmQueryDetail queryDetail, boolean rawNoId) {
this.rawSql = true;
- this.desc = request.getBeanDescriptor();
+ this.desc = request.descriptor();
this.rawNoId = rawNoId;
this.disableLazyLoad = request.query().isDisableLazyLoading();
this.query = null;
@@ -82,7 +82,7 @@ public final class SqlTreeBuilder {
SqlTreeBuilder(String columnAliasPrefix, CQueryBuilder builder, OrmQueryRequest> request, CQueryPredicates predicates) {
this.rawSql = false;
this.rawNoId = false;
- this.desc = request.getBeanDescriptor();
+ this.desc = request.descriptor();
this.query = request.query();
this.temporalMode = SpiQuery.TemporalMode.of(query);
this.disableLazyLoad = query.isDisableLazyLoading();
@@ -95,7 +95,7 @@ public final class SqlTreeBuilder {
this.manyWhereJoins = query.getManyWhereJoins();
this.queryDetail = query.getDetail();
this.predicates = predicates;
- this.alias = new SqlTreeAlias(request.getBaseTableAlias(), temporalMode);
+ this.alias = new SqlTreeAlias(request.baseTableAlias(), temporalMode);
this.distinctOnPlatform = builder.isPlatformDistinctOn();
String fromForUpdate = builder.fromForUpdate(query);
CQueryHistorySupport historySupport = builder.getHistorySupport(query);
diff --git a/ebean-core/src/main/java/io/ebeanservice/docstore/api/support/DocStoreEmbeddedInvalidation.java b/ebean-core/src/main/java/io/ebeanservice/docstore/api/support/DocStoreEmbeddedInvalidation.java
index 3a8e22403..bbf5ca009 100644
--- a/ebean-core/src/main/java/io/ebeanservice/docstore/api/support/DocStoreEmbeddedInvalidation.java
+++ b/ebean-core/src/main/java/io/ebeanservice/docstore/api/support/DocStoreEmbeddedInvalidation.java
@@ -18,6 +18,6 @@ public class DocStoreEmbeddedInvalidation {
}
public void embeddedInvalidate(PersistRequestBean> request, DocStoreUpdates docStoreUpdates) {
- docStoreUpdates.addNested(queueId, path, request.getBeanId());
+ docStoreUpdates.addNested(queueId, path, request.beanId());
}
}
diff --git a/ebean-core/src/main/java/io/ebeanservice/docstore/api/support/DocStoreEmbeddedInvalidationProperties.java b/ebean-core/src/main/java/io/ebeanservice/docstore/api/support/DocStoreEmbeddedInvalidationProperties.java
index 56b8cf39d..38f93a8a8 100644
--- a/ebean-core/src/main/java/io/ebeanservice/docstore/api/support/DocStoreEmbeddedInvalidationProperties.java
+++ b/ebean-core/src/main/java/io/ebeanservice/docstore/api/support/DocStoreEmbeddedInvalidationProperties.java
@@ -23,7 +23,7 @@ public final class DocStoreEmbeddedInvalidationProperties extends DocStoreEmbedd
@Override
public void embeddedInvalidate(PersistRequestBean> request, DocStoreUpdates docStoreUpdates) {
if (request.hasDirtyProperty(properties)) {
- docStoreUpdates.addNested(queueId, path, request.getBeanId());
+ docStoreUpdates.addNested(queueId, path, request.beanId());
}
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/loadcontext/DLoadContextTest.java b/ebean-core/src/test/java/io/ebeaninternal/server/loadcontext/DLoadContextTest.java
index 4bffce7d8..991198b3e 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/loadcontext/DLoadContextTest.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/loadcontext/DLoadContextTest.java
@@ -28,7 +28,7 @@ public class DLoadContextTest extends BaseTestCase {
queryRequest.initTransIfRequired();
queryRequest.endTransIfRequired();
- DLoadContext graphContext = (DLoadContext) queryRequest.getGraphContext();
+ DLoadContext graphContext = (DLoadContext) queryRequest.loadContext();
DLoadBeanContext customer = graphContext.getBeanContext("customer");
assertThat(customer.batchSize).isEqualTo(10);
@@ -41,7 +41,7 @@ public class DLoadContextTest extends BaseTestCase {
queryRequest.initTransIfRequired();
queryRequest.endTransIfRequired();
- DLoadContext graphContext = (DLoadContext) queryRequest.getGraphContext();
+ DLoadContext graphContext = (DLoadContext) queryRequest.loadContext();
DLoadBeanContext customer = graphContext.getBeanContext("customer");
assertThat(customer.batchSize).isEqualTo(100);
@@ -54,7 +54,7 @@ public class DLoadContextTest extends BaseTestCase {
queryRequest.initTransIfRequired();
queryRequest.endTransIfRequired();
- DLoadContext graphContext = (DLoadContext) queryRequest.getGraphContext();
+ DLoadContext graphContext = (DLoadContext) queryRequest.loadContext();
DLoadBeanContext customer = graphContext.getBeanContext("customer");
assertThat(customer.batchSize).isEqualTo(100);
@@ -67,7 +67,7 @@ public class DLoadContextTest extends BaseTestCase {
queryRequest.initTransIfRequired();
queryRequest.endTransIfRequired();
- DLoadContext graphContext = (DLoadContext) queryRequest.getGraphContext();
+ DLoadContext graphContext = (DLoadContext) queryRequest.loadContext();
DLoadBeanContext customer = graphContext.getBeanContext("customer");
assertThat(customer.batchSize).isEqualTo(50);
@@ -80,7 +80,7 @@ public class DLoadContextTest extends BaseTestCase {
queryRequest.initTransIfRequired();
queryRequest.endTransIfRequired();
- DLoadContext graphContext = (DLoadContext) queryRequest.getGraphContext();
+ DLoadContext graphContext = (DLoadContext) queryRequest.loadContext();
DLoadBeanContext customer = graphContext.getBeanContext("customer");
assertThat(customer.batchSize).isEqualTo(100);
@@ -95,7 +95,7 @@ public class DLoadContextTest extends BaseTestCase {
queryRequest.initTransIfRequired();
queryRequest.endTransIfRequired();
- DLoadContext graphContext = (DLoadContext) queryRequest.getGraphContext();
+ DLoadContext graphContext = (DLoadContext) queryRequest.loadContext();
DLoadManyContext details = graphContext.getManyContext("details", many);
assertThat(details.batchSize).isEqualTo(100);
From d072dd52cf1380e1a30e935272fbdc5dd2535ccc Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Fri, 3 Sep 2021 20:17:12 +1200
Subject: [PATCH 044/102] #2355 - Rename methods in SpiServer with deprecation
---
.../main/java/io/ebean/plugin/SpiServer.java | 60 +++++++++++++++++--
.../changelog/DefaultChangeLogListener.java | 2 +-
.../server/core/DefaultBeanLoader.java | 2 +-
.../server/core/DefaultServer.java | 12 ++--
.../java/io/ebean/plugin/BeanTypeTest.java | 2 +-
.../io/ebean/plugin/ExpressionPathTest.java | 2 +-
.../java/io/ebean/plugin/PropertyTest.java | 2 +-
.../java/io/ebean/plugin/SpiServerTest.java | 10 ++--
.../server/rawsql/TestRawSqlBuilder.java | 4 +-
.../api/support/DocStoreDeleteEventTest.java | 2 +-
.../api/support/DocStoreIndexEventTest.java | 2 +-
.../java/org/tests/ddd/iud/TestDPersonEl.java | 2 +-
.../java/org/tests/el/TestPathExpression.java | 2 +-
.../org/tests/json/TestDbJson_Jackson.java | 4 +-
.../org/tests/json/TestDbJson_Jackson2.java | 2 +-
.../model/embedded/TestEmbeddedManyToOne.java | 2 +-
.../org/tests/query/TestQueryFindIterate.java | 2 +-
.../sqlquery/TestNativeILikeExpression.java | 2 +-
.../text/json/TestTextJsonInvokeLazy.java | 2 +-
.../java/org/tests/types/TestNewTypes.java | 2 +-
.../platform/PlatformDdl_AlterColumnTest.java | 2 +-
.../platform/PlatformDdl_CreateIndexTest.java | 2 +-
22 files changed, 86 insertions(+), 38 deletions(-)
diff --git a/ebean-api/src/main/java/io/ebean/plugin/SpiServer.java b/ebean-api/src/main/java/io/ebean/plugin/SpiServer.java
index 257829a5e..96bf6eed1 100644
--- a/ebean-api/src/main/java/io/ebean/plugin/SpiServer.java
+++ b/ebean-api/src/main/java/io/ebean/plugin/SpiServer.java
@@ -16,32 +16,80 @@ public interface SpiServer extends Database {
/**
* Return the DatabaseConfig.
*/
- DatabaseConfig getServerConfig();
+ DatabaseConfig config();
+
+ /**
+ * Migrate to config().
+ */
+ @Deprecated
+ default DatabaseConfig getServerConfig() {
+ return config();
+ }
/**
* Return the DatabasePlatform for this database.
*/
- DatabasePlatform getDatabasePlatform();
+ DatabasePlatform databasePlatform();
+
+ /**
+ * Migrate to config().
+ */
+ @Deprecated
+ default DatabasePlatform getDatabasePlatform() {
+ return databasePlatform();
+ }
/**
* Return all the bean types registered on this server instance.
*/
- List extends BeanType>> getBeanTypes();
+ List extends BeanType>> beanTypes();
+
+ /**
+ * Migrate to beanTypes().
+ */
+ @Deprecated
+ default List extends BeanType>> getBeanTypes() {
+ return beanTypes();
+ }
/**
* Return the bean type for a given entity bean class.
*/
- BeanType getBeanType(Class beanClass);
+ BeanType beanType(Class beanClass);
+
+ /**
+ * Migrate to beanType().
+ */
+ @Deprecated
+ default BeanType getBeanType(Class beanClass) {
+ return beanType(beanClass);
+ }
/**
* Return the bean types mapped to the given base table.
*/
- List extends BeanType>> getBeanTypes(String baseTableName);
+ List extends BeanType>> beanTypes(String baseTableName);
+
+ /**
+ * Migrate to beanTypes().
+ */
+ @Deprecated
+ default List extends BeanType>> getBeanTypes(String baseTableName) {
+ return beanTypes(baseTableName);
+ }
/**
* Return the bean type for a given doc store queueId.
*/
- BeanType> getBeanTypeForQueueId(String queueId);
+ BeanType> beanTypeForQueueId(String queueId);
+
+ /**
+ * Migrate to beanTypes().
+ */
+ @Deprecated
+ default BeanType> getBeanTypeForQueueId(String queueId) {
+ return beanTypeForQueueId(queueId);
+ }
/**
* Return a BeanLoader.
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/changelog/DefaultChangeLogListener.java b/ebean-core/src/main/java/io/ebeaninternal/server/changelog/DefaultChangeLogListener.java
index 6e12aa31d..5cda1ed36 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/changelog/DefaultChangeLogListener.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/changelog/DefaultChangeLogListener.java
@@ -46,7 +46,7 @@ public final class DefaultChangeLogListener implements ChangeLogListener, Plugin
@Override
public void configure(SpiServer server) {
jsonBuilder = new ChangeJsonBuilder();
- Properties properties = server.getServerConfig().getProperties();
+ Properties properties = server.config().getProperties();
if (properties != null) {
String bufferSize = properties.getProperty("ebean.changeLog.bufferSize");
if (bufferSize != null) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java
index 8a42ed12f..330ec53a9 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java
@@ -35,7 +35,7 @@ final class DefaultBeanLoader {
DefaultBeanLoader(DefaultServer server) {
this.server = server;
- this.onIterateUseExtraTxn = server.getDatabasePlatform().useExtraTransactionOnIterateSecondaryQueries();
+ this.onIterateUseExtraTxn = server.databasePlatform().useExtraTransactionOnIterateSecondaryQueries();
}
void loadMany(LoadManyRequest loadRequest) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index 265e0f5dd..27aae1b29 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -305,12 +305,12 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public DatabaseConfig getServerConfig() {
+ public DatabaseConfig config() {
return config;
}
@Override
- public DatabasePlatform getDatabasePlatform() {
+ public DatabasePlatform databasePlatform() {
return databasePlatform;
}
@@ -2118,7 +2118,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
* Return all the SPI BeanTypes.
*/
@Override
- public List extends BeanType>> getBeanTypes() {
+ public List extends BeanType>> beanTypes() {
return getBeanDescriptors();
}
@@ -2126,12 +2126,12 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
* Return the SPI bean types mapped to the given table.
*/
@Override
- public List extends BeanType>> getBeanTypes(String tableName) {
+ public List extends BeanType>> beanTypes(String tableName) {
return beanDescriptorManager.getBeanTypes(tableName);
}
@Override
- public BeanType> getBeanTypeForQueueId(String queueId) {
+ public BeanType> beanTypeForQueueId(String queueId) {
return getBeanDescriptorByQueueId(queueId);
}
@@ -2144,7 +2144,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
* Return the SPI bean types for the given bean class.
*/
@Override
- public BeanType getBeanType(Class beanType) {
+ public BeanType beanType(Class beanType) {
return getBeanDescriptor(beanType);
}
diff --git a/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java b/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
index 222dd2508..6557867e9 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
@@ -28,7 +28,7 @@ public class BeanTypeTest {
private static Database db = DB.getDefault();
private BeanType beanType(Class cls) {
- return db.pluginApi().getBeanType(cls);
+ return db.pluginApi().beanType(cls);
}
@Test
diff --git a/ebean-core/src/test/java/io/ebean/plugin/ExpressionPathTest.java b/ebean-core/src/test/java/io/ebean/plugin/ExpressionPathTest.java
index de6a79308..e48ffbe25 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/ExpressionPathTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/ExpressionPathTest.java
@@ -15,7 +15,7 @@ public class ExpressionPathTest {
static EbeanServer server = Ebean.getDefaultServer();
BeanType beanType(Class cls) {
- return server.pluginApi().getBeanType(cls);
+ return server.pluginApi().beanType(cls);
}
@Test
diff --git a/ebean-core/src/test/java/io/ebean/plugin/PropertyTest.java b/ebean-core/src/test/java/io/ebean/plugin/PropertyTest.java
index 1e3fcf472..cc546b742 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/PropertyTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/PropertyTest.java
@@ -15,7 +15,7 @@ public class PropertyTest {
static EbeanServer server = Ebean.getDefaultServer();
BeanType beanType(Class cls) {
- return server.pluginApi().getBeanType(cls);
+ return server.pluginApi().beanType(cls);
}
@Test
diff --git a/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java b/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
index 507df1339..54776a643 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
@@ -25,9 +25,9 @@ public class SpiServerTest extends BaseTestCase {
EbeanServer defaultServer = Ebean.getDefaultServer();
SpiServer pluginApi = defaultServer.pluginApi();
- BeanType beanType = pluginApi.getBeanType(Customer.class);
+ BeanType beanType = pluginApi.beanType(Customer.class);
assertEquals("o_customer", beanType.getBaseTable());
- assertNotNull(pluginApi.getDatabasePlatform());
+ assertNotNull(pluginApi.databasePlatform());
assertNull(beanType.getFindController());
assertNotNull(beanType.getPersistController());
assertNull(beanType.getPersistListener());
@@ -45,15 +45,15 @@ public class SpiServerTest extends BaseTestCase {
assertEquals(42, beanType.getBeanId(customer));
- List extends BeanType>> beanTypes = pluginApi.getBeanTypes("o_customer");
+ List extends BeanType>> beanTypes = pluginApi.beanTypes("o_customer");
assertEquals(2, beanTypes.size());
- BeanType vwBeanType = pluginApi.getBeanType(VwCustomer.class);
+ BeanType vwBeanType = pluginApi.beanType(VwCustomer.class);
assertThat(beanTypes.contains(beanType)).isTrue();
assertThat(beanTypes.contains(vwBeanType)).isTrue();
- List extends BeanType>> allTypes = pluginApi.getBeanTypes();
+ List extends BeanType>> allTypes = pluginApi.beanTypes();
assertFalse(allTypes.isEmpty());
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/server/rawsql/TestRawSqlBuilder.java b/ebean-core/src/test/java/io/ebeaninternal/server/rawsql/TestRawSqlBuilder.java
index 9fa3fd0a9..274e98a7f 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/server/rawsql/TestRawSqlBuilder.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/server/rawsql/TestRawSqlBuilder.java
@@ -302,7 +302,7 @@ public class TestRawSqlBuilder extends BaseTestCase {
final String sql = "select description from ebasic_clob where id = ?";
List rows = new ArrayList<>();
- final DataSourceConfig config = ((DefaultServer) DB.getDefault()).getServerConfig().getDataSourceConfig();
+ final DataSourceConfig config = ((DefaultServer) DB.getDefault()).config().getDataSourceConfig();
try (Connection connection = DriverManager.getConnection(config.getUrl(), config.getUsername(), config.getPassword());
PreparedStatement stmt = connection.prepareStatement(sql)) {
@@ -327,7 +327,7 @@ public class TestRawSqlBuilder extends BaseTestCase {
DB.save(pfc);
List rows = new ArrayList<>();
- final DataSourceConfig config = ((DefaultServer) DB.getDefault()).getServerConfig().getDataSourceConfig();
+ final DataSourceConfig config = ((DefaultServer) DB.getDefault()).config().getDataSourceConfig();
final String sql = "select content from persistent_file_content where id = ?";
try (Connection connection = DriverManager.getConnection(config.getUrl(), config.getUsername(), config.getPassword());
diff --git a/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreDeleteEventTest.java b/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreDeleteEventTest.java
index 6bfb125fa..14eacd3ed 100644
--- a/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreDeleteEventTest.java
+++ b/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreDeleteEventTest.java
@@ -22,7 +22,7 @@ public class DocStoreDeleteEventTest {
static EbeanServer server = Ebean.getDefaultServer();
BeanType beanType(Class cls) {
- return server.pluginApi().getBeanType(cls);
+ return server.pluginApi().beanType(cls);
}
BeanType orderType() {
diff --git a/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreIndexEventTest.java b/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreIndexEventTest.java
index b2b8dd3ce..eb95708f1 100644
--- a/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreIndexEventTest.java
+++ b/ebean-core/src/test/java/io/ebeanservice/docstore/api/support/DocStoreIndexEventTest.java
@@ -20,7 +20,7 @@ public class DocStoreIndexEventTest {
static EbeanServer server = Ebean.getDefaultServer();
BeanType beanType(Class cls) {
- return server.pluginApi().getBeanType(cls);
+ return server.pluginApi().beanType(cls);
}
BeanType orderType() {
diff --git a/ebean-core/src/test/java/org/tests/ddd/iud/TestDPersonEl.java b/ebean-core/src/test/java/org/tests/ddd/iud/TestDPersonEl.java
index 9dc2ec555..260a98962 100644
--- a/ebean-core/src/test/java/org/tests/ddd/iud/TestDPersonEl.java
+++ b/ebean-core/src/test/java/org/tests/ddd/iud/TestDPersonEl.java
@@ -33,7 +33,7 @@ public class TestDPersonEl {
SpiServer server = Ebean.getDefaultServer().pluginApi();
- BeanType descriptor = server.getBeanType(DPerson.class);
+ BeanType descriptor = server.beanType(DPerson.class);
JsonContext jsonContext = server.json();
diff --git a/ebean-core/src/test/java/org/tests/el/TestPathExpression.java b/ebean-core/src/test/java/org/tests/el/TestPathExpression.java
index a39d63f9a..0852b6327 100644
--- a/ebean-core/src/test/java/org/tests/el/TestPathExpression.java
+++ b/ebean-core/src/test/java/org/tests/el/TestPathExpression.java
@@ -21,7 +21,7 @@ public class TestPathExpression {
public TestPathExpression() {
SpiServer server = Ebean.getDefaultServer().pluginApi();
- beanType = server.getBeanType(Customer.class);
+ beanType = server.beanType(Customer.class);
billingId = beanType.getExpressionPath("billingAddress.id");
line1 = beanType.getExpressionPath("billingAddress.line1");
city = beanType.getExpressionPath("billingAddress.city");
diff --git a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson.java b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson.java
index 3fb42e561..1107c6b8d 100644
--- a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson.java
+++ b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson.java
@@ -37,7 +37,7 @@ public class TestDbJson_Jackson extends BaseTestCase {
bean.getValueMap().put(1, "one");
bean.getValueMap().put(2, "two");
- ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().getServerConfig().getObjectMapper();
+ ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().config().getObjectMapper();
String json = mapper.writeValueAsString(bean);
EBasicJsonJackson found = mapper.readValue(json, EBasicJsonJackson.class);
@@ -83,7 +83,7 @@ public class TestDbJson_Jackson extends BaseTestCase {
bean.getValueMap().put(1, new StringJacksonType("A"));
bean.getValueMap().put(2, new LongJacksonType(7l));
- ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().getServerConfig().getObjectMapper();
+ ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().config().getObjectMapper();
String json = mapper.writeValueAsString(bean);
assertThat(json)
diff --git a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson2.java b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson2.java
index ef258ec86..01b971ab8 100644
--- a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson2.java
+++ b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson2.java
@@ -34,7 +34,7 @@ public class TestDbJson_Jackson2 extends BaseTestCase {
bean.getValueMap().put(1, new StringJacksonType("A"));
bean.getValueMap().put(2, new LongJacksonType(7l));
- ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().getServerConfig().getObjectMapper();
+ ObjectMapper mapper = (ObjectMapper) Ebean.getDefaultServer().pluginApi().config().getObjectMapper();
String json = mapper.writeValueAsString(bean);
found = mapper.readValue(json, EBasicJsonJackson2.class);
diff --git a/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java b/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
index 7eff8c97f..bfbb97d46 100644
--- a/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
+++ b/ebean-core/src/test/java/org/tests/model/embedded/TestEmbeddedManyToOne.java
@@ -20,7 +20,7 @@ public class TestEmbeddedManyToOne extends BaseTestCase {
ResetBasicData.reset();
- BeanType embType = Ebean.getDefaultServer().pluginApi().getBeanType(EAddr.class);
+ BeanType embType = Ebean.getDefaultServer().pluginApi().beanType(EAddr.class);
Ebean.getDefaultServer().cacheManager().clearAll();
diff --git a/ebean-core/src/test/java/org/tests/query/TestQueryFindIterate.java b/ebean-core/src/test/java/org/tests/query/TestQueryFindIterate.java
index 7fb3b3863..7ad3fe99e 100644
--- a/ebean-core/src/test/java/org/tests/query/TestQueryFindIterate.java
+++ b/ebean-core/src/test/java/org/tests/query/TestQueryFindIterate.java
@@ -233,7 +233,7 @@ public class TestQueryFindIterate extends BaseTestCase {
ResetBasicData.reset();
SpiServer pluginApi = server().pluginApi();
- DataSourcePool dsPool = (DataSourcePool) pluginApi.getServerConfig().getReadOnlyDataSource();
+ DataSourcePool dsPool = (DataSourcePool) pluginApi.config().getReadOnlyDataSource();
if (dsPool == null) {
dsPool = (DataSourcePool) server().dataSource();
}
diff --git a/ebean-core/src/test/java/org/tests/query/sqlquery/TestNativeILikeExpression.java b/ebean-core/src/test/java/org/tests/query/sqlquery/TestNativeILikeExpression.java
index 37963ead5..bc96f4e46 100644
--- a/ebean-core/src/test/java/org/tests/query/sqlquery/TestNativeILikeExpression.java
+++ b/ebean-core/src/test/java/org/tests/query/sqlquery/TestNativeILikeExpression.java
@@ -37,7 +37,7 @@ public class TestNativeILikeExpression extends BaseTestCase {
private boolean isExpectNative() {
SpiServer pluginApi = server().pluginApi();
- boolean expressionNativeIlike = pluginApi.getServerConfig().isExpressionNativeIlike();
+ boolean expressionNativeIlike = pluginApi.config().isExpressionNativeIlike();
Platform platform = pluginApi.platform().base();
return expressionNativeIlike && platform == Platform.POSTGRES;
diff --git a/ebean-core/src/test/java/org/tests/text/json/TestTextJsonInvokeLazy.java b/ebean-core/src/test/java/org/tests/text/json/TestTextJsonInvokeLazy.java
index 99b0dd279..fa11fc3e4 100644
--- a/ebean-core/src/test/java/org/tests/text/json/TestTextJsonInvokeLazy.java
+++ b/ebean-core/src/test/java/org/tests/text/json/TestTextJsonInvokeLazy.java
@@ -16,7 +16,7 @@ public class TestTextJsonInvokeLazy extends BaseTestCase {
@Before
public void clearBeanCache() {
- server().pluginApi().getBeanType(Customer.class).clearBeanCache();
+ server().pluginApi().beanType(Customer.class).clearBeanCache();
}
@Test
diff --git a/ebean-core/src/test/java/org/tests/types/TestNewTypes.java b/ebean-core/src/test/java/org/tests/types/TestNewTypes.java
index eb0210564..b55a37d0e 100644
--- a/ebean-core/src/test/java/org/tests/types/TestNewTypes.java
+++ b/ebean-core/src/test/java/org/tests/types/TestNewTypes.java
@@ -216,7 +216,7 @@ public class TestNewTypes extends BaseTestCase {
private void testSetGetPath(SomeNewTypesBean refBean) {
SomeNewTypesBean testBean = new SomeNewTypesBean();
- BeanType beanType = DB.getDefault().pluginApi().getBeanType(SomeNewTypesBean.class);
+ BeanType beanType = DB.getDefault().pluginApi().beanType(SomeNewTypesBean.class);
ExpressionPath localDate = beanType.getExpressionPath("localDate");
ExpressionPath localDateTime = beanType.getExpressionPath("localDateTime");
ExpressionPath offsetDateTime = beanType.getExpressionPath("offsetDateTime");
diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java
index 0ddbcbca1..4b3044375 100644
--- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java
+++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java
@@ -33,7 +33,7 @@ public class PlatformDdl_AlterColumnTest {
private final PlatformDdl hanaDdl = PlatformDdlBuilder.create(new HanaPlatform());
{
- DatabaseConfig serverConfig = DB.getDefault().pluginApi().getServerConfig();
+ DatabaseConfig serverConfig = DB.getDefault().pluginApi().config();
sqlServerDdl.configure(serverConfig);
}
diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java
index c1871d4db..31cd89ae5 100644
--- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java
+++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java
@@ -25,7 +25,7 @@ public class PlatformDdl_CreateIndexTest {
private final PlatformDdl hanaDdl = PlatformDdlBuilder.create(new HanaPlatform());
{
- DatabaseConfig config = DB.getDefault().pluginApi().getServerConfig();
+ DatabaseConfig config = DB.getDefault().pluginApi().config();
h2Ddl.configure(config);
pgDdl.configure(config);
mysqlDdl.configure(config);
From 4d4065c54b0f426cc990ad425a566847a6368c1b Mon Sep 17 00:00:00 2001
From: rbygrave
Date: Sat, 4 Sep 2021 21:55:23 +1200
Subject: [PATCH 045/102] #2355 - Rename methods in SpiServer with deprecation
---
.../main/java/io/ebean/plugin/BeanType.java | 3 +-
.../io/ebeaninternal/api/SpiEbeanServer.java | 13 +-
.../server/core/AbstractSqlQueryRequest.java | 2 +-
.../server/core/DScriptRunner.java | 2 +-
.../server/core/DefaultServer.java | 2 +-
.../server/core/OrmQueryRequest.java | 6 +-
.../deploy/BeanDescriptorCacheHelp.java | 2 +-
.../server/persist/DefaultPersister.java | 6 +-
.../server/querydefn/DefaultOrmQuery.java | 4 +-
.../server/text/json/DJsonContext.java | 4 +-
.../src/test/java/io/ebean/BaseTestCase.java | 14 +-
.../java/io/ebean/plugin/BeanTypeTest.java | 3 -
.../java/io/ebean/plugin/SpiServerTest.java | 2 +-
.../ebeaninternal/api/TDSpiEbeanServer.java | 46 +-
.../io/ebeaninternal/api/TDSpiServer.java | 643 ++++++++++++++++++
.../org/tests/basic/encrypt/TestEncrypt.java | 2 +-
.../batchinsert/TestBatchInsertSimple.java | 2 +-
.../TestBatchOnCascadeExceptionHandling.java | 2 +-
.../TestElementCollectionBasicCache.java | 2 +-
.../TestElementCollectionBasicMapCache.java | 2 +-
ebean-ddl-generator/pom.xml | 1 +
.../dbmigration/DdlGenerator.java | 12 +-
22 files changed, 687 insertions(+), 88 deletions(-)
create mode 100644 ebean-core/src/test/java/io/ebeaninternal/api/TDSpiServer.java
diff --git a/ebean-api/src/main/java/io/ebean/plugin/BeanType.java b/ebean-api/src/main/java/io/ebean/plugin/BeanType.java
index e44474cd3..bd79be5eb 100644
--- a/ebean-api/src/main/java/io/ebean/plugin/BeanType.java
+++ b/ebean-api/src/main/java/io/ebean/plugin/BeanType.java
@@ -121,8 +121,9 @@ public interface BeanType {
Object beanId(Object bean);
/**
- * Return the id value for the given bean.
+ * Deprecated migrate to beanId()
*/
+ @Deprecated
Object getBeanId(T bean);
/**
diff --git a/ebean-core/src/main/java/io/ebeaninternal/api/SpiEbeanServer.java b/ebean-core/src/main/java/io/ebeaninternal/api/SpiEbeanServer.java
index fae60f49d..b964d2296 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/api/SpiEbeanServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/api/SpiEbeanServer.java
@@ -8,6 +8,7 @@ import io.ebean.config.dbplatform.DatabasePlatform;
import io.ebean.event.readaudit.ReadAuditLogger;
import io.ebean.event.readaudit.ReadAuditPrepare;
import io.ebean.meta.MetricVisitor;
+import io.ebean.plugin.SpiServer;
import io.ebeaninternal.api.SpiQuery.Type;
import io.ebeaninternal.server.core.SpiResultSet;
import io.ebeaninternal.server.core.timezone.DataTimeZone;
@@ -23,7 +24,7 @@ import java.util.stream.Stream;
/**
* Service Provider extension to EbeanServer.
*/
-public interface SpiEbeanServer extends ExtendedServer, EbeanServer, BeanCollectionLoader {
+public interface SpiEbeanServer extends SpiServer, ExtendedServer, EbeanServer, BeanCollectionLoader {
/**
* Return true if the L2 cache has been disabled.
@@ -50,16 +51,6 @@ public interface SpiEbeanServer extends ExtendedServer, EbeanServer, BeanCollect
*/
Object currentTenantId();
- /**
- * Return the server configuration.
- */
- DatabaseConfig getServerConfig();
-
- /**
- * Return the DatabasePlatform for this server.
- */
- DatabasePlatform getDatabasePlatform();
-
/**
* Create an object to represent the current CallStack.
*
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/AbstractSqlQueryRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/AbstractSqlQueryRequest.java
index a88f1bbe9..f11cf9f8e 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/AbstractSqlQueryRequest.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/AbstractSqlQueryRequest.java
@@ -121,7 +121,7 @@ public abstract class AbstractSqlQueryRequest implements CancelableQuery {
int firstRow = query.getFirstRow();
int maxRows = query.getMaxRows();
if (firstRow > 0 || maxRows > 0) {
- return server.getDatabasePlatform().getBasicSqlLimiter().limit(sql, firstRow, maxRows);
+ return server.databasePlatform().getBasicSqlLimiter().limit(sql, firstRow, maxRows);
}
return sql;
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DScriptRunner.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DScriptRunner.java
index 0844bdd36..2b4c81f0b 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DScriptRunner.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DScriptRunner.java
@@ -26,7 +26,7 @@ final class DScriptRunner implements ScriptRunner {
DScriptRunner(SpiEbeanServer server) {
this.server = server;
- this.platformName = this.server.getDatabasePlatform().getPlatform().base().name();
+ this.platformName = this.server.platform().base().name();
}
@Override
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index 27aae1b29..c4afdf5ab 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -305,7 +305,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
}
@Override
- public DatabaseConfig config() {
+ public DatabaseConfig getServerConfig() {
return config;
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java
index c2f3ad4c0..6d88c4fa9 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java
@@ -129,7 +129,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
*/
@Override
public String dbLikeClause(boolean rawLikeExpression) {
- return server.getDatabasePlatform().getLikeClause(rawLikeExpression);
+ return server.databasePlatform().getLikeClause(rawLikeExpression);
}
/**
@@ -137,7 +137,7 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
*/
@Override
public String escapeLikeString(String value) {
- return server.getDatabasePlatform().escapeLikeString(value);
+ return server.databasePlatform().escapeLikeString(value);
}
@Override
@@ -806,6 +806,6 @@ public final class OrmQueryRequest extends BeanRequest implements SpiOrmQuery
* Return true if no MaxRows or use LIMIT in SQL update.
*/
public boolean isInlineSqlUpdateLimit() {
- return query.getMaxRows() < 1 || server.getDatabasePlatform().isInlineSqlUpdateLimit();
+ return query.getMaxRows() < 1 || server.databasePlatform().isInlineSqlUpdateLimit();
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
index 6eceddca4..06a13382c 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
@@ -375,7 +375,7 @@ final class BeanDescriptorCacheHelp {
for (Map.Entry entry : beanDataMap.entrySet()) {
CachedBeanData cachedBeanData = (CachedBeanData) entry.getValue();
T bean = convertToBean(entry.getKey(), false, context, cachedBeanData);
- result.add(bean, desc.getBeanId(bean));
+ result.add(bean, desc.beanId(bean));
}
return result;
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java
index fa877ae90..d41676f94 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/DefaultPersister.java
@@ -73,7 +73,7 @@ public final class DefaultPersister implements Persister {
public DefaultPersister(SpiEbeanServer server, Binder binder, BeanDescriptorManager descMgr) {
this.server = server;
this.beanDescriptorManager = descMgr;
- this.persistExecute = new DefaultPersistExecute(binder, server.getServerConfig().getPersistBatchSize());
+ this.persistExecute = new DefaultPersistExecute(binder, server.config().getPersistBatchSize());
}
@Override
@@ -208,7 +208,7 @@ public final class DefaultPersister implements Persister {
private List getBeanIds(BeanDescriptor desc, List beans) {
List idList = new ArrayList<>(beans.size());
for (T liveBean : beans) {
- idList.add(desc.getBeanId(liveBean));
+ idList.add(desc.beanId(liveBean));
}
return idList;
}
@@ -348,7 +348,7 @@ public final class DefaultPersister implements Persister {
* Publish/restore the values from the sourceBean to the matching destination bean.
*/
T publishToDestinationBean(T sourceBean) {
- id = desc.getBeanId(sourceBean);
+ id = desc.beanId(sourceBean);
T destBean = destBeans.get(id);
insert = (destBean == null);
// apply changes from liveBean to draftBean
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java b/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java
index 04f2ffc4c..9d5d7d613 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java
@@ -167,8 +167,8 @@ public final class DefaultOrmQuery extends AbstractQuery implements SpiQuery<
this.rootBeanDescriptor = desc;
this.beanType = desc.getBeanType();
this.server = server;
- this.orderById = server.getServerConfig().isDefaultOrderById();
- this.disableLazyLoading = server.getServerConfig().isDisableLazyLoading();
+ this.orderById = server.config().isDefaultOrderById();
+ this.disableLazyLoading = server.config().isDisableLazyLoading();
this.expressionFactory = expressionFactory;
this.detail = new OrmQueryDetail();
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/text/json/DJsonContext.java b/ebean-core/src/main/java/io/ebeaninternal/server/text/json/DJsonContext.java
index b0706173c..12866b61c 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/text/json/DJsonContext.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/text/json/DJsonContext.java
@@ -62,8 +62,8 @@ public final class DJsonContext implements SpiJsonContext {
public DJsonContext(SpiEbeanServer server, JsonFactory jsonFactory, TypeManager typeManager) {
this.server = server;
this.jsonFactory = (jsonFactory != null) ? jsonFactory : new JsonFactory();
- this.defaultObjectMapper = this.server.getServerConfig().getObjectMapper();
- this.defaultInclude = this.server.getServerConfig().getJsonInclude();
+ this.defaultObjectMapper = this.server.config().getObjectMapper();
+ this.defaultInclude = this.server.config().getJsonInclude();
this.jsonScalar = new DJsonScalar(typeManager);
}
diff --git a/ebean-core/src/test/java/io/ebean/BaseTestCase.java b/ebean-core/src/test/java/io/ebean/BaseTestCase.java
index e33900534..3e144debc 100644
--- a/ebean-core/src/test/java/io/ebean/BaseTestCase.java
+++ b/ebean-core/src/test/java/io/ebean/BaseTestCase.java
@@ -167,7 +167,7 @@ public abstract class BaseTestCase {
}
public boolean isPlatformCaseSensitive() {
- return spiEbeanServer().getDatabasePlatform().isCaseSensitiveCollation();
+ return spiEbeanServer().databasePlatform().isCaseSensitiveCollation();
}
/**
@@ -215,7 +215,7 @@ public abstract class BaseTestCase {
}
public boolean isPlatformBooleanNative() {
- return Types.BOOLEAN == spiEbeanServer().getDatabasePlatform().getBooleanDbType();
+ return Types.BOOLEAN == spiEbeanServer().databasePlatform().getBooleanDbType();
}
public boolean isPlatformOrderNullsSupport() {
@@ -223,11 +223,11 @@ public abstract class BaseTestCase {
}
public boolean isPlatformSupportsDeleteTableAlias() {
- return spiEbeanServer().getDatabasePlatform().isSupportsDeleteTableAlias();
+ return spiEbeanServer().databasePlatform().isSupportsDeleteTableAlias();
}
public boolean isPersistBatchOnCascade() {
- return spiEbeanServer().getDatabasePlatform().getPersistBatchOnCascade() != PersistBatch.NONE;
+ return spiEbeanServer().databasePlatform().getPersistBatchOnCascade() != PersistBatch.NONE;
}
/**
@@ -246,11 +246,11 @@ public abstract class BaseTestCase {
}
protected Platform platform() {
- return spiEbeanServer().getDatabasePlatform().getPlatform().base();
+ return spiEbeanServer().databasePlatform().getPlatform().base();
}
protected IdType idType() {
- return spiEbeanServer().getDatabasePlatform().getDbIdentity().getIdType();
+ return spiEbeanServer().databasePlatform().getDbIdentity().getIdType();
}
protected SpiEbeanServer spiEbeanServer() {
@@ -299,7 +299,7 @@ public abstract class BaseTestCase {
}
protected String concat(String property0, String separator, String property1, String suffix) {
- DbExpressionHandler dbExpressionHandler = DbExpressionHandlerFactory.from(spiEbeanServer().getDatabasePlatform());
+ DbExpressionHandler dbExpressionHandler = DbExpressionHandlerFactory.from(spiEbeanServer().databasePlatform());
return dbExpressionHandler.concat(property0, separator, property1, suffix);
}
diff --git a/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java b/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
index 6557867e9..d6edb3f0c 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/BeanTypeTest.java
@@ -92,10 +92,7 @@ public class BeanTypeTest {
order.setId(42);
Object id1 = beanType(Order.class).beanId(order);
- Object id2 = beanType(Order.class).getBeanId(order);
-
assertThat(id1).isEqualTo(order.getId());
- assertThat(id2).isEqualTo(order.getId());
}
@Test
diff --git a/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java b/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
index 54776a643..f94cf6059 100644
--- a/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
+++ b/ebean-core/src/test/java/io/ebean/plugin/SpiServerTest.java
@@ -43,7 +43,7 @@ public class SpiServerTest extends BaseTestCase {
Customer customer = new Customer();
customer.setId(42);
- assertEquals(42, beanType.getBeanId(customer));
+ assertEquals(42, beanType.beanId(customer));
List extends BeanType>> beanTypes = pluginApi.beanTypes("o_customer");
assertEquals(2, beanTypes.size());
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
index 7dc5a0b63..ae80084f4 100644
--- a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiEbeanServer.java
@@ -1,41 +1,12 @@
package io.ebeaninternal.api;
-import io.ebean.AutoTune;
-import io.ebean.BackgroundExecutor;
-import io.ebean.BeanState;
-import io.ebean.CallableSql;
-import io.ebean.DocumentStore;
-import io.ebean.DtoQuery;
-import io.ebean.ExpressionFactory;
-import io.ebean.ExtendedServer;
-import io.ebean.Filter;
-import io.ebean.FutureIds;
-import io.ebean.FutureList;
-import io.ebean.FutureRowCount;
-import io.ebean.MergeOptions;
-import io.ebean.PagedList;
-import io.ebean.PersistenceContextScope;
-import io.ebean.Query;
-import io.ebean.QueryIterator;
-import io.ebean.RowConsumer;
-import io.ebean.RowMapper;
-import io.ebean.ScriptRunner;
-import io.ebean.SqlQuery;
-import io.ebean.SqlRow;
-import io.ebean.SqlUpdate;
-import io.ebean.Transaction;
-import io.ebean.TransactionCallback;
-import io.ebean.TxScope;
-import io.ebean.Update;
-import io.ebean.UpdateQuery;
-import io.ebean.ValuePair;
-import io.ebean.Version;
+import io.ebean.*;
import io.ebean.annotation.Platform;
import io.ebean.annotation.TxIsolation;
import io.ebean.bean.BeanCollection;
import io.ebean.bean.CallOrigin;
import io.ebean.cache.ServerCacheManager;
-import io.ebean.config.ServerConfig;
+import io.ebean.config.DatabaseConfig;
import io.ebean.config.dbplatform.DatabasePlatform;
import io.ebean.event.readaudit.ReadAuditLogger;
import io.ebean.event.readaudit.ReadAuditPrepare;
@@ -56,12 +27,7 @@ import javax.persistence.OptimisticLockException;
import javax.persistence.PersistenceException;
import javax.sql.DataSource;
import java.time.Clock;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.List;
-import java.util.Map;
-import java.util.Optional;
-import java.util.Set;
+import java.util.*;
import java.util.concurrent.Callable;
import java.util.function.Consumer;
import java.util.function.Predicate;
@@ -71,7 +37,7 @@ import java.util.stream.Stream;
/**
* Test double for SpiEbeanServer.
*/
-public class TDSpiEbeanServer implements SpiEbeanServer {
+public class TDSpiEbeanServer extends TDSpiServer implements SpiEbeanServer {
String name;
@@ -158,12 +124,12 @@ public class TDSpiEbeanServer implements SpiEbeanServer {
}
@Override
- public ServerConfig getServerConfig() {
+ public DatabaseConfig config() {
return null;
}
@Override
- public DatabasePlatform getDatabasePlatform() {
+ public DatabasePlatform databasePlatform() {
return null;
}
diff --git a/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiServer.java b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiServer.java
new file mode 100644
index 000000000..fdb304332
--- /dev/null
+++ b/ebean-core/src/test/java/io/ebeaninternal/api/TDSpiServer.java
@@ -0,0 +1,643 @@
+package io.ebeaninternal.api;
+
+import io.ebean.*;
+import io.ebean.annotation.Platform;
+import io.ebean.annotation.TxIsolation;
+import io.ebean.bean.BeanLoader;
+import io.ebean.bean.EntityBeanIntercept;
+import io.ebean.cache.ServerCacheManager;
+import io.ebean.config.DatabaseConfig;
+import io.ebean.config.dbplatform.DatabasePlatform;
+import io.ebean.meta.MetaInfoManager;
+import io.ebean.plugin.BeanType;
+import io.ebean.plugin.Property;
+import io.ebean.plugin.SpiServer;
+import io.ebean.text.csv.CsvReader;
+import io.ebean.text.json.JsonContext;
+
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import javax.persistence.OptimisticLockException;
+import javax.persistence.PersistenceException;
+import javax.sql.DataSource;
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.Callable;
+
+public class TDSpiServer implements SpiServer {
+ @Override
+ public void shutdown() {
+
+ }
+
+ @Override
+ public void shutdown(boolean shutdownDataSource, boolean deregisterDriver) {
+
+ }
+
+ @Override
+ public AutoTune autoTune() {
+ return null;
+ }
+
+ @Override
+ public DataSource dataSource() {
+ return null;
+ }
+
+ @Override
+ public DataSource readOnlyDataSource() {
+ return null;
+ }
+
+ @Override
+ public String name() {
+ return null;
+ }
+
+ @Override
+ public ExpressionFactory expressionFactory() {
+ return null;
+ }
+
+ @Override
+ public MetaInfoManager metaInfo() {
+ return null;
+ }
+
+ @Override
+ public Platform platform() {
+ return null;
+ }
+
+ @Override
+ public SpiServer pluginApi() {
+ return null;
+ }
+
+ @Override
+ public BeanState beanState(Object bean) {
+ return null;
+ }
+
+ @Override
+ public Object beanId(Object bean) {
+ return null;
+ }
+
+ @Override
+ public Object beanId(Object bean, Object id) {
+ return null;
+ }
+
+ @Override
+ public Map diff(Object newBean, Object oldBean) {
+ return null;
+ }
+
+ @Override
+ public T createEntityBean(Class type) {
+ return null;
+ }
+
+ @Override
+ public CsvReader createCsvReader(Class beanType) {
+ return null;
+ }
+
+ @Override
+ public UpdateQuery update(Class beanType) {
+ return null;
+ }
+
+ @Override
+ public Query createNamedQuery(Class beanType, String namedQuery) {
+ return null;
+ }
+
+ @Override
+ public Query createQuery(Class beanType) {
+ return null;
+ }
+
+ @Override
+ public Query createQuery(Class