#1802 - Completely remove MySQL init stored procedures for drop column with foreign key (#1815)

src/main/java/io/ebean/config/PlatformConfig.java

@@ -54,8 +54,6 @@ public class PlatformConfig {
 
   private boolean caseSensitiveCollation = true;
 
-  private boolean useMigrationStoredProcedures;
-
   /**
    * Modify the default mapping of standard types such as default precision for DECIMAL etc.
    */
@@ -78,7 +76,6 @@ public class PlatformConfig {
     this.idType = platformConfig.idType;
     this.geometrySRID = platformConfig.geometrySRID;
     this.dbUuid = platformConfig.dbUuid;
-    this.useMigrationStoredProcedures = platformConfig.useMigrationStoredProcedures;
     this.caseSensitiveCollation = platformConfig.caseSensitiveCollation;
     this.allQuotedIdentifiers = platformConfig.allQuotedIdentifiers;
     this.databaseInetAddressVarchar = platformConfig.databaseInetAddressVarchar;
@@ -113,20 +110,6 @@ public class PlatformConfig {
     this.caseSensitiveCollation = caseSensitiveCollation;
   }
 
-  /**
-   * Return true if force use of helper stored procedures for migrations.
-   */
-  public boolean isUseMigrationStoredProcedures() {
-    return useMigrationStoredProcedures;
-  }
-
-  /**
-   * Set true to force use of helper stored procedures for migrations.
-   */
-  public void setUseMigrationStoredProcedures(boolean useMigrationStoredProcedures) {
-    this.useMigrationStoredProcedures = useMigrationStoredProcedures;
-  }
-
   /**
    * Return a value used to represent TRUE in the database.
    * <p>
@@ -293,7 +276,6 @@ public class PlatformConfig {
     databaseBooleanFalse = p.get("databaseBooleanFalse", databaseBooleanFalse);
     databaseInetAddressVarchar = p.getBoolean("databaseInetAddressVarchar", databaseInetAddressVarchar);
     caseSensitiveCollation = p.getBoolean("caseSensitiveCollation", caseSensitiveCollation);
-    useMigrationStoredProcedures = p.getBoolean("useMigrationStoredProcedures", useMigrationStoredProcedures);;
 
     DbUuid dbUuid = p.getEnum(DbUuid.class, "dbuuid", null);
     if (dbUuid != null) {

src/main/java/io/ebean/config/dbplatform/DatabasePlatform.java

@@ -53,8 +53,6 @@ public class DatabasePlatform {
 
   protected boolean supportsSavepointId = true;
 
-  protected boolean useMigrationStoredProcedures = true;
-
   /**
    * The behaviour used when ending a read only transaction at read committed isolation level.
    */
@@ -235,9 +233,6 @@ public class DatabasePlatform {
   public void configure(PlatformConfig config) {
     this.sequenceBatchSize = config.getDatabaseSequenceBatchSize();
     this.caseSensitiveCollation = config.isCaseSensitiveCollation();
-    if (config.isUseMigrationStoredProcedures()) {
-      useMigrationStoredProcedures = true;
-    }
     configureIdType(config.getIdType());
     configure(config, config.isAllQuotedIdentifiers());
   }
@@ -344,13 +339,6 @@ public class DatabasePlatform {
     return supportsSavepointId;
   }
 
-  /**
-   * Return true if migrations should use stored procedures.
-   */
-  public boolean isUseMigrationStoredProcedures() {
-    return useMigrationStoredProcedures;
-  }
-
   /**
    * Return the maximum table name length.
    * <p>

src/main/java/io/ebean/config/dbplatform/mysql/MySqlPlatform.java

@@ -28,7 +28,6 @@ public class MySqlPlatform extends DatabasePlatform {
     this.useExtraTransactionOnIterateSecondaryQueries = true;
     this.selectCountWithAlias = true;
     this.supportsSavepointId = false;
-    this.useMigrationStoredProcedures = false;
     this.dbEncrypt = new MySqlDbEncrypt();
     this.historySupport = new MySqlHistorySupport();
     this.columnAliasPrefix = null;

src/main/java/io/ebeaninternal/dbmigration/DdlGenerator.java

@@ -47,7 +47,6 @@ public class DdlGenerator {
   private final boolean ddlAutoCommit;
   private final String dbSchema;
   private final ScriptTransform scriptTransform;
-  private final boolean useMigrationStoredProcedures;
 
   private CurrentModel currentModel;
   private String dropAllContent;
@@ -65,11 +64,9 @@ public class DdlGenerator {
       log.warn("DDL can't be run on startup with TenantMode " + serverConfig.getTenantMode());
       this.runDdl = false;
       this.ddlAutoCommit = false;
-      this.useMigrationStoredProcedures = false;
     } else {
       this.runDdl = serverConfig.isDdlRun();
       this.ddlAutoCommit = server.getDatabasePlatform().isDdlAutoCommit();
-      this.useMigrationStoredProcedures = server.getDatabasePlatform().isUseMigrationStoredProcedures();
     }
     this.scriptTransform = createScriptTransform(serverConfig.getMigrationConfig());
     this.baseDir = initBaseDir();
@@ -182,7 +179,7 @@ public class DdlGenerator {
 
   protected void runDropSql(Connection connection) throws IOException {
     if (!createOnly) {
-      if (extraDdl && jaxbPresent && useMigrationStoredProcedures) {
+      if (extraDdl && jaxbPresent) {
         String extraApply = ExtraDdlXmlReader.buildExtra(server.getDatabasePlatform().getName(), true);
         if (extraApply != null) {
           runScript(connection, false, extraApply, "extra-ddl");
@@ -202,7 +199,7 @@ public class DdlGenerator {
     }
     runScript(connection, false, createAllContent, getCreateFileName());
 
-    if (extraDdl && jaxbPresent && useMigrationStoredProcedures) {
+    if (extraDdl && jaxbPresent) {
       if (currentModel().isTablePartitioning()) {
         String extraPartitioning = ExtraDdlXmlReader.buildPartitioning(server.getDatabasePlatform().getName());
         if (extraPartitioning != null && !extraPartitioning.isEmpty()) {

src/main/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/MySqlDdl.java

@@ -18,15 +18,12 @@ public class MySqlDdl extends PlatformDdl {
   // this flag is for compatibility. Use it with care.
   private static final boolean USE_CHECK_CONSTRAINT = Boolean.getBoolean("ebean.mysql.useCheckConstraint");
 
-  private final boolean useMigrationStoredProcedures;
-
   public MySqlDdl(DatabasePlatform platform) {
     super(platform);
     this.alterColumn = "modify";
     this.dropUniqueConstraint = "drop index";
     this.historyDdl = new MySqlHistoryDdl();
     this.inlineComments = true;
-    this.useMigrationStoredProcedures = platform.isUseMigrationStoredProcedures();
   }
 
   /**
@@ -45,21 +42,6 @@ public class MySqlDdl extends PlatformDdl {
     return "alter table " + tableName + " drop foreign key " + maxConstraintName(fkName);
   }
 
-  /**
-   * It is rather complex to delete a column on MySql as there must not exist any foreign keys.
-   * That's why we call a user stored procedure here
-   */
-  @Override
-  public void alterTableDropColumn(DdlBuffer buffer, String tableName, String columnName) throws IOException {
-
-    if (useMigrationStoredProcedures) {
-      buffer.append("CALL usp_ebean_drop_column('").append(tableName).append("', '").append(columnName).append("')").endOfStatement();
-    } else {
-      buffer.append("alter table ").append(tableName).append(" ").append(dropColumn).append(" ").append(columnName)
-        .append(dropColumnSuffix).endOfStatement();
-    }
-  }
-
   @Override
   public String createCheckConstraint(String ckName, String checkConstraint) {
     if (USE_CHECK_CONSTRAINT) {