No effective change - add code inspection suppression comments

This commit is contained in:
Robin Bygrave
2015-08-01 20:41:50 +12:00
parent 17d97623d5
commit b82223dc1d
14 changed files with 22 additions and 8 deletions
@@ -82,6 +82,7 @@ public final class ObjectGraphNode implements Serializable {
}
ObjectGraphNode e = (ObjectGraphNode) obj;
//noinspection StringEquality
return ((e.path == path) || (e.path != null && e.path.equals(path)))
&& e.originQueryPoint.equals(originQueryPoint);
}
@@ -40,6 +40,7 @@ public class ServerCacheStatistics {
protected long evictByLRU;
public String toString() {
//noinspection StringBufferReplaceableByString
StringBuilder sb = new StringBuilder(80);
sb.append(cacheName);
sb.append(" maxSize:").append(maxSize);
@@ -16,6 +16,7 @@ public class PostgresHistorySupport implements DbHistorySupport {
// for Postgres we are using the 'timestamp with timezone range' data type
// as our sys_period column so hence the predicate below
//noinspection StringBufferReplaceableByString
StringBuilder sb = new StringBuilder(40);
sb.append(asOfTableAlias).append(".").append(asOfSysPeriod).append(" @> ?::timestamptz");
return sb.toString();
@@ -37,7 +37,8 @@ public class HashQueryPlan {
}
HashQueryPlan e = (HashQueryPlan) obj;
return e.planHash == planHash
//noinspection StringEquality
return e.planHash == planHash
&& e.bindCount == bindCount
&& ((e.rawSql == rawSql) || (e.rawSql != null && e.rawSql.equals(rawSql)));
}
@@ -35,7 +35,8 @@ public class DefaultAutoFetchManager implements AutoFetchManager, Serializable {
private static final long serialVersionUID = -6826119882781771722L;
private final String statisticsMonitor = new String();
@SuppressWarnings("RedundantStringConstructorCall")
private final String statisticsMonitor = new String();
private final String fileName;
@@ -28,7 +28,8 @@ public class Statistics implements Serializable {
private final Map<String, StatisticsNodeUsage> nodeUsageMap = new LinkedHashMap<String, StatisticsNodeUsage>();
private final String monitor = new String();
@SuppressWarnings("RedundantStringConstructorCall")
private final String monitor = new String();
public Statistics(ObjectGraphOrigin origin, boolean queryTuningAddVersion) {
this.origin = origin;
@@ -25,7 +25,8 @@ public class StatisticsNodeUsage implements Serializable {
private static final Logger logger = LoggerFactory.getLogger(StatisticsNodeUsage.class);
private final String monitor = new String();
@SuppressWarnings("RedundantStringConstructorCall")
private final String monitor = new String();
private final String path;
@@ -28,7 +28,8 @@ public class TunedQueryInfo implements Serializable {
private Long lastTuneTime = (long) 0;
private final String rateMonitor = new String();
@SuppressWarnings("RedundantStringConstructorCall")
private final String rateMonitor = new String();
/**
* The number of queries tuned by this object.
@@ -30,8 +30,9 @@ public class McastStatus {
private final String lastOutgoingAcks;
public String getSummary() {
StringBuilder sb = new StringBuilder(80);
//noinspection StringBufferReplaceableByString
StringBuilder sb = new StringBuilder(80);
sb.append("txnOut:").append(totalTxnEventsSent).append("; ");
sb.append("txnIn:").append(totalTxnEventsReceived).append("; ");
sb.append("outPackets:").append(totalPacketsSent).append("; ");
@@ -263,7 +263,8 @@ public class DataSourcePool implements DataSource {
}
String transIsolation = TransactionIsolation.getLevelDescription(transactionIsolation);
StringBuilder sb = new StringBuilder(70);
//noinspection StringBufferReplaceableByString
StringBuilder sb = new StringBuilder(70);
sb.append("DataSourcePool [").append(name);
sb.append("] autoCommit[").append(autoCommit);
sb.append("] transIsolation[").append(transIsolation);
@@ -31,6 +31,7 @@ public class Str {
* Append two strings together.
*/
public static String add(String s0, String s1) {
//noinspection StringBufferReplaceableByString
StringBuilder sb = new StringBuilder(s0.length() + s1.length() + 5);
return sb.append(s0).append(s1).toString();
}
@@ -88,6 +88,7 @@ public class CQueryFetchIds {
* Return a summary description of this query.
*/
public String getSummary() {
//noinspection StringBufferReplaceableByString
StringBuilder sb = new StringBuilder(80);
sb.append("FindIds exeMicros[").append(executionTimeMicros)
.append("] rows[").append(rowCount)
@@ -75,6 +75,7 @@ public class CQueryRowCount {
* Return a summary description of this query.
*/
public String getSummary() {
//noinspection StringBufferReplaceableByString
StringBuilder sb = new StringBuilder(80);
sb.append("FindRowCount exeMicros[").append(executionTimeMicros)
.append("] rows[").append(rowCount)
@@ -41,6 +41,7 @@ public class SqlTreeProperties {
}
public void add(BeanProperty[] props) {
//noinspection ManualArrayToCollectionCopy
for (int i = 0; i < props.length; i++) {
propsList.add(props[i]);
}