diff --git a/ebean-core/src/main/java/io/ebeaninternal/api/LoadBeanRequest.java b/ebean-core/src/main/java/io/ebeaninternal/api/LoadBeanRequest.java index 79658e626..f2754e4c4 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/api/LoadBeanRequest.java +++ b/ebean-core/src/main/java/io/ebeaninternal/api/LoadBeanRequest.java @@ -47,7 +47,7 @@ public final class LoadBeanRequest extends LoadRequest { } @Override - public Class getBeanType() { + public Class beanType() { return loadBuffer.getBeanDescriptor().getBeanType(); } @@ -58,21 +58,10 @@ public final class LoadBeanRequest extends LoadRequest { /** * Return the batch of beans to actually load. */ - public List getBatch() { + public List batch() { return batch; } - /** - * Return the load context. - */ - private LoadBeanBuffer getLoadContext() { - return loadBuffer; - } - - public int getBatchSize() { - return getLoadContext().getBatchSize(); - } - /** * Return the list of Id values for the beans in the lazy load buffer. */ @@ -93,7 +82,7 @@ public final class LoadBeanRequest extends LoadRequest { query.setPersistenceContext(loadBuffer.getPersistenceContext()); query.setLoadDescription(lazy ? "+lazy" : "+query", description()); if (lazy) { - query.setLazyLoadBatchSize(getBatchSize()); + query.setLazyLoadBatchSize(loadBuffer.getBatchSize()); if (alreadyLoaded) { query.setBeanCacheMode(CacheMode.OFF); } diff --git a/ebean-core/src/main/java/io/ebeaninternal/api/LoadManyRequest.java b/ebean-core/src/main/java/io/ebeaninternal/api/LoadManyRequest.java index a26f2aa90..71ebdef78 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/api/LoadManyRequest.java +++ b/ebean-core/src/main/java/io/ebeaninternal/api/LoadManyRequest.java @@ -48,7 +48,7 @@ public final class LoadManyRequest extends LoadRequest { } @Override - public Class getBeanType() { + public Class beanType() { return loadContext.getBeanDescriptor().getBeanType(); } @@ -56,30 +56,9 @@ public final class LoadManyRequest extends LoadRequest { return loadContext.getFullPath(); } - /** - * Return the batch of collections to actually load. - */ - public List> getBatch() { - return batch; - } - - /** - * Return true if we should load the Collection ids into the cache. - */ - private boolean isLoadCache() { - return loadCache; - } - - /** - * Return the batch size used for this load context. - */ - public int getBatchSize() { - return loadContext.getBatchSize(); - } - private List parentIdList(SpiEbeanServer server) { List idList = new ArrayList<>(); - BeanPropertyAssocMany many = getMany(); + BeanPropertyAssocMany many = many(); for (BeanCollection bc : batch) { idList.add(many.getParentId(bc.getOwnerBean())); bc.setLoader(server); // don't use the load buffer again @@ -90,12 +69,12 @@ public final class LoadManyRequest extends LoadRequest { return idList; } - private BeanPropertyAssocMany getMany() { + private BeanPropertyAssocMany many() { return loadContext.getBeanProperty(); } public SpiQuery createQuery(SpiEbeanServer server) { - BeanPropertyAssocMany many = getMany(); + BeanPropertyAssocMany many = many(); SpiQuery query = many.newQuery(server); String orderBy = many.getLazyFetchOrderBy(); if (orderBy != null) { @@ -112,7 +91,7 @@ public final class LoadManyRequest extends LoadRequest { query.setPersistenceContext(loadContext.getPersistenceContext()); query.setLoadDescription(lazy ? "+lazy" : "+query", description()); if (lazy) { - query.setLazyLoadBatchSize(getBatchSize()); + query.setLazyLoadBatchSize(loadContext.getBatchSize()); } else { query.setBeanCacheMode(CacheMode.OFF); } @@ -130,7 +109,7 @@ public final class LoadManyRequest extends LoadRequest { */ public void postLoad() { BeanDescriptor desc = loadContext.getBeanDescriptor(); - BeanPropertyAssocMany many = getMany(); + BeanPropertyAssocMany many = many(); // check for BeanCollection's that where never processed // in the +query or +lazy load due to no rows (predicates) for (BeanCollection bc : batch) { @@ -140,7 +119,7 @@ public final class LoadManyRequest extends LoadRequest { Object parentId = desc.getId(ownerBean); logger.debug("BeanCollection after lazy load was empty. type:" + ownerBean.getClass().getName() + " id:" + parentId + " owner:" + ownerBean); } - } else if (isLoadCache() && many.isUseCache()) { + } else if (loadCache && many.isUseCache()) { desc.cacheManyPropPut(many, bc, desc.getId(bc.getOwnerBean())); } } diff --git a/ebean-core/src/main/java/io/ebeaninternal/api/LoadRequest.java b/ebean-core/src/main/java/io/ebeaninternal/api/LoadRequest.java index 3c797ced5..090e4bfad 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/api/LoadRequest.java +++ b/ebean-core/src/main/java/io/ebeaninternal/api/LoadRequest.java @@ -12,7 +12,7 @@ public abstract class LoadRequest { protected final Transaction transaction; protected final boolean lazy; - public LoadRequest(OrmQueryRequest parentRequest, boolean lazy) { + LoadRequest(OrmQueryRequest parentRequest, boolean lazy) { this.parentRequest = parentRequest; this.transaction = parentRequest == null ? null : parentRequest.getTransaction(); this.lazy = lazy; @@ -21,7 +21,7 @@ public abstract class LoadRequest { /** * Return the associated bean type for this load request. */ - public abstract Class getBeanType(); + public abstract Class beanType(); /** * Return true if this is a lazy load and false if it is a secondary query. @@ -36,7 +36,7 @@ public abstract class LoadRequest { * Lazy loading queries run in their own transaction. *

*/ - public Transaction getTransaction() { + public Transaction transaction() { return transaction; } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java index e2e2709f4..c1def652c 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java @@ -129,7 +129,7 @@ final class DefaultBeanLoader { * Load a batch of beans for +query or +lazy loading. */ void loadBean(LoadBeanRequest loadRequest) { - List batch = loadRequest.getBatch(); + List batch = loadRequest.batch(); if (batch.isEmpty()) { throw new RuntimeException("Nothing in batch?"); } @@ -140,7 +140,7 @@ final class DefaultBeanLoader { return; } - SpiQuery query = server.createQuery(loadRequest.getBeanType()); + SpiQuery query = server.createQuery(loadRequest.beanType()); loadRequest.configureQuery(query, idList); List list = executeQuery(loadRequest, query); loadRequest.postLoad(list); @@ -159,7 +159,7 @@ final class DefaultBeanLoader { extraTxn.end(); } } else { - return server.findList(query, loadRequest.getTransaction()); + return server.findList(query, loadRequest.transaction()); } }