github/ebean
4
0
Fork 0
mirror of https://github.com/ebean-orm/ebean.git synced 2024-04-21 10:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

#2020 - Fix potential connection leak in query-iterator WITH lazyLoadBufferSize (Refer #1164)

Browse Source
This commit is contained in:
rob bygrave
2020-06-17 17:10:16 +12:00
parent e071eecd59
commit 9d9d13060c
2 changed files with 39 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/java/org/tests/query/TestQueryFindIterate.java
+21 -7
View File
@@ -220,7 +220,16 @@ public class TestQueryFindIterate extends BaseTestCase {
}
@Test
public void testCloseConnection() {
public void testCloseConnection_findIterate() {
findIterateCloseConnection(false);
}
@Test
public void testCloseConnection_findIterate_withBatchLoad() {
findIterateCloseConnection(true);
}
public void findIterateCloseConnection(boolean withLoadBatch) {
ResetBasicData.reset();
SpiServer pluginApi = server().getPluginApi();
@@ -230,12 +239,17 @@ public class TestQueryFindIterate extends BaseTestCase {
}
int startConns = dsPool.getStatus(false).getBusy();
QueryIterator<Customer> queryIterator = server().find(Customer.class)
.where()
.isNotNull("name")
.setMaxRows(3)
.order().asc("id")
.findIterate();
final Query<Customer> query = server().find(Customer.class)
.where()
.isNotNull("name")
.setMaxRows(3)
.order().asc("id");
if (withLoadBatch) {
query.setLazyLoadBatchSize(100);
}
QueryIterator<Customer> queryIterator = query.findIterate();
assertThat(dsPool.getStatus(false).getBusy()).isEqualTo(startConns + 1);