diff --git a/src/main/java/io/ebean/config/DbMigrationConfig.java b/src/main/java/io/ebean/config/DbMigrationConfig.java index 21ad71f4e..3f6656768 100644 --- a/src/main/java/io/ebean/config/DbMigrationConfig.java +++ b/src/main/java/io/ebean/config/DbMigrationConfig.java @@ -465,12 +465,14 @@ public class DbMigrationConfig { metaTable = properties.get("migration.metaTable", metaTable); runPlaceholders = properties.get("migration.placeholders", runPlaceholders); - String adminUser = properties.get("datasource." + serverName + ".username", dbUsername); - adminUser = properties.get("datasource." + serverName + ".adminusername", adminUser); + //Do not set user and pass from "datasource.db.username" + //There is a null test in MigrationRunner::getConnection to handle this + //String adminUser = properties.get("datasource." + serverName + ".username", dbUsername); + String adminUser = properties.get("datasource." + serverName + ".adminusername", dbUsername); dbUsername = properties.get("migration.dbusername", adminUser); - String adminPwd = properties.get("datasource." + serverName + ".password", dbPassword); - adminPwd = properties.get("datasource." + serverName + ".adminpassword", adminPwd); + //String adminPwd = properties.get("datasource." + serverName + ".password", dbPassword); + String adminPwd = properties.get("datasource." + serverName + ".adminpassword", dbPassword); dbPassword = properties.get("migration.dbpassword", adminPwd); ddlHeader = properties.get("ddl.header", ddlHeader); if (ddlHeader != null && !ddlHeader.isEmpty()) { diff --git a/src/test/java/io/ebean/config/DbMigrationConfigTest.java b/src/test/java/io/ebean/config/DbMigrationConfigTest.java index 8e5480cde..0bc2ab692 100644 --- a/src/test/java/io/ebean/config/DbMigrationConfigTest.java +++ b/src/test/java/io/ebean/config/DbMigrationConfigTest.java @@ -55,8 +55,9 @@ public class DbMigrationConfigTest { DbMigrationConfig migrationConfig = new DbMigrationConfig(); migrationConfig.loadSettings(wrapper, "db"); - assertEquals(migrationConfig.getDbUsername(),"banana"); - assertEquals(migrationConfig.getDbPassword(),"apple"); + // runnerConfig will fall back itsel to the correct password + assertEquals(migrationConfig.getDbUsername(),null); + assertEquals(migrationConfig.getDbPassword(),null); } @Test