#1998 - Refactor internals rename createQueryTransaction() to createReadOnlyTransaction()

src/main/java/io/ebeaninternal/api/SpiEbeanServer.java

@@ -147,7 +147,7 @@ public interface SpiEbeanServer extends ExtendedServer, EbeanServer, BeanCollect
    *
    * @param tenantId For multi-tenant lazy loading provide the tenantId to use.
    */
-  SpiTransaction createQueryTransaction(Object tenantId);
+  SpiTransaction createReadOnlyTransaction(Object tenantId);
 
   /**
    * An event from another server in the cluster used to notify local

src/main/java/io/ebeaninternal/server/core/AbstractSqlQueryRequest.java

@@ -58,7 +58,7 @@ public abstract class AbstractSqlQueryRequest {
       trans = server.currentServerTransaction();
       if (trans == null || !trans.isActive()) {
         // create a local readOnly transaction
-        trans = server.createQueryTransaction(null);
+        trans = server.createReadOnlyTransaction(null);
         createdTransaction = true;
       }
     }

src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java

@@ -170,7 +170,7 @@ class DefaultBeanLoader {
   private List<?> executeQuery(LoadRequest loadRequest, SpiQuery<?> query) {
     if (onIterateUseExtraTxn && loadRequest.isParentFindIterate()) {
       // MySql - we need a different transaction to execute the secondary query
-      SpiTransaction extraTxn = server.createQueryTransaction(query.getTenantId());
+      SpiTransaction extraTxn = server.createReadOnlyTransaction(query.getTenantId());
       try {
         return server.findList(query, extraTxn);
       } finally {

src/main/java/io/ebeaninternal/server/core/DefaultServer.java

@@ -2322,8 +2322,8 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
   }
 
   @Override
-  public SpiTransaction createQueryTransaction(Object tenantId) {
-    return transactionManager.createQueryTransaction(tenantId);
+  public SpiTransaction createReadOnlyTransaction(Object tenantId) {
+    return transactionManager.createReadOnlyTransaction(tenantId);
   }
 
   /**

src/main/java/io/ebeaninternal/server/core/OrmQueryRequest.java

@@ -286,7 +286,7 @@ public final class OrmQueryRequest<T> extends BeanRequest implements SpiOrmQuery
       } else {
         // create an implicit transaction to execute this query
         // potentially using read-only DataSource with autoCommit
-        transaction = ebeanServer.createQueryTransaction(query.getTenantId());
+        transaction = ebeanServer.createReadOnlyTransaction(query.getTenantId());
       }
       createdTransaction = true;
     }

src/main/java/io/ebeaninternal/server/transaction/DocStoreTransactionManager.java

@@ -24,7 +24,7 @@ public class DocStoreTransactionManager extends TransactionManager {
   }
 
   @Override
-  public SpiTransaction createQueryTransaction(Object tenantId) {
+  public SpiTransaction createReadOnlyTransaction(Object tenantId) {
     return new DocStoreOnlyTransaction("", false, this);
   }
 

src/main/java/io/ebeaninternal/server/transaction/TransactionFactory.java

@@ -23,7 +23,7 @@ abstract class TransactionFactory {
    *
    * @param tenantId The tenantId for lazy loading queries.
    */
-  abstract SpiTransaction createQueryTransaction(Object tenantId);
+  abstract SpiTransaction createReadOnlyTransaction(Object tenantId);
 
   /**
    * Return a new transaction.

src/main/java/io/ebeaninternal/server/transaction/TransactionFactoryBasic.java

@@ -21,7 +21,7 @@ class TransactionFactoryBasic extends TransactionFactory {
   }
 
   @Override
-  public SpiTransaction createQueryTransaction(Object tenantId) {
+  public SpiTransaction createReadOnlyTransaction(Object tenantId) {
 
     Connection connection = null;
     try {

src/main/java/io/ebeaninternal/server/transaction/TransactionFactoryBasicWithRead.java

@@ -26,7 +26,7 @@ class TransactionFactoryBasicWithRead extends TransactionFactoryBasic {
   }
 
   @Override
-  public SpiTransaction createQueryTransaction(Object tenantId) {
+  public SpiTransaction createReadOnlyTransaction(Object tenantId) {
 
     Connection connection = null;
     try {

src/main/java/io/ebeaninternal/server/transaction/TransactionFactoryTenant.java

@@ -24,7 +24,7 @@ class TransactionFactoryTenant extends TransactionFactory {
   }
 
   @Override
-  public SpiTransaction createQueryTransaction(Object tenantId) {
+  public SpiTransaction createReadOnlyTransaction(Object tenantId) {
     return create(false, tenantId);
   }
 

src/main/java/io/ebeaninternal/server/transaction/TransactionFactoryTenantWithRead.java

@@ -23,7 +23,7 @@ class TransactionFactoryTenantWithRead extends TransactionFactoryTenant {
   }
 
   @Override
-  public SpiTransaction createQueryTransaction(Object tenantId) {
+  public SpiTransaction createReadOnlyTransaction(Object tenantId) {
 
     Connection connection = null;
     try {

src/main/java/io/ebeaninternal/server/transaction/TransactionManager.java

@@ -358,7 +358,7 @@ public class TransactionManager implements SpiTransactionManager {
 
   private SpiTransaction createTransaction(TxScope txScope) {
     if (txScope.isReadonly()) {
-      return createQueryTransaction(null);
+      return createReadOnlyTransaction(null);
     } else {
       return createTransaction(true, txScope.getIsolationLevel());
     }
@@ -374,8 +374,8 @@ public class TransactionManager implements SpiTransactionManager {
   /**
    * Create a new Transaction for query only purposes (can use read only datasource).
    */
-  public SpiTransaction createQueryTransaction(Object tenantId) {
-    return transactionFactory.createQueryTransaction(tenantId);
+  public SpiTransaction createReadOnlyTransaction(Object tenantId) {
+    return transactionFactory.createReadOnlyTransaction(tenantId);
   }
 
   /**