#1972 - Change BigDecimal to map by default DB type DECIMAL(16,3) rather than DECIMAL(38)

src/test/java/io/ebean/config/dbplatform/DatabasePlatformTest.java

@@ -49,7 +49,7 @@ public class DatabasePlatformTest {
   public void defaultTypesForDecimalAndVarchar() {
 
     DatabasePlatform dbPlatform = new DatabasePlatform();
-    assertEquals(defaultDecimalDefn(dbPlatform), "decimal(38)");
+    assertEquals(defaultDecimalDefn(dbPlatform), "decimal(16,3)");
     assertEquals(defaultDefn(DbType.VARCHAR, dbPlatform), "varchar(255)");
   }
 

src/test/java/io/ebean/config/dbplatform/H2PlatformTest.java

@@ -20,6 +20,7 @@ public class H2PlatformTest {
     assertThat(ddl.convert("varchar(20)")).isEqualTo("varchar(20)");
     assertThat(ddl.convert("decimal(10)")).isEqualTo("decimal(10)");
     assertThat(ddl.convert("decimal(8,4)")).isEqualTo("decimal(8,4)");
+    assertThat(ddl.convert("decimal")).isEqualTo("decimal(16,3)");
     assertThat(ddl.convert("boolean")).isEqualTo("boolean");
     assertThat(ddl.convert("bit")).isEqualTo("bit");
   }

src/test/java/io/ebean/config/dbplatform/HanaPlatformTest.java

@@ -27,6 +27,7 @@ public class HanaPlatformTest {
     assertThat(ddl.convert("varchar(20)")).isEqualTo("nvarchar(20)");
     assertThat(ddl.convert("decimal(10)")).isEqualTo("decimal(10)");
     assertThat(ddl.convert("decimal(8,4)")).isEqualTo("decimal(8,4)");
+    assertThat(ddl.convert("decimal")).isEqualTo("decimal(16,3)");
     assertThat(ddl.convert("boolean")).isEqualTo("boolean");
     assertThat(ddl.convert("bit")).isEqualTo("smallint");
     assertThat(ddl.convert("tinyint")).isEqualTo("smallint");

src/test/java/io/ebean/config/dbplatform/MySqlPlatformTest.java

@@ -21,6 +21,7 @@ public class MySqlPlatformTest {
     assertThat(ddl.convert("varchar(20)")).isEqualTo("varchar(20)");
     assertThat(ddl.convert("boolean")).isEqualTo("tinyint(1)");
     assertThat(ddl.convert("bit")).isEqualTo("tinyint(1)");
+    assertThat(ddl.convert("decimal")).isEqualTo("decimal(16,3)");
   }
 
   @Test

src/test/java/io/ebean/config/dbplatform/OraclePlatformTest.java

@@ -26,6 +26,7 @@ public class OraclePlatformTest {
     assertThat(ddl.convert("varchar(20)")).isEqualTo("varchar2(20)");
     assertThat(ddl.convert("decimal(10)")).isEqualTo("number(10)");
     assertThat(ddl.convert("decimal(8,4)")).isEqualTo("number(8,4)");
+    assertThat(ddl.convert("decimal")).isEqualTo("number(16,3)");
     assertThat(ddl.convert("boolean")).isEqualTo("number(1)");
     assertThat(ddl.convert("bit")).isEqualTo("bit");
     assertThat(ddl.convert("tinyint")).isEqualTo("number(3)");

src/test/java/io/ebean/config/dbplatform/PostgresPlatformTest.java

@@ -26,11 +26,11 @@ public class PostgresPlatformTest {
     assertThat(ddl.convert("tinyint")).isEqualTo("smallint");
     assertThat(ddl.convert("double")).isEqualTo("float");
     assertThat(ddl.convert("varchar(20)")).isEqualTo("varchar(20)");
+    assertThat(ddl.convert("decimal")).isEqualTo("decimal(16,3)");
     assertThat(ddl.convert("decimal(10)")).isEqualTo("decimal(10)");
     assertThat(ddl.convert("decimal(8,4)")).isEqualTo("decimal(8,4)");
     assertThat(ddl.convert("boolean")).isEqualTo("boolean");
     assertThat(ddl.convert("bit")).isEqualTo("bit");
-
   }
 
   @Test

src/test/java/io/ebean/config/dbplatform/SqlserverPlatformTest.java

@@ -26,6 +26,7 @@ public class SqlserverPlatformTest {
     assertThat(ddl.convert("varchar(20)")).isEqualTo("nvarchar(20)");
     assertThat(ddl.convert("decimal(10)")).isEqualTo("numeric(10)");
     assertThat(ddl.convert("decimal(8,4)")).isEqualTo("numeric(8,4)");
+    assertThat(ddl.convert("decimal")).isEqualTo("numeric(16,3)");
     assertThat(ddl.convert("boolean")).isEqualTo("bit");
     assertThat(ddl.convert("bit")).isEqualTo("bit");
     assertThat(ddl.convert("tinyint")).isEqualTo("smallint");