From 80253c4e078e5924b17f576f41518e7e71b3e9d7 Mon Sep 17 00:00:00 2001 From: Robin Bygrave Date: Mon, 20 Jul 2015 11:15:10 +1200 Subject: [PATCH] #339 - Remove deprecated method - save(Collection beans, Transaction transaction) ... migrate to saveAll() --- src/main/java/com/avaje/ebean/EbeanServer.java | 8 -------- .../avaje/ebeaninternal/server/core/DefaultServer.java | 8 -------- .../com/avaje/ebeaninternal/api/TDSpiEbeanServer.java | 5 ----- 3 files changed, 21 deletions(-) diff --git a/src/main/java/com/avaje/ebean/EbeanServer.java b/src/main/java/com/avaje/ebean/EbeanServer.java index 80b1b9585..336f3a497 100644 --- a/src/main/java/com/avaje/ebean/EbeanServer.java +++ b/src/main/java/com/avaje/ebean/EbeanServer.java @@ -1394,14 +1394,6 @@ public interface EbeanServer { */ void save(Object bean, Transaction transaction) throws OptimisticLockException; - /** - * Deprecated - please migrate to saveAll(). - * - * Save all the beans in the collection with an explicit transaction. - */ - @Deprecated - int save(Collection beans, Transaction transaction) throws OptimisticLockException; - /** * Save all the beans in the collection with an explicit transaction. */ diff --git a/src/main/java/com/avaje/ebeaninternal/server/core/DefaultServer.java b/src/main/java/com/avaje/ebeaninternal/server/core/DefaultServer.java index 8e4b68fdb..50d1abe9a 100644 --- a/src/main/java/com/avaje/ebeaninternal/server/core/DefaultServer.java +++ b/src/main/java/com/avaje/ebeaninternal/server/core/DefaultServer.java @@ -1681,14 +1681,6 @@ public final class DefaultServer implements SpiEbeanServer { } } - /** - * Perform an update or insert on each bean in the collection. Returns the - * number of beans that where saved. - */ - public int save(Collection c, Transaction t) { - return saveAllInternal(c.iterator(), t); - } - @Override public int saveAll(Collection beans, Transaction transaction) throws OptimisticLockException { return saveAllInternal(beans.iterator(), transaction); diff --git a/src/test/java/com/avaje/ebeaninternal/api/TDSpiEbeanServer.java b/src/test/java/com/avaje/ebeaninternal/api/TDSpiEbeanServer.java index eae141912..b6db31431 100644 --- a/src/test/java/com/avaje/ebeaninternal/api/TDSpiEbeanServer.java +++ b/src/test/java/com/avaje/ebeaninternal/api/TDSpiEbeanServer.java @@ -532,11 +532,6 @@ public class TDSpiEbeanServer implements SpiEbeanServer { public void save(Object bean, Transaction transaction) throws OptimisticLockException { } - - @Override - public int save(Collection beans, Transaction transaction) throws OptimisticLockException { - return 0; - } @Override public void markAsDirty(Object bean) {