diff --git a/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java b/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java index d3a5c9bec..dcee6530f 100644 --- a/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java +++ b/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java @@ -1202,7 +1202,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP /** * Set the value of the Version property on the bean. */ - public void setVersionValue(Object versionValue) { + private void setVersionValue(Object versionValue) { version = beanDescriptor.setVersion(entityBean, versionValue); } diff --git a/src/main/java/io/ebeaninternal/server/persist/dml/DeleteHandler.java b/src/main/java/io/ebeaninternal/server/persist/dml/DeleteHandler.java index 7dfc416e3..a5f65f257 100644 --- a/src/main/java/io/ebeaninternal/server/persist/dml/DeleteHandler.java +++ b/src/main/java/io/ebeaninternal/server/persist/dml/DeleteHandler.java @@ -14,7 +14,7 @@ public class DeleteHandler extends DmlHandler { private final DeleteMeta meta; - public DeleteHandler(PersistRequestBean persist, DeleteMeta meta) { + DeleteHandler(PersistRequestBean persist, DeleteMeta meta) { super(persist, meta.isEmptyStringAsNull()); this.meta = meta; } diff --git a/src/main/java/io/ebeaninternal/server/persist/dml/DmlHandler.java b/src/main/java/io/ebeaninternal/server/persist/dml/DmlHandler.java index a861385dc..a90e3198b 100644 --- a/src/main/java/io/ebeaninternal/server/persist/dml/DmlHandler.java +++ b/src/main/java/io/ebeaninternal/server/persist/dml/DmlHandler.java @@ -50,11 +50,6 @@ public abstract class DmlHandler implements PersistHandler, BindableRequest { protected String sql; - /** - * The generated value for the @Version property. Must be set after where clause is bound. - */ - protected Object versionValue; - protected DmlHandler(PersistRequestBean persistRequest, boolean emptyStringToNull) { this.now = System.currentTimeMillis(); this.persistRequest = persistRequest; @@ -231,30 +226,6 @@ public abstract class DmlHandler implements PersistHandler, BindableRequest { prop.bind(dataBind, value); } - /** - * Register a generated value on a update. This can not be set to the bean - * until after the where clause has been bound for concurrency checking. - *

- * GeneratedProperty values are likely going to be used for optimistic - * concurrency checking. This includes 'counter' and 'update timestamp' - * generation. - *

- */ - @Override - public void registerGeneratedVersion(Object versionValue) { - this.versionValue = versionValue; - } - - /** - * Set any update generated values to the bean. Must be called after where - * clause has been bound. - */ - public void setUpdateGenValues() { - if (versionValue != null) { - persistRequest.setVersionValue(versionValue); - } - } - /** * Check with useGeneratedKeys to get appropriate PreparedStatement. */ diff --git a/src/main/java/io/ebeaninternal/server/persist/dml/UpdateHandler.java b/src/main/java/io/ebeaninternal/server/persist/dml/UpdateHandler.java index 772396618..4d3a261b4 100644 --- a/src/main/java/io/ebeaninternal/server/persist/dml/UpdateHandler.java +++ b/src/main/java/io/ebeaninternal/server/persist/dml/UpdateHandler.java @@ -17,7 +17,7 @@ public class UpdateHandler extends DmlHandler { private boolean emptySetClause; - public UpdateHandler(PersistRequestBean persist, UpdateMeta meta) { + UpdateHandler(PersistRequestBean persist, UpdateMeta meta) { super(persist, meta.isEmptyStringAsNull()); this.meta = meta; } @@ -55,8 +55,6 @@ public class UpdateHandler extends DmlHandler { if (persistRequest.isBatched()) { batchedPstmt.registerInputStreams(dataBind.getInputStreams()); } - setUpdateGenValues(); - logSql(sql); } diff --git a/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableRequest.java b/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableRequest.java index 66a0abf2a..4a1fc6754 100644 --- a/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableRequest.java +++ b/src/main/java/io/ebeaninternal/server/persist/dmlbind/BindableRequest.java @@ -42,12 +42,6 @@ public interface BindableRequest { */ void bindNoLog(Object value, BeanProperty prop) throws SQLException; - /** - * Register the value from a update GeneratedValue. This can only be set to - * the bean property after the where clause has bean built. - */ - void registerGeneratedVersion(Object value); - /** * Return the original PersistRequest. */