diff --git a/ebean-api/pom.xml b/ebean-api/pom.xml index 22e0fd394..945d263f0 100644 --- a/ebean-api/pom.xml +++ b/ebean-api/pom.xml @@ -55,7 +55,7 @@ io.ebean ebean-annotation - 6.14-SNAPSHOT + 6.15 diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/parse/AnnotationFields.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/parse/AnnotationFields.java index 0a1bc1ff4..aafbfa182 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/parse/AnnotationFields.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/parse/AnnotationFields.java @@ -311,19 +311,23 @@ public class AnnotationFields extends AnnotationParser { DbMap dbMap = get(prop, DbMap.class); if (dbMap != null) { util.setDbMap(prop, dbMap); + setColumnName(prop, dbMap.name()); } DbJson dbJson = get(prop, DbJson.class); if (dbJson != null) { util.setDbJsonType(prop, dbJson); + setColumnName(prop, dbJson.name()); } else { DbJsonB dbJsonB = get(prop, DbJsonB.class); if (dbJsonB != null) { util.setDbJsonBType(prop, dbJsonB); + setColumnName(prop, dbJsonB.name()); } } DbArray dbArray = get(prop, DbArray.class); if (dbArray != null) { util.setDbArray(prop, dbArray); + setColumnName(prop, dbArray.name()); } } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/parse/AnnotationParser.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/parse/AnnotationParser.java index 8646aa62b..64851135d 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/parse/AnnotationParser.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/parse/AnnotationParser.java @@ -99,11 +99,7 @@ public abstract class AnnotationParser extends AnnotationBase { } void readColumn(Column columnAnn, DeployBeanProperty prop) { - - if (!isEmpty(columnAnn.name())) { - prop.setDbColumn(databasePlatform.convertQuotedIdentifiers(columnAnn.name())); - } - + setColumnName(prop, columnAnn.name()); prop.setDbInsertable(columnAnn.insertable()); prop.setDbUpdateable(columnAnn.updatable()); prop.setNullable(columnAnn.nullable()); @@ -125,6 +121,12 @@ public abstract class AnnotationParser extends AnnotationBase { } } + protected void setColumnName(DeployBeanProperty prop, String name) { + if (!isEmpty(name)) { + prop.setDbColumn(databasePlatform.convertQuotedIdentifiers(name)); + } + } + /** * Return true if the validation groups are {@link Default} (respectively empty) * can be applied to DDL generation. diff --git a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson3.java b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson3.java index 336946ab2..74f004bca 100644 --- a/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson3.java +++ b/ebean-core/src/test/java/org/tests/json/TestDbJson_Jackson3.java @@ -71,6 +71,6 @@ public class TestDbJson_Jackson3 extends BaseTestCase { final List sql = LoggedSql.stop(); assertThat(sql).hasSize(1); - assertThat(sql.get(0)).contains("update ebasic_json_list set name=?, bean_set=?, bean_list=?, plain_bean=?, version=? where id=?"); + assertThat(sql.get(0)).contains("update ebasic_json_list set name=?, beans=?, bean_list=?, plain_bean=?, version=? where id=?"); } } diff --git a/ebean-core/src/test/java/org/tests/json/TestDbJson_List.java b/ebean-core/src/test/java/org/tests/json/TestDbJson_List.java index 3686e8f16..0582818db 100644 --- a/ebean-core/src/test/java/org/tests/json/TestDbJson_List.java +++ b/ebean-core/src/test/java/org/tests/json/TestDbJson_List.java @@ -154,7 +154,7 @@ public class TestDbJson_List extends BaseTestCase { List sql = LoggedSqlCollector.stop(); // we don't update the phone numbers (as they are not dirty) - assertSql(sql.get(0)).contains("update ebasic_json_list set bean_set=?, bean_list=?, bean_map=?, plain_bean=?, version=? where id=? and version=?"); + assertSql(sql.get(0)).contains("update ebasic_json_list set beans=?, bean_list=?, bean_map=?, plain_bean=?, version=? where id=? and version=?"); } @Test diff --git a/ebean-core/src/test/java/org/tests/model/json/EBasicJsonList.java b/ebean-core/src/test/java/org/tests/model/json/EBasicJsonList.java index cf34d5826..22b32e3e1 100644 --- a/ebean-core/src/test/java/org/tests/model/json/EBasicJsonList.java +++ b/ebean-core/src/test/java/org/tests/model/json/EBasicJsonList.java @@ -22,7 +22,7 @@ public class EBasicJsonList { String name; - @DbJson(length = 700) + @DbJson(length = 700, name = "beans") Set beanSet; @DbJsonB