Replace anonymous classes with lambda expressions

src/test/java/com/avaje/tests/inheritance/TestDuplcateKeyException.java

@@ -37,17 +37,15 @@ public class TestDuplcateKeyException extends BaseTestCase {
 		holder.add(listAttribute);
 		
 		try {
-			Ebean.execute(new TxRunnable() {
-				public void run() {
-				    //Ebean.currentTransaction().log("-- saving holder first time");
-				    // Alternatively turn off cascade Persist for this transaction
-				    //Ebean.currentTransaction().setPersistCascade(false);
-					Ebean.save(holder);
-          //Ebean.currentTransaction().log("-- saving holder second time");
-					// we don't get this far before failing
-					//Ebean.save(holder);
-				}
-			});
+			Ebean.execute(() -> {
+                //Ebean.currentTransaction().log("-- saving holder first time");
+                // Alternatively turn off cascade Persist for this transaction
+                //Ebean.currentTransaction().setPersistCascade(false);
+                Ebean.save(holder);
+//Ebean.currentTransaction().log("-- saving holder second time");
+                // we don't get this far before failing
+                //Ebean.save(holder);
+            });
 		} catch (Exception e){
 			Assert.assertEquals(e.getMessage(), "test rollback");
 		}

src/test/java/com/avaje/tests/model/basic/ResetBasicData.java

@@ -23,49 +23,45 @@ public class ResetBasicData {
 
     final ResetBasicData me = new ResetBasicData();
 
-    server.execute(new TxRunnable() {
-      public void run() {
-        if (server.find(Product.class).findCount() > 0) {
-          // we can't really delete this base data as
-          // the test rely on the products being in there
-          return;
-        }
-        //me.deleteAll();
-        me.insertCountries();
-        me.insertProducts();
-        me.insertTestCustAndOrders();
+    server.execute(() -> {
+      if (server.find(Product.class).findCount() > 0) {
+        // we can't really delete this base data as
+        // the test rely on the products being in there
+        return;
       }
+      //me.deleteAll();
+      me.insertCountries();
+      me.insertProducts();
+      me.insertTestCustAndOrders();
     });
     runOnce = true;
   }
 
 
   public void deleteAll() {
-    Ebean.execute(new TxRunnable() {
-      public void run() {
+    Ebean.execute(() -> {
 
-        // orm update use bean name and bean properties
-        server.createSqlUpdate("delete from o_cached_bean_child").execute();
-        server.createSqlUpdate("delete from o_cached_bean_country").execute();
-        server.createSqlUpdate("delete from o_cached_bean").execute();
+      // orm update use bean name and bean properties
+      server.createSqlUpdate("delete from o_cached_bean_child").execute();
+      server.createSqlUpdate("delete from o_cached_bean_country").execute();
+      server.createSqlUpdate("delete from o_cached_bean").execute();
 
-        server.createUpdate(OrderShipment.class, "delete from orderShipment").execute();
+      server.createUpdate(OrderShipment.class, "delete from orderShipment").execute();
 
-        server.createUpdate(OrderDetail.class, "delete from orderDetail").execute();
+      server.createUpdate(OrderDetail.class, "delete from orderDetail").execute();
 
-        server.createUpdate(Order.class, "delete from order").execute();
+      server.createUpdate(Order.class, "delete from order").execute();
 
-        server.createUpdate(Contact.class, "delete from contact").execute();
+      server.createUpdate(Contact.class, "delete from contact").execute();
 
-        server.createUpdate(Customer.class, "delete from Customer").execute();
+      server.createUpdate(Customer.class, "delete from Customer").execute();
 
-        server.createUpdate(Address.class, "delete from address").execute();
+      server.createUpdate(Address.class, "delete from address").execute();
 
-        // sql update uses table and column names
-        server.createSqlUpdate("delete from o_country").execute();
-        server.createSqlUpdate("delete from o_product").execute();
+      // sql update uses table and column names
+      server.createSqlUpdate("delete from o_country").execute();
+      server.createSqlUpdate("delete from o_product").execute();
 
-      }
     });
   }
 
@@ -76,18 +72,16 @@ public class ResetBasicData {
       return;
     }
 
-    server.execute(new TxRunnable() {
-      public void run() {
-        Country c = new Country();
-        c.setCode("NZ");
-        c.setName("New Zealand");
-        server.save(c);
+    server.execute(() -> {
+      Country c = new Country();
+      c.setCode("NZ");
+      c.setName("New Zealand");
+      server.save(c);
 
-        Country au = new Country();
-        au.setCode("AU");
-        au.setName("Australia");
-        server.save(au);
-      }
+      Country au = new Country();
+      au.setCode("AU");
+      au.setName("Australia");
+      server.save(au);
     });
   }
 
@@ -97,46 +91,42 @@ public class ResetBasicData {
     if (server.find(Product.class).findCount() > 0) {
       return;
     }
-    server.execute(new TxRunnable() {
-      public void run() {
-        Product p = new Product();
-        p.setName("Chair");
-        p.setSku("C001");
-        server.save(p);
+    server.execute(() -> {
+      Product p = new Product();
+      p.setName("Chair");
+      p.setSku("C001");
+      server.save(p);
 
-        p = new Product();
-        p.setName("Desk");
-        p.setSku("DSK1");
-        server.save(p);
+      p = new Product();
+      p.setName("Desk");
+      p.setSku("DSK1");
+      server.save(p);
 
-        p = new Product();
-        p.setName("Computer");
-        p.setSku("C002");
-        server.save(p);
+      p = new Product();
+      p.setName("Computer");
+      p.setSku("C002");
+      server.save(p);
 
-        p = new Product();
-        p.setName("Printer");
-        p.setSku("C003");
-        server.save(p);
-      }
+      p = new Product();
+      p.setName("Printer");
+      p.setSku("C003");
+      server.save(p);
     });
   }
 
   public void insertTestCustAndOrders() {
 
-    Ebean.execute(new TxRunnable() {
-      public void run() {
-        Customer cust1 = insertCustomer("Rob");
-        Customer cust2 = insertCustomerNoAddress();
-        insertCustomerFiona();
-        insertCustomerNoContacts("NocCust");
+    Ebean.execute(() -> {
+      Customer cust1 = insertCustomer("Rob");
+      Customer cust2 = insertCustomerNoAddress();
+      insertCustomerFiona();
+      insertCustomerNoContacts("NocCust");
 
-        createOrder1(cust1);
-        createOrder2(cust2);
-        createOrder3(cust1);
-        createOrder4(cust1);
-        createOrder5(cust2);
-      }
+      createOrder1(cust1);
+      createOrder2(cust2);
+      createOrder3(cust1);
+      createOrder4(cust1);
+      createOrder5(cust2);
     });
   }
 

src/test/java/com/avaje/tests/model/selfref/TestTextJsonSelfRef.java

@@ -15,26 +15,24 @@ public class TestTextJsonSelfRef extends BaseTestCase {
   @Test
   public void test() {
 
-    Ebean.execute(new TxRunnable() {
-      public void run() {
+    Ebean.execute(() -> {
 
-        if (Ebean.find(SelfRefCustomer.class).findCount() == 0) {
-          SelfRefCustomer c1 = new SelfRefCustomer();
-          c1.setName("Foo");
-          c1.setReferredBy(c1);
+      if (Ebean.find(SelfRefCustomer.class).findCount() == 0) {
+        SelfRefCustomer c1 = new SelfRefCustomer();
+        c1.setName("Foo");
+        c1.setReferredBy(c1);
 
-          SelfRefCustomer c2 = new SelfRefCustomer();
-          c2.setName("Bar");
-          c2.setReferredBy(c1);
+        SelfRefCustomer c2 = new SelfRefCustomer();
+        c2.setName("Bar");
+        c2.setReferredBy(c1);
 
-          SelfRefCustomer c3 = new SelfRefCustomer();
-          c3.setName("baz");
-          c3.setReferredBy(c1);
+        SelfRefCustomer c3 = new SelfRefCustomer();
+        c3.setName("baz");
+        c3.setReferredBy(c1);
 
-          Ebean.save(c1);
-          Ebean.save(c2);
-          Ebean.save(c3);
-        }
+        Ebean.save(c1);
+        Ebean.save(c2);
+        Ebean.save(c3);
       }
     });
 

src/test/java/com/avaje/tests/query/TestOneToManyCorrectGrouping.java

@@ -28,14 +28,11 @@ public class TestOneToManyCorrectGrouping extends BaseTestCase {
 
     final AtomicInteger count = new AtomicInteger();
 
-    customerQuery.findEach(new QueryEachConsumer<Customer>() {
-      @Override
-      public void accept(Customer customer) {
-        for (Order order : customer.getOrders()) {
-          order.getId();
-        }
-        count.incrementAndGet();
+    customerQuery.findEach(customer -> {
+      for (Order order : customer.getOrders()) {
+        order.getId();
       }
+      count.incrementAndGet();
     });
     assertEquals(EXPECTED_ITERATIONS, count.get());
   }

src/test/java/com/avaje/tests/query/TestQueryFindEach.java

@@ -25,12 +25,9 @@ public class TestQueryFindEach extends BaseTestCase {
 
     final AtomicInteger counter = new AtomicInteger(0);
 
-    query.findEach(new QueryEachConsumer<Customer>() {
-
-      public void accept(Customer customer) {
-        counter.incrementAndGet();
-        customer.getName();
-      }
+    query.findEach(customer -> {
+      counter.incrementAndGet();
+      customer.getName();
     });
 
     Assert.assertEquals(2, counter.get());
@@ -52,13 +49,10 @@ public class TestQueryFindEach extends BaseTestCase {
 
     final AtomicInteger counter = new AtomicInteger(0);
 
-    query.findEach(new QueryEachConsumer<Customer>() {
-
-      public void accept(Customer customer) {
-        counter.incrementAndGet();
-        if (counter.intValue() > 0) {
-          throw new IllegalStateException("cause a failure");
-        }
+    query.findEach(customer -> {
+      counter.incrementAndGet();
+      if (counter.intValue() > 0) {
+        throw new IllegalStateException("cause a failure");
       }
     });
 

src/test/java/com/avaje/tests/query/TestQueryFindEachWhile.java

@@ -25,13 +25,10 @@ public class TestQueryFindEachWhile extends BaseTestCase {
 
     final AtomicInteger counter = new AtomicInteger(0);
 
-    query.findEachWhile(new QueryEachWhileConsumer< Customer > () {
-
-      public boolean accept(Customer customer) {
-        counter.incrementAndGet();
-        customer.getName();
-        return true;
-      }
+    query.findEachWhile(customer -> {
+      counter.incrementAndGet();
+      customer.getName();
+      return true;
     });
 
     Assert.assertEquals(2, counter.get());
@@ -53,15 +50,12 @@ public class TestQueryFindEachWhile extends BaseTestCase {
 
     final AtomicInteger counter = new AtomicInteger(0);
 
-    query.findEachWhile(new QueryEachWhileConsumer<Customer>() {
-
-      public boolean accept(Customer customer) {
-        counter.incrementAndGet();
-        if (counter.intValue() > 0) {
-          throw new IllegalStateException("cause a failure");
-        }
-        return true;
+    query.findEachWhile(customer -> {
+      counter.incrementAndGet();
+      if (counter.intValue() > 0) {
+        throw new IllegalStateException("cause a failure");
       }
+      return true;
     });
 
     Assert.assertFalse("Never get here - exception thrown", true);

src/test/java/com/avaje/tests/query/TestQueryFindIterate.java

@@ -94,12 +94,7 @@ public class TestQueryFindIterate extends BaseTestCase {
 
     final AtomicInteger count = new AtomicInteger();
 
-    query.findEach(new QueryEachConsumer<Customer>() {
-      @Override
-      public void accept(Customer bean) {
-        count.incrementAndGet();
-      }
-    });
+    query.findEach(bean -> count.incrementAndGet());
 
     assertEquals(2, count.get());
   }
@@ -112,16 +107,13 @@ public class TestQueryFindIterate extends BaseTestCase {
     Ebean.find(Order.class)
             //.select("orderDate")
             .where().gt("id",0).le("id",10)
-            .findEach(new QueryEachConsumer<Order>() {
-              @Override
-              public void accept(Order order) {
-                Customer customer = order.getCustomer();
-                // invoke lazy loading on customer, order details and order shipments
-                order.getId();
-                customer.getName();
-                order.getDetails().size();
-                order.getShipments().size();
-              }
+            .findEach(order -> {
+              Customer customer = order.getCustomer();
+              // invoke lazy loading on customer, order details and order shipments
+              order.getId();
+              customer.getName();
+              order.getDetails().size();
+              order.getShipments().size();
             });
 
   }
@@ -139,14 +131,11 @@ public class TestQueryFindIterate extends BaseTestCase {
       .fetch("customer", "name")
       .where().gt("id",0).le("id",10)
       .setUseCache(false)
-      .findEach(new QueryEachConsumer<Order>() {
-        @Override
-        public void accept(Order order) {
-          Customer customer = order.getCustomer();
-          customer.getName();
-          order.getDetails().size();
-          order.getShipments().size();
-        }
+      .findEach(order -> {
+        Customer customer = order.getCustomer();
+        customer.getName();
+        order.getDetails().size();
+        order.getShipments().size();
       });
 
 
@@ -179,15 +168,12 @@ public class TestQueryFindIterate extends BaseTestCase {
           .fetch("details")
           .where().gt("id",0).le("id",10)
           .order().asc("id")
-          .findEach(new QueryEachConsumer<Order>() {
-            @Override
-            public void accept(Order order) {
-              Customer customer = order.getCustomer();
-              order.getId();
-              customer.getName();
-              order.getDetails().size();
-              order.getShipments().size();
-            }
+          .findEach(order -> {
+            Customer customer = order.getCustomer();
+            order.getId();
+            customer.getName();
+            order.getDetails().size();
+            order.getShipments().size();
           });
 
     List<String> loggedSql = LoggedSqlCollector.stop();
@@ -211,11 +197,8 @@ public class TestQueryFindIterate extends BaseTestCase {
         .setMaxRows(2);
 
     // this throws an exception immediately
-    query.findEach(new QueryEachConsumer<Customer>() {
-      @Override
-      public void accept(Customer bean) {
+    query.findEach(bean -> {
 
-      }
     });
 
     if (!server.getName().equals("h2")) {
@@ -238,12 +221,9 @@ public class TestQueryFindIterate extends BaseTestCase {
         .where().gt("id", 0)
         .setMaxRows(2);
 
-    query.findEach(new QueryEachConsumer<Customer>() {
-      @Override
-      public void accept(Customer customer) {
-        if (customer != null) {
-          throw new IllegalStateException("cause an exception");
-        }
+    query.findEach(customer -> {
+      if (customer != null) {
+        throw new IllegalStateException("cause an exception");
       }
     });
   }

src/test/java/com/avaje/tests/query/TestQueryFindVisit.java

@@ -28,11 +28,7 @@ public class TestQueryFindVisit extends BaseTestCase {
 
     final AtomicInteger counter = new AtomicInteger(0);
 
-    query.findEach(new QueryEachConsumer<Customer>() {
-      public void accept(Customer bean) {
-        counter.incrementAndGet();
-      }
-    });
+    query.findEach(bean -> counter.incrementAndGet());
 
     Assert.assertEquals(2, counter.get());
   }
@@ -53,13 +49,10 @@ public class TestQueryFindVisit extends BaseTestCase {
 
     final AtomicInteger counter = new AtomicInteger(0);
 
-    query.findEach(new QueryEachConsumer<Customer>() {
-
-      public void accept(Customer bean) {
-        counter.incrementAndGet();
-        if (counter.intValue() > 0) {
-          throw new IllegalStateException("cause a failure");
-        }
+    query.findEach(bean -> {
+      counter.incrementAndGet();
+      if (counter.intValue() > 0) {
+        throw new IllegalStateException("cause a failure");
       }
     });
 

src/test/java/com/avaje/tests/query/lazy/TestQueryDefaultBatchSize.java

@@ -21,12 +21,7 @@ public class TestQueryDefaultBatchSize extends BaseTestCase {
 
     Ebean.find(Order.class)
           .setLazyLoadBatchSize(2)
-          .findEach(new QueryEachConsumer<Order>() {
-            @Override
-            public void accept(Order bean) {
-              doStuff(bean);
-            }
-          });
+          .findEach(bean -> doStuff(bean));
   }
 
   @Test
@@ -40,12 +35,7 @@ public class TestQueryDefaultBatchSize extends BaseTestCase {
           .fetch("customer")
           .fetch("customer.contacts")
           .setLazyLoadBatchSize(2)
-          .findEach(new QueryEachConsumer<Order>() {
-            @Override
-            public void accept(Order bean) {
-              doStuff(bean);
-            }
-          });
+          .findEach(bean -> doStuff(bean));
   }
 
   @Test

src/test/java/com/avaje/tests/query/other/TestFindIterateHeapDump.java

@@ -59,14 +59,11 @@ public class TestFindIterateHeapDump extends BaseTestCase {
     final AtomicInteger counter = new AtomicInteger();
 
     server.find(EBasic.class)
-        .findEach(new QueryEachConsumer<EBasic>() {
-          @Override
-          public void accept(EBasic bean) {
+        .findEach(bean -> {
 
-            int count = counter.incrementAndGet();
-            if (count == 1) {
-              dumpHeap("heap-dump13-initial.snapshot", true);
-            }
+          int count = counter.incrementAndGet();
+          if (count == 1) {
+            dumpHeap("heap-dump13-initial.snapshot", true);
           }
         });
 

src/test/java/com/avaje/tests/query/sqlquery/SqlQueryTests.java

@@ -95,12 +95,7 @@ public class SqlQueryTests extends BaseTestCase {
     sqlQuery.setMaxRows(10);
 
     LoggedSqlCollector.start();
-    sqlQuery.findEach(new QueryEachConsumer<SqlRow>() {
-      @Override
-      public void accept(SqlRow bean) {
-        bean.get("id");
-      }
-    });
+    sqlQuery.findEach(bean -> bean.get("id"));
     List<String> sql = LoggedSqlCollector.stop();
 
     assertThat(sql.get(0)).contains("limit 10");
@@ -116,12 +111,7 @@ public class SqlQueryTests extends BaseTestCase {
     final AtomicInteger count = new AtomicInteger();
 
     SqlQuery sqlQuery = Ebean.createSqlQuery("select * from o_order");
-    sqlQuery.findEach(new QueryEachConsumer<SqlRow>() {
-      @Override
-      public void accept(SqlRow bean) {
-        count.incrementAndGet();
-      }
-    });
+    sqlQuery.findEach(bean -> count.incrementAndGet());
 
     assertEquals(expectedRows, count.get());
   }
@@ -134,13 +124,10 @@ public class SqlQueryTests extends BaseTestCase {
     final AtomicInteger count = new AtomicInteger();
 
     SqlQuery sqlQuery = Ebean.createSqlQuery("select * from o_order order by id");
-    sqlQuery.findEachWhile(new QueryEachWhileConsumer<SqlRow>() {
-      @Override
-      public boolean accept(SqlRow bean) {
-        count.incrementAndGet();
-        Integer id = bean.getInteger("id");
-        return id < 3;
-      }
+    sqlQuery.findEachWhile(bean -> {
+      count.incrementAndGet();
+      Integer id = bean.getInteger("id");
+      return id < 3;
     });
 
     assertEquals(3, count.get());

src/test/java/com/avaje/tests/readaudit/TestReadAudit.java

@@ -284,12 +284,7 @@ public class TestReadAudit extends BaseTestCase {
     final AtomicInteger count = new AtomicInteger();
     server.find(EBasicChangeLog.class)
         .where().startsWith("shortDescription", "readAudit")
-        .findEach(new QueryEachConsumer<EBasicChangeLog>() {
-          @Override
-          public void accept(EBasicChangeLog bean) {
-            count.incrementAndGet();
-          }
-        });
+        .findEach(bean -> count.incrementAndGet());
 
     assertThat(count.get()).isEqualTo(2);
     assertThat(readAuditPrepare.count).isEqualTo(1);
@@ -299,12 +294,7 @@ public class TestReadAudit extends BaseTestCase {
 
     server.find(EBasicChangeLog.class)
         .where().startsWith("shortDescription", "readAudit")
-        .findEach(new QueryEachConsumer<EBasicChangeLog>() {
-          @Override
-          public void accept(EBasicChangeLog bean) {
-            count.incrementAndGet();
-          }
-        });
+        .findEach(bean -> count.incrementAndGet());
 
     assertThat(readAuditPrepare.count).isEqualTo(2);
     assertThat(readAuditLogger.plans).hasSize(1);

src/test/java/com/avaje/tests/transaction/TestNested.java

@@ -13,12 +13,7 @@ public class TestNested extends BaseTestCase {
   public void test() {
 
     try {
-      Ebean.execute(new TxRunnable() {
-        public void run() {
-
-          willFail();
-        }
-      });
+      Ebean.execute(() -> willFail());
     } catch (RuntimeException e) {
       Assert.assertEquals(e.getMessage(), "test rollback");
     }

src/test/java/com/avaje/tests/update/TestSqlUpdateInTxn.java

@@ -43,17 +43,15 @@ public class TestSqlUpdateInTxn extends BaseTestCase {
     Assert.assertEquals("foo2", log3.getDescription());
     Assert.assertEquals("mod0", log3.getModifiedDescription());
 
-    Ebean.execute(new TxRunnable() {  
-      public void run() {  
-        SqlUpdate update = Ebean.createSqlUpdate(  updateDml ) ;
-        update.setParameter("desc", "foo3");
-        update.setParameter("id", id);
-        update.execute();
+    Ebean.execute(() -> {
+      SqlUpdate update = Ebean.createSqlUpdate(  updateDml ) ;
+      update.setParameter("desc", "foo3");
+      update.setParameter("id", id);
+      update.execute();
 
-        SqlUpdate updateMod = Ebean.createSqlUpdate(  updateModDml ) ;
-        updateMod.setParameter("desc", "mod1");
-        updateMod.execute();
-      }  
+      SqlUpdate updateMod1 = Ebean.createSqlUpdate(  updateModDml ) ;
+      updateMod1.setParameter("desc", "mod1");
+      updateMod1.execute();
     });
 
     AuditLog log4 = Ebean.find(AuditLog.class, log.getId());