diff --git a/ebean-api/src/main/java/io/ebean/Query.java b/ebean-api/src/main/java/io/ebean/Query.java index 0bc8939f3..400c9775e 100644 --- a/ebean-api/src/main/java/io/ebean/Query.java +++ b/ebean-api/src/main/java/io/ebean/Query.java @@ -2,6 +2,7 @@ package io.ebean; import io.avaje.lang.NonNullApi; import io.avaje.lang.Nullable; + import javax.persistence.NonUniqueResultException; import java.sql.Connection; import java.sql.Timestamp; @@ -1372,18 +1373,9 @@ public interface Query extends CancelableQuery { * optional asc and desc keywords representing ascending and descending order * respectively. */ - Query order(String orderByClause); - - /** - * Return the OrderBy so that you can append an ascending or descending - * property to the order by clause. - *

- * This will never return a null. If no order by clause exists then an 'empty' - * OrderBy object is returned. - *

- * This is the same as orderBy() - */ - OrderBy order(); + default Query order(String orderByClause) { + return orderBy(orderByClause); + } /** * Return the OrderBy so that you can append an ascending or descending @@ -1397,15 +1389,30 @@ public interface Query extends CancelableQuery { OrderBy orderBy(); /** - * Set an OrderBy object to replace any existing OrderBy clause. + * Return the OrderBy so that you can append an ascending or descending + * property to the order by clause. + *

+ * This will never return a null. If no order by clause exists then an 'empty' + * OrderBy object is returned. + *

+ * This is the same as orderBy() */ - Query setOrder(OrderBy orderBy); + default OrderBy order() { + return orderBy(); + } /** * Set an OrderBy object to replace any existing OrderBy clause. */ Query setOrderBy(OrderBy orderBy); + /** + * Set an OrderBy object to replace any existing OrderBy clause. + */ + default Query setOrder(OrderBy orderBy) { + return setOrderBy(orderBy); + } + /** * Set whether this query uses DISTINCT. *

diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultFetchGroupQuery.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultFetchGroupQuery.java index da8caf0b1..fbc791937 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultFetchGroupQuery.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultFetchGroupQuery.java @@ -432,26 +432,11 @@ final class DefaultFetchGroupQuery implements SpiFetchGroupQuery, SpiQuery throw new RuntimeException("EB102: Only select() and fetch() clause is allowed on FetchGroup"); } - @Override - public Query order(String orderByClause) { - throw new RuntimeException("EB102: Only select() and fetch() clause is allowed on FetchGroup"); - } - - @Override - public OrderBy order() { - throw new RuntimeException("EB102: Only select() and fetch() clause is allowed on FetchGroup"); - } - @Override public OrderBy orderBy() { throw new RuntimeException("EB102: Only select() and fetch() clause is allowed on FetchGroup"); } - @Override - public Query setOrder(OrderBy orderBy) { - throw new RuntimeException("EB102: Only select() and fetch() clause is allowed on FetchGroup"); - } - @Override public Query setOrderBy(OrderBy orderBy) { throw new RuntimeException("EB102: Only select() and fetch() clause is allowed on FetchGroup"); diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java b/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java index 5fedd3b40..1736618dc 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/querydefn/DefaultOrmQuery.java @@ -1614,11 +1614,6 @@ public final class DefaultOrmQuery extends AbstractQuery implements SpiQuery< @Override public OrderBy orderBy() { - return order(); - } - - @Override - public OrderBy order() { if (orderBy == null) { orderBy = new OrderBy<>(this, null); } @@ -1627,11 +1622,6 @@ public final class DefaultOrmQuery extends AbstractQuery implements SpiQuery< @Override public Query orderBy(String orderByClause) { - return order(orderByClause); - } - - @Override - public Query order(String orderByClause) { if (orderByClause == null || orderByClause.trim().isEmpty()) { this.orderBy = null; } else { @@ -1642,11 +1632,6 @@ public final class DefaultOrmQuery extends AbstractQuery implements SpiQuery< @Override public Query setOrderBy(OrderBy orderBy) { - return setOrder(orderBy); - } - - @Override - public Query setOrder(OrderBy orderBy) { this.orderBy = orderBy; if (orderBy != null) { orderBy.setQuery(this);