diff --git a/ebean-api/src/main/java/io/ebean/DbContext.java b/ebean-api/src/main/java/io/ebean/DbContext.java
index c098f079a..3dca530a6 100644
--- a/ebean-api/src/main/java/io/ebean/DbContext.java
+++ b/ebean-api/src/main/java/io/ebean/DbContext.java
@@ -4,11 +4,12 @@ import io.ebean.config.BeanNotEnhancedException;
import io.ebean.datasource.DataSourceConfigurationException;
import javax.persistence.PersistenceException;
-import java.lang.System.Logger.Level;
import java.util.HashMap;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.ERROR;
+
/**
* Holds Database instances.
*/
@@ -52,7 +53,7 @@ final class DbContext {
throw new DataSourceConfigurationException(msg, e);
} catch (Throwable e) {
- log.log(Level.ERROR, "Error trying to create the default Database", e);
+ log.log(ERROR, "Error trying to create the default Database", e);
throw new RuntimeException(e);
}
}
diff --git a/ebean-api/src/main/java/io/ebean/EbeanVersion.java b/ebean-api/src/main/java/io/ebean/EbeanVersion.java
index 7eaf5a52a..aeb855efc 100644
--- a/ebean-api/src/main/java/io/ebean/EbeanVersion.java
+++ b/ebean-api/src/main/java/io/ebean/EbeanVersion.java
@@ -6,9 +6,10 @@ import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.LineNumberReader;
-import java.lang.System.Logger.Level;
import java.util.Properties;
+import static java.lang.System.Logger.Level.*;
+
/**
* Class to determine the ebean version.
*
@@ -36,12 +37,12 @@ public final class EbeanVersion {
if (in != null) {
try (LineNumberReader reader = new LineNumberReader(new InputStreamReader(in))) {
version = reader.readLine();
- log.log(Level.INFO, "ebean version: {0}", version);
+ log.log(INFO, "ebean version: {0}", version);
}
}
}
} catch (IOException e) {
- log.log(Level.WARNING, "Could not determine ebean version: {0}", e.getMessage());
+ log.log(WARNING, "Could not determine ebean version: {0}", e.getMessage());
}
}
@@ -53,13 +54,13 @@ public final class EbeanVersion {
String agentVersion = readVersion(in);
if (agentVersion != null) {
if (checkMinAgentVersion(agentVersion)) {
- log.log(Level.ERROR, "Expected minimum ebean-agent version {0}.{1}.0 but we have {2}, please update the ebean-agent", MIN_AGENT_MAJOR_VERSION, MIN_AGENT_MINOR_VERSION, agentVersion);
+ log.log(ERROR, "Expected minimum ebean-agent version {0}.{1}.0 but we have {2}, please update the ebean-agent", MIN_AGENT_MAJOR_VERSION, MIN_AGENT_MINOR_VERSION, agentVersion);
}
}
}
}
} catch (IOException e) {
- log.log(Level.WARNING, "Could not check minimum ebean-agent version {0}.{1}.0 required due to - {2}", MIN_AGENT_MAJOR_VERSION, MIN_AGENT_MINOR_VERSION, e.getMessage());
+ log.log(WARNING, "Could not check minimum ebean-agent version {0}.{1}.0 required due to - {2}", MIN_AGENT_MAJOR_VERSION, MIN_AGENT_MINOR_VERSION, e.getMessage());
}
}
diff --git a/ebean-api/src/main/java/io/ebean/config/dbplatform/DatabasePlatform.java b/ebean-api/src/main/java/io/ebean/config/dbplatform/DatabasePlatform.java
index 53d416372..3bb2cced8 100644
--- a/ebean-api/src/main/java/io/ebean/config/dbplatform/DatabasePlatform.java
+++ b/ebean-api/src/main/java/io/ebean/config/dbplatform/DatabasePlatform.java
@@ -11,9 +11,10 @@ import io.ebean.util.JdbcClose;
import javax.persistence.PersistenceException;
import javax.sql.DataSource;
-import java.lang.System.Logger.Level;
import java.sql.*;
+import static java.lang.System.Logger.Level.*;
+
/**
* Database platform specific settings.
*/
@@ -659,7 +660,7 @@ public class DatabasePlatform {
if (isQuote(dbName.charAt(dbName.length() - 1))) {
return openQuote + dbName.substring(1, dbName.length() - 1) + closeQuote;
} else {
- log.log(Level.ERROR, "Missing backquote on [" + dbName + "]");
+ log.log(ERROR, "Missing backquote on [" + dbName + "]");
}
} else if (allQuotedIdentifiers) {
return openQuote + dbName + closeQuote;
@@ -722,7 +723,7 @@ public class DatabasePlatform {
protected String withForUpdate(String sql, Query.LockWait lockWait, Query.LockType lockType) {
// silently assume the database does not support the "for update" clause.
- log.log(Level.INFO, "it seems your database does not support the 'for update' clause");
+ log.log(INFO, "it seems your database does not support the 'for update' clause");
return sql;
}
@@ -756,7 +757,7 @@ public class DatabasePlatform {
if (!schemaExists(dbSchema, connection)) {
Statement query = connection.createStatement();
try {
- log.log(Level.DEBUG, "create schema:{0}", dbSchema);
+ log.log(DEBUG, "create schema:{0}", dbSchema);
query.executeUpdate("create schema " + dbSchema);
} finally {
JdbcClose.close(query);
diff --git a/ebean-api/src/main/java/io/ebean/config/dbplatform/SequenceIdGenerator.java b/ebean-api/src/main/java/io/ebean/config/dbplatform/SequenceIdGenerator.java
index 658c5e94e..246e8f1c0 100644
--- a/ebean-api/src/main/java/io/ebean/config/dbplatform/SequenceIdGenerator.java
+++ b/ebean-api/src/main/java/io/ebean/config/dbplatform/SequenceIdGenerator.java
@@ -7,7 +7,6 @@ import io.ebean.util.JdbcClose;
import javax.persistence.PersistenceException;
import javax.sql.DataSource;
-import java.lang.System.Logger.Level;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
@@ -19,6 +18,9 @@ import java.util.TreeSet;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.DEBUG;
+import static java.lang.System.Logger.Level.ERROR;
+
/**
* Database sequence based IdGenerator.
*/
@@ -120,7 +122,7 @@ public abstract class SequenceIdGenerator implements PlatformIdGenerator {
protected void loadInBackground(final int requestSize) {
if (currentlyBackgroundLoading.get()) {
// skip as already background loading
- log.log(Level.DEBUG, "... skip background sequence load (another load in progress)");
+ log.log(DEBUG, "... skip background sequence load (another load in progress)");
return;
}
currentlyBackgroundLoading.set(true);
@@ -161,7 +163,7 @@ public abstract class SequenceIdGenerator implements PlatformIdGenerator {
} catch (SQLException e) {
if (e.getMessage().contains("Database is already closed")) {
String msg = "Error getting SEQ when DB shutting down " + e.getMessage();
- log.log(Level.ERROR, msg);
+ log.log(ERROR, msg);
System.out.println(msg);
return Collections.emptyList();
} else {
diff --git a/ebean-api/src/main/java/io/ebean/event/ShutdownManager.java b/ebean-api/src/main/java/io/ebean/event/ShutdownManager.java
index 2547ee542..3de1bb10b 100644
--- a/ebean-api/src/main/java/io/ebean/event/ShutdownManager.java
+++ b/ebean-api/src/main/java/io/ebean/event/ShutdownManager.java
@@ -4,7 +4,6 @@ import io.ebean.Database;
import io.ebean.EbeanVersion;
import io.ebean.service.SpiContainer;
-import java.lang.System.Logger.Level;
import java.sql.Driver;
import java.sql.DriverManager;
import java.sql.SQLException;
@@ -13,6 +12,8 @@ import java.util.Enumeration;
import java.util.List;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.*;
+
/**
* Manages the shutdown of Ebean.
*
@@ -121,8 +122,8 @@ public final class ShutdownManager {
// Already run shutdown...
return;
}
- if (log.isLoggable(Level.DEBUG)) {
- log.log(Level.DEBUG, "Ebean shutting down");
+ if (log.isLoggable(DEBUG)) {
+ log.log(DEBUG, "Ebean shutting down");
}
stopping = true;
deregisterShutdownHook();
@@ -134,7 +135,7 @@ public final class ShutdownManager {
Runnable r = (Runnable) ClassUtil.newInstance(shutdownRunner);
r.run();
} catch (Exception e) {
- log.log(Level.ERROR, "Error running custom shutdown runnable", e);
+ log.log(ERROR, "Error running custom shutdown runnable", e);
}
}
@@ -148,7 +149,7 @@ public final class ShutdownManager {
try {
server.shutdown();
} catch (Exception ex) {
- log.log(Level.ERROR, "Error executing shutdown runnable", ex);
+ log.log(ERROR, "Error executing shutdown runnable", ex);
ex.printStackTrace();
}
}
@@ -166,10 +167,10 @@ public final class ShutdownManager {
while (drivers.hasMoreElements()) {
Driver driver = drivers.nextElement();
try {
- log.log(Level.INFO, "De-registering jdbc driver: " + driver);
+ log.log(INFO, "De-registering jdbc driver: " + driver);
DriverManager.deregisterDriver(driver);
} catch (SQLException e) {
- log.log(Level.ERROR, "Error de-registering driver " + driver, e);
+ log.log(ERROR, "Error de-registering driver " + driver, e);
}
}
}
diff --git a/ebean-api/src/main/java/io/ebean/text/csv/DefaultCsvCallback.java b/ebean-api/src/main/java/io/ebean/text/csv/DefaultCsvCallback.java
index d2e6d3f98..3fcc8cc51 100644
--- a/ebean-api/src/main/java/io/ebean/text/csv/DefaultCsvCallback.java
+++ b/ebean-api/src/main/java/io/ebean/text/csv/DefaultCsvCallback.java
@@ -4,7 +4,8 @@ import io.ebean.Database;
import io.ebean.EbeanVersion;
import io.ebean.Transaction;
-import java.lang.System.Logger.Level;
+import static java.lang.System.Logger.Level.DEBUG;
+import static java.lang.System.Logger.Level.INFO;
/**
* Provides the default implementation of CsvCallback.
@@ -129,7 +130,7 @@ public class DefaultCsvCallback implements CsvCallback {
// related beans (e.g. customer -> customer.billingAddress
server.save(bean, transaction);
if (logInfoFrequency > 0 && (row % logInfoFrequency == 0)) {
- log.log(Level.DEBUG, "processed {0} rows", row);
+ log.log(DEBUG, "processed {0} rows", row);
}
}
@@ -140,7 +141,7 @@ public class DefaultCsvCallback implements CsvCallback {
public void end(int row) {
commitTransactionIfCreated();
exeTime = System.currentTimeMillis() - startTime;
- log.log(Level.INFO, "Csv finished, rows[{0}] exeMillis[{1}]", row, exeTime);
+ log.log(INFO, "Csv finished, rows[{0}] exeMillis[{1}]", row, exeTime);
}
/**
diff --git a/ebean-api/src/main/java/io/ebean/util/JdbcClose.java b/ebean-api/src/main/java/io/ebean/util/JdbcClose.java
index b450db79a..d6b35539c 100644
--- a/ebean-api/src/main/java/io/ebean/util/JdbcClose.java
+++ b/ebean-api/src/main/java/io/ebean/util/JdbcClose.java
@@ -2,12 +2,13 @@ package io.ebean.util;
import io.ebean.EbeanVersion;
-import java.lang.System.Logger.Level;
import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
+import static java.lang.System.Logger.Level.WARNING;
+
/**
* Utility for closing raw Jdbc resources.
*/
@@ -24,7 +25,7 @@ public final class JdbcClose {
statement.close();
}
} catch (SQLException e) {
- log.log(Level.WARNING, "Error closing statement", e);
+ log.log(WARNING, "Error closing statement", e);
}
}
@@ -37,7 +38,7 @@ public final class JdbcClose {
resultSet.close();
}
} catch (SQLException e) {
- log.log(Level.WARNING, "Error closing resultSet", e);
+ log.log(WARNING, "Error closing resultSet", e);
}
}
@@ -50,7 +51,7 @@ public final class JdbcClose {
connection.close();
}
} catch (SQLException e) {
- log.log(Level.WARNING, "Error closing connection", e);
+ log.log(WARNING, "Error closing connection", e);
}
}
@@ -63,7 +64,7 @@ public final class JdbcClose {
connection.rollback();
}
} catch (SQLException e) {
- log.log(Level.WARNING, "Error on connection rollback", e);
+ log.log(WARNING, "Error on connection rollback", e);
}
}
@@ -76,7 +77,7 @@ public final class JdbcClose {
stmt.cancel();
}
} catch (SQLException e) {
- log.log(Level.WARNING, "Error on cancelling statement", e);
+ log.log(WARNING, "Error on cancelling statement", e);
}
}
}
diff --git a/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/DefaultAutoTuneService.java b/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/DefaultAutoTuneService.java
index be43c42af..a0031f938 100644
--- a/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/DefaultAutoTuneService.java
+++ b/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/DefaultAutoTuneService.java
@@ -12,10 +12,11 @@ import io.ebeaninternal.server.autotune.model.Origin;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
-import java.lang.System.Logger.Level;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.*;
+
/**
* Implementation of the AutoTuneService which is comprised of profiling and query tuning.
*/
@@ -111,7 +112,7 @@ public class DefaultAutoTuneService implements AutoTuneService {
if (stream != null) {
loadAutoTuneProfiling(AutoTuneXmlReader.read(stream));
} else {
- logger.log(Level.WARNING, "AutoTune file {0} not found - no initial automatic query tuning", tuningFile);
+ logger.log(WARNING, "AutoTune file {0} not found - no initial automatic query tuning", tuningFile);
}
} catch (IOException e) {
throw new IllegalStateException("Error on auto close of " + tuningFile, e);
@@ -120,7 +121,7 @@ public class DefaultAutoTuneService implements AutoTuneService {
}
private void loadAutoTuneProfiling(Autotune profiling) {
- logger.log(Level.INFO, "AutoTune loading {0} tuning entries", profiling.getOrigin().size());
+ logger.log(INFO, "AutoTune loading {0} tuning entries", profiling.getOrigin().size());
for (Origin origin : profiling.getOrigin()) {
queryTuner.put(origin);
}
@@ -141,17 +142,17 @@ public class DefaultAutoTuneService implements AutoTuneService {
event.process();
if (event.isEmpty()) {
long exeMillis = System.currentTimeMillis() - start;
- logger.log(Level.DEBUG, "No query tuning updates for server:{0} executionMillis:{1}", serverName, exeMillis);
+ logger.log(DEBUG, "No query tuning updates for server:{0} executionMillis:{1}", serverName, exeMillis);
} else {
// report the query tuning changes that have been made
runtimeChangeCount += event.getChangeCount();
event.writeFile(profilingFile + "-" + serverName + "-update");
long exeMillis = System.currentTimeMillis() - start;
- logger.log(Level.INFO, "query tuning updates - new:{0} diff:{1} for server:{2} executionMillis:{3}", event.getNewCount(), event.getDiffCount(), serverName, exeMillis);
+ logger.log(INFO, "query tuning updates - new:{0} diff:{1} for server:{2} executionMillis:{3}", event.getNewCount(), event.getDiffCount(), serverName, exeMillis);
}
} catch (Throwable e) {
- logger.log(Level.ERROR, "Error collecting or applying automatic query tuning", e);
+ logger.log(ERROR, "Error collecting or applying automatic query tuning", e);
}
} finally {
lock.unlock();
@@ -172,11 +173,11 @@ public class DefaultAutoTuneService implements AutoTuneService {
AutoTuneDiffCollection event = new AutoTuneDiffCollection(profiling, queryTuner, false);
event.process();
if (event.isEmpty()) {
- logger.log(Level.INFO, "No new or diff entries for profiling server:{0}", serverName);
+ logger.log(INFO, "No new or diff entries for profiling server:{0}", serverName);
} else {
event.writeFile(profilingFile + "-" + serverName);
- logger.log(Level.INFO, "writing new:{0} diff:{1} profiling entries for server:{2}", event.getNewCount(), event.getDiffCount(), serverName);
+ logger.log(INFO, "writing new:{0} diff:{1} profiling entries for server:{2}", event.getNewCount(), event.getDiffCount(), serverName);
}
}
} finally {
@@ -196,7 +197,7 @@ public class DefaultAutoTuneService implements AutoTuneService {
private void outputAllTuning() {
if (runtimeChangeCount == 0) {
- logger.log(Level.INFO, "no runtime query tuning changes for server:{0}", serverName);
+ logger.log(INFO, "no runtime query tuning changes for server:{0}", serverName);
} else {
AutoTuneAllCollection event = new AutoTuneAllCollection(queryTuner);
@@ -205,12 +206,12 @@ public class DefaultAutoTuneService implements AutoTuneService {
if (existingTuning.exists()) {
// rename the existing autotune.xml file (appending 'now')
if (!existingTuning.renameTo(new File(tuningFile + "." + AutoTuneXmlWriter.now()))) {
- logger.log(Level.WARNING, "Failed to rename autotune file [{0}]", tuningFile);
+ logger.log(WARNING, "Failed to rename autotune file [{0}]", tuningFile);
}
}
event.writeFile(tuningFile, false);
- logger.log(Level.INFO, "query tuning detected [{0}] changes, writing all [{1}] tuning entries for server:{2}", runtimeChangeCount, size, serverName);
+ logger.log(INFO, "query tuning detected [{0}] changes, writing all [{1}] tuning entries for server:{2}", runtimeChangeCount, size, serverName);
}
}
@@ -279,7 +280,7 @@ public class DefaultAutoTuneService implements AutoTuneService {
} catch (InterruptedException e) {
// restore the interrupted status
Thread.currentThread().interrupt();
- logger.log(Level.WARNING, "Error while sleeping after System.gc() request.", e);
+ logger.log(WARNING, "Error while sleeping after System.gc() request.", e);
}
}
diff --git a/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/ProfileOriginNodeUsage.java b/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/ProfileOriginNodeUsage.java
index fb9007ebf..408d9c1ff 100644
--- a/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/ProfileOriginNodeUsage.java
+++ b/ebean-autotune/src/main/java/io/ebeaninternal/server/autotune/service/ProfileOriginNodeUsage.java
@@ -9,11 +9,12 @@ import io.ebeaninternal.server.deploy.BeanProperty;
import io.ebeaninternal.server.deploy.BeanPropertyAssoc;
import io.ebeaninternal.server.el.ElPropertyValue;
-import java.lang.System.Logger.Level;
import java.util.LinkedHashSet;
import java.util.Set;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.WARNING;
+
/**
* Collects usages statistics for a given node in the object graph.
*/
@@ -45,7 +46,7 @@ public class ProfileOriginNodeUsage {
if (path != null) {
ElPropertyValue elGetValue = rootDesc.elGetValue(path);
if (elGetValue == null) {
- logger.log(Level.WARNING, "AutoTune: Can't find join for path[" + path + "] for " + rootDesc.name());
+ logger.log(WARNING, "AutoTune: Can't find join for path[" + path + "] for " + rootDesc.name());
return;
} else {
BeanProperty beanProperty = elGetValue.beanProperty();
@@ -61,7 +62,7 @@ public class ProfileOriginNodeUsage {
for (String propName : aggregateUsed) {
BeanProperty beanProp = desc.findPropertyFromPath(propName);
if (beanProp == null) {
- logger.log(Level.WARNING, "AutoTune: Can't find property[" + propName + "] for " + desc.name());
+ logger.log(WARNING, "AutoTune: Can't find property[" + propName + "] for " + desc.name());
} else {
if (beanProp.isId()) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultCacheHolder.java b/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultCacheHolder.java
index cf6a02089..aff1929b6 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultCacheHolder.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultCacheHolder.java
@@ -9,12 +9,14 @@ import io.ebean.config.CurrentTenantProvider;
import io.ebean.meta.MetricVisitor;
import io.ebean.util.AnnotationUtil;
-import java.lang.System.Logger.Level;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentSkipListSet;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.DEBUG;
+import static java.lang.System.Logger.Level.TRACE;
+
/**
* Manages the construction of caches.
*/
@@ -89,7 +91,7 @@ final class DefaultCacheHolder {
}
void clearAll() {
- log.log(Level.DEBUG, "clearAll");
+ log.log(DEBUG, "clearAll");
for (ServerCache serverCache : allCaches.values()) {
serverCache.clear();
}
@@ -97,7 +99,7 @@ final class DefaultCacheHolder {
public void clear(String name) {
- log.log(Level.DEBUG, "clear {0}", name);
+ log.log(DEBUG, "clear {0}", name);
clearIfExists(key(name, ServerCacheType.QUERY));
clearIfExists(key(name, ServerCacheType.BEAN));
clearIfExists(key(name, ServerCacheType.NATURAL_KEY));
@@ -112,7 +114,7 @@ final class DefaultCacheHolder {
private void clearIfExists(String fullKey) {
ServerCache cache = allCaches.get(fullKey);
if (cache != null) {
- log.log(Level.TRACE, "clear cache {0}", fullKey);
+ log.log(TRACE, "clear cache {0}", fullKey);
cache.clear();
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultServerCache.java b/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultServerCache.java
index e5bfd2628..e68c9a308 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultServerCache.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultServerCache.java
@@ -9,13 +9,15 @@ import io.ebean.metric.CountMetric;
import io.ebean.metric.MetricFactory;
import java.io.Serializable;
-import java.lang.System.Logger.Level;
import java.lang.ref.SoftReference;
import java.util.*;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.TRACE;
+import static java.lang.System.Logger.Level.WARNING;
+
/**
* The default cache implementation.
*
@@ -287,13 +289,13 @@ public class DefaultServerCache implements ServerCache {
evictCount.add(trimmedByGC);
evictCount.add(trimmedByTTL);
evictCount.add(trimmedByLRU);
- if (logger.isLoggable(Level.TRACE)) {
+ if (logger.isLoggable(TRACE)) {
long exeMicros = TimeUnit.MICROSECONDS.convert(System.nanoTime() - startNanos, TimeUnit.NANOSECONDS);
- logger.log(Level.TRACE, "Executed trim of cache {0} in [{1}]millis idle[{2}] timeToLive[{3}] accessTime[{4}] gc[{5}]",
+ logger.log(TRACE, "Executed trim of cache {0} in [{1}]millis idle[{2}] timeToLive[{3}] accessTime[{4}] gc[{5}]",
name, exeMicros, trimmedByIdle, trimmedByTTL, trimmedByLRU, trimmedByGC);
}
} catch (Throwable e) {
- logger.log(Level.WARNING, "Error during trim of DefaultServerCache [" + name + "]. Cache might be bigger than desired.", e);
+ logger.log(WARNING, "Error during trim of DefaultServerCache [" + name + "]. Cache might be bigger than desired.", e);
}
} finally {
lock.unlock();
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultServerCacheManager.java b/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultServerCacheManager.java
index 6142f6d50..0b7264ff9 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultServerCacheManager.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/cache/DefaultServerCacheManager.java
@@ -9,9 +9,11 @@ import io.ebeaninternal.api.SpiCacheRegion;
import io.ebeaninternal.server.cluster.ClusterManager;
import io.ebeaninternal.server.deploy.DCacheRegion;
-import java.lang.System.Logger.Level;
import java.util.*;
+import static java.lang.System.Logger.Level.DEBUG;
+import static java.lang.System.Logger.Level.INFO;
+
/**
* Manages the bean and query caches.
*/
@@ -65,23 +67,23 @@ public final class DefaultServerCacheManager implements SpiCacheManager {
enabled.add(region.name());
if (!region.isEnabled()) {
region.setEnabled(true);
- log.log(Level.DEBUG, "Cache region[{0}] enabled", region.name());
+ log.log(DEBUG, "Cache region[{0}] enabled", region.name());
}
} else {
disabled.add(region.name());
if (region.isEnabled()) {
region.setEnabled(false);
- log.log(Level.DEBUG, "Cache region[{0}] disabled", region.name());
+ log.log(DEBUG, "Cache region[{0}] disabled", region.name());
}
}
}
- log.log(Level.INFO, "Cache regions enabled:{0} disabled:{1}", enabled, disabled);
+ log.log(INFO, "Cache regions enabled:{0} disabled:{1}", enabled, disabled);
}
}
@Override
public void setAllRegionsEnabled(boolean enabled) {
- log.log(Level.DEBUG, "All cache regions enabled[{0}]", enabled);
+ log.log(DEBUG, "All cache regions enabled[{0}]", enabled);
for (SpiCacheRegion region : regionMap.values()) {
region.setEnabled(enabled);
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/changelog/DefaultChangeLogListener.java b/ebean-core/src/main/java/io/ebeaninternal/server/changelog/DefaultChangeLogListener.java
index c85edd315..7ababb99f 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/changelog/DefaultChangeLogListener.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/changelog/DefaultChangeLogListener.java
@@ -10,9 +10,11 @@ import io.ebean.plugin.SpiServer;
import io.ebeaninternal.api.CoreLog;
import java.io.StringWriter;
-import java.lang.System.Logger.Level;
import java.util.Properties;
+import static java.lang.System.Logger.Level.ERROR;
+import static java.lang.System.Logger.Level.INFO;
+
/**
* Simply logs the change sets in JSON form to logger named io.ebean.ChangeLog.
*/
@@ -65,9 +67,9 @@ public final class DefaultChangeLogListener implements ChangeLogListener, Plugin
try {
StringWriter writer = new StringWriter(getBufferSize(beanChange));
jsonBuilder.writeBeanJson(writer, beanChange, changeSet);
- changeLog.log(Level.INFO, writer.toString());
+ changeLog.log(INFO, writer.toString());
} catch (Exception e) {
- CoreLog.log.log(Level.ERROR, "Exception logging beanChange " + beanChange, e);
+ CoreLog.log.log(ERROR, "Exception logging beanChange " + beanChange, e);
}
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/cluster/ClusterManager.java b/ebean-core/src/main/java/io/ebeaninternal/server/cluster/ClusterManager.java
index 4af7e1fce..e370534d9 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/cluster/ClusterManager.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/cluster/ClusterManager.java
@@ -5,12 +5,13 @@ import io.ebean.Database;
import io.ebean.config.ContainerConfig;
import io.ebeaninternal.server.transaction.RemoteTransactionEvent;
-import java.lang.System.Logger.Level;
import java.util.Iterator;
import java.util.ServiceLoader;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.DEBUG;
+
/**
* Manages the cluster service.
*/
@@ -112,8 +113,8 @@ public class ClusterManager implements ServerLookup {
*/
public void broadcast(RemoteTransactionEvent event) {
if (broadcast != null) {
- if (clusterLogger.isLoggable(Level.DEBUG)) {
- clusterLogger.log(Level.DEBUG, "sending: {0}", event);
+ if (clusterLogger.isLoggable(DEBUG)) {
+ clusterLogger.log(DEBUG, "sending: {0}", event);
}
broadcast.broadcast(event);
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/BeanRequest.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/BeanRequest.java
index 6d68210bd..b8224bc23 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/BeanRequest.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/BeanRequest.java
@@ -6,7 +6,7 @@ import io.ebeaninternal.api.SpiEbeanServer;
import io.ebeaninternal.api.SpiTransaction;
import io.ebeaninternal.server.core.timezone.DataTimeZone;
-import java.lang.System.Logger.Level;
+import static java.lang.System.Logger.Level.ERROR;
/**
* Base class for find and persist requests.
@@ -63,7 +63,7 @@ public abstract class BeanRequest {
// Just log this and carry on. A previous exception has been
// thrown and if this rollback throws exception it likely means
// that the connection is broken (and the dataSource and db will cleanup)
- CoreLog.log.log(Level.ERROR, "Error trying to rollback a transaction (after a prior exception thrown)", e);
+ CoreLog.log.log(ERROR, "Error trying to rollback a transaction (after a prior exception thrown)", e);
}
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DatabasePlatformFactory.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DatabasePlatformFactory.java
index 265e71cba..8fa1093be 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DatabasePlatformFactory.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DatabasePlatformFactory.java
@@ -8,7 +8,6 @@ import io.ebeaninternal.api.DbOffline;
import javax.persistence.PersistenceException;
import javax.sql.DataSource;
-import java.lang.System.Logger.Level;
import java.sql.Connection;
import java.sql.DatabaseMetaData;
import java.sql.SQLException;
@@ -16,6 +15,9 @@ import java.util.ArrayList;
import java.util.List;
import java.util.ServiceLoader;
+import static java.lang.System.Logger.Level.DEBUG;
+import static java.lang.System.Logger.Level.INFO;
+
/**
* Create a DatabasePlatform from the configuration.
*
@@ -39,7 +41,7 @@ public class DatabasePlatformFactory {
try {
String offlinePlatform = DbOffline.getPlatform();
if (offlinePlatform != null) {
- CoreLog.log.log(Level.INFO, "offline platform [{0}]", offlinePlatform);
+ CoreLog.log.log(INFO, "offline platform [{0}]", offlinePlatform);
return byDatabaseName(offlinePlatform);
}
if (config.getDatabasePlatformName() != null) {
@@ -88,7 +90,7 @@ public class DatabasePlatformFactory {
String dbProductName = metaData.getDatabaseProductName().toLowerCase();
final int majorVersion = metaData.getDatabaseMajorVersion();
final int minorVersion = metaData.getDatabaseMinorVersion();
- CoreLog.log.log(Level.DEBUG, "platform for productName[{0}] version[{1}.{2}]", dbProductName, majorVersion, minorVersion);
+ CoreLog.log.log(DEBUG, "platform for productName[{0}] version[{1}.{2}]", dbProductName, majorVersion, minorVersion);
for (DatabasePlatformProvider provider : providers) {
if (provider.matchByProductName(dbProductName)) {
return provider.create(majorVersion, minorVersion, metaData, connection);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java
index 7cd82edeb..8e1f2fb84 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultBeanLoader.java
@@ -14,10 +14,11 @@ import io.ebeaninternal.server.deploy.BeanPropertyAssocMany;
import io.ebeaninternal.server.transaction.DefaultPersistenceContext;
import javax.persistence.EntityNotFoundException;
-import java.lang.System.Logger.Level;
import java.util.List;
import java.util.Set;
+import static java.lang.System.Logger.Level.DEBUG;
+
/**
* Helper to handle lazy loading and refreshing of beans.
*/
@@ -108,8 +109,8 @@ final class DefaultBeanLoader {
server.findOne(query, null);
if (beanCollection != null) {
if (beanCollection.checkEmptyLazyLoad()) {
- if (log.isLoggable(Level.DEBUG)) {
- log.log(Level.DEBUG, "BeanCollection after load was empty. Owner:" + beanCollection.getOwnerBean());
+ if (log.isLoggable(DEBUG)) {
+ log.log(DEBUG, "BeanCollection after load was empty. Owner:" + beanCollection.getOwnerBean());
}
} else if (useManyIdCache) {
parentDesc.cacheManyPropPut(many, beanCollection, parentId);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultContainer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultContainer.java
index eb1cb1fe2..16df24f4c 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultContainer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultContainer.java
@@ -14,7 +14,6 @@ import io.ebeaninternal.server.core.bootup.BootupClasses;
import io.ebeaninternal.server.executor.DefaultBackgroundExecutor;
import javax.persistence.PersistenceException;
-import java.lang.System.Logger.Level;
import java.net.URL;
import java.sql.Connection;
import java.sql.SQLException;
@@ -22,6 +21,8 @@ import java.util.List;
import java.util.ServiceLoader;
import java.util.concurrent.locks.ReentrantLock;
+import static java.lang.System.Logger.Level.*;
+
/**
* Default Server side implementation of ServerFactory.
*/
@@ -107,7 +108,7 @@ public final class DefaultContainer implements SpiContainer {
startServer(online, server);
}
DbOffline.reset();
- log.log(Level.INFO, "Started database[{0}] platform[{1}] in {2}ms", config.getName(), config.getDatabasePlatform().getPlatform(), System.currentTimeMillis() - start);
+ log.log(INFO, "Started database[{0}] platform[{1}] in {2}ms", config.getName(), config.getDatabasePlatform().getPlatform(), System.currentTimeMillis() - start);
return server;
} finally {
lock.unlock();
@@ -136,7 +137,7 @@ public final class DefaultContainer implements SpiContainer {
private void checkMissingModulePathProvides() {
URL servicesFile = ClassLoader.getSystemResource("META-INF/services/io.ebean.config.EntityClassRegister");
if (servicesFile != null) {
- log.log(Level.ERROR, "module-info.java is probably missing 'provides io.ebean.config.EntityClassRegister with EbeanEntityRegister' clause. EntityClassRegister exists but was not service loaded.");
+ log.log(ERROR, "module-info.java is probably missing 'provides io.ebean.config.EntityClassRegister with EbeanEntityRegister' clause. EntityClassRegister exists but was not service loaded.");
}
}
@@ -214,7 +215,7 @@ public final class DefaultContainer implements SpiContainer {
*/
private void setDataSource(DatabaseConfig config) {
if (isOfflineMode(config)) {
- log.log(Level.DEBUG, "... DbOffline using platform [{0}]", DbOffline.getPlatform());
+ log.log(DEBUG, "... DbOffline using platform [{0}]", DbOffline.getPlatform());
} else {
InitDataSource.init(config);
}
@@ -250,7 +251,7 @@ public final class DefaultContainer implements SpiContainer {
}
try (Connection connection = config.getDataSource().getConnection()) {
if (connection.getAutoCommit()) {
- log.log(Level.WARNING, "DataSource [{0}] has autoCommit defaulting to true!", config.getName());
+ log.log(WARNING, "DataSource [{0}] has autoCommit defaulting to true!", config.getName());
}
return true;
} catch (SQLException ex) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
index b6b498b0d..d0333acda 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultServer.java
@@ -51,7 +51,6 @@ import javax.persistence.NonUniqueResultException;
import javax.persistence.OptimisticLockException;
import javax.persistence.PersistenceException;
import javax.sql.DataSource;
-import java.lang.System.Logger.Level;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;
@@ -65,6 +64,7 @@ import java.util.function.Function;
import java.util.function.Predicate;
import java.util.stream.Stream;
+import static java.lang.System.Logger.Level.*;
import static java.util.Spliterators.spliteratorUnknownSize;
import static java.util.stream.StreamSupport.stream;
@@ -331,7 +331,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
if (config.isQueryPlanCapture()) {
long secs = config.getQueryPlanCapturePeriodSecs();
if (secs > 10) {
- log.log(Level.INFO, "capture query plan enabled, every {0}secs", secs);
+ log.log(INFO, "capture query plan enabled, every {0}secs", secs);
backgroundExecutor.scheduleWithFixedDelay(this::collectQueryPlans, secs, secs, TimeUnit.SECONDS);
}
}
@@ -379,7 +379,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
* Shutdown the services like threads and DataSource.
*/
private void shutdownInternal(boolean shutdownDataSource, boolean deregisterDriver) {
- log.log(Level.TRACE, "shutting down instance {0}", serverName);
+ log.log(TRACE, "shutting down instance {0}", serverName);
if (shutdown) {
// already shutdown
return;
@@ -408,7 +408,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
try {
plugin.shutdown();
} catch (Exception e) {
- log.log(Level.ERROR, "Error when shutting down plugin", e);
+ log.log(ERROR, "Error when shutting down plugin", e);
}
}
}
@@ -2075,7 +2075,7 @@ public final class DefaultServer implements SpiServer, SpiEbeanServer {
try {
serverCacheManager.clearLocal(Class.forName(cache));
} catch (Exception e) {
- log.log(Level.ERROR, "Error clearing local cache for type " + cache, e);
+ log.log(ERROR, "Error clearing local cache for type " + cache, e);
}
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/InternalConfigXmlMap.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/InternalConfigXmlMap.java
index 4bd2545ed..c55467ce4 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/InternalConfigXmlMap.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/InternalConfigXmlMap.java
@@ -6,11 +6,12 @@ import io.ebeaninternal.xmapping.api.XmapDto;
import io.ebeaninternal.xmapping.api.XmapEbean;
import io.ebeaninternal.xmapping.api.XmapRawSql;
-import java.lang.System.Logger.Level;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import static java.lang.System.Logger.Level.ERROR;
+
/**
* Reads the Xml deployment information.
*/
@@ -56,7 +57,7 @@ final class InternalConfigXmlMap {
try {
dtoClass = Class.forName(dto.getClazz(), false, classLoader);
} catch (Exception e) {
- CoreLog.internal.log(Level.ERROR, "Could not load dto bean class " + dto.getClazz() + " for ebean xml entry");
+ CoreLog.internal.log(ERROR, "Could not load dto bean class " + dto.getClazz() + " for ebean xml entry");
return;
}
DtoNamedQueries namedQueries = dtoNamedQueries.computeIfAbsent(dtoClass, aClass -> new DtoNamedQueries());
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/InternalConfiguration.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/InternalConfiguration.java
index c8b7f8810..51e4a7d5f 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/InternalConfiguration.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/InternalConfiguration.java
@@ -57,9 +57,10 @@ import io.ebeanservice.docstore.api.DocStoreIntegration;
import io.ebeanservice.docstore.api.DocStoreUpdateProcessor;
import io.ebeanservice.docstore.none.NoneDocStoreFactory;
-import java.lang.System.Logger.Level;
import java.util.*;
+import static java.lang.System.Logger.Level.*;
+
/**
* Used to extend the DatabaseConfig with additional objects used to configure and
* construct an Database.
@@ -433,7 +434,7 @@ public final class InternalConfiguration {
externalTransactionManager = new JtaTransactionManager();
}
if (externalTransactionManager != null) {
- log.log(Level.INFO, "Using Transaction Manager {0}", externalTransactionManager.getClass());
+ log.log(INFO, "Using Transaction Manager {0}", externalTransactionManager.getClass());
return new ExternalTransactionScopeManager(externalTransactionManager);
} else {
return new DefaultTransactionScopeManager();
@@ -523,7 +524,7 @@ public final class InternalConfiguration {
if (iterator.hasNext()) {
// use the cacheFactory (via classpath service loader)
plugin = iterator.next();
- log.log(Level.DEBUG, "using ServerCacheFactory {0}", plugin.getClass());
+ log.log(DEBUG, "using ServerCacheFactory {0}", plugin.getClass());
} else {
// use the built in default l2 caching which is local cache based
localL2Caching = true;
@@ -613,7 +614,7 @@ public final class InternalConfiguration {
@Override
public void execute(boolean online) {
if (online && ddlRun) {
- CoreLog.log.log(Level.ERROR, "Configured to run DDL but ebean-ddl-generator is not in the classpath (or ebean-test in the test classpath?)");
+ CoreLog.log.log(ERROR, "Configured to run DDL but ebean-ddl-generator is not in the classpath (or ebean-test in the test classpath?)");
}
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/BootupClassPathSearch.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/BootupClassPathSearch.java
index 031c87688..8e2dd4d7f 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/BootupClassPathSearch.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/BootupClassPathSearch.java
@@ -5,10 +5,11 @@ import io.ebean.config.DatabaseConfig;
import io.ebeaninternal.api.CoreLog;
import io.ebeaninternal.server.core.ClassPathScanners;
-import java.lang.System.Logger.Level;
import java.util.List;
import java.util.Set;
+import static java.lang.System.Logger.Level.DEBUG;
+
/**
* Searches for interesting classes such as Entities, Embedded and ScalarTypes.
*/
@@ -58,7 +59,7 @@ public class BootupClassPathSearch {
}
long searchTime = System.currentTimeMillis() - st;
- log.log(Level.DEBUG, "Classpath search entities[{0}] searchTime[{1}] in packages[{2}]", bc.getEntities().size(), searchTime, packages);
+ log.log(DEBUG, "Classpath search entities[{0}] searchTime[{1}] in packages[{2}]", bc.getEntities().size(), searchTime, packages);
return bc;
} catch (Exception ex) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/BootupClasses.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/BootupClasses.java
index b3f777c6f..40c4ad442 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/BootupClasses.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/BootupClasses.java
@@ -18,13 +18,15 @@ import javax.persistence.AttributeConverter;
import javax.persistence.Embeddable;
import javax.persistence.Entity;
import javax.persistence.Table;
-import java.lang.System.Logger.Level;
import java.lang.annotation.Annotation;
import java.lang.reflect.Modifier;
import java.util.ArrayList;
import java.util.List;
import java.util.function.Predicate;
+import static java.lang.System.Logger.Level.DEBUG;
+import static java.lang.System.Logger.Level.ERROR;
+
/**
* Interesting classes for a EbeanServer such as Embeddable, Entity,
* ScalarTypes, Finders, Listeners and Controllers.
@@ -205,13 +207,13 @@ public class BootupClasses implements Predicate> {
try {
return cls.getConstructor().newInstance();
} catch (NoSuchMethodException e) {
- log.log(Level.DEBUG, "Ignore/expected - no default constructor: " + e.getMessage());
+ log.log(DEBUG, "Ignore/expected - no default constructor: " + e.getMessage());
return null;
} catch (Exception e) {
if (logOnException) {
// not expected but we log and carry on
- log.log(Level.ERROR, "Error creating " + cls, e);
+ log.log(ERROR, "Error creating " + cls, e);
return null;
} else {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/ManifestReader.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/ManifestReader.java
index a9dbf21ab..456b90987 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/ManifestReader.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/bootup/ManifestReader.java
@@ -6,7 +6,6 @@ import io.ebeaninternal.util.UrlHelper;
import java.io.IOException;
import java.io.InputStream;
-import java.lang.System.Logger.Level;
import java.net.URL;
import java.util.Collections;
import java.util.Enumeration;
@@ -15,6 +14,8 @@ import java.util.Set;
import java.util.jar.Attributes;
import java.util.jar.Manifest;
+import static java.lang.System.Logger.Level.WARNING;
+
/**
* Reads all the META-INF/ebean.mf resources with the package locations of entity beans.
*/
@@ -63,7 +64,7 @@ class ManifestReader {
}
}
} catch (IOException e) {
- log.log(Level.WARNING, "Error reading " + resourcePath + " manifest resources", e);
+ log.log(WARNING, "Error reading " + resourcePath + " manifest resources", e);
}
return packageSet;
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
index 4fd54268f..d86e75a7b 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java
@@ -58,7 +58,6 @@ import io.ebeanservice.docstore.api.mapping.DocumentMapping;
import javax.persistence.PersistenceException;
import java.io.IOException;
import java.io.StringWriter;
-import java.lang.System.Logger.Level;
import java.lang.reflect.Modifier;
import java.sql.SQLException;
import java.sql.Types;
@@ -68,6 +67,8 @@ import java.util.function.Consumer;
import java.util.stream.Collectors;
import static io.ebeaninternal.server.persist.DmlUtil.isNullOrZero;
+import static java.lang.System.Logger.Level.ERROR;
+import static java.lang.System.Logger.Level.INFO;
/**
* Describes Beans including their deployment information.
@@ -792,7 +793,7 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType {
changeJson.flush();
return beanChange(ChangeType.UPDATE, request.beanId(), changeJson.newJson(), changeJson.oldJson());
} catch (RuntimeException e) {
- log.log(Level.ERROR, "Failed to write ChangeLog entry for update", e);
+ log.log(ERROR, "Failed to write ChangeLog entry for update", e);
return null;
}
}
@@ -808,7 +809,7 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType {
jsonWriter.flush();
return beanChange(ChangeType.INSERT, request.beanId(), writer.toString(), null);
} catch (IOException e) {
- log.log(Level.ERROR, "Failed to write ChangeLog entry for insert", e);
+ log.log(ERROR, "Failed to write ChangeLog entry for insert", e);
return null;
}
}
@@ -2288,11 +2289,11 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType {
private ElComparator createPropertyComparator(SortByClause.Property sortProp) {
ElPropertyValue elGetValue = elGetValue(sortProp.getName());
if (elGetValue == null) {
- log.log(Level.ERROR, "Sort property [" + sortProp + "] not found in " + beanType + ". Cannot sort.");
+ log.log(ERROR, "Sort property [" + sortProp + "] not found in " + beanType + ". Cannot sort.");
return new ElComparatorNoop<>();
}
if (elGetValue.isAssocMany()) {
- log.log(Level.ERROR, "Sort property [" + sortProp + "] in " + beanType + " is a many-property. Cannot sort.");
+ log.log(ERROR, "Sort property [" + sortProp + "] in " + beanType + " is a many-property. Cannot sort.");
return new ElComparatorNoop<>();
}
Boolean nullsHigh = sortProp.getNullsHigh();
@@ -2768,7 +2769,7 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType {
public void markAsDeleted(EntityBean bean) {
if (softDeleteProperty == null) {
Object id = getId(bean);
- log.log(Level.INFO, "(Lazy) loading unsuccessful for type:{0} id:{1} - expecting when bean has been deleted", name(), id);
+ log.log(INFO, "(Lazy) loading unsuccessful for type:{0} id:{1} - expecting when bean has been deleted", name(), id);
bean._ebean_getIntercept().setLazyLoadFailure(id);
} else {
softDeleteValue(bean);
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
index 4e0c39b39..015fcbe70 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptorCacheHelp.java
@@ -16,9 +16,10 @@ import io.ebeaninternal.server.core.PersistRequestBean;
import io.ebeaninternal.server.transaction.DefaultPersistenceContext;
import java.io.IOException;
-import java.lang.System.Logger.Level;
import java.util.*;
+import static java.lang.System.Logger.Level.*;
+
/**
* Helper for BeanDescriptor that manages the bean, query and collection caches.
*
@@ -104,10 +105,10 @@ final class BeanDescriptorCacheHelp {
void deriveNotifyFlags() {
cacheNotifyOnAll = (invalidateQueryCache || beanCache != null || queryCache != null);
cacheNotifyOnDelete = !cacheNotifyOnAll && isNotifyOnDeletes();
- if (log.isLoggable(Level.DEBUG)) {
+ if (log.isLoggable(DEBUG)) {
if (cacheNotifyOnAll || cacheNotifyOnDelete) {
String notifyMode = cacheNotifyOnAll ? "All" : "Delete";
- log.log(Level.DEBUG, "l2 caching on {0} - beanCaching:{1} queryCaching:{2} notifyMode:{3} ",
+ log.log(DEBUG, "l2 caching on {0} - beanCaching:{1} queryCaching:{2} notifyMode:{3} ",
desc.fullName(), isBeanCaching(), isQueryCaching(), notifyMode);
}
}
@@ -178,8 +179,8 @@ final class BeanDescriptorCacheHelp {
*/
void queryCacheClear() {
if (queryCache != null) {
- if (queryLog.isLoggable(Level.DEBUG)) {
- queryLog.log(Level.DEBUG, " CLEAR {0}", cacheName);
+ if (queryLog.isLoggable(DEBUG)) {
+ queryLog.log(DEBUG, " CLEAR {0}", cacheName);
}
queryCache.clear();
}
@@ -202,11 +203,11 @@ final class BeanDescriptorCacheHelp {
throw new IllegalStateException("No query cache enabled on " + desc + ". Need explicit @Cache(enableQueryCache=true)");
}
Object queryResult = queryCache.get(id);
- if (queryLog.isLoggable(Level.DEBUG)) {
+ if (queryLog.isLoggable(DEBUG)) {
if (queryResult == null) {
- queryLog.log(Level.DEBUG, " GET {0}({1}) - cache miss", cacheName, id);
+ queryLog.log(DEBUG, " GET {0}({1}) - cache miss", cacheName, id);
} else {
- queryLog.log(Level.DEBUG, " GET {0}({1}) - hit", cacheName, id);
+ queryLog.log(DEBUG, " GET {0}({1}) - hit", cacheName, id);
}
}
return queryResult;
@@ -219,8 +220,8 @@ final class BeanDescriptorCacheHelp {
if (queryCache == null) {
throw new IllegalStateException("No query cache enabled on " + desc + ". Need explicit @Cache(enableQueryCache=true)");
}
- if (queryLog.isLoggable(Level.DEBUG)) {
- queryLog.log(Level.DEBUG, " PUT {0}({1})", cacheName, id);
+ if (queryLog.isLoggable(DEBUG)) {
+ queryLog.log(DEBUG, " PUT {0}({1})", cacheName, id);
}
queryCache.put(id, entry);
}
@@ -228,16 +229,16 @@ final class BeanDescriptorCacheHelp {
void manyPropRemove(String propertyName, Object parentId) {
ServerCache collectionIdsCache = cacheManager.getCollectionIdsCache(beanType, propertyName);
- if (manyLog.isLoggable(Level.TRACE)) {
- manyLog.log(Level.TRACE, " REMOVE {0}({1}).{2}", cacheName, parentId, propertyName);
+ if (manyLog.isLoggable(TRACE)) {
+ manyLog.log(TRACE, " REMOVE {0}({1}).{2}", cacheName, parentId, propertyName);
}
collectionIdsCache.remove(parentId);
}
void manyPropClear(String propertyName) {
ServerCache collectionIdsCache = cacheManager.getCollectionIdsCache(beanType, propertyName);
- if (manyLog.isLoggable(Level.DEBUG)) {
- manyLog.log(Level.DEBUG, " CLEAR {0}(*).{1} ", cacheName, propertyName);
+ if (manyLog.isLoggable(DEBUG)) {
+ manyLog.log(DEBUG, " CLEAR {0}(*).{1} ", cacheName, propertyName);
}
collectionIdsCache.clear();
}
@@ -249,11 +250,11 @@ final class BeanDescriptorCacheHelp {
ServerCache collectionIdsCache = cacheManager.getCollectionIdsCache(beanType, propertyName);
CachedManyIds entry = (CachedManyIds) collectionIdsCache.get(parentId);
if (entry == null) {
- if (manyLog.isLoggable(Level.TRACE)) {
- manyLog.log(Level.TRACE, " GET {0}({1}).{2} - cache miss", cacheName, parentId, propertyName);
+ if (manyLog.isLoggable(TRACE)) {
+ manyLog.log(TRACE, " GET {0}({1}).{2} - cache miss", cacheName, parentId, propertyName);
}
- } else if (manyLog.isLoggable(Level.DEBUG)) {
- manyLog.log(Level.DEBUG, " GET {0}({1}).{2} - hit", cacheName, parentId, propertyName);
+ } else if (manyLog.isLoggable(DEBUG)) {
+ manyLog.log(DEBUG, " GET {0}({1}).{2} - hit", cacheName, parentId, propertyName);
}
return entry;
}
@@ -303,12 +304,12 @@ final class BeanDescriptorCacheHelp {
changes.put(many.name(), asJson);
CachedBeanData newData = data.update(changes, data.getVersion());
- if (beanLog.isLoggable(Level.DEBUG)) {
- beanLog.log(Level.DEBUG, " UPDATE {0}({1}) changes:{2}", cacheName, parentId, changes);
+ if (beanLog.isLoggable(DEBUG)) {
+ beanLog.log(DEBUG, " UPDATE {0}({1}) changes:{2}", cacheName, parentId, changes);
}
beanCache.put(parentId, newData);
} catch (IOException e) {
- log.log(Level.ERROR, "Error updating L2 cache", e);
+ log.log(ERROR, "Error updating L2 cache", e);
}
}
} else {
@@ -321,8 +322,8 @@ final class BeanDescriptorCacheHelp {
void cachePutManyIds(Object parentId, String manyName, CachedManyIds entry) {
ServerCache collectionIdsCache = cacheManager.getCollectionIdsCache(beanType, manyName);
- if (manyLog.isLoggable(Level.DEBUG)) {
- manyLog.log(Level.DEBUG, " PUT {0}({1}).{2} - ids:{3}", cacheName, parentId, manyName, entry);
+ if (manyLog.isLoggable(DEBUG)) {
+ manyLog.log(DEBUG, " PUT {0}({1}).{2} - ids:{3}", cacheName, parentId, manyName, entry);
}
collectionIdsCache.put(parentId, entry);
}
@@ -353,8 +354,8 @@ final class BeanDescriptorCacheHelp {
return new BeanCacheResult<>();
}
Map