diff --git a/ebean-api/src/main/java/io/ebean/Transaction.java b/ebean-api/src/main/java/io/ebean/Transaction.java
index b2bce9abf..d4918e84e 100644
--- a/ebean-api/src/main/java/io/ebean/Transaction.java
+++ b/ebean-api/src/main/java/io/ebean/Transaction.java
@@ -519,11 +519,11 @@ public interface Transaction extends AutoCloseable {
void flush() throws PersistenceException;
/**
- * This is a synonym for flush() and will be deprecated.
+ * Deprecated - migrate to flush().
*
* flush() is preferred as it matches the JPA flush() method.
- *
*/
+ @Deprecated
void flushBatch() throws PersistenceException;
/**
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java
index 3311ad866..eb48fc2ef 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/PersistRequestBean.java
@@ -388,7 +388,7 @@ public final class PersistRequestBean extends PersistRequest implements BeanP
@Override
public void preGetterTrigger(int propertyIndex) {
if (flushBatchOnGetter(propertyIndex)) {
- transaction.flushBatch();
+ transaction.flush();
}
}
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/persist/MergeNodeAssocManyToMany.java b/ebean-core/src/main/java/io/ebeaninternal/server/persist/MergeNodeAssocManyToMany.java
index 4516cefd4..7fd74e8a9 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/persist/MergeNodeAssocManyToMany.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/persist/MergeNodeAssocManyToMany.java
@@ -56,7 +56,7 @@ class MergeNodeAssocManyToMany extends MergeNode {
IntersectionTable intersectionTable = many.intersectionTable();
if (!deletions.isEmpty()) {
- transaction.flushBatch();
+ transaction.flush();
SqlUpdate delete = intersectionTable.delete(server, false);
for (EntityBean deletion : deletions) {
@@ -67,7 +67,7 @@ class MergeNodeAssocManyToMany extends MergeNode {
}
if (!additions.isEmpty()) {
- transaction.flushBatch();
+ transaction.flush();
SqlUpdate insert = intersectionTable.insert(server, false);
for (EntityBean addition : additions) {
diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultOrmQueryEngine.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultOrmQueryEngine.java
index 1c59a614e..b112c7986 100644
--- a/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultOrmQueryEngine.java
+++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/DefaultOrmQueryEngine.java
@@ -58,7 +58,7 @@ public class DefaultOrmQueryEngine implements OrmQueryEngine {
// before we perform a query, we need to flush any
// previous persist requests that are queued/batched.
// The query may read data affected by those requests.
- t.flushBatch();
+ t.flush();
}
}
diff --git a/ebean-core/src/test/java/org/tests/insert/TestInsertDuplicateKey.java b/ebean-core/src/test/java/org/tests/insert/TestInsertDuplicateKey.java
index 06edab471..0c728eaa3 100644
--- a/ebean-core/src/test/java/org/tests/insert/TestInsertDuplicateKey.java
+++ b/ebean-core/src/test/java/org/tests/insert/TestInsertDuplicateKey.java
@@ -24,7 +24,7 @@ public class TestInsertDuplicateKey extends BaseTestCase {
public void clearDb() {
server().find(Document.class).asDraft().where().contains("title", "UniqueKey").delete();
}
-
+
@Test(expected = DuplicateKeyException.class)
public void insert_duplicateKey() {
@@ -89,7 +89,7 @@ public class TestInsertDuplicateKey extends BaseTestCase {
doc2.save();
// flush at this point, fails
- Ebean.getDefaultServer().currentTransaction().flushBatch();
+ Ebean.getDefaultServer().currentTransaction().flush();
} catch (DuplicateKeyException e) {
log.info("duplicate failed but just continue" + e.getMessage());
try {
diff --git a/ebean-core/src/test/java/org/tests/model/basic/xtra/TestInsertBatchThenFlushThenUpdate.java b/ebean-core/src/test/java/org/tests/model/basic/xtra/TestInsertBatchThenFlushThenUpdate.java
index 6fe2e0d18..f42b1c2b7 100644
--- a/ebean-core/src/test/java/org/tests/model/basic/xtra/TestInsertBatchThenFlushThenUpdate.java
+++ b/ebean-core/src/test/java/org/tests/model/basic/xtra/TestInsertBatchThenFlushThenUpdate.java
@@ -40,7 +40,7 @@ public class TestInsertBatchThenFlushThenUpdate extends BaseTestCase {
// nothing flushed yet
assertThat(LoggedSqlCollector.start()).isEmpty();
- txn.flushBatch();
+ txn.flush();
List loggedSql1 = LoggedSqlCollector.start();
assertThat(loggedSql1).hasSize(4);
diff --git a/ebean-core/src/test/java/org/tests/transaction/TestSqlServerBatch.java b/ebean-core/src/test/java/org/tests/transaction/TestSqlServerBatch.java
index b6c1c7658..019193413 100644
--- a/ebean-core/src/test/java/org/tests/transaction/TestSqlServerBatch.java
+++ b/ebean-core/src/test/java/org/tests/transaction/TestSqlServerBatch.java
@@ -11,7 +11,7 @@ import org.tests.model.basic.ESimple;
/**
* This test tests a strange bug in the 6.2.0. sqlserver JDBC driver.
* (Version 6.1.7.jre8-preview works)
- *
+ *
* https://github.com/Microsoft/mssql-jdbc/pull/374
*
* @author Roland Praml, FOCONIS AG
@@ -29,7 +29,7 @@ public class TestSqlServerBatch extends BaseTestCase {
for (int i = 0; i < 10; i++) {
ESimple model = new ESimple();
- model.setName("baz "+i);
+ model.setName("baz " + i);
Ebean.save(model);
}
@@ -56,13 +56,13 @@ public class TestSqlServerBatch extends BaseTestCase {
txn.setGetGeneratedKeys(false);
// explicitly flush the JDBC batch buffer
- txn.flushBatch();
+ txn.flush();
- for (int i = 0; i < 10; i++) {
- ESimple model = new ESimple();
- model.setName(i % 2 == 0 ? null:"foobar");
- Ebean.save(model);
- }
+ for (int i = 0; i < 10; i++) {
+ ESimple model = new ESimple();
+ model.setName(i % 2 == 0 ? null : "foobar");
+ Ebean.save(model);
+ }
// do not commit
} finally {