Tidy API making some classes final

ebean-api/src/main/java/io/ebean/DatabaseFactory.java

@@ -26,7 +26,7 @@ import java.util.concurrent.locks.ReentrantLock;
  * methods on the DB singleton such as {@link DB#find(Class)} are just a
  * convenient way of using the 'default/primary' Database.
  */
-public class DatabaseFactory {
+public final class DatabaseFactory {
 
   private static final ReentrantLock lock = new ReentrantLock();
   private static SpiContainer container;

ebean-api/src/main/java/io/ebean/DbPrimary.java

@@ -10,7 +10,7 @@ import java.util.concurrent.locks.ReentrantLock;
  * <p/>
  * Intended for internal use as part of bootup, construction, registration of the default database.
  */
-class DbPrimary {
+final class DbPrimary {
 
   private static final ReentrantLock lock = new ReentrantLock();
   private static String defaultServerName;

ebean-api/src/main/java/io/ebean/EbeanVersion.java

@@ -12,7 +12,7 @@ import java.util.Properties;
  *
  * @author Roland Praml, FOCONIS AG
  */
-public class EbeanVersion {
+public final class EbeanVersion {
 
   private static final Logger log = LoggerFactory.getLogger("io.ebean");
 

ebean-api/src/main/java/io/ebean/Expr.java

@@ -25,7 +25,7 @@ import java.util.Map;
  *
  * @see Query#where()
  */
-public class Expr {
+public final class Expr {
 
   private Expr() {
   }

ebean-api/src/main/java/io/ebean/FetchConfig.java

@@ -31,7 +31,7 @@ import java.io.Serializable;
  * @author mario
  * @author rbygrave
  */
-public class FetchConfig implements Serializable {
+public final class FetchConfig implements Serializable {
 
   private static final long serialVersionUID = 1L;
 

ebean-api/src/main/java/io/ebean/XServiceProvider.java

@@ -11,7 +11,7 @@ import java.util.ServiceLoader;
 /**
  * Lookup internal services.
  */
-class XServiceProvider {
+final class XServiceProvider {
 
   private static SpiRawSqlService rawSqlService = initRawSql();
 

ebean-api/src/main/java/io/ebean/meta/ServerMetricsAsJson.java

@@ -19,6 +19,7 @@ public interface ServerMetricsAsJson {
 
   /**
    * Set the sort property - see SortMetric
+   *
    * @see SortMetric
    */
   ServerMetricsAsJson withSort(Comparator<MetaTimedMetric> sortBy);
@@ -35,9 +36,9 @@ public interface ServerMetricsAsJson {
    */
   ServerMetricsAsJson withHeader(boolean withHeader);
 
-    /**
-     * Collect and write metrics as JSON to the given buffer.
-     */
+  /**
+   * Collect and write metrics as JSON to the given buffer.
+   */
   void write(Appendable buffer);
 
   /**

ebean-api/src/main/java/io/ebean/meta/SortMetric.java

@@ -5,7 +5,7 @@ import java.util.Comparator;
 /**
  * Comparator for timed metrics sorted by name and then count.
  */
-public class SortMetric {
+public final class SortMetric {
 
   public static final Comparator<MetaCountMetric> COUNT_NAME = new CountName();
 

ebean-api/src/main/java/io/ebean/metric/MetricServiceProvider.java

@@ -6,7 +6,7 @@ import java.util.ServiceLoader;
 /**
  * Lookup MetricFactory service.
  */
-class MetricServiceProvider {
+final class MetricServiceProvider {
 
   private static final MetricFactory metricFactory = init();
 

ebean-api/src/main/java/io/ebean/util/AnnotationUtil.java

@@ -10,7 +10,7 @@ import java.util.Set;
 /**
  * Annotation utility methods to find annotations.
  */
-public class AnnotationUtil {
+public final class AnnotationUtil {
 
   /**
    * Determine if the supplied {@link Annotation} is defined in the core JDK {@code java.lang.annotation} package.

ebean-api/src/main/java/io/ebean/util/CamelCaseHelper.java

@@ -1,6 +1,6 @@
 package io.ebean.util;
 
-public class CamelCaseHelper {
+public final class CamelCaseHelper {
 
   /**
    * To underscore from camel case using digits compressed true and force upper case false.

ebean-api/src/main/java/io/ebean/util/IOUtils.java

@@ -16,7 +16,7 @@ import java.nio.charset.StandardCharsets;
  * Utilities for IO. It uses UTF-8 as encoding when reading/writing and uses
  * buffered IO for better performance.
  */
-public class IOUtils {
+public final class IOUtils {
 
   /**
    * Read from stream as UTF-8.

ebean-api/src/main/java/io/ebean/util/JdbcClose.java

@@ -11,7 +11,7 @@ import java.sql.Statement;
 /**
  * Utility for closing raw Jdbc resources.
  */
-public class JdbcClose {
+public final class JdbcClose {
 
   private static final Logger log = LoggerFactory.getLogger("io.ebean");
 

ebean-api/src/main/java/io/ebean/util/SplitName.java

@@ -3,7 +3,7 @@ package io.ebean.util;
 /**
  * Helper for dot notation property paths.
  */
-public class SplitName {
+public final class SplitName {
 
   private static final char PERIOD = '.';
 

ebean-api/src/main/java/io/ebean/util/StringHelper.java

@@ -7,7 +7,7 @@ import java.util.regex.Pattern;
 /**
  * Utility String class that supports String manipulation functions.
  */
-public class StringHelper {
+public final class StringHelper {
 
   private static final Pattern SPLIT_NAMES = Pattern.compile("[\\s,;]+");