diff --git a/ebean-api/src/main/java/io/ebean/meta/MetaQueryMetric.java b/ebean-api/src/main/java/io/ebean/meta/MetaQueryMetric.java index edfe978e5..e3907c69c 100644 --- a/ebean-api/src/main/java/io/ebean/meta/MetaQueryMetric.java +++ b/ebean-api/src/main/java/io/ebean/meta/MetaQueryMetric.java @@ -21,8 +21,8 @@ public interface MetaQueryMetric extends MetaTimedMetric { String getSql(); /** - * Return the hash of the plan. + * Return the hash of the sql. */ - long getHash(); + long getSqlHash(); } diff --git a/ebean-api/src/main/java/io/ebean/meta/MetricData.java b/ebean-api/src/main/java/io/ebean/meta/MetricData.java index 9a24aa9f2..d8f80a0a9 100644 --- a/ebean-api/src/main/java/io/ebean/meta/MetricData.java +++ b/ebean-api/src/main/java/io/ebean/meta/MetricData.java @@ -6,7 +6,7 @@ package io.ebean.meta; public class MetricData { private String name; - private long hash; + private long sqlHash; private String loc; private String sql; @@ -30,12 +30,12 @@ public class MetricData { this.name = name; } - public long getHash() { - return hash; + public long getSqlHash() { + return sqlHash; } - public void setHash(long hash) { - this.hash = hash; + public void setSqlHash(long sqlHash) { + this.sqlHash = sqlHash; } public String getLoc() { diff --git a/ebean-core/src/main/java/io/ebeaninternal/api/SpiQueryPlan.java b/ebean-core/src/main/java/io/ebeaninternal/api/SpiQueryPlan.java index cd6c83114..878dcc716 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/api/SpiQueryPlan.java +++ b/ebean-core/src/main/java/io/ebeaninternal/api/SpiQueryPlan.java @@ -18,9 +18,9 @@ public interface SpiQueryPlan { String getName(); /** - * The hash for the query plan. + * The hash of the sql. */ - long getHash(); + long getSqlHash(); /** * The SQL for the query plan. diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetrics.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetrics.java index 972ee2754..4c42c4b11 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetrics.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetrics.java @@ -120,7 +120,7 @@ class DumpMetrics { appendQueryName(metric, sb); appendCounters(metric, sb); if (dumpHash) { - sb.append("\n hash:").append(metric.getHash()); + sb.append("\n sqlHash:").append(metric.getSqlHash()); } appendProfileAndSql(metric, sb); out(sb.toString()); diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsData.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsData.java index 9854cafea..7458d0468 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsData.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsData.java @@ -67,7 +67,7 @@ class DumpMetricsData { final MetricData data = create(metric); appendCounters(data, metric); appendLocationAndSql(data, metric); - data.setHash(metric.getHash()); + data.setSqlHash(metric.getSqlHash()); } private void appendLocationAndSql(MetricData data, MetaQueryMetric metric) { diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsJson.java b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsJson.java index 240d050f3..6f74dac97 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsJson.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/core/DumpMetricsJson.java @@ -197,7 +197,7 @@ class DumpMetricsJson implements ServerMetricsAsJson { metricStart(metric); appendTiming(metric); if (withHash) { - keyVal("hash", metric.getHash()); + keyVal("sqlHash", metric.getSqlHash()); } if (isIncludeDetail(metric)) { appendExtra("loc", metric.getLocation()); diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java index 8f0fea0f2..e08b37d1d 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanDescriptor.java @@ -1558,7 +1558,7 @@ public class BeanDescriptor implements BeanType, STreeType, SpiBeanType { void queryPlanInit(QueryPlanInit request, List list) { for (CQueryPlan queryPlan : queryPlanCache.values()) { - if (request.includeHash(queryPlan.getHash())) { + if (request.includeHash(queryPlan.getSqlHash())) { queryPlan.queryPlanInit(request.getThresholdMicros()); list.add(queryPlan.createMeta(null, null)); } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/profile/DQueryPlanMeta.java b/ebean-core/src/main/java/io/ebeaninternal/server/profile/DQueryPlanMeta.java index 0f25f0d9c..5359d96ed 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/profile/DQueryPlanMeta.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/profile/DQueryPlanMeta.java @@ -10,7 +10,7 @@ class DQueryPlanMeta { private final ProfileLocation profileLocation; private final String name; private final String sql; - private final long hash; + private final long sqlHash; DQueryPlanMeta(Class type, String label, ProfileLocation profileLocation, String sql) { this.type = type; @@ -22,15 +22,15 @@ class DQueryPlanMeta { name += "_" + label; } this.name = name; - this.hash = Checksum.checksum(sql); + this.sqlHash = Checksum.checksum(sql); } public Class getType() { return type; } - public long getHash() { - return hash; + public long getSqlHash() { + return sqlHash; } public String getName() { diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/profile/DQueryPlanMetric.java b/ebean-core/src/main/java/io/ebeaninternal/server/profile/DQueryPlanMetric.java index 765679404..fda2b62b8 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/profile/DQueryPlanMetric.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/profile/DQueryPlanMetric.java @@ -59,8 +59,8 @@ class DQueryPlanMetric implements QueryPlanMetric { } @Override - public long getHash() { - return meta.getHash(); + public long getSqlHash() { + return meta.getSqlHash(); } @Override diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java index 3c322190f..796290808 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlan.java @@ -68,7 +68,7 @@ public class CQueryPlan implements SpiQueryPlan { private final boolean rawSql; private final String sql; - private final long hash; + private final long sqlHash; private final String logWhereSql; @@ -118,7 +118,7 @@ public class CQueryPlan implements SpiQueryPlan { this.stats = new CQueryPlanStats(this); this.dependentTables = sqlTree.dependentTables(); this.bindCapture = initBindCapture(query); - this.hash = Checksum.checksum(sql); + this.sqlHash = Checksum.checksum(sql); } /** @@ -143,7 +143,7 @@ public class CQueryPlan implements SpiQueryPlan { this.stats = new CQueryPlanStats(this); this.dependentTables = sqlTree.dependentTables(); this.bindCapture = initBindCaptureRaw(sql, query); - this.hash = Checksum.checksum(sql); + this.sqlHash = Checksum.checksum(sql); } private String deriveName(String label, SpiQuery.Type type, String simpleName) { @@ -193,8 +193,8 @@ public class CQueryPlan implements SpiQueryPlan { } @Override - public long getHash() { - return hash; + public long getSqlHash() { + return sqlHash; } @Override @@ -226,7 +226,7 @@ public class CQueryPlan implements SpiQueryPlan { @Override public DQueryPlanOutput createMeta(String bind, String planString) { - return new DQueryPlanOutput(getBeanType(), name, hash, sql, profileLocation, bind, planString); + return new DQueryPlanOutput(getBeanType(), name, sqlHash, sql, profileLocation, bind, planString); } public DataReader createDataReader(ResultSet rset) { @@ -273,7 +273,7 @@ public class CQueryPlan implements SpiQueryPlan { private String calcAuditQueryKey() { // rawSql needs to include the MD5 hash of the sql - return rawSql ? planKey.getPartialKey() + "_" + hash : planKey.getPartialKey(); + return rawSql ? planKey.getPartialKey() + "_" + sqlHash : planKey.getPartialKey(); } SqlTree getSqlTree() { diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlanStats.java b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlanStats.java index 3f7f61070..bbcfea2b9 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlanStats.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlanStats.java @@ -127,8 +127,8 @@ public final class CQueryPlanStats { } @Override - public long getHash() { - return queryPlan.getHash(); + public long getSqlHash() { + return queryPlan.getSqlHash(); } @Override diff --git a/ebean-core/src/test/java/org/tests/query/finder/TestCustomerFinder.java b/ebean-core/src/test/java/org/tests/query/finder/TestCustomerFinder.java index 8e8c5a288..b6a40903f 100644 --- a/ebean-core/src/test/java/org/tests/query/finder/TestCustomerFinder.java +++ b/ebean-core/src/test/java/org/tests/query/finder/TestCustomerFinder.java @@ -216,7 +216,7 @@ public class TestCustomerFinder extends BaseTestCase { assertThat(plans0).isNotEmpty(); for (MetaQueryPlan plan : plans) { - logger.info("queryplan label:{}, queryTimeMicros:{} loc:{} sql:{} bind:{} plan:{}", + logger.info("queryPlan label:{}, queryTimeMicros:{} loc:{} sql:{} bind:{} plan:{}", plan.getLabel(), plan.getQueryTimeMicros(), plan.getProfileLocation(), plan.getSql(), plan.getBind(), plan.getPlan()); System.out.println(plan); @@ -244,7 +244,7 @@ public class TestCustomerFinder extends BaseTestCase { assertThat(metricsJson).contains("\"name\":\"orm.Customer.findList\""); assertThat(metricsJson).contains("\"loc\":\"CustomerFinder.byNameStatus(CustomerFinder.java:44)\""); if (isH2() || isPostgres()) { - assertThat(metricsJson).contains("\"hash\":3634991469"); + assertThat(metricsJson).contains("\"sqlHash\":3634991469"); assertThat(metricsJson).contains("\"sql\":\"select t0.id, t0.status,"); } } @@ -267,7 +267,7 @@ public class TestCustomerFinder extends BaseTestCase { assertThat(metricsJson).contains("\"name\":\"txn.main\""); assertThat(metricsJson).contains("\"name\":\"orm.Customer.findList\""); assertThat(metricsJson).doesNotContain("\"loc\":"); - assertThat(metricsJson).doesNotContain("\"hash\":"); + assertThat(metricsJson).doesNotContain("\"sqlHash\":"); assertThat(metricsJson).doesNotContain("\"sql\":"); }