diff --git a/ebean-api/src/main/java/io/ebean/cache/TenantAwareCache.java b/ebean-api/src/main/java/io/ebean/cache/TenantAwareCache.java index 42e22a950..06db455e7 100644 --- a/ebean-api/src/main/java/io/ebean/cache/TenantAwareCache.java +++ b/ebean-api/src/main/java/io/ebean/cache/TenantAwareCache.java @@ -29,9 +29,10 @@ public final class TenantAwareCache implements ServerCache { /** * Return the underlying ServerCache that is being delegated to. */ + @SuppressWarnings("unchecked") @Override public T unwrap(Class cls) { - return (T)delegate; + return (T) delegate; } @Override diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BaseCollectionHelp.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BaseCollectionHelp.java index 817f4e1de..502135111 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BaseCollectionHelp.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BaseCollectionHelp.java @@ -28,7 +28,7 @@ abstract class BaseCollectionHelp implements BeanCollectionHelp { } @Override - public void setLoader(BeanCollectionLoader loader) { + public final void setLoader(BeanCollectionLoader loader) { this.loader = loader; } @@ -43,7 +43,7 @@ abstract class BaseCollectionHelp implements BeanCollectionHelp { @SuppressWarnings("rawtypes") @Override - public Collection underlying(Object value) { + public final Collection underlying(Object value) { if (value instanceof BeanCollection) { return ((BeanCollection)value).getActualDetails(); } else { @@ -51,7 +51,7 @@ abstract class BaseCollectionHelp implements BeanCollectionHelp { } } - void jsonWriteCollection(SpiJsonWriter ctx, String name, Collection list) throws IOException { + final void jsonWriteCollection(SpiJsonWriter ctx, String name, Collection list) throws IOException { if (!list.isEmpty() || ctx.isIncludeEmpty()) { ctx.beginAssocMany(name); for (Object bean : list) { diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanListHelp.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanListHelp.java index 31e13bfd1..97b92fb9b 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanListHelp.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanListHelp.java @@ -28,8 +28,7 @@ public class BeanListHelp extends BaseCollectionHelp { } @Override - public BeanCollectionAdd getBeanCollectionAdd(Object bc, String mapKey) { - + public final BeanCollectionAdd getBeanCollectionAdd(Object bc, String mapKey) { if (bc instanceof BeanList) { BeanList bl = (BeanList) bc; if (bl.getActualList() == null) { @@ -43,17 +42,17 @@ public class BeanListHelp extends BaseCollectionHelp { } @Override - public Object createEmptyReference() { + public final Object createEmptyReference() { return Collections.EMPTY_LIST; } @Override - public BeanCollection createEmptyNoParent() { + public final BeanCollection createEmptyNoParent() { return new BeanList<>(); } @Override - public BeanCollection createEmpty(EntityBean parentBean) { + public final BeanCollection createEmpty(EntityBean parentBean) { BeanList beanList = new BeanList<>(loader, parentBean, propertyName); if (many != null) { beanList.setModifyListening(many.modifyListenMode()); @@ -62,29 +61,23 @@ public class BeanListHelp extends BaseCollectionHelp { } @Override - public BeanCollection createReference(EntityBean parentBean) { - + public final BeanCollection createReference(EntityBean parentBean) { BeanList beanList = new BeanList<>(loader, parentBean, propertyName); beanList.setModifyListening(many.modifyListenMode()); return beanList; } @Override - public void refresh(SpiEbeanServer server, Query query, Transaction t, EntityBean parentBean) { - + public final void refresh(SpiEbeanServer server, Query query, Transaction t, EntityBean parentBean) { BeanList newBeanList = (BeanList) server.findList(query, t); refresh(newBeanList, parentBean); } @Override - public void refresh(BeanCollection bc, EntityBean parentBean) { - + public final void refresh(BeanCollection bc, EntityBean parentBean) { BeanList newBeanList = (BeanList) bc; - List currentList = (List) many.getValue(parentBean); - newBeanList.setModifyListening(many.modifyListenMode()); - if (currentList == null) { // the currentList is null? Not really expecting this... many.setValue(parentBean, newBeanList); @@ -102,8 +95,7 @@ public class BeanListHelp extends BaseCollectionHelp { } @Override - public void jsonWrite(SpiJsonWriter ctx, String name, Object collection, boolean explicitInclude) throws IOException { - + public final void jsonWrite(SpiJsonWriter ctx, String name, Object collection, boolean explicitInclude) throws IOException { List list; if (collection instanceof BeanCollection) { BeanList beanList = (BeanList) collection; @@ -120,7 +112,6 @@ public class BeanListHelp extends BaseCollectionHelp { } else { list = (List) collection; } - jsonWriteCollection(ctx, name, list); } diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanMapHelp.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanMapHelp.java index 4943b3b80..896a87267 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanMapHelp.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanMapHelp.java @@ -37,13 +37,11 @@ public class BeanMapHelp extends BaseCollectionHelp { @Override @SuppressWarnings("unchecked") - public BeanCollectionAdd getBeanCollectionAdd(Object bc, String mapKey) { - + public final BeanCollectionAdd getBeanCollectionAdd(Object bc, String mapKey) { if (mapKey == null) { mapKey = many.mapKey(); } BeanProperty beanProp = targetDescriptor.beanProperty(mapKey); - if (bc instanceof BeanMap) { BeanMap bm = (BeanMap) bc; Map actualMap = bm.getActualMap(); @@ -58,10 +56,9 @@ public class BeanMapHelp extends BaseCollectionHelp { } } - static class Adder implements BeanCollectionAdd { + static final class Adder implements BeanCollectionAdd { private final BeanProperty beanProperty; - private final Map map; Adder(BeanProperty beanProperty, Map map) { @@ -77,18 +74,17 @@ public class BeanMapHelp extends BaseCollectionHelp { } @Override - public Object createEmptyReference() { + public final Object createEmptyReference() { return Collections.EMPTY_MAP; } @Override - public BeanCollection createEmptyNoParent() { + public final BeanCollection createEmptyNoParent() { return new BeanMap<>(); } @Override - public BeanCollection createEmpty(EntityBean ownerBean) { - + public final BeanCollection createEmpty(EntityBean ownerBean) { BeanMap beanMap = new BeanMap<>(loader, ownerBean, propertyName); if (many != null) { beanMap.setModifyListening(many.modifyListenMode()); @@ -98,7 +94,6 @@ public class BeanMapHelp extends BaseCollectionHelp { @Override public void add(BeanCollection collection, EntityBean bean, boolean withCheck) { - if (bean == null) { ((BeanMap) collection).internalPutNull(); } else { @@ -110,8 +105,7 @@ public class BeanMapHelp extends BaseCollectionHelp { @Override @SuppressWarnings({"unchecked", "rawtypes"}) - public BeanCollection createReference(EntityBean parentBean) { - + public final BeanCollection createReference(EntityBean parentBean) { BeanMap beanMap = new BeanMap(loader, parentBean, propertyName); if (many != null) { beanMap.setModifyListening(many.modifyListenMode()); @@ -120,14 +114,13 @@ public class BeanMapHelp extends BaseCollectionHelp { } @Override - public void refresh(SpiEbeanServer server, Query query, Transaction t, EntityBean parentBean) { + public final void refresh(SpiEbeanServer server, Query query, Transaction t, EntityBean parentBean) { BeanMap newBeanMap = (BeanMap) server.findMap(query, t); refresh(newBeanMap, parentBean); } @Override - public void refresh(BeanCollection bc, EntityBean parentBean) { - + public final void refresh(BeanCollection bc, EntityBean parentBean) { BeanMap newBeanMap = (BeanMap) bc; Map current = (Map) many.getValue(parentBean); @@ -149,8 +142,7 @@ public class BeanMapHelp extends BaseCollectionHelp { } @Override - public void jsonWrite(SpiJsonWriter ctx, String name, Object collection, boolean explicitInclude) throws IOException { - + public final void jsonWrite(SpiJsonWriter ctx, String name, Object collection, boolean explicitInclude) throws IOException { Map map; if (collection instanceof BeanCollection) { BeanMap bc = (BeanMap) collection; diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanMapHelpElement.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanMapHelpElement.java index 1c6fb7931..3d5936c79 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanMapHelpElement.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanMapHelpElement.java @@ -15,7 +15,6 @@ public final class BeanMapHelpElement extends BeanMapHelp { public void add(BeanCollection collection, EntityBean bean, boolean withCheck) { Object key = bean._ebean_getField(0); Object val = bean._ebean_getField(1); - BeanMap map = ((BeanMap) collection); if (withCheck) { map.internalPutWithCheck(key, val); diff --git a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanSetHelp.java b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanSetHelp.java index 4d538cb8c..1f8512f9c 100644 --- a/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanSetHelp.java +++ b/ebean-core/src/main/java/io/ebeaninternal/server/deploy/BeanSetHelp.java @@ -34,7 +34,7 @@ public class BeanSetHelp extends BaseCollectionHelp { } @Override - public BeanCollectionAdd getBeanCollectionAdd(Object bc, String mapKey) { + public final BeanCollectionAdd getBeanCollectionAdd(Object bc, String mapKey) { if (bc instanceof BeanSet) { BeanSet beanSet = (BeanSet) bc; if (beanSet.getActualSet() == null) { @@ -47,17 +47,17 @@ public class BeanSetHelp extends BaseCollectionHelp { } @Override - public Object createEmptyReference() { + public final Object createEmptyReference() { return Collections.EMPTY_SET; } @Override - public BeanCollection createEmptyNoParent() { + public final BeanCollection createEmptyNoParent() { return new BeanSet<>(); } @Override - public BeanCollection createEmpty(EntityBean ownerBean) { + public final BeanCollection createEmpty(EntityBean ownerBean) { BeanSet beanSet = new BeanSet<>(loader, ownerBean, propertyName); if (many != null) { beanSet.setModifyListening(many.modifyListenMode()); @@ -66,20 +66,20 @@ public class BeanSetHelp extends BaseCollectionHelp { } @Override - public BeanCollection createReference(EntityBean parentBean) { + public final BeanCollection createReference(EntityBean parentBean) { BeanSet beanSet = new BeanSet<>(loader, parentBean, propertyName); beanSet.setModifyListening(many.modifyListenMode()); return beanSet; } @Override - public void refresh(SpiEbeanServer server, Query query, Transaction t, EntityBean parentBean) { + public final void refresh(SpiEbeanServer server, Query query, Transaction t, EntityBean parentBean) { BeanSet newBeanSet = (BeanSet) server.findSet(query, t); refresh(newBeanSet, parentBean); } @Override - public void refresh(BeanCollection bc, EntityBean parentBean) { + public final void refresh(BeanCollection bc, EntityBean parentBean) { BeanSet newBeanSet = (BeanSet) bc; Set current = (Set) many.getValue(parentBean); newBeanSet.setModifyListening(many.modifyListenMode()); @@ -100,7 +100,7 @@ public class BeanSetHelp extends BaseCollectionHelp { } @Override - public void jsonWrite(SpiJsonWriter ctx, String name, Object collection, boolean explicitInclude) throws IOException { + public final void jsonWrite(SpiJsonWriter ctx, String name, Object collection, boolean explicitInclude) throws IOException { Set set; if (collection instanceof BeanCollection) { BeanSet bc = (BeanSet) collection;