Fix like escaping for DB2, Oracle and MySql (#1162)

* Extended test case to show problem

* FIX: Proper escaping of backslash in like/contains queries

* Had to replace "like ?" assertions in tests with "like " as mysql will do a "like binary ? escape'|'" now to be case sensitive

src/test/java/io/ebean/EbeanServer_eqlTest.java

@@ -135,7 +135,7 @@ public class EbeanServer_eqlTest extends BaseTestCase {
     query.setParameter("name", "Ro");
     query.findList();
 
-    assertThat(query.getGeneratedSql()).contains("where t0.name like ? ");
+    assertThat(query.getGeneratedSql()).contains("where t0.name like ");
   }
 
   @Test(expected = PersistenceException.class)

src/test/java/io/ebeaninternal/server/expression/DefaultExampleExpressionTest.java

@@ -86,8 +86,8 @@ public class DefaultExampleExpressionTest extends BaseExpressionTest {
 
     query1.findList();
 
-    assertThat(query1.getGeneratedSql()).contains("(t0.name like ? ");
-    assertThat(query1.getGeneratedSql()).contains(" and t1.city like ? ");
+    assertThat(query1.getGeneratedSql()).contains("(t0.name like ");
+    assertThat(query1.getGeneratedSql()).contains(" and t1.city like ");
 
   }
 

src/test/java/io/ebeaninternal/server/grammer/EqlParserTest.java

@@ -123,7 +123,7 @@ public class EqlParserTest extends BaseTestCase {
     query.setParameter("name", "Rob");
     query.findList();
 
-    assertThat(query.getGeneratedSql()).contains("where t0.name like ?");
+    assertThat(query.getGeneratedSql()).contains("where t0.name like ");
   }
 
   @Test

src/test/java/org/tests/batchload/TestBatchLazyWithCacheHits.java

@@ -78,7 +78,7 @@ public class TestBatchLazyWithCacheHits extends BaseTestCase {
 
     // batch lazy loading into cache
     assertThat(sql).hasSize(2);
-    assertThat(sql.get(0)).contains("from uuone t0 where t0.name like ?");
+    assertThat(sql.get(0)).contains("from uuone t0 where t0.name like ");
     assertThat(sql.get(1)).contains("from uuone t0 where t0.id in (?,");
 
     statistics = beanCache.getStatistics(true);

src/test/java/org/tests/query/TestExprNestedDisjunction.java

@@ -27,7 +27,7 @@ public class TestExprNestedDisjunction extends BaseTestCase {
     q.findList();
     String s = q.getGeneratedSql();
 
-    assertThat(s).contains("(t0.name like ? ");
+    assertThat(s).contains("(t0.name like ");
     assertThat(s).contains(" and t0.anniversary = ? )  or (t0.status = ?  and t0.id > ? )");
   }
 
@@ -51,7 +51,7 @@ public class TestExprNestedDisjunction extends BaseTestCase {
     q.findList();
     String s = q.getGeneratedSql();
 
-    assertThat(s).contains("(t0.name like ? ");
+    assertThat(s).contains("(t0.name like ");
     assertThat(s).contains(" and t0.anniversary = ? )  or (t0.status = ?  and t0.id > ? )");
   }
 

src/test/java/org/tests/query/TestQueryFetchManyTwoDeep.java

@@ -154,7 +154,7 @@ public class TestQueryFetchManyTwoDeep extends BaseTestCase {
 
     Assert.assertTrue(generatedSql.contains("from contact t0 "));
     Assert.assertTrue(generatedSql.contains("join o_customer t1 on t1.id = t0.customer_id"));
-    Assert.assertTrue(generatedSql.contains("where lower(t1.name) like ?"));
+    Assert.assertTrue(generatedSql.contains("where lower(t1.name) like "));
 
   }
 

src/test/java/org/tests/query/aggregation/TestAggregationCount.java

@@ -82,7 +82,7 @@ public class TestAggregationCount extends BaseTestCase {
     String sql = sqlOf(query2, 5);
     assertThat(sql).contains("select t0.id, t0.name, count(u1.id), sum(u1.units), sum(u1.units * u1.amount) from tevent_one t0");
     assertThat(sql).contains("from tevent_one t0 join tevent_many u1 on u1.event_id = t0.id ");
-    assertThat(sql).contains("where u1.description like ? ");
+    assertThat(sql).contains("where u1.description like ");
     assertThat(sql).contains(" group by t0.id, t0.name having count(u1.id) >= ?  order by t0.name");
 
     // invoke lazy loading

src/test/java/org/tests/query/joins/TestQueryManyToOneWhereClauseJoin.java

@@ -26,7 +26,7 @@ public class TestQueryManyToOneWhereClauseJoin extends BaseTestCase {
     query.findList();
 
     //select t0.id c0, t0.status c1, t0.order_date c2, t0.ship_date c3, t1.name c4, t0.cretime c5, t0.updtime c6, t0.kcustomer_id c7
-    String expectedSql = "from o_order t0 join o_customer t1 on t1.id = t0.kcustomer_id  where lower(t1.name) like ? ";
+    String expectedSql = "from o_order t0 join o_customer t1 on t1.id = t0.kcustomer_id  where lower(t1.name) like ";
     Assert.assertTrue(query.getGeneratedSql().contains(expectedSql));
 
     // select t0.id c0, t0.status c1, t0.order_date c2, t0.ship_date c3, t1.name c4, t0.cretime c5, t0.updtime c6, t0.kcustomer_id c7
@@ -50,7 +50,7 @@ public class TestQueryManyToOneWhereClauseJoin extends BaseTestCase {
     query.findList();
 
     //select t0.id c0, t0.status c1, t0.order_date c2, t0.ship_date c3, t1.name c4, t0.cretime c5, t0.updtime c6, t0.kcustomer_id c7
-    String expectedSql = "from o_order t0 join o_customer t1 on t1.id = t0.kcustomer_id  where (lower(t1.name) like ? ";
+    String expectedSql = "from o_order t0 join o_customer t1 on t1.id = t0.kcustomer_id  where (lower(t1.name) like ";
     Assert.assertTrue(query.getGeneratedSql().contains(expectedSql));
 
     // select t0.id c0, t0.status c1, t0.order_date c2, t0.ship_date c3, t1.name c4, t0.cretime c5, t0.updtime c6, t0.kcustomer_id c7
@@ -80,7 +80,7 @@ public class TestQueryManyToOneWhereClauseJoin extends BaseTestCase {
     String generatedSql = query.getGeneratedSql();
     Assert.assertTrue(generatedSql.contains("from o_order t0 join o_customer t1 on t1.id = t0.kcustomer_id"));
     Assert.assertTrue(generatedSql.contains("left join contact t2 on t2.customer_id = t1.id"));
-    Assert.assertTrue(generatedSql.contains("where lower(t1.name) like ?"));
+    Assert.assertTrue(generatedSql.contains("where lower(t1.name) like "));
 
     // select t0.id c0, t0.status c1, t0.order_date c2, t0.ship_date c3, t1.name c4, t0.cretime c5, t0.updtime c6,
     //        t1.id c7, t1.status c8, t1.name c9, t1.smallnote c10, t1.anniversary c11, t1.cretime c12, t1.updtime c13, t1.billing_address_id c14, t1.shipping_address_id c15,

src/test/java/org/tests/query/orderby/TestOrderByWithDistinctTake2.java

@@ -46,7 +46,7 @@ public class TestOrderByWithDistinctTake2 extends BaseTestCase {
     }
     assertThat(generatedSql).contains("order by t0.name desc");
     assertThat(generatedSql).contains("from o_customer t0 join contact u1 on u1.customer_id = t0.id");
-    assertThat(generatedSql).contains("where lower(u1.first_name) like ?");
+    assertThat(generatedSql).contains("where lower(u1.first_name) like ");
   }
 
   @Test
@@ -68,7 +68,7 @@ public class TestOrderByWithDistinctTake2 extends BaseTestCase {
     }
     assertThat(generatedSql).contains("order by t0.name, t0.id desc");
     assertThat(generatedSql).contains("from o_customer t0 join contact u1 on u1.customer_id = t0.id");
-    assertThat(generatedSql).contains("where lower(u1.first_name) like ?");
+    assertThat(generatedSql).contains("where lower(u1.first_name) like ");
   }
 
 }

src/test/java/org/tests/query/other/TestLikeEscaping.java

@@ -22,11 +22,19 @@ public class TestLikeEscaping extends BaseTestCase {
     Ebean.save(ResetBasicData.createCustomer("Paul %% Doublepercentage", "|Pipeway", "[other]", 1, null));
     Ebean.save(ResetBasicData.createCustomer("_Udo Underscore", "|Pipeway", "[other]", 1, null));
     
+    Ebean.save(ResetBasicData.createCustomer("Bodo \\ backslash", "\\BS", "[other]", 1, null));
     
     assertThat(Ebean.find(Customer.class)
         .where().contains("name", "Paul %%").findCount()
     ).isEqualTo(1);
     
+    assertThat(Ebean.find(Customer.class)
+        .where().contains("name", "o \\ b").findCount()
+    ).isEqualTo(1);
+
+    assertThat(Ebean.find(Customer.class)
+        .where().contains("name", "o \\\\ b").findCount()
+    ).isEqualTo(0);
     
     assertThat(Ebean.find(Customer.class)
         .where().startsWith("name", "_").findCount()
@@ -48,10 +56,13 @@ public class TestLikeEscaping extends BaseTestCase {
         .where().startsWith("shippingAddress.line1", "|P").findCount()
     ).isEqualTo(2);
     
-    
+    assertThat(Ebean.find(Customer.class)
+        .where().startsWith("shippingAddress.line1", "\\B").findCount()
+    ).isEqualTo(1);
+   
     assertThat(Ebean.find(Customer.class)
         .where().endsWith("billingAddress.line1", "]").findCount()
-    ).isEqualTo(4);
+    ).isEqualTo(5);
     
     assertThat(Ebean.find(Customer.class)
         .where().endsWith("billingAddress.line1", "[none]").findCount()

src/test/java/org/tests/query/other/TestQuerySingleAttribute.java

@@ -112,7 +112,7 @@ public class TestQuerySingleAttribute extends BaseTestCase {
 
     List<String> names = query.findSingleAttributeList();
 
-    assertThat(sqlOf(query)).contains("select distinct t0.name from o_customer t0 left join o_address t1 on t1.id = t0.billing_address_id  where t0.status = ?  and lower(t1.city) like ?");
+    assertThat(sqlOf(query)).contains("select distinct t0.name from o_customer t0 left join o_address t1 on t1.id = t0.billing_address_id  where t0.status = ?  and lower(t1.city) like ");
     assertThat(names).isNotNull();
   }