diff --git a/ebean-api/pom.xml b/ebean-api/pom.xml index db07c4dac..e3872012e 100644 --- a/ebean-api/pom.xml +++ b/ebean-api/pom.xml @@ -105,9 +105,9 @@ - org.avaje.composite + io.avaje junit - 1.1 + 1.0 test diff --git a/ebean-autotune/pom.xml b/ebean-autotune/pom.xml index fe5c2d720..5248a7359 100644 --- a/ebean-autotune/pom.xml +++ b/ebean-autotune/pom.xml @@ -46,9 +46,9 @@ - org.avaje.composite + io.avaje junit - 1.1 + 1.0 test diff --git a/ebean-autotune/src/test/java/io/ebeaninternal/server/autotune/service/AutoTuneXmlReaderTest.java b/ebean-autotune/src/test/java/io/ebeaninternal/server/autotune/service/AutoTuneXmlReaderTest.java index 845e68624..d67f2ec64 100644 --- a/ebean-autotune/src/test/java/io/ebeaninternal/server/autotune/service/AutoTuneXmlReaderTest.java +++ b/ebean-autotune/src/test/java/io/ebeaninternal/server/autotune/service/AutoTuneXmlReaderTest.java @@ -1,7 +1,7 @@ package io.ebeaninternal.server.autotune.service; import io.ebeaninternal.server.autotune.model.Autotune; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.File; import java.io.InputStream; diff --git a/ebean-autotune/src/test/java/io/ebeaninternal/server/autotune/service/ProfileOriginTest.java b/ebean-autotune/src/test/java/io/ebeaninternal/server/autotune/service/ProfileOriginTest.java index b1f982024..9f981a404 100644 --- a/ebean-autotune/src/test/java/io/ebeaninternal/server/autotune/service/ProfileOriginTest.java +++ b/ebean-autotune/src/test/java/io/ebeaninternal/server/autotune/service/ProfileOriginTest.java @@ -5,7 +5,7 @@ import io.ebean.bean.ObjectGraphNode; import io.ebean.bean.ObjectGraphOrigin; import io.ebeaninternal.server.deploy.BeanDescriptor; import io.ebeaninternal.server.querydefn.OrmQueryDetail; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.tests.autofetch.BaseTestCase; import org.tests.model.basic.Order; diff --git a/ebean-ddl-generator/pom.xml b/ebean-ddl-generator/pom.xml index f83727127..31216b1a4 100644 --- a/ebean-ddl-generator/pom.xml +++ b/ebean-ddl-generator/pom.xml @@ -50,9 +50,9 @@ - org.avaje.composite + io.avaje junit - 1.1 + 1.0 test diff --git a/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java b/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java index 5b76d754f..1d7d8d057 100644 --- a/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java +++ b/ebean-ddl-generator/src/test/java/io/ebean/BaseTestCase.java @@ -12,12 +12,8 @@ import io.ebeaninternal.api.SpiTransaction; import io.ebeaninternal.server.deploy.BeanDescriptor; import io.ebeaninternal.server.expression.platform.DbExpressionHandler; import io.ebeaninternal.server.expression.platform.DbExpressionHandlerFactory; -import io.ebeaninternal.server.transaction.TransactionScopeManager; import org.assertj.core.api.AbstractCharSequenceAssert; -import org.junit.After; -import org.junit.Rule; -import org.junit.rules.TestName; -import org.junit.runner.RunWith; +import org.junit.jupiter.api.extension.ExtendWith; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -26,25 +22,24 @@ import java.util.List; import java.util.stream.Collectors; import static org.assertj.core.api.Assertions.assertThat; -import static org.junit.Assert.fail; -@RunWith(ConditionalTestRunner.class) +@ExtendWith(PlatformCondition.class) public abstract class BaseTestCase { protected static Logger logger = LoggerFactory.getLogger(BaseTestCase.class); - @Rule public TestName name = new TestName(); - - @After - public void checkForLeak() { - TransactionScopeManager scope = spiEbeanServer().getTransactionManager().scope(); - SpiTransaction trans = scope.getInScope(); - if (trans != null) { - String msg = getClass().getSimpleName() + "." + name.getMethodName() + " did not clear threadScope:" + trans; - scope.clearExternal(); // clear for next test - fail(msg); - } - } +// @Rule public TestName name = new TestName(); +// +// @After +// public void checkForLeak() { +// TransactionScopeManager scope = spiEbeanServer().getTransactionManager().scope(); +// SpiTransaction trans = scope.getInScope(); +// if (trans != null) { +// String msg = getClass().getSimpleName() + "." + name.getMethodName() + " did not clear threadScope:" + trans; +// scope.clearExternal(); // clear for next test +// fail(msg); +// } +// } /** diff --git a/ebean-ddl-generator/src/test/java/io/ebean/ConditionalTestRunner.java b/ebean-ddl-generator/src/test/java/io/ebean/ConditionalTestRunner.java deleted file mode 100644 index d0dea0067..000000000 --- a/ebean-ddl-generator/src/test/java/io/ebean/ConditionalTestRunner.java +++ /dev/null @@ -1,48 +0,0 @@ -package io.ebean; - -import io.ebean.annotation.ForPlatform; -import io.ebean.annotation.IgnorePlatform; -import io.ebean.annotation.Platform; -import org.junit.runner.notification.RunNotifier; -import org.junit.runners.BlockJUnit4ClassRunner; -import org.junit.runners.model.FrameworkMethod; -import org.junit.runners.model.InitializationError; - -/** - * This testrunner checks for an {@link IgnorePlatform} annotation and ignores the test. - * - * @author Roland Praml, FOCONIS AG - */ -public class ConditionalTestRunner extends BlockJUnit4ClassRunner { - public ConditionalTestRunner(Class klass) throws InitializationError { - super(klass); - } - @Override - public void runChild(FrameworkMethod method, RunNotifier notifier) { - ForPlatform forPlatform = method.getAnnotation(ForPlatform.class); - if (forPlatform != null) { - if (!platformMath(forPlatform.value())) { - notifier.fireTestIgnored(describeChild(method)); - return; - } - } - - IgnorePlatform ignore = method.getAnnotation(IgnorePlatform.class); - - if (ignore == null || !platformMath(ignore.value())) { - super.runChild(method, notifier); - } else { - notifier.fireTestIgnored(describeChild(method)); - } - - } - private boolean platformMath(Platform[] platforms) { - Platform basePlatform = DB.getDefault().platform().base(); - for (Platform platform : platforms) { - if (platform.equals(basePlatform)) { - return true; - } - } - return false; - } -} diff --git a/ebean-ddl-generator/src/test/java/io/ebean/PlatformCondition.java b/ebean-ddl-generator/src/test/java/io/ebean/PlatformCondition.java new file mode 100644 index 000000000..b04f3db1c --- /dev/null +++ b/ebean-ddl-generator/src/test/java/io/ebean/PlatformCondition.java @@ -0,0 +1,37 @@ +package io.ebean; + +import io.ebean.annotation.ForPlatform; +import io.ebean.annotation.Platform; +import org.junit.jupiter.api.extension.ConditionEvaluationResult; +import org.junit.jupiter.api.extension.ExecutionCondition; +import org.junit.jupiter.api.extension.ExtensionContext; + +import java.lang.reflect.AnnotatedElement; +import java.util.Optional; + +public class PlatformCondition implements ExecutionCondition { + + private static final ConditionEvaluationResult ENABLED = ConditionEvaluationResult.enabled("ForPlatform is not present"); + + @Override + public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext context) { + Optional element = context.getElement(); + if (element.isPresent()) { + final ForPlatform annotation = element.get().getAnnotation(ForPlatform.class); + if (annotation != null && !platformMath(annotation.value())) { + return ConditionEvaluationResult.disabled("@ForPlatform"); + } + } + return ENABLED; + } + + private boolean platformMath(Platform[] platforms) { + Platform basePlatform = DB.getDefault().platform().base(); + for (Platform platform : platforms) { + if (platform.equals(basePlatform)) { + return true; + } + } + return false; + } +} diff --git a/ebean-ddl-generator/src/test/java/io/ebean/dbmigration/DbMigrationSqlServerTest.java b/ebean-ddl-generator/src/test/java/io/ebean/dbmigration/DbMigrationSqlServerTest.java index 2ee20516c..b30bcbc8b 100644 --- a/ebean-ddl-generator/src/test/java/io/ebean/dbmigration/DbMigrationSqlServerTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebean/dbmigration/DbMigrationSqlServerTest.java @@ -2,16 +2,19 @@ package io.ebean.dbmigration; import io.ebean.annotation.Platform; import io.ebeaninternal.api.DbOffline; -import org.junit.Test; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertThrows; public class DbMigrationSqlServerTest { - @Test(expected = IllegalArgumentException.class) + @Test public void need_explicitPlatform() { - try { DbMigration dbMigration = DbMigration.create(); - dbMigration.setPlatform(Platform.SQLSERVER); + assertThrows(IllegalArgumentException.class, + () -> dbMigration.setPlatform(Platform.SQLSERVER)); } finally { DbOffline.reset(); } @@ -19,7 +22,6 @@ public class DbMigrationSqlServerTest { @Test public void explicit_16_isGood() { - DbMigration dbMigration = DbMigration.create(); dbMigration.setPlatform(Platform.SQLSERVER16); DbOffline.reset(); @@ -27,7 +29,6 @@ public class DbMigrationSqlServerTest { @Test public void explicit_17_isGood() { - DbMigration dbMigration = DbMigration.create(); dbMigration.setPlatform(Platform.SQLSERVER17); DbOffline.reset(); diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationDropHistoryTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationDropHistoryTest.java index 320406a7c..56752e7f2 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationDropHistoryTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationDropHistoryTest.java @@ -3,7 +3,7 @@ package io.ebeaninternal.dbmigration; import io.ebean.Database; import io.ebean.DatabaseFactory; import io.ebean.config.DatabaseConfig; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationGenerateTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationGenerateTest.java index f5bf01a56..cdfc3df13 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationGenerateTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationGenerateTest.java @@ -4,7 +4,7 @@ import io.ebean.Database; import io.ebean.DatabaseFactory; import io.ebean.annotation.Platform; import io.ebean.config.DatabaseConfig; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationTest.java index a659a2b65..6eacdc2ac 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DbMigrationTest.java @@ -6,7 +6,7 @@ import io.ebean.SqlUpdate; import io.ebean.annotation.IgnorePlatform; import io.ebean.annotation.Platform; import io.ebeaninternal.dbmigration.ddlgeneration.Helper; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.IOException; import java.util.List; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DefaultDbMigrationTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DefaultDbMigrationTest.java index 642b3dc2c..dc787935f 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DefaultDbMigrationTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/DefaultDbMigrationTest.java @@ -1,8 +1,8 @@ package io.ebeaninternal.dbmigration; -import org.junit.Test; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.*; +import static org.junit.jupiter.api.Assertions.assertEquals; public class DefaultDbMigrationTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/H2PlatformTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/H2PlatformTest.java index 8f68a49d9..f282b75fc 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/H2PlatformTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/H2PlatformTest.java @@ -3,7 +3,7 @@ package io.ebeaninternal.dbmigration; import io.ebean.config.dbplatform.h2.H2Platform; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; import io.ebeaninternal.dbmigration.ddlgeneration.platform.PlatformDdl; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/HanaPlatformTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/HanaPlatformTest.java index bd0dea4c5..5bafff7e0 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/HanaPlatformTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/HanaPlatformTest.java @@ -5,7 +5,7 @@ import io.ebean.config.dbplatform.DbPlatformType; import io.ebean.config.dbplatform.hana.HanaPlatform; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; import io.ebeaninternal.dbmigration.ddlgeneration.platform.PlatformDdl; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/IndexMigrationTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/IndexMigrationTest.java index a22a42ec7..f953088b9 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/IndexMigrationTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/IndexMigrationTest.java @@ -3,7 +3,7 @@ package io.ebeaninternal.dbmigration; import io.ebean.config.dbplatform.DatabasePlatform; import io.ebean.config.dbplatform.h2.H2Platform; import io.ebean.config.dbplatform.postgres.PostgresPlatform; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.File; import java.io.IOException; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/LastMigrationTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/LastMigrationTest.java index e0adf54b2..3571b21cc 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/LastMigrationTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/LastMigrationTest.java @@ -1,6 +1,6 @@ package io.ebeaninternal.dbmigration; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.File; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/MChecksumTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/MChecksumTest.java index e52c43755..0f41e7ba0 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/MChecksumTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/MChecksumTest.java @@ -1,6 +1,6 @@ package io.ebeaninternal.dbmigration; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.File; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/MySqlPlatformTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/MySqlPlatformTest.java index 69486c4c7..8cfcae78a 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/MySqlPlatformTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/MySqlPlatformTest.java @@ -3,7 +3,7 @@ package io.ebeaninternal.dbmigration; import io.ebean.config.dbplatform.mysql.MySqlPlatform; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; import io.ebeaninternal.dbmigration.ddlgeneration.platform.PlatformDdl; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/OraclePlatformTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/OraclePlatformTest.java index ff7472eb5..9f38f6879 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/OraclePlatformTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/OraclePlatformTest.java @@ -3,7 +3,7 @@ package io.ebeaninternal.dbmigration; import io.ebean.config.dbplatform.oracle.OraclePlatform; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; import io.ebeaninternal.dbmigration.ddlgeneration.platform.PlatformDdl; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/PostgresPlatformTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/PostgresPlatformTest.java index c18e224cf..a374afbeb 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/PostgresPlatformTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/PostgresPlatformTest.java @@ -3,7 +3,7 @@ package io.ebeaninternal.dbmigration; import io.ebean.config.dbplatform.postgres.PostgresPlatform; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; import io.ebeaninternal.dbmigration.ddlgeneration.platform.PlatformDdl; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/SqlserverPlatformTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/SqlserverPlatformTest.java index 0230b3534..9d80285a2 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/SqlserverPlatformTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/SqlserverPlatformTest.java @@ -5,7 +5,7 @@ import io.ebean.config.dbplatform.DbPlatformType; import io.ebean.config.dbplatform.sqlserver.SqlServer17Platform; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; import io.ebeaninternal.dbmigration.ddlgeneration.platform.PlatformDdl; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/BaseDdlHandlerTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/BaseDdlHandlerTest.java index f9742350e..cef125750 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/BaseDdlHandlerTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/BaseDdlHandlerTest.java @@ -11,8 +11,8 @@ import io.ebean.config.dbplatform.sqlserver.SqlServer17Platform; import io.ebeaninternal.api.SpiEbeanServer; import io.ebeaninternal.dbmigration.migration.ChangeSet; import io.ebeaninternal.dbmigration.model.CurrentModel; -import org.junit.Ignore; -import org.junit.Test; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; @@ -223,7 +223,7 @@ public class BaseDdlHandlerTest extends BaseTestCase { assertThat(write.dropAll().getBuffer()).isEqualTo(rollbackLast); } - @Ignore + @Disabled @Test public void generateChangeSetFromModel() throws Exception { @@ -243,7 +243,7 @@ public class BaseDdlHandlerTest extends BaseTestCase { assertThat(write.dropAll().getBuffer()).isEqualTo(rollbackLast); } - @Ignore + @Disabled @Test public void generateChangeSetFromModel_given_postgresTypes() throws Exception { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/BaseTableDdlTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/BaseTableDdlTest.java index c32d6ad80..b087803db 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/BaseTableDdlTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/BaseTableDdlTest.java @@ -13,13 +13,13 @@ import io.ebeaninternal.dbmigration.migration.AlterColumn; import io.ebeaninternal.dbmigration.migration.Column; import io.ebeaninternal.dbmigration.migration.CreateTable; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.IOException; import java.util.List; import static org.assertj.core.api.Assertions.assertThat; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; public class BaseTableDdlTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/ClickHouseDbArrayTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/ClickHouseDbArrayTest.java index 181630396..7e9dc946c 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/ClickHouseDbArrayTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/ClickHouseDbArrayTest.java @@ -1,6 +1,6 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/DbNameNormaliseTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/DbNameNormaliseTest.java index d2c8e855c..bbdb51294 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/DbNameNormaliseTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/DbNameNormaliseTest.java @@ -1,7 +1,7 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; import io.ebean.config.DbConstraintNormalise; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/H2HistoryDdlTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/H2HistoryDdlTest.java index 87441f89e..62b0f535c 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/H2HistoryDdlTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/H2HistoryDdlTest.java @@ -9,7 +9,7 @@ import io.ebeaninternal.dbmigration.model.MConfiguration; import io.ebeaninternal.dbmigration.model.ModelContainer; import io.ebeaninternal.api.SpiEbeanServer; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/HanaDdlTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/HanaDdlTest.java index 6fc27e34d..3e467babe 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/HanaDdlTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/HanaDdlTest.java @@ -3,11 +3,11 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; import io.ebean.config.dbplatform.hana.HanaPlatform; import io.ebeaninternal.dbmigration.ddlgeneration.DdlWrite; import io.ebeaninternal.dbmigration.migration.Column; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.IOException; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; public class HanaDdlTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/HistoryTableUpdateTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/HistoryTableUpdateTest.java index 7e9e2e490..a2f2c6080 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/HistoryTableUpdateTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/HistoryTableUpdateTest.java @@ -1,6 +1,6 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/IndexSetTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/IndexSetTest.java index ce91ab2e1..8a171b52e 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/IndexSetTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/IndexSetTest.java @@ -1,10 +1,10 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; import io.ebeaninternal.dbmigration.ddlgeneration.platform.util.IndexSet; -import org.junit.Test; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; public class IndexSetTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/NativeDbArrayTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/NativeDbArrayTest.java index 7d37363e4..3c609a2ba 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/NativeDbArrayTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/NativeDbArrayTest.java @@ -1,6 +1,6 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/OracleDdlTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/OracleDdlTest.java index c9eb698ab..5d74e0b68 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/OracleDdlTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/OracleDdlTest.java @@ -2,7 +2,7 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; import io.ebean.annotation.ConstraintMode; import io.ebean.config.dbplatform.oracle.OraclePlatform; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java index 4b3044375..5da1a25a8 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_AlterColumnTest.java @@ -14,14 +14,14 @@ import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; import io.ebeaninternal.dbmigration.migration.AlterColumn; import io.ebeaninternal.dbmigration.migration.AlterForeignKey; import io.ebeaninternal.dbmigration.migration.Column; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.IOException; import static org.assertj.core.api.Assertions.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNull; -import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertTrue; public class PlatformDdl_AlterColumnTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java index 31cd89ae5..e7b8fab30 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_CreateIndexTest.java @@ -10,10 +10,10 @@ import io.ebean.config.dbplatform.postgres.PostgresPlatform; import io.ebean.config.dbplatform.sqlserver.SqlServer17Platform; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; import io.ebeaninternal.dbmigration.migration.CreateIndex; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; public class PlatformDdl_CreateIndexTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_dropUniqueConstraintTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_dropUniqueConstraintTest.java index 3d345623b..0139565dd 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_dropUniqueConstraintTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformDdl_dropUniqueConstraintTest.java @@ -8,9 +8,9 @@ import io.ebean.config.dbplatform.oracle.OraclePlatform; import io.ebean.config.dbplatform.postgres.PostgresPlatform; import io.ebean.config.dbplatform.sqlserver.SqlServer17Platform; import io.ebeaninternal.dbmigration.ddlgeneration.PlatformDdlBuilder; -import org.junit.Test; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; public class PlatformDdl_dropUniqueConstraintTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformTypeConverterTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformTypeConverterTest.java index c6a9d1953..45dbd60b6 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformTypeConverterTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PlatformTypeConverterTest.java @@ -4,7 +4,7 @@ import io.ebean.config.dbplatform.DbPlatformTypeMapping; import io.ebean.config.dbplatform.h2.H2Platform; import io.ebean.config.dbplatform.postgres.PostgresPlatform; import io.ebeaninternal.dbmigration.ddlgeneration.platform.util.PlatformTypeConverter; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PostgresDdlTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PostgresDdlTest.java index 611ec94dd..3d12d29b7 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PostgresDdlTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/PostgresDdlTest.java @@ -1,7 +1,7 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; import io.ebean.config.dbplatform.postgres.PostgresPlatform; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/SqlServerHistoryDdlTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/SqlServerHistoryDdlTest.java index f1ac32365..73dd7c57f 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/SqlServerHistoryDdlTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/SqlServerHistoryDdlTest.java @@ -1,6 +1,6 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/util/VowelRemoverTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/util/VowelRemoverTest.java index 894760ce8..46318bbbd 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/util/VowelRemoverTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/ddlgeneration/platform/util/VowelRemoverTest.java @@ -1,8 +1,8 @@ package io.ebeaninternal.dbmigration.ddlgeneration.platform.util; -import org.junit.Test; +import org.junit.jupiter.api.Test; -import static org.junit.Assert.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; public class VowelRemoverTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/migrationreader/MigrationXmlWriterTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/migrationreader/MigrationXmlWriterTest.java index c0b87b47e..9805a263c 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/migrationreader/MigrationXmlWriterTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/migrationreader/MigrationXmlWriterTest.java @@ -1,7 +1,7 @@ package io.ebeaninternal.dbmigration.migrationreader; import io.ebeaninternal.dbmigration.migration.Migration; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.io.File; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/EntryTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/EntryTest.java index df9657e5d..7c2fe8de1 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/EntryTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/EntryTest.java @@ -3,7 +3,7 @@ package io.ebeaninternal.dbmigration.model; import io.ebean.migration.MigrationVersion; import io.ebeaninternal.dbmigration.migration.ChangeSet; import io.ebeaninternal.dbmigration.migration.DropColumn; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MColumnTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MColumnTest.java index 4cbd63cfa..29d01efdc 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MColumnTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MColumnTest.java @@ -1,7 +1,7 @@ package io.ebeaninternal.dbmigration.model; import io.ebeaninternal.dbmigration.migration.AlterColumn; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MTableIdentityTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MTableIdentityTest.java index 5c76d62c0..7774d91c2 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MTableIdentityTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MTableIdentityTest.java @@ -6,11 +6,12 @@ import io.ebeaninternal.dbmigration.migration.CreateTable; import io.ebeaninternal.dbmigration.migration.IdentityType; import io.ebeaninternal.server.deploy.IdentityMode; import io.ebeaninternal.server.deploy.meta.DeployIdentityMode; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.math.BigInteger; -import static org.junit.Assert.*; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; public class MTableIdentityTest { diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MTableTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MTableTest.java index 290cff30a..f3e2d5648 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MTableTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MTableTest.java @@ -6,13 +6,12 @@ import io.ebeaninternal.dbmigration.migration.AlterColumn; import io.ebeaninternal.dbmigration.migration.DropColumn; import io.ebeaninternal.dbmigration.migration.DropHistoryTable; import io.ebeaninternal.dbmigration.migration.DropTable; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.util.List; import static org.assertj.core.api.Assertions.assertThat; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNull; +import static org.junit.jupiter.api.Assertions.*; public class MTableTest { @@ -155,27 +154,26 @@ public class MTableTest { assertThat(base.getColumn("name")).isNull(); } - @Test(expected = IllegalStateException.class) + @Test public void test_apply_dropColumn_doesNotExist() { - MTable base = base(); DropColumn dropColumn = new DropColumn(); dropColumn.setTableName(base.getName()); dropColumn.setColumnName("DoesNotExist"); - base.apply(dropColumn); + assertThrows(IllegalStateException.class, () -> base.apply(dropColumn)); } - @Test(expected = IllegalStateException.class) + @Test public void test_apply_alterColumn_doesNotExist() { - MTable base = base(); AlterColumn alterColumn = new AlterColumn(); alterColumn.setTableName(base.getName()); alterColumn.setColumnName("DoesNotExist"); alterColumn.setType("integer"); - base.apply(alterColumn); + + assertThrows(IllegalStateException.class, () -> base.apply(alterColumn)); } @Test diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MigrationVersionTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MigrationVersionTest.java index 87a4fecd9..b3c4d5240 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MigrationVersionTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/MigrationVersionTest.java @@ -1,6 +1,6 @@ package io.ebeaninternal.dbmigration.model; -import org.junit.Test; +import org.junit.jupiter.api.Test; import io.ebean.migration.MigrationVersion; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelContainerApplyTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelContainerApplyTest.java index 895b24f3f..da493f9ef 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelContainerApplyTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelContainerApplyTest.java @@ -7,7 +7,7 @@ import io.ebeaninternal.dbmigration.migration.CreateTable; import io.ebeaninternal.dbmigration.migration.DropColumn; import io.ebeaninternal.dbmigration.migration.Migration; import io.ebeaninternal.dbmigration.migrationreader.MigrationXmlReader; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.util.List; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelContainerTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelContainerTest.java index c9c1dc8c0..c76906fd1 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelContainerTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelContainerTest.java @@ -7,7 +7,7 @@ import io.ebeaninternal.dbmigration.migration.DropIndex; import io.ebeaninternal.dbmigration.migration.DropTable; import io.ebeaninternal.dbmigration.migration.Migration; import io.ebeaninternal.dbmigration.migrationreader.MigrationXmlReader; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.util.List; import java.util.Set; @@ -158,7 +158,7 @@ public class ModelContainerTest { public void apply_renameColumn() { ModelContainer container = new ModelContainer(); container.apply(mig("6.0__renameColumn.model.xml"), ver("6.0")); - + final MTable table = container.getTable("document"); assertThat(table.getColumn("title")).isNotNull(); assertThat(table.getColumn("short_title")).isNull(); diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelDiffTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelDiffTest.java index e2cdde859..15245e921 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelDiffTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/ModelDiffTest.java @@ -1,6 +1,6 @@ package io.ebeaninternal.dbmigration.model; -import org.junit.Test; +import org.junit.jupiter.api.Test; import static org.assertj.core.api.Assertions.assertThat; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/PendingDropsTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/PendingDropsTest.java index df58fbc45..66e091aae 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/PendingDropsTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/PendingDropsTest.java @@ -4,29 +4,29 @@ import io.ebean.migration.MigrationVersion; import io.ebeaninternal.dbmigration.migration.ChangeSet; import io.ebeaninternal.dbmigration.migration.DropColumn; import io.ebeaninternal.dbmigration.migration.Migration; -import org.junit.Test; +import org.junit.jupiter.api.Test; import java.util.ArrayList; import java.util.List; import static org.assertj.core.api.Assertions.assertThat; +import static org.junit.jupiter.api.Assertions.assertThrows; public class PendingDropsTest { static final MigrationVersion V1_1 = MigrationVersion.parse("1.1"); - static final MigrationVersion V1_2 = MigrationVersion.parse("1.2"); @Test - public void test_add() throws Exception { + public void test_add() { PendingDrops pendingDrops = new PendingDrops(); pendingDrops.add(V1_1, new ChangeSet()); } @Test - public void test_appliedDropsFor_when_matchesSome_then_removesMatched() throws Exception { + public void test_appliedDropsFor_when_matchesSome_then_removesMatched() { PendingDrops pendingDrops = new PendingDrops(); @@ -45,7 +45,7 @@ public class PendingDropsTest { } @Test - public void test_appliedDropsFor_when_matchesAll_then_removesChangeSet() throws Exception { + public void test_appliedDropsFor_when_matchesAll_then_removesChangeSet() { PendingDrops pendingDrops = new PendingDrops(); @@ -63,7 +63,7 @@ public class PendingDropsTest { } @Test - public void test_appliedDropsFor_when_changeSetSuppressed_isIgnored() throws Exception { + public void test_appliedDropsFor_when_changeSetSuppressed_isIgnored() { PendingDrops pendingDrops = new PendingDrops(); @@ -81,7 +81,7 @@ public class PendingDropsTest { @Test - public void test_pendingDrops() throws Exception { + public void test_pendingDrops() { PendingDrops pendingDrops = new PendingDrops(); assertThat(pendingDrops.pendingDrops()).isEmpty(); @@ -92,7 +92,7 @@ public class PendingDropsTest { } @Test - public void test_pendingDrops_when_suppressForever() throws Exception { + public void test_pendingDrops_when_suppressForever() { PendingDrops pendingDrops = new PendingDrops(); assertThat(pendingDrops.pendingDrops()).isEmpty(); @@ -105,7 +105,7 @@ public class PendingDropsTest { } @Test - public void test_pendingDrops_when_both() throws Exception { + public void test_pendingDrops_when_both() { PendingDrops pendingDrops = new PendingDrops(); assertThat(pendingDrops.pendingDrops()).isEmpty(); @@ -119,7 +119,7 @@ public class PendingDropsTest { } @Test - public void test_migrationForVersion() throws Exception { + public void test_migrationForVersion() { PendingDrops pendingDrops = new PendingDrops(); @@ -137,7 +137,7 @@ public class PendingDropsTest { } @Test - public void test_migrationForVersion_when_both() throws Exception { + public void test_migrationForVersion_when_both() { PendingDrops pendingDrops = new PendingDrops(); @@ -153,7 +153,7 @@ public class PendingDropsTest { } @Test - public void test_migrationForVersion_when_next() throws Exception { + public void test_migrationForVersion_when_next() { PendingDrops pendingDrops = new PendingDrops(); MigrationVersion version = V1_1; @@ -168,32 +168,28 @@ public class PendingDropsTest { assertThat(pendingDrops.testContainsEntryFor(version)).isTrue(); } - @Test(expected = IllegalArgumentException.class) - public void test_migrationForVersion_when_next_isSuppressForever() throws Exception { - + @Test + public void test_migrationForVersion_when_next_isSuppressForever() { PendingDrops pendingDrops = new PendingDrops(); pendingDrops.add(V1_1, newSuppressForeverChangeSet()); - pendingDrops.migrationForVersion("next"); + assertThrows(IllegalArgumentException.class, () -> pendingDrops.migrationForVersion("next")); } - @Test(expected = IllegalArgumentException.class) - public void test_migrationForVersion_when_doesNotExist() throws Exception { - + @Test + public void test_migrationForVersion_when_doesNotExist() { PendingDrops pendingDrops = new PendingDrops(); - pendingDrops.migrationForVersion("1_1"); + assertThrows(IllegalArgumentException.class, () -> pendingDrops.migrationForVersion("1_1")); } - @Test(expected = IllegalArgumentException.class) - public void test_migrationForVersion_when_next_doesNotExist() throws Exception { - + @Test + public void test_migrationForVersion_when_next_doesNotExist(){ PendingDrops pendingDrops = new PendingDrops(); - pendingDrops.migrationForVersion("next"); + assertThrows(IllegalArgumentException.class, () -> pendingDrops.migrationForVersion("next")); } @Test - public void test_registerPendingHistoryDropColumns() throws Exception { - + public void test_registerPendingHistoryDropColumns() { TDModelContainer modelContainer = new TDModelContainer(); DropColumn drop1 = col("one"); @@ -210,7 +206,7 @@ public class PendingDropsTest { assertThat(modelContainer.drops).containsExactly(changeSet); } - class TDModelContainer extends ModelContainer { + static class TDModelContainer extends ModelContainer { List drops = new ArrayList<>(); diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuildBeanVisitorTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuildBeanVisitorTest.java index 3d94d859f..70c0d70e1 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuildBeanVisitorTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuildBeanVisitorTest.java @@ -15,7 +15,7 @@ import io.ebeaninternal.dbmigration.model.MCompoundForeignKey; import io.ebeaninternal.dbmigration.model.MTable; import io.ebeaninternal.dbmigration.model.ModelContainer; import io.ebeaninternal.dbmigration.model.visitor.VisitAllUsing; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.tests.model.basic.CKeyAssoc; import org.tests.model.basic.CKeyDetail; import org.tests.model.basic.CKeyParent; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_compoundKeyTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_compoundKeyTest.java index 7db211782..3d95eb951 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_compoundKeyTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_compoundKeyTest.java @@ -11,7 +11,7 @@ import io.ebeaninternal.dbmigration.migrationreader.MigrationXmlReader; import io.ebeaninternal.dbmigration.model.CurrentModel; import io.ebeaninternal.dbmigration.model.MTable; import io.ebeaninternal.dbmigration.model.ModelContainer; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.tests.model.basic.CKeyAssoc; import org.tests.model.basic.CKeyDetail; import org.tests.model.basic.CKeyParent; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_compound_IdClassTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_compound_IdClassTest.java index fa435937a..6cd16314d 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_compound_IdClassTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_compound_IdClassTest.java @@ -11,7 +11,7 @@ import io.ebeaninternal.dbmigration.migrationreader.MigrationXmlReader; import io.ebeaninternal.dbmigration.model.CurrentModel; import io.ebeaninternal.dbmigration.model.MTable; import io.ebeaninternal.dbmigration.model.ModelContainer; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.tests.model.basic.CKeyAssoc; import org.tests.model.basic.CKeyDetail; import org.tests.model.basic.CKeyParent; diff --git a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_explicitSequencesTest.java b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_explicitSequencesTest.java index b65a1b061..07f29e34e 100644 --- a/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_explicitSequencesTest.java +++ b/ebean-ddl-generator/src/test/java/io/ebeaninternal/dbmigration/model/build/ModelBuild_explicitSequencesTest.java @@ -8,7 +8,7 @@ import io.ebeaninternal.api.SpiEbeanServer; import io.ebeaninternal.dbmigration.ddlgeneration.DdlOptions; import io.ebeaninternal.dbmigration.ddlgeneration.Helper; import io.ebeaninternal.dbmigration.model.CurrentModel; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.tests.model.basic.Person; import org.tests.model.basic.Phone; diff --git a/ebean-ddl-generator/src/test/java/org/tests/inheritance/company/domain/TestInheritAbstract.java b/ebean-ddl-generator/src/test/java/org/tests/inheritance/company/domain/TestInheritAbstract.java index 4e4e5b64a..46596e2a3 100644 --- a/ebean-ddl-generator/src/test/java/org/tests/inheritance/company/domain/TestInheritAbstract.java +++ b/ebean-ddl-generator/src/test/java/org/tests/inheritance/company/domain/TestInheritAbstract.java @@ -2,13 +2,16 @@ package org.tests.inheritance.company.domain; import io.ebean.Ebean; import io.ebean.EbeanServer; -import junit.framework.TestCase; -import org.junit.Assert; +import org.junit.jupiter.api.Test; import java.util.List; -public class TestInheritAbstract extends TestCase { +import static org.assertj.core.api.Assertions.assertThat; +import static org.junit.jupiter.api.Assertions.assertNotNull; +public class TestInheritAbstract { + + @Test public void testMe() { EbeanServer server = Ebean.getServer(null); @@ -16,13 +19,13 @@ public class TestInheritAbstract extends TestCase { List list0 = server.find(AbstractBar.class) .findList(); - Assert.assertNotNull(list0); + assertNotNull(list0); List list1 = server.find(AbstractBar.class) .fetch("foo", "importantText") .findList(); - Assert.assertNotNull(list1); + assertNotNull(list1); Foo f = new Foo(); f.setImportantText("blah"); @@ -37,16 +40,14 @@ public class TestInheritAbstract extends TestCase { .fetch("foo", "importantText") .findList(); - Assert.assertNotNull(list2); - Assert.assertTrue(!list2.isEmpty()); + assertNotNull(list2); + assertThat(list2).isNotEmpty(); for (AbstractBar abstractBar : list2) { Foo foo = abstractBar.getFoo(); String importantText = foo.getImportantText(); - Assert.assertNotNull(importantText); + assertNotNull(importantText); } - - } } diff --git a/pom.xml b/pom.xml index 0943bc0f6..e1d70a943 100644 --- a/pom.xml +++ b/pom.xml @@ -65,6 +65,13 @@ test + + com.h2database + h2 + 1.4.199 + test + +