github/ebean
4
0
Fork 0
mirror of https://github.com/ebean-orm/ebean.git synced 2024-04-21 10:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Wrong alter table / alter column DDL was generated (#988)

Browse Source 
* FIX: alter column type uses correct DB-type now.

* FIX: Oracle test case
This commit is contained in:
Roland Praml
2017-04-01 00:38:23 +13:00
committed by Rob Bygrave
parent b821702b8d
commit 0557e6cd08
4 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/io/ebean/dbmigration/ddlgeneration/platform/MySqlDdl.java
+1
View File
@@ -71,6 +71,7 @@ public class MySqlDdl extends PlatformDdl {
String tableName = alter.getTableName();
String columnName = alter.getColumnName();
String type = alter.getType() != null ? alter.getType() : alter.getCurrentType();
type = convert(type, false);
boolean notnull = (alter.isNotnull() != null) ? alter.isNotnull() : Boolean.TRUE.equals(alter.isCurrentNotnull());
String notnullClause = notnull ? " not null" : "";
src/main/java/io/ebean/dbmigration/ddlgeneration/platform/PlatformDdl.java
+1 -1
View File
@@ -376,7 +376,7 @@ public class PlatformDdl {
*/
public String alterColumnType(String tableName, String columnName, String type) {
return "alter table " + tableName + " " + alterColumn + " " + columnName + " " + columnSetType + type;
return "alter table " + tableName + " " + alterColumn + " " + columnName + " " + columnSetType + convert(type, false);
}
/**
src/main/java/io/ebean/dbmigration/ddlgeneration/platform/SqlServerDdl.java
+1
View File
@@ -70,6 +70,7 @@ public class SqlServerDdl extends PlatformDdl {
String tableName = alter.getTableName();
String columnName = alter.getColumnName();
String type = alter.getType() != null ? alter.getType() : alter.getCurrentType();
type = convert(type, false);
boolean notnull = (alter.isNotnull() != null) ? alter.isNotnull() : Boolean.TRUE.equals(alter.isCurrentNotnull());
String notnullClause = notnull ? " not null" : "";