Change OraclePlatform to default to use Identity (rather than sequence) (#1976)

* Change OraclePlatform to default to use Identity

- Keep Oracle11Platform to default to Sequence
- Refactor rename Oracle10Ddl to OracleDdl

* Change OraclePlatform to default to use Identity

- DDL review changes in src/test

* Bump ebean-test-docker for StartOracle
This commit is contained in:
Rob Bygrave
2020-04-30 23:35:20 +12:00
committed by GitHub
parent 7c17098f17
commit 02bdace144
13 changed files with 399 additions and 1114 deletions
@@ -6,16 +6,16 @@ import org.junit.Test;
import static org.assertj.core.api.Assertions.assertThat;
public class Oracle10DdlTest {
public class OracleDdlTest {
Oracle10Ddl create() {
return new Oracle10Ddl(new OraclePlatform());
OracleDdl create() {
return new OracleDdl(new OraclePlatform());
}
@Test
public void appendForeignKeyOnDelete_expectEmtpy_when_nullRestrictSetDefault() {
Oracle10Ddl oracle = create();
OracleDdl oracle = create();
StringBuilder sb = new StringBuilder();
oracle.appendForeignKeyOnDelete(sb, oracle.withDefault(null));
@@ -34,7 +34,7 @@ public class Oracle10DdlTest {
@Test
public void appendForeignKeyOnDelete_setNull() {
Oracle10Ddl oracle = create();
OracleDdl oracle = create();
StringBuilder sb = new StringBuilder();
oracle.appendForeignKeyOnDelete(sb, ConstraintMode.SET_NULL);
@@ -44,7 +44,7 @@ public class Oracle10DdlTest {
@Test
public void appendForeignKeyOnDelete_cascade() {
Oracle10Ddl oracle = create();
OracleDdl oracle = create();
StringBuilder sb = new StringBuilder();
oracle.appendForeignKeyOnDelete(sb, ConstraintMode.CASCADE);
@@ -267,7 +267,7 @@ public class PlatformDdl_AlterColumnTest {
@Test
public void useIdentityType_oracle() {
assertEquals(oraDdl.useIdentityType(null), IdType.SEQUENCE);
assertEquals(oraDdl.useIdentityType(null), IdType.IDENTITY);
assertEquals(oraDdl.useIdentityType(IdType.SEQUENCE), IdType.SEQUENCE);
assertEquals(oraDdl.useIdentityType(IdType.IDENTITY), IdType.IDENTITY);
assertEquals(oraDdl.useIdentityType(IdType.GENERATOR), IdType.GENERATOR);