6 Commits
Author SHA1 Message Date
John WoodandGitHub 79f1ecf29f Unconditionally add forward slash in OCSP GET requests (#282) 2022-07-01 13:41:01 -07:00
John WoodandGitHub 4c8f1c5862 Fix OCSP checking (#274)
Fixes #272. The root of the problem is that we're asking the wrong OCSP servers. The current code does something like:

leaf, issuers := chain[0], chain[1:]
for _, issuer := range issuers {
  // check for revocation of leaf via issuer.OCSPServer
}

The main problem is that OCSPServer is the URI of the OCSP server for that certificate, and by asking issuer.OCSPServer about leaf, we're requesting OCSP responses from the wrong server. We should be checking leaf.OCSPServer in this example instead of issuer.OCSPServer.

The second problem is that the loop makes no sense. One would not expect any OCSP server in a given chain to be authoritative for a given leaf.

If you do certigo connect google.com, you'll see

Certificate has OCSP extension, but was unable to check status:
	ocsp: error from server: unauthorized

The "unauthorized" means the OCSP server we asked doesn't know anything about the cert we asked about.
2022-06-28 14:51:03 -07:00
John WoodandGitHub 8f0d49f5b3 Don't check OCSP if there are no OCSP servers in the chain (#255) 2022-02-09 10:07:55 -08:00
Cedric Staub 4dba9b2f4e Improve reliability of OCSP checks 2018-04-06 13:06:05 -07:00
Cedric Staub 594b04e874 Print revocation reason & staple status 2018-04-05 16:01:17 -07:00
Matthew McPherrin c58011aee0 Move ocsp.go and verify.go into lib
This reduces a bunch of copy-paste code.
2018-04-04 21:21:46 -07:00