From e5506005de92bf109691a751840bd2a68542d93e Mon Sep 17 00:00:00 2001
From: XenoAmess <xenoamess@gmail.com>
Date: Tue, 19 Oct 2021 11:00:44 +0800
Subject: [PATCH] use static inner class when can (#1981)

---
 .../taobao/arthas/core/command/klass100/ClassLoaderCommand.java | 2 +-
 .../com/taobao/arthas/core/command/monitor200/MBeanCommand.java | 2 +-
 .../core/distribution/impl/SharingResultDistributorImpl.java    | 2 +-
 .../main/java/com/taobao/arthas/core/shell/impl/ShellImpl.java  | 2 +-
 .../arthas/core/shell/term/impl/http/api/HttpApiHandler.java    | 2 +-
 .../main/java/com/alibaba/arthas/tunnel/client/ProxyClient.java | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/core/src/main/java/com/taobao/arthas/core/command/klass100/ClassLoaderCommand.java b/core/src/main/java/com/taobao/arthas/core/command/klass100/ClassLoaderCommand.java
index efffde390..70ab73fba 100644
--- a/core/src/main/java/com/taobao/arthas/core/command/klass100/ClassLoaderCommand.java
+++ b/core/src/main/java/com/taobao/arthas/core/command/klass100/ClassLoaderCommand.java
@@ -627,7 +627,7 @@ public class ClassLoaderCommand extends AnnotatedCommand {
         }
     }
 
-    private class ClassLoaderInterruptHandler implements Handler<Void> {
+    private static class ClassLoaderInterruptHandler implements Handler<Void> {
 
         private ClassLoaderCommand command;
 
diff --git a/core/src/main/java/com/taobao/arthas/core/command/monitor200/MBeanCommand.java b/core/src/main/java/com/taobao/arthas/core/command/monitor200/MBeanCommand.java
index 563281337..03dfd6579 100644
--- a/core/src/main/java/com/taobao/arthas/core/command/monitor200/MBeanCommand.java
+++ b/core/src/main/java/com/taobao/arthas/core/command/monitor200/MBeanCommand.java
@@ -349,7 +349,7 @@ public class MBeanCommand extends AnnotatedCommand {
     }
 
 
-    public class MBeanInterruptHandler extends CommandInterruptHandler {
+    public static class MBeanInterruptHandler extends CommandInterruptHandler {
 
         private volatile Timer timer;
 
diff --git a/core/src/main/java/com/taobao/arthas/core/distribution/impl/SharingResultDistributorImpl.java b/core/src/main/java/com/taobao/arthas/core/distribution/impl/SharingResultDistributorImpl.java
index 3ecd4ca2a..680974735 100644
--- a/core/src/main/java/com/taobao/arthas/core/distribution/impl/SharingResultDistributorImpl.java
+++ b/core/src/main/java/com/taobao/arthas/core/distribution/impl/SharingResultDistributorImpl.java
@@ -135,7 +135,7 @@ public class SharingResultDistributorImpl implements SharingResultDistributor {
         }
     }
 
-    private class SharingResultConsumerImpl implements ResultConsumer {
+    private static class SharingResultConsumerImpl implements ResultConsumer {
         private BlockingQueue<ResultModel> resultQueue = new ArrayBlockingQueue<ResultModel>(DistributorOptions.resultQueueSize);
         private ReentrantLock queueLock = new ReentrantLock();
         private InputStatusModel lastInputStatus;
diff --git a/core/src/main/java/com/taobao/arthas/core/shell/impl/ShellImpl.java b/core/src/main/java/com/taobao/arthas/core/shell/impl/ShellImpl.java
index 8e317ff81..c37b43033 100644
--- a/core/src/main/java/com/taobao/arthas/core/shell/impl/ShellImpl.java
+++ b/core/src/main/java/com/taobao/arthas/core/shell/impl/ShellImpl.java
@@ -227,7 +227,7 @@ public class ShellImpl implements Shell {
         return currentForegroundJob;
     }
 
-    private class ShellJobHandler implements JobListener {
+    private static class ShellJobHandler implements JobListener {
         ShellImpl shell;
 
         public ShellJobHandler(ShellImpl shell) {
diff --git a/core/src/main/java/com/taobao/arthas/core/shell/term/impl/http/api/HttpApiHandler.java b/core/src/main/java/com/taobao/arthas/core/shell/term/impl/http/api/HttpApiHandler.java
index 163fa5932..2dbf88b69 100644
--- a/core/src/main/java/com/taobao/arthas/core/shell/term/impl/http/api/HttpApiHandler.java
+++ b/core/src/main/java/com/taobao/arthas/core/shell/term/impl/http/api/HttpApiHandler.java
@@ -658,7 +658,7 @@ public class HttpApiHandler {
         }
     }
 
-    private class ApiTerm implements Term {
+    private static class ApiTerm implements Term {
 
         private Session session;
 
diff --git a/tunnel-client/src/main/java/com/alibaba/arthas/tunnel/client/ProxyClient.java b/tunnel-client/src/main/java/com/alibaba/arthas/tunnel/client/ProxyClient.java
index f85cb3326..5bcdb3359 100644
--- a/tunnel-client/src/main/java/com/alibaba/arthas/tunnel/client/ProxyClient.java
+++ b/tunnel-client/src/main/java/com/alibaba/arthas/tunnel/client/ProxyClient.java
@@ -103,7 +103,7 @@ public class ProxyClient {
         return httpResponse;
     }
 
-    class HttpProxyClientHandler extends SimpleChannelInboundHandler<HttpObject> {
+    static class HttpProxyClientHandler extends SimpleChannelInboundHandler<HttpObject> {
 
         private Promise<SimpleHttpResponse> promise;