From 487742dfb059882dd0f4ece59cfcb92bb6bd360d Mon Sep 17 00:00:00 2001 From: hengyunabc Date: Tue, 14 May 2019 19:50:32 +0800 Subject: [PATCH] polish #614 --- .../arthas/core/shell/system/impl/ProcessImpl.java | 10 ++++------ .../arthas/compiler/DynamicCompilerException.java | 10 ++++------ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/core/src/main/java/com/taobao/arthas/core/shell/system/impl/ProcessImpl.java b/core/src/main/java/com/taobao/arthas/core/shell/system/impl/ProcessImpl.java index 379aa6ee9..d457129c9 100644 --- a/core/src/main/java/com/taobao/arthas/core/shell/system/impl/ProcessImpl.java +++ b/core/src/main/java/com/taobao/arthas/core/shell/system/impl/ProcessImpl.java @@ -607,12 +607,10 @@ public class ProcessImpl implements Process { if (statisticsHandler != null && flushHandlerChain != null) { String data = statisticsHandler.result(); - if (flushHandlerChain != null) { - for (Function function : flushHandlerChain) { - data = function.apply(data); - if (function instanceof StatisticsFunction) { - data = ((StatisticsFunction) function).result(); - } + for (Function function : flushHandlerChain) { + data = function.apply(data); + if (function instanceof StatisticsFunction) { + data = ((StatisticsFunction) function).result(); } } } diff --git a/memorycompiler/src/main/java/com/taobao/arthas/compiler/DynamicCompilerException.java b/memorycompiler/src/main/java/com/taobao/arthas/compiler/DynamicCompilerException.java index c883a69a8..9c623beec 100644 --- a/memorycompiler/src/main/java/com/taobao/arthas/compiler/DynamicCompilerException.java +++ b/memorycompiler/src/main/java/com/taobao/arthas/compiler/DynamicCompilerException.java @@ -54,13 +54,11 @@ public class DynamicCompilerException extends RuntimeException { private String getErrors() { StringBuilder errors = new StringBuilder(); - for (Map entry : getErrorList()) { - - for (String key : entry.keySet()) { - - Object value = entry.get(key); + for (Map message : getErrorList()) { + for (Map.Entry entry : message.entrySet()) { + Object value = entry.getValue(); if (value != null && !value.toString().isEmpty()) { - errors.append(key); + errors.append(entry.getKey()); errors.append(": "); errors.append(value); }